From owner-freebsd-standards@FreeBSD.ORG Sun Mar 20 18:00:11 2005 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DC6B16A4CE for ; Sun, 20 Mar 2005 18:00:11 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D105043D2F for ; Sun, 20 Mar 2005 18:00:10 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2KI0ADs031953 for ; Sun, 20 Mar 2005 18:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2KI0AwG031946; Sun, 20 Mar 2005 18:00:10 GMT (envelope-from gnats) Resent-Date: Sun, 20 Mar 2005 18:00:10 GMT Resent-Message-Id: <200503201800.j2KI0AwG031946@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, David Magda Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC65416A4CE for ; Sun, 20 Mar 2005 17:50:32 +0000 (GMT) Received: from tomts10-srv.bellnexxia.net (tomts10.bellnexxia.net [209.226.175.54]) by mx1.FreeBSD.org (Postfix) with ESMTP id 145B643D5A for ; Sun, 20 Mar 2005 17:50:32 +0000 (GMT) (envelope-from dmagda@magda.ca) Received: from number6.magda.ca ([65.95.110.102]) by tomts10-srv.bellnexxia.netESMTP <20050320175030.ZPNL19622.tomts10-srv.bellnexxia.net@number6.magda.ca> for ; Sun, 20 Mar 2005 12:50:30 -0500 Received: from number6.magda.ca (localhost.magda.ca [127.0.0.1]) by number6.magda.ca (8.13.1/8.13.1) with ESMTP id j2KHoUT4045208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 20 Mar 2005 12:50:30 -0500 (EST) (envelope-from dmagda@magda.ca) Received: (from dmagda@localhost) by number6.magda.ca (8.13.1/8.13.1/Submit) id j2KHoUJg045207; Sun, 20 Mar 2005 12:50:30 -0500 (EST) (envelope-from dmagda) Message-Id: <200503201750.j2KHoUJg045207@number6.magda.ca> Date: Sun, 20 Mar 2005 12:50:30 -0500 (EST) From: David Magda To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: standards/79055: Add an IFS regression test for shells X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: David Magda List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2005 18:00:11 -0000 >Number: 79055 >Category: standards >Synopsis: Add an IFS regression test for shells >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Mar 20 18:00:10 GMT 2005 >Closed-Date: >Last-Modified: >Originator: David Magda >Release: FreeBSD 4.10-STABLE i386 >Organization: We're organized? >Environment: System: FreeBSD number6.magda.ca 4.10-STABLE FreeBSD 4.10-STABLE #5: Wed Dec 1 16:07:51 EST 2004 dave@number6.magda.ca:/usr/obj/usr/src/sys/MYKERNELE i386 >Description: Not so much a bug report but simply a way to test that the IFS code in sh(1) is up to snuff. Glenn Fowler at AT&T Research has a shell script [1] that tests how good a shell's IFS code is. The script can be downloaded from [1] but is also attached to the end of this PR. [1] http://www.research.att.com/~gsf/public/ifs.sh >How-To-Repeat: /bin/sh ifs.sh >Fix: On my 4.10 box sh(1) has the following results: [...] # tests 6856 passed 1097 failed 5759 ordered 1644 I don't have any other systems to test on. Here's the script: # Usage: $SHELL ifs.sh # # This script generates 6856 tests for the set(1) and read(1) # builtins w.r.t. IFS whitespace and non-whitespace characters. # Each failed test produces one line on the standard output that # contains the test along with the expected and actual results. # The last output line contains the test result counts. ordered>0 # are the number of tests where IFS=": " produced different results # than IFS=" :". If a test fails the same way for IFS=": " and # IFS=" :" then the second output line is suppressed. TESTS=6856 ksh_read=0 echo 1 | read ksh_read ksh_arith=0 eval '((ksh_arith+=1))' 2>/dev/null failed=0 ordered=0 passed=0 split() { i=$1 s=$2 r=$3 S='' R='' for ifs in ': ' ' :' do IFS=$ifs set x $i shift IFS=' ' g="[$#]" while : do case $# in 0) break ;; esac g="$g($1)" shift done case $g in "$s") case $ksh_arith in 1) ((passed+=1)) ;; *) passed=`expr $passed + 1` ;; esac case $S in '') S=$g ;; "$g") ;; *) case $ksh_arith in 1) ((ordered+=1)) ;; *) ordered=`expr $ordered + 1` ;; esac ;; esac ;; "$S") case $ksh_arith in 1) ((failed+=1)) ;; *) failed=`expr $failed + 1` ;; esac ;; *) case $ksh_arith in 1) ((failed+=1)) ;; *) failed=`expr $failed + 1` ;; esac case $s in "$S") ;; ?0*) echo "IFS=\"$ifs\"; x=\"$i\"; set x \$x; shift; echo \"[\$#]\" # expected \"$s\" got \"$g\"" ;; ?1*) echo "IFS=\"$ifs\"; x=\"$i\"; set x \$x; shift; echo \"[\$#](\$1)\" # expected \"$s\" got \"$g\"" ;; ?2*) echo "IFS=\"$ifs\"; x=\"$i\"; set x \$x; shift; echo \"[\$#](\$1)(\$2)\" # expected \"$s\" got \"$g\"" ;; ?3*) echo "IFS=\"$ifs\"; x=\"$i\"; set x \$x; shift; echo \"[\$#](\$1)(\$2)(\$3)\" # expected \"$s\" got \"$g\"" ;; *) echo TEST ERROR i="'$i'" s="'$s'" ;; esac case $S in '') S=$g ;; "$g") ;; *) case $ksh_arith in 1) ((ordered+=1)) ;; *) ordered=`expr $ordered + 1` ;; esac ;; esac esac case $ksh_read in 1) echo "$i" | IFS=$ifs read x y; g="($x)($y)" ;; *) g=`export ifs; echo "$i" | ( IFS=$ifs; read x y; echo "($x)($y)" )` ;; esac case $g in "$r") case $ksh_arith in 1) ((passed+=1)) ;; *) passed=`expr $passed + 1` ;; esac case $R in '') R=$g ;; "$g") ;; *) case $ksh_arith in 1) ((ordered+=1)) ;; *) ordered=`expr $ordered + 1` ;; esac ;; esac ;; "$R") case $ksh_arith in 1) ((failed+=1)) ;; *) failed=`expr $failed + 1` ;; esac ;; *) case $ksh_arith in 1) ((failed+=1)) ;; *) failed=`expr $failed + 1` ;; esac case $r in "$R") ;; *) echo "echo \"$i\" | ( IFS=\"$ifs\" read x y; echo \"(\$x)(\$y)\" ) # expected \"$r\" got \"$g\"" ;; esac case $R in '') R=$g ;; "$g") ;; *) case $ksh_arith in 1) ((ordered+=1)) ;; *) ordered=`expr $ordered + 1` ;; esac ;; esac ;; esac done } for str in \ '-' \ 'a' \ '- -' \ '- a' \ 'a -' \ 'a b' \ '- - -' \ '- - a' \ '- a -' \ '- a b' \ 'a - -' \ 'a - b' \ 'a b -' \ 'a b c' \ do IFS=' ' set x $str shift case $# in 0) continue ;; esac f1=$1 case $f1 in '-') f1='' ;; esac shift case $# in 0) for d0 in '' ' ' do for d1 in '' ' ' ':' ' :' ': ' ' : ' do case $f1$d1 in '') split "$d0$f1$d1" "[0]" "()()" ;; ' ') ;; *) split "$d0$f1$d1" "[1]($f1)" "($f1)()" ;; esac done done continue ;; esac f2=$1 case $f2 in '-') f2='' ;; esac shift case $# in 0) for d0 in '' ' ' do for d1 in ' ' ':' ' :' ': ' ' : ' do case ' ' in $f1$d1|$d1$f2) continue ;; esac for d2 in '' ' ' ':' ' :' ': ' ' : ' do case $f2$d2 in '') split "$d0$f1$d1$f2$d2" "[1]($f1)" "($f1)()" ;; ' ') ;; *) split "$d0$f1$d1$f2$d2" "[2]($f1)($f2)" "($f1)($f2)" ;; esac done done done continue ;; esac f3=$1 case $f3 in '-') f3='' ;; esac shift case $# in 0) for d0 in '' ' ' do for d1 in ':' ' :' ': ' ' : ' do case ' ' in $f1$d1|$d1$f2) continue ;; esac for d2 in ' ' ':' ' :' ': ' ' : ' do case $f2$d2 in ' ') continue ;; esac case ' ' in $f2$d2|$d2$f3) continue ;; esac for d3 in '' ' ' ':' ' :' ': ' ' : ' do case $f3$d3 in '') split "$d0$f1$d1$f2$d2$f3$d3" "[2]($f1)($f2)" "($f1)($f2)" ;; ' ') ;; *) x=$f2$d2$f3$d3 x=${x#' '} x=${x%' '} split "$d0$f1$d1$f2$d2$f3$d3" "[3]($f1)($f2)($f3)" "($f1)($x)" ;; esac done done done done continue ;; esac done case $ksh_arith in 1) ((tests=passed+failed)) ;; *) tests=`expr $passed + $failed` ;; esac case $ordered in 0) ordered="" ;; *) ordered=" ordered $ordered" ;; esac case $tests in $TESTS) fatal="" ;; *) fatal=" -- fundamental IFS error -- $TESTS tests expected" esac echo "# tests $tests passed $passed failed $failed$ordered$fatal" >Release-Note: >Audit-Trail: >Unformatted: