From owner-freebsd-usb@FreeBSD.ORG Sun May 1 13:08:19 2005 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E387016A4FC; Sun, 1 May 2005 13:08:19 +0000 (GMT) Received: from ms-smtp-02.nyroc.rr.com (ms-smtp-02.nyroc.rr.com [24.24.2.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46DD543D2F; Sun, 1 May 2005 13:08:19 +0000 (GMT) (envelope-from akropel1@rochester.rr.com) Received: from mail.kroptech.com (cpe-24-93-20-125.rochester.res.rr.com [24.93.20.125])j41D8DJj024259; Sun, 1 May 2005 09:08:13 -0400 (EDT) Received: from pia (pia.kroptech.com [192.168.200.3]) by mail.kroptech.com (Postfix) with SMTP id 814DD11376E; Sun, 1 May 2005 09:19:00 -0400 (EDT) Message-ID: <004c01c54e4e$d45baa80$03c8a8c0@kroptech.com> From: "Adam Kropelin" To: "Thierry Thomas" , "Lonnie Mendez" References: <20050427055531.07B7D60FB@gnome.dnsalias.net> <20050430160650.GC95709@graf.pompo.net> Date: Sun, 1 May 2005 09:08:12 -0400 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 8bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2527 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.2527 X-Virus-Scanned: Symantec AntiVirus Scan Engine cc: FreeBSD-gnats-submit@freebsd.org cc: freebsd-usb@freebsd.org Subject: Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain usbdevices (blacklist) X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2005 13:08:20 -0000 Thierry Thomas wrote: >> Le Mer 27 avr 05 à 7:55:31 +0200, Lonnie Mendez >> écrivait : >>> >>>> Number: 80383 >>>> Category: kern >>>> Synopsis: [PATCH] Add quirk for uhid to ignore certain usb >>>> devices (blacklist) >> >>>> Description: >>> >>> This patch allows uhid to leave alone devices that identify >>> themselves as hid based, but are indeed >>> used via another interface. This is very simliar in concept to the >>> hid blacklist table found in hid-core.c in the linux kernel. >> >> Fine! I also need this to use the new MGE UPS devices (with nut, >> libusb and the newhidups driver). I have applied the submitted patch >> on a >> 5.4-STABLE, and it's OK. >> >> To add the MGE UPS devices, I need the attached patches. Just to nitpick a little... > +product MGE UPS1 0x0001 MGEUPS newhidups 1 > +product MGE UPS2 0xffff MGEUPS newhidups 2 I'm not sure it's appropriate in this context to refer to a userspace program like "newhidups". I think this field is really meant to be a textual name for the product being identified. Based on the other entries in the file, something like a model name or generc description may be more appropriate. --Adam