From owner-p4-projects@FreeBSD.ORG Mon Nov 7 15:25:23 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6B0AF16A421; Mon, 7 Nov 2005 15:25:23 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2AD1616A41F for ; Mon, 7 Nov 2005 15:25:23 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEFF643D48 for ; Mon, 7 Nov 2005 15:25:22 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jA7FPMdV096641 for ; Mon, 7 Nov 2005 15:25:22 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jA7FPMcA096638 for perforce@freebsd.org; Mon, 7 Nov 2005 15:25:22 GMT (envelope-from millert@freebsd.org) Date: Mon, 7 Nov 2005 15:25:22 GMT Message-Id: <200511071525.jA7FPMcA096638@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 86418 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2005 15:25:24 -0000 http://perforce.freebsd.org/chv.cgi?CH=86418 Change 86418 by millert@millert_ibook on 2005/11/07 15:24:50 style(9) cleanup Affected files ... .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#5 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#5 (text+ko) ==== @@ -68,25 +68,25 @@ int sebsd_check_ipc_method1(int subj, int obj, int msgid) { - struct msgid_classinfo *mcl = hashtab_search(msgid2class, &msgid); - int i; + struct msgid_classinfo *mcl; + struct av_decision ad; + access_vector_t perms; + int cl; /* * Return allowed for messages in an unknown subsystem. * Instead, we probably should make a check against a * new permission to be added to mach_port for this purpose. */ - if (!mcl) + mcl = hashtab_search(msgid2class, &msgid); + if (mcl == NULL) return 0; - struct av_decision avd; - int cl = (msgid-mcl->baseid) / (8*sizeof(access_vector_t)); - access_vector_t perms; - + cl = msgid-mcl->baseid / (8 * sizeof(access_vector_t)); if (cl >= mcl->nclasses) - return (1); /* bad message, access denied */ + return (1); /* bad message, access denied */ perms = (access_vector_t)1 << - (msgid - mcl->baseid - cl * 8 * sizeof(access_vector_t)); - return avc_has_perm_audit(subj, obj, mcl->classes[cl], perms, &avd); + (msgid - mcl->baseid - (cl * 8 * sizeof(access_vector_t))); + return avc_has_perm_audit(subj, obj, mcl->classes[cl], perms, &ad); }