From owner-cvs-src@FreeBSD.ORG  Sun Jun 18 00:37:56 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C381016A47F;
	Sun, 18 Jun 2006 00:37:56 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 20E3A43D66;
	Sun, 18 Jun 2006 00:37:55 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 5720646BBA;
	Sat, 17 Jun 2006 20:37:54 -0400 (EDT)
Date: Sun, 18 Jun 2006 01:37:54 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Andre Oppermann <andre@FreeBSD.org>
In-Reply-To: <200606171732.k5HHWdl9086272@repoman.freebsd.org>
Message-ID: <20060618013509.M67789@fledge.watson.org>
References: <200606171732.k5HHWdl9086272@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jun 2006 00:37:56 -0000


On Sat, 17 Jun 2006, Andre Oppermann wrote:

>  Revision  Changes    Path
>  1.299     +9 -6      src/sys/netinet/tcp_input.c
>  1.87      +286 -255  src/sys/netinet/tcp_syncache.c
>  1.130     +9 -6      src/sys/netinet/tcp_var.h

This change appears to have broken world on all architectures by exposing the 
mutex data structure to usr.bin/netstat/inet.c via tcp_var.h.  I'm not quite 
sure what the "right" solution is, but if the syncache structures aren't 
actually used anywhere in user space, sticking them under #ifdef _KERNEL is 
probably a good start.

The UDP and TCP monitoring code more generally suffer from the problem of 
exposing their internal data structures for user space monitoring purposes.

Robert N M Watson
Computer Laboratory
University of Cambridge