From owner-freebsd-acpi@FreeBSD.ORG Sun Oct 1 02:21:28 2006 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B39FB16A40F; Sun, 1 Oct 2006 02:21:28 +0000 (UTC) (envelope-from nate@root.org) Received: from ylpvm12.prodigy.net (ylpvm12-ext.prodigy.net [207.115.57.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id E969E43D58; Sun, 1 Oct 2006 02:21:25 +0000 (GMT) (envelope-from nate@root.org) X-ORBL: [71.139.46.150] Received: from [10.0.5.50] (ppp-71-139-46-150.dsl.snfc21.pacbell.net [71.139.46.150]) by ylpvm12.prodigy.net (8.13.7 out spool5000 dk/8.13.7) with ESMTP id k912KNi3021200; Sat, 30 Sep 2006 22:20:24 -0400 Message-ID: <451F2620.6030102@root.org> Date: Sat, 30 Sep 2006 19:21:20 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Matteo Riondato References: <20060930123244.GA29307@kaiser.sig11.org> <451EC4E6.7030304@root.org> <20060930221744.GB29307@kaiser.sig11.org> In-Reply-To: <20060930221744.GB29307@kaiser.sig11.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: Powerd patch review X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2006 02:21:28 -0000 Matteo Riondato wrote: > On Sat, Sep 30, 2006 at 12:26:30PM -0700, Nate Lawson wrote: >> Matteo Riondato wrote: >>> Hi folks, >>> I'm writing you to ask if you could be so kind to review the >>> attached patch to src/usr.sbin/powerd/powerd.c . It should fix the >>> problem descripted in PR bin/97198. I haven't a broken BIOS to test if >>> it really works, but it should. >>> Thanks >>> Best regards >>> P.s. I'm not subscribed to the list, so please CC me. >>> >>> >>> ------------------------------------------------------------------------ >>> >>> Index: powerd.c >> I thought this was already fixed and merged in July by Bruno. In any >> case, the right place to fix this is in the cpufreq driver (or >> acpi_perf, where I think this only occurs). See rev 1.21.2.3 of >> acpi_perf.c. > > Yes. PR was filed before that change, which, from my understanding, > solves the issue. Sorry for the noise. > >> Actually, it would be important to see if this is happening in another >> driver. The output of "sysctl dev.cpu" will show all the child drivers >> and settings so we can see if he's using acpi_perf or some other cpufreq >> driver. > > I'll ask the PR submitter. Thanks. > Best regards Also check if 6-stable fixes the problem for him. If so, this issue is closed. -- Nate