From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 8 00:20:04 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13AB016A41F for ; Sun, 8 Jan 2006 00:20:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BC1B43D46 for ; Sun, 8 Jan 2006 00:20:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k080K3uw021870 for ; Sun, 8 Jan 2006 00:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k080K32F021865; Sun, 8 Jan 2006 00:20:03 GMT (envelope-from gnats) Resent-Date: Sun, 8 Jan 2006 00:20:03 GMT Resent-Message-Id: <200601080020.k080K32F021865@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Carl Drougge Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E536E16A41F for ; Sun, 8 Jan 2006 00:15:06 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9240743D48 for ; Sun, 8 Jan 2006 00:15:06 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k080F6Ru032530 for ; Sun, 8 Jan 2006 00:15:06 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k080F6Mr032529; Sun, 8 Jan 2006 00:15:06 GMT (envelope-from nobody) Message-Id: <200601080015.k080F6Mr032529@www.freebsd.org> Date: Sun, 8 Jan 2006 00:15:06 GMT From: Carl Drougge To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/91488: [patch] cd9660 filesystem cannot handle files larger than 2GB X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2006 00:20:04 -0000 >Number: 91488 >Category: kern >Synopsis: [patch] cd9660 filesystem cannot handle files larger than 2GB >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 08 00:20:02 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Carl Drougge >Release: 6.0-RELEASE >Organization: >Environment: FreeBSD k6.lundagatan.com 6.0-RELEASE FreeBSD 6.0-RELEASE #1: Sun Jan 8 00:15:19 CET 2006 root@k6.lundagatan.com:/usr/src/sys/i386/compile/K6 i386 >Description: The cd9660 filesystem can not handle files of more than 2147483647 bytes, while the specification of the filesystem arguably allows for files up to 4294967295 bytes. (Specifically, the "32 bit quantity" is not specified as signed or unsigned. In my opinion, since negative file sizes are not meaningfull, it should be interpreted as unsigned.) >How-To-Repeat: Mount an iso9660 filesystem containing a file of more than 2147483647 bytes, and try to access this file. ls gives "ls: large_file: Value too large to be stored in data type", attempts to read the file return EOF at once. >Fix: I have not tested this patch much, but it seems to work. --- sys/isofs/cd9660/cd9660_node.h.org Wed Mar 16 09:09:52 2005 +++ sys/isofs/cd9660/cd9660_node.h Sun Jan 8 00:14:54 2006 @@ -69,7 +69,7 @@ ino_t i_ino; /* inode number of found directory */ long iso_extent; /* extent of file */ - long i_size; + u_long i_size; long iso_start; /* actual start of data of file (may be different */ /* from iso_extent, if file has extended attributes) */ ISO_RRIP_INODE inode; >Release-Note: >Audit-Trail: >Unformatted: