Date: Sun, 22 Oct 2006 17:34:36 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org Subject: Re: src.conf(5) seems to affect ports build Message-ID: <20061022153436.GW53114@obiwan.tataz.chchile.org> In-Reply-To: <20061021172533.GA69551@rambler-co.ru> References: <20061020150848.GQ53114@obiwan.tataz.chchile.org> <20061020191332.GC59856@rambler-co.ru> <20061021162635.GS53114@obiwan.tataz.chchile.org> <20061021172533.GA69551@rambler-co.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan,
On Sat, Oct 21, 2006 at 09:25:33PM +0400, Ruslan Ermilov wrote:
> > Also, your patch avoids performing the WITH(OUT)_* stuff for ports in
> > order to prevent from polluting the namespace. If there is to be
> > some WITH(OUT)_* knobs which leads to CFLAGS modification in the future
> > (I'm thinking about ProPolice with the upcoming GCC 4.1), wouldn't it
> > be worth benefiting this framework for ports ?
>
> It avoids only /etc/src.conf stuff when running bsd.port.mk; if you put
> WITH(OUT)_* in /etc/make.conf it will still be picked up.
Yes indeed, but MK_FOO won't be set and this would require to either
duplicate the code that modifies CFLAGS, or at least test for MK_FOO
or WITH_FOO at the same time.
Let me show you an example.
I have an additional <bsd.ssp.mk> that is included from both bsd.sys.mk
and bsd.port.mk:
% .if ${MK_SSP} != "no"
% SSP_CFLAGS ?= -fstack-protector
% CFLAGS += ${SSP_CFLAGS}
% . if defined(WARNS) && ${WARNS} >= 7 && !empty(SSP_CFLAGS)
% CWARNFLAGS += -Wstack-protector
% . endif
% .endif
Currently it is thus quite useful to use MK_SSP when this file is
included from bsd.ports.mk. With your whole patch I would have to
either duplicate these bits in bsd.ports.mk or turn the condition to
something like:
% .if (defined(MK_SSP) && ${MK_SSP} != "no") || defined(WITH_SSP)
What do you advice me to do ?
Thank you for your help.
Best regards,
--
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061022153436.GW53114>