From owner-freebsd-mobile@FreeBSD.ORG Sun Jan 15 02:18:56 2006 Return-Path: X-Original-To: mobile@freebsd.org Delivered-To: freebsd-mobile@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7144316A41F for ; Sun, 15 Jan 2006 02:18:56 +0000 (GMT) (envelope-from markus@brueffer.de) Received: from mailout08.sul.t-online.com (mailout08.sul.t-online.com [194.25.134.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id B37C443D45 for ; Sun, 15 Jan 2006 02:18:55 +0000 (GMT) (envelope-from markus@brueffer.de) Received: from fwd32.aul.t-online.de by mailout08.sul.t-online.com with smtp id 1ExxTq-0000G1-01; Sun, 15 Jan 2006 03:18:54 +0100 Received: from ramses.kicks-ass.net (VyvzFvZpwepu117zpTB1CrlFyl28NOWRztbvI3xihr6nnzU-6GYX40@[80.143.202.2]) by fwd32.sul.t-online.de with esmtp id 1ExxTp-0MF2Gm0; Sun, 15 Jan 2006 03:18:53 +0100 Received: from [192.168.1.100] (dslb-084-061-021-116.pools.arcor-ip.net [84.61.21.116]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ramses.kicks-ass.net (Postfix) with ESMTP id 1F5A6B833; Sun, 15 Jan 2006 03:18:53 +0100 (CET) Message-ID: <43C9B10C.40207@brueffer.de> Date: Sun, 15 Jan 2006 03:18:52 +0100 From: Markus Brueffer User-Agent: Thunderbird 1.5 (Macintosh/20051201) MIME-Version: 1.0 To: Tobias Roth References: <20060110175214.GA2519@droopy.unibe.ch> <43C659A5.7080904@brueffer.de> <20060112182958.20cdb395@localhost> <43C8490B.6000506@brueffer.de> <20060114094316.GA47546@staatsfeind.org> <20060114101230.GB25379@droopy.unibe.ch> In-Reply-To: <20060114101230.GB25379@droopy.unibe.ch> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ID: VyvzFvZpwepu117zpTB1CrlFyl28NOWRztbvI3xihr6nnzU-6GYX40@t-dialin.net X-TOI-MSGID: 73a88d44-c708-4366-a61f-fe3c4b4c240c Cc: mobile@freebsd.org Subject: Re: IBM Thinkpad Fan Control (acpi_ibm) X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2006 02:18:56 -0000 Tobias Roth schrieb: > On Sat, Jan 14, 2006 at 10:43:16AM +0100, Matthias Schmidt wrote: >> Hi, >> >> * Markus Brueffer wrote: >>> I have committed the patch to -CURRENT. I'll MFC it in about one week if >>> nothing goes wrong. >> Thanks for your work. I've applied the patch to a 6.0-REL system >> running on a Thinkpad T43 and the fan control works great :) > > Dito on my T43p with 6.0-STABLE. Thanks a lot! One question though: > Why is the default set to manual/fullspeed instead of automatically? > Provided that without the patch, the behaviour would be equal to > automatic mode, this breaks POLA and people might complain, or worse, > send their thinkpads to Lenovo for repair, since they don't know > why the fan is now constantly on full speed. The current patch doesn't change the system default which obviously is automatic mode. After further reading I discovered, that after boot, the embedded controller register (which the driver exports via the sysctls) may not reflect the true state of the embedded controller. On some models it reads 0x07, which translates to: "manual mode with fan level of 7", even though the embedded controller is actually in automatic mode. This is what you are seeing. I have created another patch which takes this into account and explicitly sets the embedded controller register to enable automatic mode and set level 0 for manual mode. Furthermore I have added code for re-enabling automatic mode on unloading the module. You can find it here (you need the first patch already applied): http://people.freebsd.org/~markus/ibm/acpi_ibm.c.diff-2 Markus