From owner-freebsd-net@FreeBSD.ORG Sun Feb 12 06:58:29 2006 Return-Path: X-Original-To: net@FreeBSD.org Delivered-To: freebsd-net@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D89E616A420 for ; Sun, 12 Feb 2006 06:58:29 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C75943D48 for ; Sun, 12 Feb 2006 06:58:29 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 54F521A3C1B; Sat, 11 Feb 2006 22:58:29 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 737B75152B; Sun, 12 Feb 2006 01:58:28 -0500 (EST) Date: Sun, 12 Feb 2006 01:58:28 -0500 From: Kris Kennaway To: "JINMEI Tatuya / ?$B?@L@C#:H" Message-ID: <20060212065828.GA56138@xor.obsecurity.org> References: <20060116004438.GA27901@xor.obsecurity.org> <20060207054502.GA18560@xor.obsecurity.org> <20060211035025.GA77114@xor.obsecurity.org> <20060211071411.GA82302@xor.obsecurity.org> <20060211073123.AA7002E35A@impact.jinmei.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <20060211073123.AA7002E35A@impact.jinmei.org> User-Agent: Mutt/1.4.2.1i Cc: net@FreeBSD.org, Kris Kennaway Subject: Re: Changing time causes ipv6 panics X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2006 06:58:30 -0000 --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 11, 2006 at 04:31:23PM +0900, JINMEI Tatuya / ?$B?@L@C#:H wrote: > >>>>> On Sat, 11 Feb 2006 02:14:11 -0500,=20 > >>>>> Kris Kennaway said: >=20 > >> >> Sorry, not really (we've not got a test environment to reproduce it= ). > >> >> But from a quick review of nd6.c, there seems to be one thing that = is > >> >> obviously wrong. The possible bug has been there since rev. 1.19 > >> >> committed in April 2002. We've been probably just lucky so far... > >> >>=20 > >> >> Could you try the patch attached below? We'll probably also need to > >> >> apply this fix to 4.X and 5.X. > >>=20 > >> > The patch did not fix the panic. > >>=20 > >> Hmm, but this time the point where the panic happened should be > >> different. Can you identify where it was? >=20 > > I reduced the hw.physmem size and was able to get a dump: >=20 > > (kgdb) frame 10 >=20 > > #10 0xffffffff80333a86 in nd6_timer (ignored_arg=3D0xffffffff8059ab60) = at ../../../netinet6/nd6.c:585 > > 585 ia6->ia6_flags |=3D IN6_IFF_DEPRECATED; >=20 > Are you sure you applied the patch? In the 'patched' version of > nd6.c, line 585 is blank, so at least it doesn't match the above > backtrace. Sorry, you're right - what was happening was that I'd apply the patch, then go to build the kernel and realise the time was still wrong, then run ntpdate and it would panic again, and because of soft updates the patch hadn't been synced yet and it would be gone when I rebooted again. In fact I cannot seem to reproduce the panic with the patch successfully applied. Next I'll test David's patch. Kris --0F1p//8PRICkK4MW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD7tyTWry0BWjoQKURAt7AAJ90BhTZLHnUwIV8ZaFUaIjNEqARfACgla8f bFm3hAxwlZspp5Y9g/5cTn8= =j9Mt -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--