From owner-freebsd-ports@FreeBSD.ORG Sun Jun 4 16:43:27 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54A1016A540 for ; Sun, 4 Jun 2006 16:43:27 +0000 (UTC) (envelope-from gabor.kovesdan@t-hosting.hu) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59F9543D46 for ; Sun, 4 Jun 2006 16:43:26 +0000 (GMT) (envelope-from gabor.kovesdan@t-hosting.hu) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id 10F5C99925A; Sun, 4 Jun 2006 18:43:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AFk6p88hRynj; Sun, 4 Jun 2006 18:43:14 +0200 (CEST) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) by server.t-hosting.hu (Postfix) with ESMTP id 64206999197; Sun, 4 Jun 2006 18:43:14 +0200 (CEST) Message-ID: <44830D96.3060809@t-hosting.hu> Date: Sun, 04 Jun 2006 18:43:02 +0200 From: =?ISO-8859-1?Q?K=F6vesd=E1n_G=E1bor?= User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Paul Murphy References: <447F68B4.7050503@cogeco.ca> In-Reply-To: <447F68B4.7050503@cogeco.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gkovesdan@t-hosting.hu, freebsd-ports@freebsd.org Subject: Re: security/amavisd-new startup script X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2006 16:43:29 -0000 Paul Murphy wrote: > I need to keep the amavisd-new pid file in a location other than the > default (/var/amavis/amavisd.pid), so I have rewritten the amavis rc > script to include a knob for 'pidfile'. Please consider the attached > file for the amavisd-new port. > ------------------------------------------------------------------------ > > #!/bin/sh > # > # $FreeBSD: ports/security/amavisd-new/files/amavisd.sh.in,v 1.3 2006/02/20 20:47:36 dougb Exp $ > # > > # PROVIDE: amavisd > # REQUIRE: LOGIN > # BEFORE: mail > # KEYWORD: shutdown > > # > # Add the following lines to /etc/rc.conf to enable amavisd: > # > #amavisd_enable="YES" > # > > . /etc/rc.subr > > name=amavisd > rcvar=`set_rcvar` > > load_rc_config $name > > # Set defaults > : ${amavisd_enable:="NO"} > > pidfile=${amavisd_pid:-"/var/amavis/amavisd.pid"} > command=/usr/local/sbin/amavisd > /dev/null 2>&1 > required_files=/usr/local/etc/amavisd.conf > > stop_postcmd=stop_postcmd > > stop_postcmd() > { > rm -f $pidfile > } > > run_rc_command "$1" > I'd found this "new feature" a good idea first, but now, after a deeper look, I realized that we can't set the pid file with a command-line option, just in the config file. Thus, if we wanted to use an alternate location for a pid file, we would have to change it in two places: in amavisd.conf and in rc.conf. Accordingly, I think such modification in the rc script might deceive people, so I'd prefer keeping it as is. Anyway, I don't think that location does have to be changed in the average case, it might be a special requirement of you. Opinions from others are appreciated! Regards, Gabor Kovesdan