From owner-freebsd-rc@FreeBSD.ORG Sun Mar 26 11:21:57 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 327D816A425; Sun, 26 Mar 2006 11:21:57 +0000 (UTC) (envelope-from simon@zaphod.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B48543D67; Sun, 26 Mar 2006 11:21:52 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: from zaphod.nitro.dk (unknown [192.168.3.18]) by mx.nitro.dk (Postfix) with ESMTP id 66A612D484A; Sun, 26 Mar 2006 11:21:49 +0000 (UTC) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 81EB11141E; Sun, 26 Mar 2006 13:21:51 +0200 (CEST) Date: Sun, 26 Mar 2006 13:21:51 +0200 From: "Simon L. Nielsen" To: freebsd-rc@freebsd.org Message-ID: <20060326112150.GC828@zaphod.nitro.dk> References: <20060117075817.GA8473@droopy.unibe.ch> <43CCA738.20601@FreeBSD.org> <20060117101325.GB938@eddie.nitro.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lteA1dqeVaWQ9QQl" Content-Disposition: inline In-Reply-To: <20060117101325.GB938@eddie.nitro.dk> User-Agent: Mutt/1.5.11 Cc: Doug Barton , sumikawa@FreeBSD.org, vanhu@netasq.com Subject: Re: rc.d/ike broken. retire it? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2006 11:21:57 -0000 --lteA1dqeVaWQ9QQl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2006.01.17 11:13:25 +0100, Simon L. Nielsen wrote: > On 2006.01.17 00:13:44 -0800, Doug Barton wrote: > > Tobias Roth wrote: > > > Hi > > >=20 > > > /etc/rc.d/ike is broken. Something along the lines of > > >=20 > > > load_rc_config $name > > > +command=3D"${ike_program}" > > > run_rc_command "$1" > > >=20 > > > fixed it for me. Although now that we have ports rcordering with the > > > base rc.d/ scripts, should rc.d/ike be retired, and the various ike > > > startup scripts be fixed/adapted? Those that come to mind are > > >=20 > > > security/racoon2 > > > security/ipsec-tools > > > security/isakmpd > >=20 > > This was fixed in HEAD, but I haven't merged the fix because I too would > > prefer that the script be retired from the base, and the ports be fixed= =2E I > > would be glad to assist with this effort, as would the fine folks at > > freebsd-rc@freebsd.org. >=20 > I think it should be removed since there is no use for it. >=20 > isakmpd will get an rc.d script as soon as I get around to it. > Hopefully within a not too distant future (it is more or less done, > mainly needs testing to make sure it really works as intended). So, I finally got around to adding an rc.d script to the isakmpd port. Both racoon2 and ipsec-tools also installs rc.d scipts now, so are there any objections to removing the src/etc/rc.d/ike script from HEAD? --=20 Simon L. Nielsen --lteA1dqeVaWQ9QQl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEJnlOh9pcDSc1mlERAvEyAJ9eDd/NziaMEaxTq4wYkifpSR393ACfQQ7S RRYZ0xUUpVKlkW4/xRLagts= =QwZ9 -----END PGP SIGNATURE----- --lteA1dqeVaWQ9QQl-- From owner-freebsd-rc@FreeBSD.ORG Sun Mar 26 15:40:54 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C100616A401 for ; Sun, 26 Mar 2006 15:40:54 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [80.237.196.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id F24B843D48 for ; Sun, 26 Mar 2006 15:40:53 +0000 (GMT) (envelope-from erdgeist@erdgeist.org) Received: (qmail 28065 invoked by uid 0); 26 Mar 2006 15:40:30 -0000 Received: from e178042194.adsl.alicedsl.de (HELO ?10.1.1.106?) (erdgeist@erdgeist.org@85.178.42.194) by elektropost.org with AES256-SHA encrypted SMTP; 26 Mar 2006 15:40:30 -0000 Message-ID: <4426B641.7030203@erdgeist.org> Date: Sun, 26 Mar 2006 17:41:53 +0200 From: Dirk Engling User-Agent: Thunderbird 1.5 (Macintosh/20051201) MIME-Version: 1.0 To: freebsd-rc@freebsd.org X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Extend the rc interface for configuration X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2006 15:40:54 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear rc-hackers, in my understanding the rc.d interface is a generic abstraction of common actions you want to perform on server software. When administrating lots of servers of different type I stumbled accross many configuration actions that were similar, for example adding/removing virtual hosts and users for my mail/ web/ ftp/ name/ jabber-server, configuring ports, logfiles, ssl-ports + certs/ keys etc. Some servers bring their own configuration tools (~vpopmail/bin/*, /etc/tinydns/root), in that case rc.d-scripts could just be a wrapper for the config interface. I wrote simple scripts that copy and modify apache vhost config files (www_adddomain). Scripts like those would implement the new interface for servers not bringing config tools. The interface is simple enough to cover most of everyday uses and defining it does no harm, since noone is forced to implement it, on the other hand it would be a lot easier to find the appropriate tools, even, if their interface doesn't (yet) match the one I thought of. rc.subr could provide some helper functions to replace variables in value=expr stlye config files. So providing a conf_file=/usr/local/etc/fooserver.conf conf_ip_variable=listen-address conf_port_variable=listen-port conf_logfile_variable=log could be enough to implement the config interface for a simple server, where /usr/local/etc/rc.d/fooserver.sh conf ip 127.0.0.1 port 2342 log /var/log/fooserver.log autostart would setup our server appropriately and a keyword like autostart could even add the rcvar fooserver_enable="YES" to /etc/rc.conf. I know, this is not totally thought through but before investing time in implementing a prototype I'd like to hear some thoughts from you, having spent more time than me in rc scripts. Regards erdgeist -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (Darwin) iD8DBQFEJrZAImmQdUyYEgkRAoCSAJ4p5amTuNbMuhUt4k2qcsw+77kcfACfeASm WXLx2o7KUowLYSnkmOoETz0= =/DmV -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Sun Mar 26 19:46:08 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C65F016A423 for ; Sun, 26 Mar 2006 19:46:08 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 064A543D4C for ; Sun, 26 Mar 2006 19:46:07 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 15509 invoked by uid 399); 26 Mar 2006 19:46:04 -0000 Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 26 Mar 2006 19:46:04 -0000 Message-ID: <4426EF81.4090407@FreeBSD.org> Date: Sun, 26 Mar 2006 11:46:09 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: "Simon L. Nielsen" References: <20060117075817.GA8473@droopy.unibe.ch> <43CCA738.20601@FreeBSD.org> <20060117101325.GB938@eddie.nitro.dk> <20060326112150.GC828@zaphod.nitro.dk> In-Reply-To: <20060326112150.GC828@zaphod.nitro.dk> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: sumikawa@FreeBSD.org, freebsd-rc@freebsd.org, vanhu@netasq.com Subject: Re: rc.d/ike broken. retire it? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2006 19:46:08 -0000 Simon L. Nielsen wrote: > So, I finally got around to adding an rc.d script to the isakmpd port. Thanks! If I can make one small suggestion, you might want to review the section on rc.d scripts in the Porter's Handbook for a couple small points, but other than that it looks good! > Both racoon2 and ipsec-tools also installs rc.d scipts now, so are > there any objections to removing the src/etc/rc.d/ike script from > HEAD? No objections here, please sharpen that axe! It's probably worth also MFC'ing the change after the 6.1-RELEASE, IMO. Thanks again, Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Mar 27 11:03:06 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C80FD16A400 for ; Mon, 27 Mar 2006 11:03:06 +0000 (UTC) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E5B043D46 for ; Mon, 27 Mar 2006 11:03:06 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2RB35OA062354 for ; Mon, 27 Mar 2006 11:03:05 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2RB345a062348 for freebsd-rc@freebsd.org; Mon, 27 Mar 2006 11:03:04 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 27 Mar 2006 11:03:04 GMT Message-Id: <200603271103.k2RB345a062348@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 11:03:06 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2006/02/13] conf/93287 rc [patch] Make rc.subr jail-aware o [2006/03/12] conf/94377 rc [patch] /etc/rc.d/sshd improperly tests r 2 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2002/11/12] conf/45226 rc Fix for rc.network, ppp-user annoyance o [2004/11/13] conf/73909 rc [patch] rc.d/sshd does not work with port o [2005/02/18] conf/77663 rc Suggestion: add /etc/rc.d/addnetswap afte o [2005/03/16] conf/78906 rc [patch] Allow mixer_enable="NO" in rc.con o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces o [2005/06/28] conf/82738 rc [patch] add amd_program line to defaults/ o [2005/08/27] conf/85363 rc syntax error in /etc/rc.d/devfs o [2005/11/13] conf/88913 rc [patch] wrapper support for rc.subr o [2005/11/14] conf/88974 rc autoconfigured vlans confuse rc.d/netif o [2005/12/03] conf/89870 rc [patch] feature request to make netif ver o [2006/01/30] conf/92523 rc [patch] allow rc scripts to kill process o [2006/02/25] conf/93815 rc [patch] Adds in the ability to save ipfw o [2006/03/21] bin/94767 rc [patch] rcorder(8) dumps core when does n 13 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Mar 27 11:17:52 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E1A716A41F for ; Mon, 27 Mar 2006 11:17:52 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id C276F43D45 for ; Mon, 27 Mar 2006 11:17:51 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id A1108117C7; Mon, 27 Mar 2006 13:17:49 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83660-01; Mon, 27 Mar 2006 13:17:38 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 834EC11677; Mon, 27 Mar 2006 13:17:36 +0200 (CEST) From: Florent Thoumie To: Dirk Engling In-Reply-To: <4426B641.7030203@erdgeist.org> References: <4426B641.7030203@erdgeist.org> Content-Type: text/plain Date: Mon, 27 Mar 2006 12:17:31 +0100 Message-Id: <1143458251.4290.1.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: Extend the rc interface for configuration X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 11:17:52 -0000 On Sun, 2006-03-26 at 17:41 +0200, Dirk Engling wrote: > Dear rc-hackers, > > in my understanding the rc.d interface is a generic abstraction of > common actions you want to perform on server software. > > When administrating lots of servers of different type I stumbled accross > many configuration actions that were similar, for example > adding/removing virtual hosts and users for my mail/ web/ ftp/ name/ > jabber-server, configuring ports, logfiles, ssl-ports + certs/ keys etc. I think it doesn't belong to rc.subr. Think of it as a set of common routines to start/stop services. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Mon Mar 27 12:06:44 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26A7E16A420 for ; Mon, 27 Mar 2006 12:06:44 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BDF243D46 for ; Mon, 27 Mar 2006 12:06:43 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 9553511629; Mon, 27 Mar 2006 14:06:42 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83814-06; Mon, 27 Mar 2006 14:06:32 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 4332C115E7; Mon, 27 Mar 2006 14:06:32 +0200 (CEST) From: Florent Thoumie To: Brooks Davis In-Reply-To: <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> Content-Type: text/plain Date: Mon, 27 Mar 2006 13:06:30 +0100 Message-Id: <1143461191.4290.5.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 12:06:44 -0000 On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: > On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > > > On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > >> This is based on Oliver's patch for rc.d/sshd that can be found in > >> Gnats. > >> > >> In load_rc_config, I'm extracting prefix from ${command} (or > >> ${name}_program, which part is moved from run_rc_command), and > >> setting > >> etcdir accordingly. > >> > >> The point is that some scripts (like rc.d/sshd) can be used for base > >> sshd as well as ports sshd, and makes possible to source > >> ${prefix}/etc/rc.conf.d/${name}. > >> > >> This patch also documents ${name}_program above run_rc_command > >> (though > >> it's actually used in load_rc_config). > > > > Is command always set? I'm pretty sure it isn't so this may not be > > entierly > > safe. If it's not set, should we try to guess prefix from $0? > > Somehow, command gets set to the right value, but you're right, I'm > missing a bit here. Hum, re-reading rc.subr, you were right, so I just did what you supposed. > > > The other issue I see is that instead of: > > > > if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > . ${etcdir}/rc.conf.d/"$_command" > > fi > > > > I think we should do: > > > > if [ -f /etc/rc.conf.d/"$_command" ]; then > > debug "Sourcing /etc/rc.conf.d/${_command}" > > . /etc/rc.conf.d/"$_command" > > fi > > if [ "${etcdir}" != "/etc" -a -f ${etcdir}/ > > rc.conf.d/"$_command" ]; then > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > . ${etcdir}/rc.conf.d/"$_command" > > fi > > > > That preserves the old behavior while adding support for > > ${prefix}/etc/rc.conf.d. > > Fair enough, but I'd like to add a note saying that /etc/rc.conf.d/$ > {name} is deprecated for ${etcdir} != "/etc". Here's the new patch : http://people.freebsd.org/~flz/local/rc.d-sshd.diff -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Mon Mar 27 18:37:46 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 707D016A400 for ; Mon, 27 Mar 2006 18:37:46 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02E0643D70 for ; Mon, 27 Mar 2006 18:37:45 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k2RIbjkE009224; Mon, 27 Mar 2006 10:37:45 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k2RIbjwE009223; Mon, 27 Mar 2006 10:37:45 -0800 Date: Mon, 27 Mar 2006 10:37:45 -0800 From: Brooks Davis To: Florent Thoumie Message-ID: <20060327183745.GA19473@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <1143461191.4290.5.camel@mayday.esat.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 18:37:46 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: > On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: > > On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > >=20 > > > On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > > >> This is based on Oliver's patch for rc.d/sshd that can be found in > > >> Gnats. > > >> > > >> In load_rc_config, I'm extracting prefix from ${command} (or > > >> ${name}_program, which part is moved from run_rc_command), and =20 > > >> setting > > >> etcdir accordingly. > > >> > > >> The point is that some scripts (like rc.d/sshd) can be used for base > > >> sshd as well as ports sshd, and makes possible to source > > >> ${prefix}/etc/rc.conf.d/${name}. > > >> > > >> This patch also documents ${name}_program above run_rc_command =20 > > >> (though > > >> it's actually used in load_rc_config). > > > > > > Is command always set? I'm pretty sure it isn't so this may not be = =20 > > > entierly > > > safe. If it's not set, should we try to guess prefix from $0? > >=20 > > Somehow, command gets set to the right value, but you're right, I'm =20 > > missing a bit here. >=20 > Hum, re-reading rc.subr, you were right, so I just did what you > supposed. Thinking about this a bit more, in the guessing frmo $0 case, your proposed code: + prefix=3D${0%/etc/rc.d/*}/ won't work reliably when the user uses a relative path. I think something like this would be better: _tmp=3D`/bin/realpath $0` prefix=3D${_tmp%/etc/rc.d/*}/ > > > The other issue I see is that instead of: > > > > > > if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > . ${etcdir}/rc.conf.d/"$_command" > > > fi > > > > > > I think we should do: > > > > > > if [ -f /etc/rc.conf.d/"$_command" ]; then > > > debug "Sourcing /etc/rc.conf.d/${_command}" > > > . /etc/rc.conf.d/"$_command" > > > fi > > > if [ "${etcdir}" !=3D "/etc" -a -f ${etcdir}/=20 > > > rc.conf.d/"$_command" ]; then > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > . ${etcdir}/rc.conf.d/"$_command" > > > fi > > > > > > That preserves the old behavior while adding support for > > > ${prefix}/etc/rc.conf.d. > >=20 > > Fair enough, but I'd like to add a note saying that /etc/rc.conf.d/$=20 > > {name} is deprecated for ${etcdir} !=3D "/etc". The deprecation warning should not be printed in the case that ${etcdir} is /etc. You should also avoid sourcing the file twice in the /etc case. The easiest way to do that is probably to make the first case contingent on ${etcdir} !=3D /etc. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEKDD4XY6L6fI4GtQRApZmAKDQJkO8hiZiplUSlA9koyHAhfyPMACdHh0a AANCTUi1bHKNtdbvj4ZOTVc= =RldB -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB-- From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 02:50:23 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2451716A400 for ; Tue, 28 Mar 2006 02:50:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E553343D46 for ; Tue, 28 Mar 2006 02:50:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2S2oLvu039655 for ; Tue, 28 Mar 2006 02:50:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2S2oLeK039648; Tue, 28 Mar 2006 02:50:21 GMT (envelope-from gnats) Date: Tue, 28 Mar 2006 02:50:21 GMT Message-Id: <200603280250.k2S2oLeK039648@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Ganbold Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ganbold List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 02:50:23 -0000 The following reply was made to PR bin/94767; it has been noted by GNATS. From: Ganbold To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) Date: Tue, 28 Mar 2006 11:49:07 +0900 In Dragonfly rcorder code, those lines which frees memory are commented out. Clearer way will be just to delete those lines. In any case I just commented out those lines, since it can be used later on. So the patch would be: --- rcorder.c.orig Tue Jan 17 16:01:00 2006 +++ rcorder.c Mon Mar 27 16:41:49 2006 @@ -757,8 +757,8 @@ r_tmp = r; satisfy_req(r, fnode->filename); r = r->next; - if (was_set == 0) - free(r_tmp); +/* if (was_set == 0)*/ +/* free(r_tmp);*/ } fnode->req_list = NULL; @@ -797,10 +797,10 @@ } DPRINTF((stderr, "nuking %s\n", fnode->filename)); - if (was_set == 0) { - free(fnode->filename); - free(fnode); - } +/* if (was_set == 0) {*/ +/* free(fnode->filename);*/ +/* free(fnode);*/ +/* }*/ } void From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 14:38:58 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65E4416A420 for ; Tue, 28 Mar 2006 14:38:58 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B29D943D49 for ; Tue, 28 Mar 2006 14:38:57 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 792B3117F7; Tue, 28 Mar 2006 16:38:53 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15177-09; Tue, 28 Mar 2006 16:38:42 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 945B211413; Tue, 28 Mar 2006 16:38:41 +0200 (CEST) From: Florent Thoumie To: Brooks Davis In-Reply-To: <20060327183745.GA19473@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> <20060327183745.GA19473@odin.ac.hmc.edu> Content-Type: text/plain Date: Tue, 28 Mar 2006 15:38:35 +0100 Message-Id: <1143556715.65237.4.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 14:38:58 -0000 On Mon, 2006-03-27 at 10:37 -0800, Brooks Davis wrote: > On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: > > On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: > > > On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > > > > > > > On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > > > >> This is based on Oliver's patch for rc.d/sshd that can be found in > > > >> Gnats. > > > >> > > > >> In load_rc_config, I'm extracting prefix from ${command} (or > > > >> ${name}_program, which part is moved from run_rc_command), and > > > >> setting > > > >> etcdir accordingly. > > > >> > > > >> The point is that some scripts (like rc.d/sshd) can be used for base > > > >> sshd as well as ports sshd, and makes possible to source > > > >> ${prefix}/etc/rc.conf.d/${name}. > > > >> > > > >> This patch also documents ${name}_program above run_rc_command > > > >> (though > > > >> it's actually used in load_rc_config). > > > > > > > > Is command always set? I'm pretty sure it isn't so this may not be > > > > entierly > > > > safe. If it's not set, should we try to guess prefix from $0? > > > > > > Somehow, command gets set to the right value, but you're right, I'm > > > missing a bit here. > > > > Hum, re-reading rc.subr, you were right, so I just did what you > > supposed. > > Thinking about this a bit more, in the guessing frmo $0 case, your proposed > code: > > + prefix=${0%/etc/rc.d/*}/ > > won't work reliably when the user uses a relative path. I think something > like this would be better: > > _tmp=`/bin/realpath $0` > prefix=${_tmp%/etc/rc.d/*}/ Indeed, fixed. > > > > The other issue I see is that instead of: > > > > > > > > if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > > . ${etcdir}/rc.conf.d/"$_command" > > > > fi > > > > > > > > I think we should do: > > > > > > > > if [ -f /etc/rc.conf.d/"$_command" ]; then > > > > debug "Sourcing /etc/rc.conf.d/${_command}" > > > > . /etc/rc.conf.d/"$_command" > > > > fi > > > > if [ "${etcdir}" != "/etc" -a -f ${etcdir}/ > > > > rc.conf.d/"$_command" ]; then > > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > > . ${etcdir}/rc.conf.d/"$_command" > > > > fi > > > > > > > > That preserves the old behavior while adding support for > > > > ${prefix}/etc/rc.conf.d. > > > > > > Fair enough, but I'd like to add a note saying that /etc/rc.conf.d/$ > > > {name} is deprecated for ${etcdir} != "/etc". > > The deprecation warning should not be printed in the case that ${etcdir} > is /etc. You should also avoid sourcing the file twice in the /etc > case. The easiest way to do that is probably to make the first case > contingent on ${etcdir} != /etc. Next time I'll test my changes (and sleep more). Did that too, and added a check to test if there's a ${etcdir}/rc.conf.d/${_command} file. Patch updated : http://people.freebsd.org/~flz/local/rc.d-sshd.diff BTW, I think that we should s/_command/_name/ in load_rc_config(), this is a bit confusing. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 17:08:44 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0129216A41F for ; Tue, 28 Mar 2006 17:08:44 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4110844DAA for ; Tue, 28 Mar 2006 17:08:42 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k2SH8gdX017824; Tue, 28 Mar 2006 09:08:42 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k2SH8gDh017820; Tue, 28 Mar 2006 09:08:42 -0800 Date: Tue, 28 Mar 2006 09:08:42 -0800 From: Brooks Davis To: Florent Thoumie Message-ID: <20060328170842.GA16561@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> <20060327183745.GA19473@odin.ac.hmc.edu> <1143556715.65237.4.camel@mayday.esat.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <1143556715.65237.4.camel@mayday.esat.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 17:08:44 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 28, 2006 at 03:38:35PM +0100, Florent Thoumie wrote: > On Mon, 2006-03-27 at 10:37 -0800, Brooks Davis wrote: > > On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: > > > On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: > > > > On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > > > >=20 > > > > > On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > > > > >> This is based on Oliver's patch for rc.d/sshd that can be found = in > > > > >> Gnats. > > > > >> > > > > >> In load_rc_config, I'm extracting prefix from ${command} (or > > > > >> ${name}_program, which part is moved from run_rc_command), and = =20 > > > > >> setting > > > > >> etcdir accordingly. > > > > >> > > > > >> The point is that some scripts (like rc.d/sshd) can be used for = base > > > > >> sshd as well as ports sshd, and makes possible to source > > > > >> ${prefix}/etc/rc.conf.d/${name}. > > > > >> > > > > >> This patch also documents ${name}_program above run_rc_command = =20 > > > > >> (though > > > > >> it's actually used in load_rc_config). > > > > > > > > > > Is command always set? I'm pretty sure it isn't so this may not = be =20 > > > > > entierly > > > > > safe. If it's not set, should we try to guess prefix from $0? > > > >=20 > > > > Somehow, command gets set to the right value, but you're right, I'm= =20 > > > > missing a bit here. > > >=20 > > > Hum, re-reading rc.subr, you were right, so I just did what you > > > supposed. > >=20 > > Thinking about this a bit more, in the guessing frmo $0 case, your prop= osed > > code: > >=20 > > + prefix=3D${0%/etc/rc.d/*}/ > >=20 > > won't work reliably when the user uses a relative path. I think somethi= ng > > like this would be better: > >=20 > > _tmp=3D`/bin/realpath $0` > > prefix=3D${_tmp%/etc/rc.d/*}/ >=20 > Indeed, fixed. >=20 > > > > > The other issue I see is that instead of: > > > > > > > > > > if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > > > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > > > . ${etcdir}/rc.conf.d/"$_command" > > > > > fi > > > > > > > > > > I think we should do: > > > > > > > > > > if [ -f /etc/rc.conf.d/"$_command" ]; then > > > > > debug "Sourcing /etc/rc.conf.d/${_command}" > > > > > . /etc/rc.conf.d/"$_command" > > > > > fi > > > > > if [ "${etcdir}" !=3D "/etc" -a -f ${etcdir}/=20 > > > > > rc.conf.d/"$_command" ]; then > > > > > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > > > > > . ${etcdir}/rc.conf.d/"$_command" > > > > > fi > > > > > > > > > > That preserves the old behavior while adding support for > > > > > ${prefix}/etc/rc.conf.d. > > > >=20 > > > > Fair enough, but I'd like to add a note saying that /etc/rc.conf.d/= $=20 > > > > {name} is deprecated for ${etcdir} !=3D "/etc". > >=20 > > The deprecation warning should not be printed in the case that ${etcdir} > > is /etc. You should also avoid sourcing the file twice in the /etc > > case. The easiest way to do that is probably to make the first case > > contingent on ${etcdir} !=3D /etc. >=20 > Next time I'll test my changes (and sleep more). >=20 > Did that too, and added a check to test if there's a > ${etcdir}/rc.conf.d/${_command} file. Testing prefix=3D/ isn't sufficent since prefix could also be /usr. You should check etcdir=3D/etc. I don't think there's much point in the second test. I don't like silent ignoring of files, it's really hard to debug. Instead, I'd source the file in that case, but print a warning that two files exist. > Patch updated : http://people.freebsd.org/~flz/local/rc.d-sshd.diff >=20 > BTW, I think that we should s/_command/_name/ in load_rc_config(), this > is a bit confusing. That sounds reasonable. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEKW2ZXY6L6fI4GtQRAr3QAKDbNJOQexY58hnMcaToOhaoKr8x3ACg1gUT abDIkLNY/5+If4Y3EoeLp1s= =Nz23 -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 17:39:51 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F44C16A438 for ; Tue, 28 Mar 2006 17:39:51 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0300244439 for ; Tue, 28 Mar 2006 17:31:22 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id DA9BA116F1; Tue, 28 Mar 2006 19:30:52 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18053-03; Tue, 28 Mar 2006 19:30:38 +0200 (CEST) Received: from [192.168.1.102] (unknown [83.141.123.158]) by smtp.xbsd.org (Postfix) with ESMTP id 2E3E911493; Tue, 28 Mar 2006 19:30:32 +0200 (CEST) In-Reply-To: <20060328170842.GA16561@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> <20060327183745.GA19473@odin.ac.hmc.edu> <1143556715.65237.4.camel@mayday.esat.net> <20060328170842.GA16561@odin.ac.hmc.edu> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <9783E661-7B92-47ED-ABF3-EC1AC4369CE0@xbsd.org> Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Tue, 28 Mar 2006 18:30:22 +0100 To: Brooks Davis X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 17:39:52 -0000 On Mar 28, 2006, at 6:08 PM, Brooks Davis wrote: > On Tue, Mar 28, 2006 at 03:38:35PM +0100, Florent Thoumie wrote: >> On Mon, 2006-03-27 at 10:37 -0800, Brooks Davis wrote: >>> On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: >>>> On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: >>>>> On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: >>>>> >>>>>> On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: >>>>>>> This is based on Oliver's patch for rc.d/sshd that can be >>>>>>> found in >>>>>>> Gnats. >>>>>>> >>>>>>> In load_rc_config, I'm extracting prefix from ${command} (or >>>>>>> ${name}_program, which part is moved from run_rc_command), and >>>>>>> setting >>>>>>> etcdir accordingly. >>>>>>> >>>>>>> The point is that some scripts (like rc.d/sshd) can be used >>>>>>> for base >>>>>>> sshd as well as ports sshd, and makes possible to source >>>>>>> ${prefix}/etc/rc.conf.d/${name}. >>>>>>> >>>>>>> This patch also documents ${name}_program above run_rc_command >>>>>>> (though >>>>>>> it's actually used in load_rc_config). >>>>>> >>>>>> Is command always set? I'm pretty sure it isn't so this may >>>>>> not be >>>>>> entierly >>>>>> safe. If it's not set, should we try to guess prefix from $0? >>>>> >>>>> Somehow, command gets set to the right value, but you're right, >>>>> I'm >>>>> missing a bit here. >>>> >>>> Hum, re-reading rc.subr, you were right, so I just did what you >>>> supposed. >>> >>> Thinking about this a bit more, in the guessing frmo $0 case, >>> your proposed >>> code: >>> >>> + prefix=${0%/etc/rc.d/*}/ >>> >>> won't work reliably when the user uses a relative path. I think >>> something >>> like this would be better: >>> >>> _tmp=`/bin/realpath $0` >>> prefix=${_tmp%/etc/rc.d/*}/ >> >> Indeed, fixed. >> >>>>>> The other issue I see is that instead of: >>>>>> >>>>>> if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then >>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" >>>>>> . ${etcdir}/rc.conf.d/"$_command" >>>>>> fi >>>>>> >>>>>> I think we should do: >>>>>> >>>>>> if [ -f /etc/rc.conf.d/"$_command" ]; then >>>>>> debug "Sourcing /etc/rc.conf.d/${_command}" >>>>>> . /etc/rc.conf.d/"$_command" >>>>>> fi >>>>>> if [ "${etcdir}" != "/etc" -a -f ${etcdir}/ >>>>>> rc.conf.d/"$_command" ]; then >>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" >>>>>> . ${etcdir}/rc.conf.d/"$_command" >>>>>> fi >>>>>> >>>>>> That preserves the old behavior while adding support for >>>>>> ${prefix}/etc/rc.conf.d. >>>>> >>>>> Fair enough, but I'd like to add a note saying that /etc/ >>>>> rc.conf.d/$ >>>>> {name} is deprecated for ${etcdir} != "/etc". >>> >>> The deprecation warning should not be printed in the case that $ >>> {etcdir} >>> is /etc. You should also avoid sourcing the file twice in the /etc >>> case. The easiest way to do that is probably to make the first case >>> contingent on ${etcdir} != /etc. >> >> Next time I'll test my changes (and sleep more). >> >> Did that too, and added a check to test if there's a >> ${etcdir}/rc.conf.d/${_command} file. > > Testing prefix=/ isn't sufficent since prefix could also be /usr. You > should check etcdir=/etc. True. > I don't think there's much point in the second test. I don't like > silent > ignoring of files, it's really hard to debug. Instead, I'd source > the file > in that case, but print a warning that two files exist. I thought there might be cases where you'd want different options in / etc/rc.conf.d/$name and $etcdir/rc.conf.d/$name. So keeping both made sense. >> Patch updated : http://people.freebsd.org/~flz/local/rc.d-sshd.diff >> >> BTW, I think that we should s/_command/_name/ in load_rc_config(), >> this >> is a bit confusing. > > That sounds reasonable. Ok, will do then. I've merged latest rc.subr changes from NetBSD too, will post the diff with everything tomorrow in the (european) morning. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 18:42:42 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 111AC16A436; Tue, 28 Mar 2006 18:42:42 +0000 (UTC) (envelope-from simon@zaphod.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF6FB43E1A; Tue, 28 Mar 2006 18:41:59 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: from zaphod.nitro.dk (unknown [192.168.3.18]) by mx.nitro.dk (Postfix) with ESMTP id 827872D48CD; Tue, 28 Mar 2006 18:40:44 +0000 (UTC) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 4E6811141E; Tue, 28 Mar 2006 20:41:57 +0200 (CEST) Date: Tue, 28 Mar 2006 20:41:57 +0200 From: "Simon L. Nielsen" To: Doug Barton Message-ID: <20060328184156.GA968@zaphod.nitro.dk> References: <20060117075817.GA8473@droopy.unibe.ch> <43CCA738.20601@FreeBSD.org> <20060117101325.GB938@eddie.nitro.dk> <20060326112150.GC828@zaphod.nitro.dk> <4426EF81.4090407@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <4426EF81.4090407@FreeBSD.org> User-Agent: Mutt/1.5.11 Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ike broken. retire it? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 18:42:42 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [Cc: trimmed] On 2006.03.26 11:46:09 -0800, Doug Barton wrote: > Simon L. Nielsen wrote: >=20 > > So, I finally got around to adding an rc.d script to the isakmpd port. >=20 > Thanks! If I can make one small suggestion, you might want to review the > section on rc.d scripts in the Porter's Handbook for a couple small point= s, > but other than that it looks good! Oh, I wasn't aware we had gotten such a section :-). I fixed the obvious things I noticed from the sample script. > > Both racoon2 and ipsec-tools also installs rc.d scipts now, so are > > there any objections to removing the src/etc/rc.d/ike script from > > HEAD? >=20 > No objections here, please sharpen that axe! It's probably worth also > MFC'ing the change after the 6.1-RELEASE, IMO. OK it's gone :-). WRT. MFC, I guess anyone who actually uses the ike script (for whatever reason) can just tell mergemaster not to delete it, so POLA shouldn't be a problem? --=20 Simon L. Nielsen --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEKYN0h9pcDSc1mlERAuWPAJ9zM7hzTr8mU4VukO7x3O9jBkmTbQCfeJmK k2f26GzjI1wFOtRAYKNc+28= =Osfy -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7-- From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 22:38:52 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC20716A60A for ; Tue, 28 Mar 2006 22:38:52 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id A965E43E1F for ; Tue, 28 Mar 2006 22:05:21 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 96018 invoked by uid 399); 28 Mar 2006 22:05:20 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 28 Mar 2006 22:05:20 -0000 Message-ID: <4429B31E.2010803@FreeBSD.org> Date: Tue, 28 Mar 2006 14:05:18 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20060112) MIME-Version: 1.0 To: Dirk Engling References: <4426B641.7030203@erdgeist.org> In-Reply-To: <4426B641.7030203@erdgeist.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: Extend the rc interface for configuration X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 22:38:55 -0000 Dirk Engling wrote: > Dear rc-hackers, > > in my understanding the rc.d interface is a generic abstraction of > common actions you want to perform on server software. Alas, such is not the case. You can get more information at http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/configtuning-rcd.html > When administrating lots of servers of different type I stumbled accross > many configuration actions that were similar, for example > adding/removing virtual hosts and users for my mail/ web/ ftp/ name/ > jabber-server, configuring ports, logfiles, ssl-ports + certs/ keys etc. There are already excellent tools to deal with the class of problems you describe, the most popular being cfengine. hth, Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Tue Mar 28 22:40:26 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93EB316A432 for ; Tue, 28 Mar 2006 22:40:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1079F43D97 for ; Tue, 28 Mar 2006 22:40:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2SMeLF9023760 for ; Tue, 28 Mar 2006 22:40:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2SMeLrm023759; Tue, 28 Mar 2006 22:40:21 GMT (envelope-from gnats) Date: Tue, 28 Mar 2006 22:40:21 GMT Message-Id: <200603282240.k2SMeLrm023759@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Freddie Cash Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Freddie Cash List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 22:40:26 -0000 The following reply was made to PR bin/94767; it has been noted by GNATS. From: Freddie Cash To: bug-followup@freebsd.org Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) Date: Tue, 28 Mar 2006 14:37:47 -0800 I've submitted a PR (ports/94802) that should fix the dansguardian circular dependency issue (and make the RC script work correcty in 'the new world order'). Hopefully, it also fixes the core dump for dansguardian. Testing on my 6.0 box shows no errors. Don't have access to a -CURRENT box to test on there. -- Freddie Cash, LPIC-1 CCNT CCLP Helpdesk / Network Support Tech. School District 73 (250) 377-HELP [377-4357] fcash@sd73.bc.ca helpdesk@sd73.bc.ca From owner-freebsd-rc@FreeBSD.ORG Wed Mar 29 23:48:57 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99D0116A401 for ; Wed, 29 Mar 2006 23:48:57 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 079FC43D45 for ; Wed, 29 Mar 2006 23:48:56 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 033631183A; Thu, 30 Mar 2006 01:48:54 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 46711-08; Thu, 30 Mar 2006 01:48:43 +0200 (CEST) Received: from [192.168.1.102] (unknown [83.141.123.209]) by smtp.xbsd.org (Postfix) with ESMTP id C729311608; Thu, 30 Mar 2006 01:48:41 +0200 (CEST) In-Reply-To: <9783E661-7B92-47ED-ABF3-EC1AC4369CE0@xbsd.org> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> <20060327183745.GA19473@odin.ac.hmc.edu> <1143556715.65237.4.camel@mayday.esat.net> <20060328170842.GA16561@odin.ac.hmc.edu> <9783E661-7B92-47ED-ABF3-EC1AC4369CE0@xbsd.org> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Thu, 30 Mar 2006 00:48:24 +0100 To: Brooks Davis X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2006 23:48:57 -0000 On Mar 28, 2006, at 6:30 PM, Florent Thoumie wrote: > On Mar 28, 2006, at 6:08 PM, Brooks Davis wrote: > >> On Tue, Mar 28, 2006 at 03:38:35PM +0100, Florent Thoumie wrote: >>> On Mon, 2006-03-27 at 10:37 -0800, Brooks Davis wrote: >>>> On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: >>>>> On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: >>>>>> On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: >>>>>> >>>>>>> On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: >>>>>>>> This is based on Oliver's patch for rc.d/sshd that can be >>>>>>>> found in >>>>>>>> Gnats. >>>>>>>> >>>>>>>> In load_rc_config, I'm extracting prefix from ${command} (or >>>>>>>> ${name}_program, which part is moved from run_rc_command), and >>>>>>>> setting >>>>>>>> etcdir accordingly. >>>>>>>> >>>>>>>> The point is that some scripts (like rc.d/sshd) can be used >>>>>>>> for base >>>>>>>> sshd as well as ports sshd, and makes possible to source >>>>>>>> ${prefix}/etc/rc.conf.d/${name}. >>>>>>>> >>>>>>>> This patch also documents ${name}_program above run_rc_command >>>>>>>> (though >>>>>>>> it's actually used in load_rc_config). >>>>>>> >>>>>>> Is command always set? I'm pretty sure it isn't so this may >>>>>>> not be >>>>>>> entierly >>>>>>> safe. If it's not set, should we try to guess prefix from $0? >>>>>> >>>>>> Somehow, command gets set to the right value, but you're >>>>>> right, I'm >>>>>> missing a bit here. >>>>> >>>>> Hum, re-reading rc.subr, you were right, so I just did what you >>>>> supposed. >>>> >>>> Thinking about this a bit more, in the guessing frmo $0 case, >>>> your proposed >>>> code: >>>> >>>> + prefix=${0%/etc/rc.d/*}/ >>>> >>>> won't work reliably when the user uses a relative path. I think >>>> something >>>> like this would be better: >>>> >>>> _tmp=`/bin/realpath $0` >>>> prefix=${_tmp%/etc/rc.d/*}/ >>> >>> Indeed, fixed. >>> >>>>>>> The other issue I see is that instead of: >>>>>>> >>>>>>> if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then >>>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" >>>>>>> . ${etcdir}/rc.conf.d/"$_command" >>>>>>> fi >>>>>>> >>>>>>> I think we should do: >>>>>>> >>>>>>> if [ -f /etc/rc.conf.d/"$_command" ]; then >>>>>>> debug "Sourcing /etc/rc.conf.d/${_command}" >>>>>>> . /etc/rc.conf.d/"$_command" >>>>>>> fi >>>>>>> if [ "${etcdir}" != "/etc" -a -f ${etcdir}/ >>>>>>> rc.conf.d/"$_command" ]; then >>>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" >>>>>>> . ${etcdir}/rc.conf.d/"$_command" >>>>>>> fi >>>>>>> >>>>>>> That preserves the old behavior while adding support for >>>>>>> ${prefix}/etc/rc.conf.d. >>>>>> >>>>>> Fair enough, but I'd like to add a note saying that /etc/ >>>>>> rc.conf.d/$ >>>>>> {name} is deprecated for ${etcdir} != "/etc". >>>> >>>> The deprecation warning should not be printed in the case that $ >>>> {etcdir} >>>> is /etc. You should also avoid sourcing the file twice in the /etc >>>> case. The easiest way to do that is probably to make the first >>>> case >>>> contingent on ${etcdir} != /etc. >>> >>> Next time I'll test my changes (and sleep more). >>> >>> Did that too, and added a check to test if there's a >>> ${etcdir}/rc.conf.d/${_command} file. >> >> Testing prefix=/ isn't sufficent since prefix could also be /usr. >> You >> should check etcdir=/etc. > > True. > >> I don't think there's much point in the second test. I don't like >> silent >> ignoring of files, it's really hard to debug. Instead, I'd source >> the file >> in that case, but print a warning that two files exist. > > I thought there might be cases where you'd want different options > in /etc/rc.conf.d/$name and $etcdir/rc.conf.d/$name. So keeping > both made sense. > >>> Patch updated : http://people.freebsd.org/~flz/local/rc.d-sshd.diff >>> >>> BTW, I think that we should s/_command/_name/ in load_rc_config >>> (), this >>> is a bit confusing. >> >> That sounds reasonable. > > Ok, will do then. > > I've merged latest rc.subr changes from NetBSD too, will post the > diff with everything tomorrow in the (european) morning. Here's new diff (merge from NetBSD + load_rc_config changes) : http://people.freebsd.org/~flz/local/rc.d-merge-sshd.diff I'm still unsure about what you proposed (warning when both /etc/ rc.conf.d/${name} and ${etcdir}/rc.conf.d/${name} exist). It would be nice to have comments from somebody else. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Thu Mar 30 04:11:52 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDB3016A420 for ; Thu, 30 Mar 2006 04:11:52 +0000 (UTC) (envelope-from duane@greenmeadow.ca) Received: from smtpout.eastlink.ca (smtpout.eastlink.ca [24.222.0.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56A9E43D49 for ; Thu, 30 Mar 2006 04:11:52 +0000 (GMT) (envelope-from duane@greenmeadow.ca) Received: from ip03.eastlink.ca ([24.222.10.15]) by mta01.eastlink.ca (Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005)) with ESMTP id <0IWX00HBEABIOYU0@mta01.eastlink.ca> for freebsd-rc@freebsd.org; Thu, 30 Mar 2006 00:11:42 -0400 (AST) Received: from blk-224-199-230.eastlink.ca (HELO [192.168.0.103]) ([24.224.199.230]) by ip03.eastlink.ca with ESMTP; Thu, 30 Mar 2006 00:11:46 -0400 Date: Thu, 30 Mar 2006 00:10:54 -0400 From: Duane Whitty To: freebsd-rc@freebsd.org Message-id: <442B5A4E.5000403@greenmeadow.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-BrightmailFiltered: true X-Brightmail-Tracker: AAAAAQAAA+k= User-Agent: Thunderbird 1.5 (X11/20060309) Subject: script processing order X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2006 04:11:52 -0000 Hi, Am I correct in believing that CUPS should be running before Samba is started? It appears from my console messages that Samba (nmbd and smbd) appears to be launched before CUPS (cupsd). Samba then complains for a while that it cannot connect to the CUPS server. I'm working on serving up my local CUPS based printer to MS-Windows XP clients and I would like to rule this situation out as a problem. I interpreted rc(8) to mean that scripts in /usr/local/etc/rc.d/ would be processed in lexicographical order. Does this only hold true for scripts in /etc/rc.d? Do I need a BEFORE entry in cupsd.sh such as BEFORE nmbd if I want CUPS loaded before Samba? Thanks in advance, --Duane -------------------------------------------- dwpc@ /home/duane# uname -a FreeBSD dwpc.dwlabs.ca 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #1: Fri Mar 24 19:34:58 AST 2006 root@dwpc.dwlabs.ca:/usr/obj/usr/src/sys/DWPC-200603230410 i386 extract of /var/log/console.log -------------------------------------------- Mar 29 23:08:06 dwpc kernel: Starting named. Mar 29 23:08:07 dwpc kernel: Starting SAMBA: removing stale tdbs : Mar 29 23:08:07 dwpc kernel: /var/db/samba/connections.tdb Mar 29 23:08:07 dwpc kernel: /var/db/samba/messages.tdb Mar 29 23:08:07 dwpc kernel: /var/db/samba/sessionid.tdb Mar 29 23:08:07 dwpc kernel: /var/db/samba/unexpected.tdb Mar 29 23:08:07 dwpc kernel: /var/db/samba/brlock.tdb Mar 29 23:08:07 dwpc kernel: /var/db/samba/locking.tdb Mar 29 23:08:07 dwpc kernel: Starting nmbd. Mar 29 23:08:08 dwpc kernel: Starting smbd. Mar 29 23:08:08 dwpc kernel: Mar 29 23:08:08 dwpc smbd[536]: [2006/03/29 23:08:08, 0] printing/ print_cups.c:cups_cache_reload(85) Mar 29 23:08:08 dwpc kernel: Mar 29 23:08:08 dwpc smbd[536]: Unable to connect to CUPS server localhost - Connection refused Mar 29 23:08:08 dwpc kernel: Mar 29 23:08:08 dwpc smbd[536]: [2006/03/29 23:08:08, 0] printing/ print_cups.c:cups_cache_reload(85) Mar 29 23:08:08 dwpc kernel: Mar 29 23:08:08 dwpc smbd[536]: Unable to connect to CUPS server localhost - Connection refused Mar 29 23:08:08 dwpc kernel: Starting cupsd.