From owner-freebsd-rc@FreeBSD.ORG Mon Apr 3 11:03:04 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DB1A16A420 for ; Mon, 3 Apr 2006 11:03:04 +0000 (UTC) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5573443D48 for ; Mon, 3 Apr 2006 11:03:04 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k33B34Ra006035 for ; Mon, 3 Apr 2006 11:03:04 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k33B33SK006029 for freebsd-rc@freebsd.org; Mon, 3 Apr 2006 11:03:03 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 3 Apr 2006 11:03:03 GMT Message-Id: <200604031103.k33B33SK006029@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 11:03:04 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2006/02/13] conf/93287 rc [patch] Make rc.subr jail-aware o [2006/03/12] conf/94377 rc [patch] /etc/rc.d/sshd improperly tests r 2 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2002/11/12] conf/45226 rc Fix for rc.network, ppp-user annoyance o [2004/11/13] conf/73909 rc [patch] rc.d/sshd does not work with port o [2005/02/18] conf/77663 rc Suggestion: add /etc/rc.d/addnetswap afte o [2005/03/16] conf/78906 rc [patch] Allow mixer_enable="NO" in rc.con o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces o [2005/06/28] conf/82738 rc [patch] add amd_program line to defaults/ o [2005/08/27] conf/85363 rc syntax error in /etc/rc.d/devfs o [2005/11/13] conf/88913 rc [patch] wrapper support for rc.subr o [2005/11/14] conf/88974 rc autoconfigured vlans confuse rc.d/netif o [2005/12/03] conf/89870 rc [patch] feature request to make netif ver o [2006/01/30] conf/92523 rc [patch] allow rc scripts to kill process o [2006/02/25] conf/93815 rc [patch] Adds in the ability to save ipfw o [2006/03/21] bin/94767 rc [patch] rcorder(8) dumps core when does n 13 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Apr 3 22:57:45 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82D4416A41F for ; Mon, 3 Apr 2006 22:57:45 +0000 (UTC) (envelope-from wmoran@collaborativefusion.com) Received: from mx00.pub.collaborativefusion.com (mx00.pub.collaborativefusion.com [206.210.89.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D99143D76 for ; Mon, 3 Apr 2006 22:57:44 +0000 (GMT) (envelope-from wmoran@collaborativefusion.com) Received: from vanquish.pgh.priv.collaborativefusion.com (vanquish.pgh.priv.collaborativefusion.com [192.168.2.61]) by wingspan with esmtp; Mon, 03 Apr 2006 18:57:44 -0400 id 00056416.4431A868.00008A77 Date: Mon, 3 Apr 2006 18:57:44 -0400 From: Bill Moran To: freebsd-rc@freebsd.org Message-Id: <20060403185744.61697002.wmoran@collaborativefusion.com> Organization: Collaborative Fusion X-Mailer: Sylpheed version 2.2.0 (GTK+ 2.8.12; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: syslogd script bug?: syslogd_program= not honored X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 22:57:45 -0000 It doesn't seem as if syslogd_program (in rc.conf) is honored. To reproduce, install syslog-ng, then set the following in /etc/rc.conf: syslogd_enable="YES" syslogd_program="/usr/local/sbin/syslog-ng" This does not result in syslog-ng starting - in fact, it seems as if the FreeBSD syslogd is still started. In my (unexpert) opinion, the problem is that /etc/rc.d/syslogd contains the line: command="/usr/sbin/${name}" which seems atypical compared to other rc.d scripts. I'm not sure if the rc.d/syslogd script can reliably start other syslog- ish programs. The syslogd_precmd() makes me wonder if this script would be problematic starting anything but FreeBSD's syslogd. There's definately an issue, since syslogd_program doesn't work as advertised. My question is whether it's a documentation issue (the references to syslogd_program should be removed) or a bug in the rc.d script. -- Bill Moran Collaborative Fusion Inc. From owner-freebsd-rc@FreeBSD.ORG Mon Apr 3 23:41:17 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D3B416A440 for ; Mon, 3 Apr 2006 23:41:17 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7786943D55 for ; Mon, 3 Apr 2006 23:41:16 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k33NfFeV008841; Mon, 3 Apr 2006 16:41:15 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k33NfFmS008840; Mon, 3 Apr 2006 16:41:15 -0700 Date: Mon, 3 Apr 2006 16:41:15 -0700 From: Brooks Davis To: Florent Thoumie Message-ID: <20060403234115.GA6719@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> <1143461191.4290.5.camel@mayday.esat.net> <20060327183745.GA19473@odin.ac.hmc.edu> <1143556715.65237.4.camel@mayday.esat.net> <20060328170842.GA16561@odin.ac.hmc.edu> <9783E661-7B92-47ED-ABF3-EC1AC4369CE0@xbsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 23:41:17 -0000 --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 30, 2006 at 12:48:24AM +0100, Florent Thoumie wrote: > On Mar 28, 2006, at 6:30 PM, Florent Thoumie wrote: >=20 > >On Mar 28, 2006, at 6:08 PM, Brooks Davis wrote: > > > >>On Tue, Mar 28, 2006 at 03:38:35PM +0100, Florent Thoumie wrote: > >>>On Mon, 2006-03-27 at 10:37 -0800, Brooks Davis wrote: > >>>>On Mon, Mar 27, 2006 at 01:06:30PM +0100, Florent Thoumie wrote: > >>>>>On Sat, 2006-03-25 at 11:06 +0000, Florent Thoumie wrote: > >>>>>>On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > >>>>>> > >>>>>>>On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > >>>>>>>>This is based on Oliver's patch for rc.d/sshd that can be =20 > >>>>>>>>found in > >>>>>>>>Gnats. > >>>>>>>> > >>>>>>>>In load_rc_config, I'm extracting prefix from ${command} (or > >>>>>>>>${name}_program, which part is moved from run_rc_command), and > >>>>>>>>setting > >>>>>>>>etcdir accordingly. > >>>>>>>> > >>>>>>>>The point is that some scripts (like rc.d/sshd) can be used =20 > >>>>>>>>for base > >>>>>>>>sshd as well as ports sshd, and makes possible to source > >>>>>>>>${prefix}/etc/rc.conf.d/${name}. > >>>>>>>> > >>>>>>>>This patch also documents ${name}_program above run_rc_command > >>>>>>>>(though > >>>>>>>>it's actually used in load_rc_config). > >>>>>>> > >>>>>>>Is command always set? I'm pretty sure it isn't so this may =20 > >>>>>>>not be > >>>>>>>entierly > >>>>>>>safe. If it's not set, should we try to guess prefix from $0? > >>>>>> > >>>>>>Somehow, command gets set to the right value, but you're =20 > >>>>>>right, I'm > >>>>>>missing a bit here. > >>>>> > >>>>>Hum, re-reading rc.subr, you were right, so I just did what you > >>>>>supposed. > >>>> > >>>>Thinking about this a bit more, in the guessing frmo $0 case, =20 > >>>>your proposed > >>>>code: > >>>> > >>>>+ prefix=3D${0%/etc/rc.d/*}/ > >>>> > >>>>won't work reliably when the user uses a relative path. I think =20 > >>>>something > >>>>like this would be better: > >>>> > >>>> _tmp=3D`/bin/realpath $0` > >>>> prefix=3D${_tmp%/etc/rc.d/*}/ > >>> > >>>Indeed, fixed. > >>> > >>>>>>>The other issue I see is that instead of: > >>>>>>> > >>>>>>> if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > >>>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > >>>>>>> . ${etcdir}/rc.conf.d/"$_command" > >>>>>>> fi > >>>>>>> > >>>>>>>I think we should do: > >>>>>>> > >>>>>>> if [ -f /etc/rc.conf.d/"$_command" ]; then > >>>>>>> debug "Sourcing /etc/rc.conf.d/${_command}" > >>>>>>> . /etc/rc.conf.d/"$_command" > >>>>>>> fi > >>>>>>> if [ "${etcdir}" !=3D "/etc" -a -f ${etcdir}/ > >>>>>>>rc.conf.d/"$_command" ]; then > >>>>>>> debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > >>>>>>> . ${etcdir}/rc.conf.d/"$_command" > >>>>>>> fi > >>>>>>> > >>>>>>>That preserves the old behavior while adding support for > >>>>>>>${prefix}/etc/rc.conf.d. > >>>>>> > >>>>>>Fair enough, but I'd like to add a note saying that /etc/=20 > >>>>>>rc.conf.d/$ > >>>>>>{name} is deprecated for ${etcdir} !=3D "/etc". > >>>> > >>>>The deprecation warning should not be printed in the case that $=20 > >>>>{etcdir} > >>>>is /etc. You should also avoid sourcing the file twice in the /etc > >>>>case. The easiest way to do that is probably to make the first =20 > >>>>case > >>>>contingent on ${etcdir} !=3D /etc. > >>> > >>>Next time I'll test my changes (and sleep more). > >>> > >>>Did that too, and added a check to test if there's a > >>>${etcdir}/rc.conf.d/${_command} file. > >> > >>Testing prefix=3D/ isn't sufficent since prefix could also be /usr. = =20 > >>You > >>should check etcdir=3D/etc. > > > >True. > > > >>I don't think there's much point in the second test. I don't like =20 > >>silent > >>ignoring of files, it's really hard to debug. Instead, I'd source =20 > >>the file > >>in that case, but print a warning that two files exist. > > > >I thought there might be cases where you'd want different options =20 > >in /etc/rc.conf.d/$name and $etcdir/rc.conf.d/$name. So keeping =20 > >both made sense. > > > >>>Patch updated : http://people.freebsd.org/~flz/local/rc.d-sshd.diff > >>> > >>>BTW, I think that we should s/_command/_name/ in load_rc_config=20 > >>>(), this > >>>is a bit confusing. > >> > >>That sounds reasonable. > > > >Ok, will do then. > > > >I've merged latest rc.subr changes from NetBSD too, will post the =20 > >diff with everything tomorrow in the (european) morning. >=20 > Here's new diff (merge from NetBSD + load_rc_config changes) : >=20 > http://people.freebsd.org/~flz/local/rc.d-merge-sshd.diff >=20 > I'm still unsure about what you proposed (warning when both /etc/=20 > rc.conf.d/${name} and ${etcdir}/rc.conf.d/${name} exist). It would =20 > be nice to have comments from somebody else. I suggested the warning because it's hard to diagnose issues since a change to /etc/rc.conf.d/xxx won't do anything if it's set in ${etcdir}/etc/rc.conf.d/xxx in that case and you suggested marking /etc/rc.conf.d/ deprecated for scripts who's etcdir wasn't /etc. If it's not deprecated, the warning isn't needed. Other than resolving that issue one way or another I'm happy with this patch. I'd suggest committing the NetBSD changes separately from local changes where possible. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --liOOAslEiF7prFVr Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEMbKaXY6L6fI4GtQRAg19AKDKiQNZLz4jyqekc8XTwlM+Fq/TPwCeIUQb P6XMobfHSbRDjd8x3LWD+2A= =azu0 -----END PGP SIGNATURE----- --liOOAslEiF7prFVr-- From owner-freebsd-rc@FreeBSD.ORG Mon Apr 3 23:43:34 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0125C16A423 for ; Mon, 3 Apr 2006 23:43:34 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id A69BF43D49 for ; Mon, 3 Apr 2006 23:43:33 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k33NhWKF009104; Mon, 3 Apr 2006 16:43:32 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k33NhWN8009103; Mon, 3 Apr 2006 16:43:32 -0700 Date: Mon, 3 Apr 2006 16:43:32 -0700 From: Brooks Davis To: Bill Moran Message-ID: <20060403234332.GB6719@odin.ac.hmc.edu> References: <20060403185744.61697002.wmoran@collaborativefusion.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline In-Reply-To: <20060403185744.61697002.wmoran@collaborativefusion.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new Cc: freebsd-rc@freebsd.org Subject: Re: syslogd script bug?: syslogd_program= not honored X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 23:43:34 -0000 --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2006 at 06:57:44PM -0400, Bill Moran wrote: >=20 > It doesn't seem as if syslogd_program (in rc.conf) is honored. >=20 > To reproduce, install syslog-ng, then set the following in /etc/rc.conf: > syslogd_enable=3D"YES" > syslogd_program=3D"/usr/local/sbin/syslog-ng" >=20 > This does not result in syslog-ng starting - in fact, it seems as if > the FreeBSD syslogd is still started. >=20 > In my (unexpert) opinion, the problem is that /etc/rc.d/syslogd contains > the line: > command=3D"/usr/sbin/${name}" > which seems atypical compared to other rc.d scripts. >=20 > I'm not sure if the rc.d/syslogd script can reliably start other syslog- > ish programs. The syslogd_precmd() makes me wonder if this script would > be problematic starting anything but FreeBSD's syslogd. >=20 > There's definately an issue, since syslogd_program doesn't work as > advertised. My question is whether it's a documentation issue (the > references to syslogd_program should be removed) or a bug in the > rc.d script. It's a bug in the script. flz has patches that correct it by causing ${name}_program to unconditionally override command if both are set which fixes it in the infrastructure (along with other things). Here's the latest: http://people.freebsd.org/~flz/local/rc.d-merge-sshd.diff -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEMbMjXY6L6fI4GtQRAps0AJwOh87j4qaxqWvRUaG52Jv4Gm1b2QCeIgJ6 11zLtJ2UWA4tE5ZhU1aChs8= =QR14 -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE-- From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 09:51:15 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF72416A401 for ; Tue, 4 Apr 2006 09:51:15 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE87043D5D for ; Tue, 4 Apr 2006 09:51:12 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 29C4E118E5; Tue, 4 Apr 2006 11:51:08 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 78733-01; Tue, 4 Apr 2006 11:50:57 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id B99F2118A6; Tue, 4 Apr 2006 11:50:56 +0200 (CEST) From: Florent Thoumie To: Brooks Davis In-Reply-To: <20060403234332.GB6719@odin.ac.hmc.edu> References: <20060403185744.61697002.wmoran@collaborativefusion.com> <20060403234332.GB6719@odin.ac.hmc.edu> Content-Type: text/plain Date: Tue, 04 Apr 2006 10:50:55 +0100 Message-Id: <1144144255.65237.29.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: syslogd script bug?: syslogd_program= not honored X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 09:51:15 -0000 On Mon, 2006-04-03 at 16:43 -0700, Brooks Davis wrote: > On Mon, Apr 03, 2006 at 06:57:44PM -0400, Bill Moran wrote: > > > > It doesn't seem as if syslogd_program (in rc.conf) is honored. > > > > To reproduce, install syslog-ng, then set the following in /etc/rc.conf: > > syslogd_enable="YES" > > syslogd_program="/usr/local/sbin/syslog-ng" > > > > This does not result in syslog-ng starting - in fact, it seems as if > > the FreeBSD syslogd is still started. > > > > In my (unexpert) opinion, the problem is that /etc/rc.d/syslogd contains > > the line: > > command="/usr/sbin/${name}" > > which seems atypical compared to other rc.d scripts. > > > > I'm not sure if the rc.d/syslogd script can reliably start other syslog- > > ish programs. The syslogd_precmd() makes me wonder if this script would > > be problematic starting anything but FreeBSD's syslogd. > > > > There's definately an issue, since syslogd_program doesn't work as > > advertised. My question is whether it's a documentation issue (the > > references to syslogd_program should be removed) or a bug in the > > rc.d script. > > It's a bug in the script. flz has patches that correct it by causing > ${name}_program to unconditionally override command if both are set > which fixes it in the infrastructure (along with other things). Here's > the latest: > > http://people.freebsd.org/~flz/local/rc.d-merge-sshd.diff Hum, my patch doesn't do anything like this actually. I guess the problems comes from syslogd_flags being "-s" in /etc/defaults/rc.conf. Setting syslogd_flags="" in /etc/rc.conf should fix it. I could remove the startup script installed by sysutils/syslog-ng and tweak /etc/rc.d/syslogd to take required_files in account. Will do this later. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 11:06:46 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6F3716A420 for ; Tue, 4 Apr 2006 11:06:46 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C51E43D46 for ; Tue, 4 Apr 2006 11:06:46 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id A288F118E5; Tue, 4 Apr 2006 13:06:41 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 79364-03; Tue, 4 Apr 2006 13:06:19 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 7F7791183A; Tue, 4 Apr 2006 13:06:18 +0200 (CEST) From: Florent Thoumie To: Brooks Davis In-Reply-To: <1144144255.65237.29.camel@mayday.esat.net> References: <20060403185744.61697002.wmoran@collaborativefusion.com> <20060403234332.GB6719@odin.ac.hmc.edu> <1144144255.65237.29.camel@mayday.esat.net> Content-Type: text/plain Date: Tue, 04 Apr 2006 12:06:12 +0100 Message-Id: <1144148772.65237.37.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: syslogd script bug?: syslogd_program= not honored X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 11:06:46 -0000 On Tue, 2006-04-04 at 10:50 +0100, Florent Thoumie wrote: > I could remove the startup script installed by sysutils/syslog-ng and > tweak /etc/rc.d/syslogd to take required_files in account. Actually, it would need more work than I first thought. Maybe it's time to introduce a new ${name}_conf variable and make it default for required_files. I'm not sure if this is worth the pain, since there might not be a lot of programs concerned (present in base and alternatives in ports having different name for its configuration file). -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 19:42:58 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72F3E16A401 for ; Tue, 4 Apr 2006 19:42:58 +0000 (UTC) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (corp.grupos.com.br [200.193.29.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5EEF43D46 for ; Tue, 4 Apr 2006 19:42:57 +0000 (GMT) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (localhost [127.0.0.1]) by corp.grupos.com.br (Postfix) with ESMTP id 0F9AF5570 for ; Tue, 4 Apr 2006 16:42:54 -0300 (BRT) Received: from [192.168.10.10] (marcus.grupos.com.br [192.168.10.10]) by corp.grupos.com.br (Postfix) with ESMTP id E0D68556B for ; Tue, 4 Apr 2006 16:42:53 -0300 (BRT) Message-ID: <4432CC3D.5070501@FreeBSD.org> Date: Tue, 04 Apr 2006 16:42:53 -0300 From: Marcus Alves Grando Organization: FreeBSD.org User-Agent: Thunderbird 1.5 (X11/20060114) MIME-Version: 1.0 To: freebsd-rc@freebsd.org X-Enigmail-Version: 0.94.0.0 Content-Type: multipart/mixed; boundary="------------020206030900080402010707" X-Filtered: By ProxSMTP using Clamav and Bogofilter Subject: compat{4,5}x X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 19:42:58 -0000 This is a multi-part message in MIME format. --------------020206030900080402010707 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi list, Please look my message to portmgr@ about compat{4,5}x ports. -------- Original Message -------- Subject: Re: compat5x Date: Tue, 4 Apr 2006 14:35:43 -0400 From: Kris Kennaway To: Marcus Alves Grando CC: portmgr@FreeBSD.org References: <44317910.7060809@FreeBSD.org> On Mon, Apr 03, 2006 at 04:35:44PM -0300, Marcus Alves Grando wrote: > Portmgr's > > After migrate two servers from 5.x to 6.x, i produce this patch [1]. > This patch fix rcorder to start compat5x before programs compiled in > 5.x. Another point is turn "YES" by default in compat5x. I think if user > install compat5x that's because he's need. > > Another option is use misc/ldconfig_compat in compat5x. > > What portmgr's thinking about this changes? I agree that compatNx ports should be enabled automatically. I don't know about rcorder issues; please discuss them with the freebsd-rc list. Kris > [1] > http://marcus.grupos.com.br:8080/patch/compat5x.patch -- Marcus Alves Grando marcus(at)corp.grupos.com.br | Grupos Internet S/A mnag(at)FreeBSD.org | FreeBSD.org --------------020206030900080402010707 Content-Type: application/pgp-signature; name="file:///tmp/nsmail-1.tmp" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="file:///tmp/nsmail-1.tmp" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC4yLjIg KEZyZWVCU0QpCgppRDhEQlFGRU1yeC9XcnkwQldqb1FLVVJBdHVKQUo5Qm8zcWhJNVFOUjVh QmlRdEtRWUlJMlBrdk13Q2ZiNVBBCmRXTDM3RVhtYkI3cFA1cEYybFkxVkpFPQo9Y3pubQot LS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0KCg== --------------020206030900080402010707-- From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 20:23:55 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C92CC16A443; Tue, 4 Apr 2006 20:23:55 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C2A343D4C; Tue, 4 Apr 2006 20:23:55 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k34KNsxk003545; Tue, 4 Apr 2006 13:23:54 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k34KNs68003544; Tue, 4 Apr 2006 13:23:54 -0700 Date: Tue, 4 Apr 2006 13:23:54 -0700 From: Brooks Davis To: Marcus Alves Grando Message-ID: <20060404202354.GA2798@odin.ac.hmc.edu> References: <4432CC3D.5070501@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <4432CC3D.5070501@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new Cc: freebsd-rc@freebsd.org Subject: Re: compat{4,5}x X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 20:23:55 -0000 --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2006 at 04:42:53PM -0300, Marcus Alves Grando wrote: > Hi list, >=20 > Please look my message to portmgr@ about compat{4,5}x ports. >=20 > -------- Original Message -------- > Subject: Re: compat5x > Date: Tue, 4 Apr 2006 14:35:43 -0400 > From: Kris Kennaway > To: Marcus Alves Grando > CC: portmgr@FreeBSD.org > References: <44317910.7060809@FreeBSD.org> >=20 > On Mon, Apr 03, 2006 at 04:35:44PM -0300, Marcus Alves Grando wrote: > > Portmgr's > >=20 > > After migrate two servers from 5.x to 6.x, i produce this patch [1]. > > This patch fix rcorder to start compat5x before programs compiled in > > 5.x. Another point is turn "YES" by default in compat5x. I think if user > > install compat5x that's because he's need. > > > > Another option is use misc/ldconfig_compat in compat5x. > >=20 > > What portmgr's thinking about this changes? >=20 > I agree that compatNx ports should be enabled automatically. I don't > know about rcorder issues; please discuss them with the freebsd-rc > list. misc/ldconfig_compat should be used. These sorts of scripts should just die for a number of reasons including the fact that rc.d scripts aren't supposted to start by default. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEMtXZXY6L6fI4GtQRAu9aAKCgUfsN5andomwOBrtzZdAXGQ3lSwCgifHu 3UtjmKDrqMXM6DwtmUb0jXA= =Bo1o -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd-- From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 21:54:09 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A4B816A41F; Tue, 4 Apr 2006 21:54:09 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id E17E143D5E; Tue, 4 Apr 2006 21:54:04 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 6161F118F9; Tue, 4 Apr 2006 23:53:57 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 86330-07; Tue, 4 Apr 2006 23:53:50 +0200 (CEST) Received: from [192.168.1.100] (unknown [83.141.123.172]) by smtp.xbsd.org (Postfix) with ESMTP id 0E93911833; Tue, 4 Apr 2006 23:53:32 +0200 (CEST) In-Reply-To: <20060404202354.GA2798@odin.ac.hmc.edu> References: <4432CC3D.5070501@FreeBSD.org> <20060404202354.GA2798@odin.ac.hmc.edu> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Tue, 4 Apr 2006 22:50:53 +0100 To: Brooks Davis X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org, Kris Kennaway Subject: Re: compat{4,5}x X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 21:54:09 -0000 On Apr 4, 2006, at 9:23 PM, Brooks Davis wrote: > On Tue, Apr 04, 2006 at 04:42:53PM -0300, Marcus Alves Grando wrote: >> Hi list, >> >> Please look my message to portmgr@ about compat{4,5}x ports. >> >> -------- Original Message -------- >> Subject: Re: compat5x >> Date: Tue, 4 Apr 2006 14:35:43 -0400 >> From: Kris Kennaway >> To: Marcus Alves Grando >> CC: portmgr@FreeBSD.org >> References: <44317910.7060809@FreeBSD.org> >> >> On Mon, Apr 03, 2006 at 04:35:44PM -0300, Marcus Alves Grando wrote: >>> Portmgr's >>> >>> After migrate two servers from 5.x to 6.x, i produce this patch [1]. >>> This patch fix rcorder to start compat5x before programs compiled in >>> 5.x. Another point is turn "YES" by default in compat5x. I think >>> if user >>> install compat5x that's because he's need. >>> >>> Another option is use misc/ldconfig_compat in compat5x. >>> >>> What portmgr's thinking about this changes? >> >> I agree that compatNx ports should be enabled automatically. I don't >> know about rcorder issues; please discuss them with the freebsd-rc >> list. > > misc/ldconfig_compat should be used. These sorts of scripts should > just > die for a number of reasons including the fact that rc.d scripts > aren't > supposted to start by default. Agreed, I've submitted a patch for bsd.port.mk to integrate bsd.ldconfig.mk, I hope it'll be integrated soon. In the meantime, it's still possible to use bsd.ldconfig.mk directly. As for not starting services by default, I've had something in mind for quite some time now. I'd like to have all ${name}_enable="YES" in one specific file (say / etc/rc.conf.local, but I guess people are already using it), default specific configuration for ${name} in ${prefix}/etc/rc.conf.d/$ {name}.defaults and user specific configuration in ${prefix}/etc/ rc.conf.d/${name}. That way everything could be automated. The port could install ${name}.defaults no matter what, a ${name}_enable="YES" could be added automatically if something like AUTO_ENABLE_RC_SCRIPT is defined (and removed automatically too). Kris, any chance we have this ports.conf patch and UID/GID files committed once src/doc trees are tagged? -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 22:10:05 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6432416A426; Tue, 4 Apr 2006 22:10:05 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id D66E643D7E; Tue, 4 Apr 2006 22:09:52 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 950701A3C33; Tue, 4 Apr 2006 15:09:52 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id BD83C53CA9; Tue, 4 Apr 2006 18:09:51 -0400 (EDT) Date: Tue, 4 Apr 2006 18:09:51 -0400 From: Kris Kennaway To: Florent Thoumie Message-ID: <20060404220951.GC85154@xor.obsecurity.org> References: <4432CC3D.5070501@FreeBSD.org> <20060404202354.GA2798@odin.ac.hmc.edu> <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WplhKdTI2c8ulnbP" Content-Disposition: inline In-Reply-To: <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> User-Agent: Mutt/1.4.2.1i Cc: freebsd-rc@freebsd.org, Kris Kennaway Subject: Re: compat{4,5}x X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 22:10:05 -0000 --WplhKdTI2c8ulnbP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2006 at 10:50:53PM +0100, Florent Thoumie wrote: > On Apr 4, 2006, at 9:23 PM, Brooks Davis wrote: >=20 > >On Tue, Apr 04, 2006 at 04:42:53PM -0300, Marcus Alves Grando wrote: > >>Hi list, > >> > >>Please look my message to portmgr@ about compat{4,5}x ports. > >> > >>-------- Original Message -------- > >>Subject: Re: compat5x > >>Date: Tue, 4 Apr 2006 14:35:43 -0400 > >>From: Kris Kennaway > >>To: Marcus Alves Grando > >>CC: portmgr@FreeBSD.org > >>References: <44317910.7060809@FreeBSD.org> > >> > >>On Mon, Apr 03, 2006 at 04:35:44PM -0300, Marcus Alves Grando wrote: > >>>Portmgr's > >>> > >>>After migrate two servers from 5.x to 6.x, i produce this patch [1]. > >>>This patch fix rcorder to start compat5x before programs compiled in > >>>5.x. Another point is turn "YES" by default in compat5x. I think =20 > >>>if user > >>>install compat5x that's because he's need. > >>> > >>>Another option is use misc/ldconfig_compat in compat5x. > >>> > >>>What portmgr's thinking about this changes? > >> > >>I agree that compatNx ports should be enabled automatically. I don't > >>know about rcorder issues; please discuss them with the freebsd-rc > >>list. > > > >misc/ldconfig_compat should be used. These sorts of scripts should =20 > >just > >die for a number of reasons including the fact that rc.d scripts =20 > >aren't > >supposted to start by default. >=20 > Agreed, I've submitted a patch for bsd.port.mk to integrate =20 > bsd.ldconfig.mk, I hope it'll be integrated soon. In the meantime, =20 > it's still possible to use bsd.ldconfig.mk directly. >=20 > As for not starting services by default, I've had something in mind =20 > for quite some time now. >=20 > I'd like to have all ${name}_enable=3D"YES" in one specific file (say /= =20 > etc/rc.conf.local, but I guess people are already using it), default =20 > specific configuration for ${name} in ${prefix}/etc/rc.conf.d/$=20 > {name}.defaults and user specific configuration in ${prefix}/etc/=20 > rc.conf.d/${name}. That way everything could be automated. The port =20 > could install ${name}.defaults no matter what, a ${name}_enable=3D"YES" = =20 > could be added automatically if something like AUTO_ENABLE_RC_SCRIPT =20 > is defined (and removed automatically too). >=20 > Kris, any chance we have this ports.conf patch and UID/GID files =20 > committed once src/doc trees are tagged? Yes, we'll be doing another round of bsd.port.mk patches as usual. Kris --WplhKdTI2c8ulnbP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEMu6uWry0BWjoQKURAjMJAJ99yQK5oVdrjQ3i6uiOVZO2SwBj3gCfaoZy NXCif61xW16FlbKk3zytnyg= =l0n/ -----END PGP SIGNATURE----- --WplhKdTI2c8ulnbP-- From owner-freebsd-rc@FreeBSD.ORG Tue Apr 4 22:44:12 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4761516A41F for ; Tue, 4 Apr 2006 22:44:12 +0000 (UTC) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (corp.grupos.com.br [200.193.29.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id A124043D46 for ; Tue, 4 Apr 2006 22:44:11 +0000 (GMT) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (localhost [127.0.0.1]) by corp.grupos.com.br (Postfix) with ESMTP id A56BF5583; Tue, 4 Apr 2006 19:44:09 -0300 (BRT) Received: from [192.168.10.10] (marcus.grupos.com.br [192.168.10.10]) by corp.grupos.com.br (Postfix) with ESMTP id 5AE235570; Tue, 4 Apr 2006 19:44:09 -0300 (BRT) Message-ID: <4432F6B8.7070205@FreeBSD.org> Date: Tue, 04 Apr 2006 19:44:08 -0300 From: Marcus Alves Grando Organization: FreeBSD.org User-Agent: Thunderbird 1.5 (X11/20060114) MIME-Version: 1.0 To: Florent Thoumie References: <4432CC3D.5070501@FreeBSD.org> <20060404202354.GA2798@odin.ac.hmc.edu> <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> In-Reply-To: <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Filtered: By ProxSMTP using Clamav and Bogofilter Cc: freebsd-rc@freebsd.org, Kris Kennaway Subject: Re: compat{4,5}x X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 22:44:12 -0000 Well... New patch using misc/ldconfig_compat http://marcus.grupos.com.br:8080/patch/compat5x.patch Not tested yet. Regards Florent Thoumie wrote: > On Apr 4, 2006, at 9:23 PM, Brooks Davis wrote: > >> On Tue, Apr 04, 2006 at 04:42:53PM -0300, Marcus Alves Grando wrote: >>> Hi list, >>> >>> Please look my message to portmgr@ about compat{4,5}x ports. >>> >>> -------- Original Message -------- >>> Subject: Re: compat5x >>> Date: Tue, 4 Apr 2006 14:35:43 -0400 >>> From: Kris Kennaway >>> To: Marcus Alves Grando >>> CC: portmgr@FreeBSD.org >>> References: <44317910.7060809@FreeBSD.org> >>> >>> On Mon, Apr 03, 2006 at 04:35:44PM -0300, Marcus Alves Grando wrote: >>>> Portmgr's >>>> >>>> After migrate two servers from 5.x to 6.x, i produce this patch [1]. >>>> This patch fix rcorder to start compat5x before programs compiled in >>>> 5.x. Another point is turn "YES" by default in compat5x. I think if >>>> user >>>> install compat5x that's because he's need. >>>> >>>> Another option is use misc/ldconfig_compat in compat5x. >>>> >>>> What portmgr's thinking about this changes? >>> >>> I agree that compatNx ports should be enabled automatically. I don't >>> know about rcorder issues; please discuss them with the freebsd-rc >>> list. >> >> misc/ldconfig_compat should be used. These sorts of scripts should just >> die for a number of reasons including the fact that rc.d scripts aren't >> supposted to start by default. > > Agreed, I've submitted a patch for bsd.port.mk to integrate > bsd.ldconfig.mk, I hope it'll be integrated soon. In the meantime, it's > still possible to use bsd.ldconfig.mk directly. > > As for not starting services by default, I've had something in mind for > quite some time now. > > I'd like to have all ${name}_enable="YES" in one specific file (say > /etc/rc.conf.local, but I guess people are already using it), default > specific configuration for ${name} in > ${prefix}/etc/rc.conf.d/${name}.defaults and user specific configuration > in ${prefix}/etc/rc.conf.d/${name}. That way everything could be > automated. The port could install ${name}.defaults no matter what, a > ${name}_enable="YES" could be added automatically if something like > AUTO_ENABLE_RC_SCRIPT is defined (and removed automatically too). > > Kris, any chance we have this ports.conf patch and UID/GID files > committed once src/doc trees are tagged? > > --Florent Thoumie > flz@FreeBSD.org > FreeBSD Committer > > -- Marcus Alves Grando marcus(at)corp.grupos.com.br | Grupos Internet S/A mnag(at)FreeBSD.org | FreeBSD.org From owner-freebsd-rc@FreeBSD.ORG Wed Apr 5 12:10:21 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D94FD16A400 for ; Wed, 5 Apr 2006 12:10:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC6C243D78 for ; Wed, 5 Apr 2006 12:10:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k35CAH3r015559 for ; Wed, 5 Apr 2006 12:10:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k35CAHhP015558; Wed, 5 Apr 2006 12:10:17 GMT (envelope-from gnats) Date: Wed, 5 Apr 2006 12:10:17 GMT Message-Id: <200604051210.k35CAHhP015558@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Ganbold Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ganbold List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2006 12:10:21 -0000 The following reply was made to PR bin/94767; it has been noted by GNATS. From: Ganbold To: bug-followup@FreeBSD.org Cc: dougb@freebsd.org Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) Date: Wed, 05 Apr 2006 20:59:17 +0900 Can somebody close this PR by committing it? By commenting out those free()s in rcorder.c solves the core dump problem when there are circular dependent rc scripts on the system. thanks, Ganbold From owner-freebsd-rc@FreeBSD.ORG Wed Apr 5 22:07:02 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5DB016A41F; Wed, 5 Apr 2006 22:07:02 +0000 (UTC) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (corp.grupos.com.br [200.193.29.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52B1643D45; Wed, 5 Apr 2006 22:07:02 +0000 (GMT) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (localhost [127.0.0.1]) by corp.grupos.com.br (Postfix) with ESMTP id CC736552A; Wed, 5 Apr 2006 19:06:58 -0300 (BRT) Received: from [192.168.10.10] (marcus.grupos.com.br [192.168.10.10]) by corp.grupos.com.br (Postfix) with ESMTP id A3496551F; Wed, 5 Apr 2006 19:06:58 -0300 (BRT) Message-ID: <44343F82.7080002@FreeBSD.org> Date: Wed, 05 Apr 2006 19:06:58 -0300 From: Marcus Alves Grando Organization: FreeBSD.org User-Agent: Thunderbird 1.5 (X11/20060114) MIME-Version: 1.0 To: Marcus Alves Grando References: <4432CC3D.5070501@FreeBSD.org> <20060404202354.GA2798@odin.ac.hmc.edu> <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> <4432F6B8.7070205@FreeBSD.org> In-Reply-To: <4432F6B8.7070205@FreeBSD.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Filtered: By ProxSMTP using Clamav and Bogofilter Cc: Kris Kennaway , freebsd-rc@freebsd.org Subject: Changes in compat{4,5}x (using misc/ldconfig_compat) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2006 22:07:02 -0000 People, I change compat{4,5}x to use ldconfig_compat, this change fix rc.d script starting too late. With this, ldconfig run automaticaly on startup and doesn't need add compat{4,5}x_enable in rc.conf. I test in i386 {4,5,6}-STABLE and amd64 {5,6}-STABLE. More tests are appreciated. http://marcus.grupos.com.br:8080/patch/compat4x.patch http://marcus.grupos.com.br:8080/patch/compat5x.patch Thanks -- Marcus Alves Grando marcus(at)corp.grupos.com.br | Grupos Internet S/A mnag(at)FreeBSD.org | FreeBSD.org From owner-freebsd-rc@FreeBSD.ORG Thu Apr 6 19:27:57 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8323116A90B for ; Thu, 6 Apr 2006 19:27:57 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 05D2A45E63 for ; Thu, 6 Apr 2006 18:35:58 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 18064 invoked by uid 399); 6 Apr 2006 18:35:58 -0000 Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 6 Apr 2006 18:35:58 -0000 Message-ID: <44355F90.2060204@FreeBSD.org> Date: Thu, 06 Apr 2006 11:36:00 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Marcus Alves Grando References: <4432CC3D.5070501@FreeBSD.org> <20060404202354.GA2798@odin.ac.hmc.edu> <72A3202F-7561-47CE-8E30-F43CC3B7C17E@xbsd.org> <4432F6B8.7070205@FreeBSD.org> <44343F82.7080002@FreeBSD.org> In-Reply-To: <44343F82.7080002@FreeBSD.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org, Kris Kennaway Subject: Re: Changes in compat{4,5}x (using misc/ldconfig_compat) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2006 19:27:58 -0000 Marcus Alves Grando wrote: > People, > > I change compat{4,5}x to use ldconfig_compat, this change fix rc.d > script starting too late. With this, ldconfig run automaticaly on > startup and doesn't need add compat{4,5}x_enable in rc.conf. Speaking strictly as the last person to do any significant work on these two, I have had this conversion on my TO DO list for some time, but have not been able to get to it, so I welcome anyone else who wants to take the lead on this. :) Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Thu Apr 6 22:22:05 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 195D016A402; Thu, 6 Apr 2006 22:22:05 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id D437643D62; Thu, 6 Apr 2006 22:21:58 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 40FD411969; Fri, 7 Apr 2006 00:21:57 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89034-03; Fri, 7 Apr 2006 00:21:46 +0200 (CEST) Received: from [193.120.13.131] (unknown [193.120.13.131]) by smtp.xbsd.org (Postfix) with ESMTP id 5B9E6114B8; Fri, 7 Apr 2006 00:21:45 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v749.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Thu, 6 Apr 2006 23:21:41 +0100 To: freebsd-rc@FreeBSD.org X-Mailer: Apple Mail (2.749.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: simon@FreeBSD.org Subject: rc.d/jail patch for test/review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2006 22:22:05 -0000 This patch creates jail general options shared by all jails while keeping the ability to override the value on a per-jail basis (discussed with simon on IRC). Example is: jail_mount_enable=3D"YES" jail_foo_mount_enable=3D"NO" It also adds the ability to automatically add (and remove) the IP alias for each jail (jail_interface/jail_foo_interface). http://people.freebsd.org/~flz/local/rc.d-jail.diff Even if the patch is quite simple, I haven't tried it yet, so testing is more than welcome. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Fri Apr 7 10:49:51 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DC1E16A403; Fri, 7 Apr 2006 10:49:51 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id C390243D45; Fri, 7 Apr 2006 10:49:50 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 8899211926; Fri, 7 Apr 2006 12:49:43 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 03682-05; Fri, 7 Apr 2006 12:49:33 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 8FD9111493; Fri, 7 Apr 2006 12:49:32 +0200 (CEST) From: Florent Thoumie To: freebsd-rc@FreeBSD.org In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-eXkKb7sIaWoTgKtGNZwR" Date: Fri, 07 Apr 2006 11:49:29 +0100 Message-Id: <1144406969.27663.8.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: simon@FreeBSD.org Subject: Re: rc.d/jail patch for test/review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2006 10:49:51 -0000 --=-eXkKb7sIaWoTgKtGNZwR Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2006-04-06 at 23:21 +0100, Florent Thoumie wrote: > This patch creates jail general options shared by all jails while =20 > keeping the ability to override the value on a per-jail basis =20 > (discussed with simon on IRC). >=20 > Example is: >=20 > jail_mount_enable=3D3D"YES" > jail_foo_mount_enable=3D3D"NO" >=20 > It also adds the ability to automatically add (and remove) the IP =20 > alias for each jail (jail_interface/jail_foo_interface). >=20 > http://people.freebsd.org/~flz/local/rc.d-jail.diff >=20 > Even if the patch is quite simple, I haven't tried it yet, so testing =20 > is more than welcome. Patch updated, some silly mistakes have been removed. Seems to work for me, but I haven't tested all possibilities. Simon, could you review the doc part? I have duplicated jail_foo/jail__foo, not sure if it was needed. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-eXkKb7sIaWoTgKtGNZwR Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBENkO5MxEkbVFH3PQRAuc4AJ4nglB5B/ZhUJQ629kUlYM73Hm7QQCdEzET iHrRg1V+ja3DU0oCjOyUdTM= =FMOi -----END PGP SIGNATURE----- --=-eXkKb7sIaWoTgKtGNZwR--