From owner-freebsd-usb@FreeBSD.ORG Sun Mar 26 09:00:51 2006 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E94A016A420 for ; Sun, 26 Mar 2006 09:00:51 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CB6643D79 for ; Sun, 26 Mar 2006 09:00:35 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2Q90ZoX055199 for ; Sun, 26 Mar 2006 09:00:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2Q90YaT055196; Sun, 26 Mar 2006 09:00:34 GMT (envelope-from gnats) Resent-Date: Sun, 26 Mar 2006 09:00:34 GMT Resent-Message-Id: <200603260900.k2Q90YaT055196@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lonnie Mendez Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9ACD516A41F for ; Sun, 26 Mar 2006 08:53:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67EFC43D49 for ; Sun, 26 Mar 2006 08:53:09 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k2Q8r9Gj000435 for ; Sun, 26 Mar 2006 08:53:09 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k2Q8r9la000434; Sun, 26 Mar 2006 08:53:09 GMT (envelope-from nobody) Message-Id: <200603260853.k2Q8r9la000434@www.freebsd.org> Date: Sun, 26 Mar 2006 08:53:09 GMT From: Lonnie Mendez To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: usb/94946: [uhub][patch] code dynamic status size for status change endpoint X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2006 09:00:52 -0000 >Number: 94946 >Category: usb >Synopsis: [uhub][patch] code dynamic status size for status change endpoint >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Mar 26 09:00:34 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Lonnie Mendez >Release: 6.1-BETA2 >Organization: >Environment: FreeBSD twind 6.1-BETA2 FreeBSD 6.1-BETA2 #4: Fri Mar 10 22:09:38 CST 2006 root@twind:/usr/src/sys/i386/compile/MYKERNEL i386 >Description: Found this while running freebsd as guest in qemu with -usb parameter. The patch implements the missing dynamic size based on number of ports a hub has. >How-To-Repeat: >Fix: Index: sys/dev/usb/uhub.c @@ -84,7 +84,7 @@ USBBASEDEVICE sc_dev; /* base device */ usbd_device_handle sc_hub; /* USB device */ usbd_pipe_handle sc_ipipe; /* interrupt pipe */ - u_int8_t sc_status[1]; /* xxx more ports */ + u_int8_t sc_status[32]; /* max 255 ports */ u_char sc_running; }; #define UHUB_PROTO(sc) ((sc)->sc_hub->ddesc.bDeviceProtocol) @@ -279,7 +279,7 @@ err = usbd_open_pipe_intr(iface, ed->bEndpointAddress, USBD_SHORT_XFER_OK, &sc->sc_ipipe, sc, sc->sc_status, - sizeof(sc->sc_status), uhub_intr, UHUB_INTR_INTERVAL); + (nports + 1 + 7) / 8, uhub_intr, UHUB_INTR_INTERVAL); if (err) { printf("%s: cannot open interrupt pipe\n", USBDEVNAME(sc->sc_dev)); >Release-Note: >Audit-Trail: >Unformatted: