From owner-cvs-src@FreeBSD.ORG Sun Apr 29 00:41:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E2B3616A407; Sun, 29 Apr 2007 00:41:29 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BA0E213C468; Sun, 29 Apr 2007 00:41:29 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3T0fT9i077176; Sun, 29 Apr 2007 00:41:29 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3T0fTw9077175; Sun, 29 Apr 2007 00:41:29 GMT (envelope-from pjd) Message-Id: <200704290041.l3T0fTw9077175@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 29 Apr 2007 00:41:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs vdev_geom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 00:41:30 -0000 pjd 2007-04-29 00:41:29 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs vdev_geom.c Log: Fix two use-after-free cases. Revision Changes Path 1.2 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 11:32:26 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F62816A404; Sun, 29 Apr 2007 11:32:26 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id EF9F413C43E; Sun, 29 Apr 2007 11:32:25 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TBWPEH019126; Sun, 29 Apr 2007 11:32:25 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TBWPH8019125; Sun, 29 Apr 2007 11:32:25 GMT (envelope-from brueffer) Message-Id: <200704291132.l3TBWPH8019125@repoman.freebsd.org> From: Christian Brueffer Date: Sun, 29 Apr 2007 11:32:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 11:32:26 -0000 brueffer 2007-04-29 11:32:25 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: - edsc(4) added - pmcstat(4) -c and -t flags, defaults changed - rpcbind -h and -6 flags Modified release notes: - Moved pmcstat information from kernel to userland section - MSI-X supported as well, remove ref to pci(4) manpage, which is different from the kernel's PCI code - rpc.lockd/rpc.statd entry moved to the right place Revision Changes Path 1.1026 +24 -9 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Sun Apr 29 14:00:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 953A416A400; Sun, 29 Apr 2007 14:00:59 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6F58113C459; Sun, 29 Apr 2007 14:00:59 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TE0xCa053267; Sun, 29 Apr 2007 14:00:59 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TE0xRB053262; Sun, 29 Apr 2007 14:00:59 GMT (envelope-from deischen) Message-Id: <200704291400.l3TE0xRB053262@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 14:00:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.symver.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 14:00:59 -0000 deischen 2007-04-29 14:00:58 UTC FreeBSD src repository Modified files: share/mk bsd.symver.mk Log: Use CPP to preprocess version map files so we can conditionalize symbols. Revision Changes Path 1.2 +4 -2 src/share/mk/bsd.symver.mk From owner-cvs-src@FreeBSD.ORG Sun Apr 29 14:01:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2487816A403; Sun, 29 Apr 2007 14:01:46 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id F2B8D13C448; Sun, 29 Apr 2007 14:01:45 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TE1jFo053841; Sun, 29 Apr 2007 14:01:45 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TE1jbc053840; Sun, 29 Apr 2007 14:01:45 GMT (envelope-from deischen) Message-Id: <200704291401.l3TE1jbc053840@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 14:01:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/librt Makefile Version.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 14:01:46 -0000 deischen 2007-04-29 14:01:45 UTC FreeBSD src repository Modified files: lib/librt Makefile Added files: lib/librt Version.map Log: Symbol version librt. Revision Changes Path 1.3 +2 -0 src/lib/librt/Makefile 1.1 +69 -0 src/lib/librt/Version.map (new) From owner-cvs-src@FreeBSD.ORG Sun Apr 29 14:03:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2E09116A403; Sun, 29 Apr 2007 14:03:46 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0832413C448; Sun, 29 Apr 2007 14:03:46 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TE3jmN055145; Sun, 29 Apr 2007 14:03:45 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TE3ji6055140; Sun, 29 Apr 2007 14:03:45 GMT (envelope-from deischen) Message-Id: <200704291403.l3TE3ji6055140@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 14:03:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc Versions.def X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 14:03:46 -0000 deischen 2007-04-29 14:03:45 UTC FreeBSD src repository Modified files: lib/libc Versions.def Log: Number the private version namespace in case we ever want to have compatibility between versions (as we do for the public namespace). Revision Changes Path 1.2 +1 -1 src/lib/libc/Versions.def From owner-cvs-src@FreeBSD.ORG Sun Apr 29 14:05:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 697BA16A402; Sun, 29 Apr 2007 14:05:23 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 5863513C44C; Sun, 29 Apr 2007 14:05:23 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TE5Nak056241; Sun, 29 Apr 2007 14:05:23 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TE5NhR056238; Sun, 29 Apr 2007 14:05:23 GMT (envelope-from deischen) Message-Id: <200704291405.l3TE5NhR056238@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 14:05:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libpthread pthread.map src/lib/libc/amd64 Symbol.map src/lib/libc/arm Symbol.map src/lib/libc/compat-43 Symbol.map src/lib/libc/db Symbol.map src/lib/libc/gdtoa Symbol.map src/lib/libc/gen Symbol.map src/lib/libc/gmon ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 14:05:23 -0000 deischen 2007-04-29 14:05:22 UTC FreeBSD src repository Modified files: lib/libpthread pthread.map lib/libc/amd64 Symbol.map lib/libc/arm Symbol.map lib/libc/compat-43 Symbol.map lib/libc/db Symbol.map lib/libc/gdtoa Symbol.map lib/libc/gen Symbol.map lib/libc/gmon Symbol.map lib/libc/i386 Symbol.map lib/libc/ia64 Symbol.map lib/libc/inet Symbol.map lib/libc/locale Symbol.map lib/libc/nameser Symbol.map lib/libc/net Symbol.map lib/libc/nls Symbol.map lib/libc/posix1e Symbol.map lib/libc/powerpc Symbol.map lib/libc/quad Symbol.map lib/libc/regex Symbol.map lib/libc/resolv Symbol.map lib/libc/rpc Symbol.map lib/libc/softfloat Symbol.map lib/libc/sparc64 Symbol.map lib/libc/stdio Symbol.map lib/libc/stdlib Symbol.map lib/libc/stdtime Symbol.map lib/libc/string Symbol.map lib/libc/sys Symbol.map lib/libc/uuid Symbol.map lib/libc/xdr Symbol.map lib/libc/yp Symbol.map lib/libthr pthread.map lib/msun Symbol.map lib/msun/amd64 Symbol.map lib/msun/arm Symbol.map lib/msun/i387 Symbol.map lib/msun/ia64 Symbol.map lib/msun/powerpc Symbol.map lib/msun/sparc64 Symbol.map lib/libelf Version.map lib/libthread_db Symbol.map libexec/rtld-elf/i386 Symbol.map libexec/rtld-elf Symbol.map Log: Use C comments since we now preprocess these files with CPP. Revision Changes Path 1.2 +16 -12 src/lib/libc/amd64/Symbol.map 1.2 +13 -11 src/lib/libc/arm/Symbol.map 1.2 +4 -2 src/lib/libc/compat-43/Symbol.map 1.2 +4 -2 src/lib/libc/db/Symbol.map 1.4 +8 -4 src/lib/libc/gdtoa/Symbol.map 1.5 +26 -15 src/lib/libc/gen/Symbol.map 1.2 +6 -4 src/lib/libc/gmon/Symbol.map 1.3 +11 -9 src/lib/libc/i386/Symbol.map 1.2 +11 -9 src/lib/libc/ia64/Symbol.map 1.2 +3 -1 src/lib/libc/inet/Symbol.map 1.3 +4 -2 src/lib/libc/locale/Symbol.map 1.3 +3 -1 src/lib/libc/nameser/Symbol.map 1.8 +8 -6 src/lib/libc/net/Symbol.map 1.2 +3 -1 src/lib/libc/nls/Symbol.map 1.2 +3 -1 src/lib/libc/posix1e/Symbol.map 1.2 +11 -9 src/lib/libc/powerpc/Symbol.map 1.2 +33 -29 src/lib/libc/quad/Symbol.map 1.2 +3 -1 src/lib/libc/regex/Symbol.map 1.7 +4 -4 src/lib/libc/resolv/Symbol.map 1.2 +11 -7 src/lib/libc/rpc/Symbol.map 1.2 +4 -2 src/lib/libc/softfloat/Symbol.map 1.3 +14 -12 src/lib/libc/sparc64/Symbol.map 1.5 +5 -3 src/lib/libc/stdio/Symbol.map 1.4 +4 -2 src/lib/libc/stdlib/Symbol.map 1.2 +3 -1 src/lib/libc/stdtime/Symbol.map 1.2 +4 -2 src/lib/libc/string/Symbol.map 1.5 +14 -11 src/lib/libc/sys/Symbol.map 1.2 +3 -1 src/lib/libc/uuid/Symbol.map 1.2 +4 -2 src/lib/libc/xdr/Symbol.map 1.2 +3 -1 src/lib/libc/yp/Symbol.map 1.3 +7 -7 src/lib/libelf/Version.map 1.19 +21 -20 src/lib/libpthread/pthread.map 1.17 +14 -11 src/lib/libthr/pthread.map 1.2 +8 -4 src/lib/libthread_db/Symbol.map 1.4 +3 -1 src/lib/msun/Symbol.map 1.2 +3 -1 src/lib/msun/amd64/Symbol.map 1.2 +3 -1 src/lib/msun/arm/Symbol.map 1.2 +3 -1 src/lib/msun/i387/Symbol.map 1.2 +3 -1 src/lib/msun/ia64/Symbol.map 1.2 +3 -1 src/lib/msun/powerpc/Symbol.map 1.2 +3 -1 src/lib/msun/sparc64/Symbol.map 1.3 +3 -1 src/libexec/rtld-elf/Symbol.map 1.3 +3 -1 src/libexec/rtld-elf/i386/Symbol.map From owner-cvs-src@FreeBSD.ORG Sun Apr 29 14:16:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FDB416A400; Sun, 29 Apr 2007 14:16:19 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 599F813C44C; Sun, 29 Apr 2007 14:16:19 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TEGJqI058179; Sun, 29 Apr 2007 14:16:19 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TEGJSC058178; Sun, 29 Apr 2007 14:16:19 GMT (envelope-from deischen) Message-Id: <200704291416.l3TEGJSC058178@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 14:16:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf Versions.def X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 14:16:19 -0000 deischen 2007-04-29 14:16:19 UTC FreeBSD src repository Modified files: libexec/rtld-elf Versions.def Log: Give the private version namespace a number to match libc. Revision Changes Path 1.3 +1 -1 src/libexec/rtld-elf/Versions.def From owner-cvs-src@FreeBSD.ORG Sun Apr 29 15:27:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D3C3516A402; Sun, 29 Apr 2007 15:27:23 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AD30B13C458; Sun, 29 Apr 2007 15:27:23 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TFRNm6071145; Sun, 29 Apr 2007 15:27:23 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TFRNGa071144; Sun, 29 Apr 2007 15:27:23 GMT (envelope-from deischen) Message-Id: <200704291527.l3TFRNGa071144@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 15:27:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libpthread/thread thr_private.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 15:27:23 -0000 deischen 2007-04-29 15:27:23 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_private.h Log: Catch up with the renaming of the private version namespace. Revision Changes Path 1.129 +1 -1 src/lib/libpthread/thread/thr_private.h From owner-cvs-src@FreeBSD.ORG Sun Apr 29 16:12:07 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C55CF16A400; Sun, 29 Apr 2007 16:12:07 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9E97713C448; Sun, 29 Apr 2007 16:12:07 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TGC73W082307; Sun, 29 Apr 2007 16:12:07 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TGC7rt082306; Sun, 29 Apr 2007 16:12:07 GMT (envelope-from kan) Message-Id: <200704291612.l3TGC7rt082306@repoman.freebsd.org> From: Alexander Kabaev Date: Sun, 29 Apr 2007 16:12:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf Makefile Versions.def X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 16:12:07 -0000 kan 2007-04-29 16:12:07 UTC FreeBSD src repository Modified files: libexec/rtld-elf Makefile Removed files: libexec/rtld-elf Versions.def Log: Retire rtld-specific Versions.def. Symbols exported by rtld are supposed to override weak symbols exported by libc, so by definition these two are using the same symbol version names. Reflect the reality by referring to libc's Versions.def directly. Revision Changes Path 1.39 +3 -2 src/libexec/rtld-elf/Makefile 1.4 +0 -7 src/libexec/rtld-elf/Versions.def (dead) From owner-cvs-src@FreeBSD.ORG Sun Apr 29 16:14:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0811C16A400; Sun, 29 Apr 2007 16:14:18 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D620113C44B; Sun, 29 Apr 2007 16:14:17 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TGEHlr082677; Sun, 29 Apr 2007 16:14:17 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TGEHD0082676; Sun, 29 Apr 2007 16:14:17 GMT (envelope-from kan) Message-Id: <200704291614.l3TGEHD0082676@repoman.freebsd.org> From: Alexander Kabaev Date: Sun, 29 Apr 2007 16:14:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc Versions.def X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 16:14:18 -0000 kan 2007-04-29 16:14:17 UTC FreeBSD src repository Modified files: lib/libc Versions.def Log: Make sure FBSDprivate_1.0 is located at the end of the version inheritance chain. Revision Changes Path 1.3 +1 -1 src/lib/libc/Versions.def From owner-cvs-src@FreeBSD.ORG Sun Apr 29 16:20:33 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3A02916A46B; Sun, 29 Apr 2007 16:20:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 130C313C457; Sun, 29 Apr 2007 16:20:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TGKW0T083040; Sun, 29 Apr 2007 16:20:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TGKWUw083039; Sun, 29 Apr 2007 16:20:32 GMT (envelope-from rwatson) Message-Id: <200704291620.l3TGKWUw083039@repoman.freebsd.org> From: Robert Watson Date: Sun, 29 Apr 2007 16:20:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/security/audit audit_ioctl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 16:20:33 -0000 rwatson 2007-04-29 16:20:32 UTC FreeBSD src repository Modified files: sys/security/audit audit_ioctl.h Log: Don't expose #ifdef NOTYET parts to userspace via audit_ioctl.h, just remove them, since the functionality they are associated with isn't there yet. MFC after: 3 days Revision Changes Path 1.5 +0 -3 src/sys/security/audit/audit_ioctl.h From owner-cvs-src@FreeBSD.ORG Sun Apr 29 17:08:14 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 18EA216A403; Sun, 29 Apr 2007 17:08:14 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E6A4313C4BC; Sun, 29 Apr 2007 17:08:13 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TH8DF3000384; Sun, 29 Apr 2007 17:08:13 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TH8D4k000383; Sun, 29 Apr 2007 17:08:13 GMT (envelope-from deischen) Message-Id: <200704291708.l3TH8D4k000383@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 29 Apr 2007 17:08:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/librt Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 17:08:14 -0000 deischen 2007-04-29 17:08:13 UTC FreeBSD src repository Modified files: lib/librt Makefile Log: Don't enable symbol versioning for librt by default just yet. Revision Changes Path 1.4 +2 -0 src/lib/librt/Makefile From owner-cvs-src@FreeBSD.ORG Sun Apr 29 19:22:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 44B7416A403; Sun, 29 Apr 2007 19:22:13 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1C01D13C455; Sun, 29 Apr 2007 19:22:13 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TJMDC0025715; Sun, 29 Apr 2007 19:22:13 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TJMCgj025714; Sun, 29 Apr 2007 19:22:12 GMT (envelope-from dwmalone) Message-Id: <200704291922.l3TJMCgj025714@repoman.freebsd.org> From: David Malone Date: Sun, 29 Apr 2007 19:22:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/inetd inetd.8 inetd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 19:22:13 -0000 dwmalone 2007-04-29 19:22:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/inetd inetd.8 inetd.c Log: MFC: Man page improvements and don't put unix domain sockets into the per-ip limits code. Revision Changes Path 1.81.2.2 +39 -30 src/usr.sbin/inetd/inetd.8 1.129.2.2 +1 -0 src/usr.sbin/inetd/inetd.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 19:24:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 49A1716A402; Sun, 29 Apr 2007 19:24:12 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 20C7713C4AD; Sun, 29 Apr 2007 19:24:12 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TJOCIg026301; Sun, 29 Apr 2007 19:24:12 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TJOBuv026300; Sun, 29 Apr 2007 19:24:11 GMT (envelope-from dwmalone) Message-Id: <200704291924.l3TJOBuv026300@repoman.freebsd.org> From: David Malone Date: Sun, 29 Apr 2007 19:24:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.sbin/inetd inetd.8 inetd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 19:24:12 -0000 dwmalone 2007-04-29 19:24:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.sbin/inetd inetd.8 inetd.c Log: MFC: Man page improvements and don't put unix domain sockets into the per-ip limits code. Revision Changes Path 1.80.2.2 +38 -29 src/usr.sbin/inetd/inetd.8 1.127.2.2 +1 -0 src/usr.sbin/inetd/inetd.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 19:31:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E2A316A409; Sun, 29 Apr 2007 19:31:16 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D961E13C44B; Sun, 29 Apr 2007 19:31:15 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TJVFC7027209; Sun, 29 Apr 2007 19:31:15 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TJVF31027207; Sun, 29 Apr 2007 19:31:15 GMT (envelope-from dwmalone) Message-Id: <200704291931.l3TJVF31027207@repoman.freebsd.org> From: David Malone Date: Sun, 29 Apr 2007 19:31:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/usr.sbin/inetd inetd.8 inetd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 19:31:16 -0000 dwmalone 2007-04-29 19:31:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/inetd inetd.8 inetd.c Log: MFC: Man page improvements and don't put unix domain sockets into the per-ip limits code. Revision Changes Path 1.46.2.14 +41 -30 src/usr.sbin/inetd/inetd.8 1.80.2.14 +1 -0 src/usr.sbin/inetd/inetd.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 19:46:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0CAC516A406; Sun, 29 Apr 2007 19:46:34 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D835E13C484; Sun, 29 Apr 2007 19:46:33 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TJkXGx030441; Sun, 29 Apr 2007 19:46:33 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TJkXqj030440; Sun, 29 Apr 2007 19:46:33 GMT (envelope-from jmg) Message-Id: <200704291946.l3TJkXqj030440@repoman.freebsd.org> From: John-Mark Gurney Date: Sun, 29 Apr 2007 19:46:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 rman.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 19:46:34 -0000 jmg 2007-04-29 19:46:33 UTC FreeBSD src repository Modified files: share/man/man9 rman.9 Log: Document requirements to calling rman_init... (Hmmm, maybe we should make these areguments to rman_init?) MFC after: 1 week Revision Changes Path 1.9 +16 -1 src/share/man/man9/rman.9 From owner-cvs-src@FreeBSD.ORG Sun Apr 29 20:03:07 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 65F7F16A402; Sun, 29 Apr 2007 20:03:07 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3C9D513C458; Sun, 29 Apr 2007 20:03:07 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TK37Jo034128; Sun, 29 Apr 2007 20:03:07 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TK37al034125; Sun, 29 Apr 2007 20:03:07 GMT (envelope-from dwmalone) Message-Id: <200704292003.l3TK37al034125@repoman.freebsd.org> From: David Malone Date: Sun, 29 Apr 2007 20:03:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar/calendars calendar.usholiday X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 20:03:07 -0000 dwmalone 2007-04-29 20:03:06 UTC FreeBSD src repository Modified files: usr.bin/calendar/calendars calendar.usholiday Log: Change the date for Daylight Savings in the US. PR: 111102 Submitted by: Sean Farley Obtained from: OpenBSD Revision Changes Path 1.9 +2 -2 src/usr.bin/calendar/calendars/calendar.usholiday From owner-cvs-src@FreeBSD.ORG Sun Apr 29 20:14:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8870E16A413; Sun, 29 Apr 2007 20:14:19 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 755A213C457; Sun, 29 Apr 2007 20:14:19 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TKEJb5036688; Sun, 29 Apr 2007 20:14:19 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TKEJXE036687; Sun, 29 Apr 2007 20:14:19 GMT (envelope-from dwmalone) Message-Id: <200704292014.l3TKEJXE036687@repoman.freebsd.org> From: David Malone Date: Sun, 29 Apr 2007 20:14:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/calendar day.c src/usr.bin/calendar/calendars calendar.freebsd calendar.holiday calendar.judaic calendar.music calendar.usholiday src/usr.bin/calendar/calendars/de_DE.ISO8859-1 calendar.musik X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 20:14:19 -0000 dwmalone 2007-04-29 20:14:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/calendar day.c usr.bin/calendar/calendars calendar.freebsd calendar.holiday calendar.judaic calendar.music calendar.usholiday usr.bin/calendar/calendars/de_DE.ISO8859-1 calendar.musik Log: MFC calendar from with -current and remove some undeeded break statements. Revision Changes Path 1.165.2.8 +27 -6 src/usr.bin/calendar/calendars/calendar.freebsd 1.28.8.5 +8 -8 src/usr.bin/calendar/calendars/calendar.holiday 1.12.12.1 +212 -206 src/usr.bin/calendar/calendars/calendar.judaic 1.17.2.2 +2 -1 src/usr.bin/calendar/calendars/calendar.music 1.8.12.1 +2 -2 src/usr.bin/calendar/calendars/calendar.usholiday 1.12.2.1 +0 -1 src/usr.bin/calendar/calendars/de_DE.ISO8859-1/calendar.musik 1.21.2.2 +0 -2 src/usr.bin/calendar/day.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 21:38:26 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D76816A400; Sun, 29 Apr 2007 21:38:26 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 139E713C43E; Sun, 29 Apr 2007 21:38:26 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TLcPdo061705; Sun, 29 Apr 2007 21:38:25 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TLcPEO061704; Sun, 29 Apr 2007 21:38:25 GMT (envelope-from pjd) Message-Id: <200704292138.l3TLcPEO061704@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 29 Apr 2007 21:38:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/sys Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 21:38:26 -0000 pjd 2007-04-29 21:38:25 UTC FreeBSD src repository Modified files: lib/libc/sys Makefile.inc Log: Add missing links and sort. Revision Changes Path 1.124 +9 -3 src/lib/libc/sys/Makefile.inc From owner-cvs-src@FreeBSD.ORG Sun Apr 29 21:43:10 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7646616A400; Sun, 29 Apr 2007 21:43:10 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4C4C613C469; Sun, 29 Apr 2007 21:43:10 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TLhAk0062775; Sun, 29 Apr 2007 21:43:10 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TLhAW1062774; Sun, 29 Apr 2007 21:43:10 GMT (envelope-from ceri) Message-Id: <200704292143.l3TLhAW1062774@repoman.freebsd.org> From: Ceri Davies Date: Sun, 29 Apr 2007 21:43:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libcrypt crypt.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 21:43:10 -0000 ceri 2007-04-29 21:43:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libcrypt crypt.3 Log: MFC r1.32: cipher(3) is gone. Revision Changes Path 1.31.2.1 +0 -1 src/lib/libcrypt/crypt.3 From owner-cvs-src@FreeBSD.ORG Sun Apr 29 23:08:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7A6DE16A402; Sun, 29 Apr 2007 23:08:25 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4FEE413C469; Sun, 29 Apr 2007 23:08:25 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TN8PQJ091291; Sun, 29 Apr 2007 23:08:25 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TN8PO3091290; Sun, 29 Apr 2007 23:08:25 GMT (envelope-from pjd) Message-Id: <200704292308.l3TN8PO3091290@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 29 Apr 2007 23:08:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 23:08:25 -0000 pjd 2007-04-29 23:08:24 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: Avoid freeing NULL pointer in case of an error. Revision Changes Path 1.12 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 23:12:01 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79F6A16A401; Sun, 29 Apr 2007 23:12:01 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4F7D313C43E; Sun, 29 Apr 2007 23:12:01 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TNC1mU092196; Sun, 29 Apr 2007 23:12:01 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TNC1Zi092195; Sun, 29 Apr 2007 23:12:01 GMT (envelope-from pjd) Message-Id: <200704292312.l3TNC1Zi092195@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 29 Apr 2007 23:12:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 23:12:01 -0000 pjd 2007-04-29 23:12:01 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: Oops, correct important typo in last commit. Revision Changes Path 1.13 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Apr 29 23:28:08 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 197D816A401; Sun, 29 Apr 2007 23:28:08 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E215F13C44B; Sun, 29 Apr 2007 23:28:07 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3TNS7jP094842; Sun, 29 Apr 2007 23:28:07 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3TNS73j094841; Sun, 29 Apr 2007 23:28:07 GMT (envelope-from pjd) Message-Id: <200704292328.l3TNS73j094841@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 29 Apr 2007 23:28:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs gfs.c src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 23:28:08 -0000 pjd 2007-04-29 23:28:07 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs gfs.c sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: - Define d_type for ".", ".." and ".zfs" directories. - Add a TODO comment where d_type is still noe defined. Revision Changes Path 1.2 +2 -0 src/sys/contrib/opensolaris/uts/common/fs/gfs.c 1.14 +3 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 02:25:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AEB9B16A403; Mon, 30 Apr 2007 02:25:02 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9D95713C44C; Mon, 30 Apr 2007 02:25:02 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U2P2wP036237; Mon, 30 Apr 2007 02:25:02 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U2P2n2036236; Mon, 30 Apr 2007 02:25:02 GMT (envelope-from ache) Message-Id: <200704300225.l3U2P2n2036236@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 02:25:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 02:25:02 -0000 ache 2007-04-30 02:25:02 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c Log: Make setenv, putenv, getenv and unsetenv conforming to Open Group specs Issue 6 (also IEEE Std 1003.1-2001) in following areas: args, return, errors. Putenv still needs rewriting because specs explicitly says that altering passed string later should change the environment (currently we copy the string so can't provide that). Revision Changes Path 1.21 +23 -9 src/lib/libc/stdlib/getenv.3 1.6 +5 -5 src/lib/libc/stdlib/getenv.c 1.4 +6 -2 src/lib/libc/stdlib/putenv.c 1.11 +14 -3 src/lib/libc/stdlib/setenv.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 02:27:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 53E1E16A406; Mon, 30 Apr 2007 02:27:44 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2B96D13C44C; Mon, 30 Apr 2007 02:27:44 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U2Rio0036411; Mon, 30 Apr 2007 02:27:44 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U2Rii4036410; Mon, 30 Apr 2007 02:27:44 GMT (envelope-from ache) Message-Id: <200704300227.l3U2Rii4036410@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 02:27:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include stdlib.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 02:27:44 -0000 ache 2007-04-30 02:27:43 UTC FreeBSD src repository Modified files: include stdlib.h Log: Fix unsetenv and putenv prototypes to conform Open Group specs Issue 6 (also IEEE Std 1003.1-2001) Revision Changes Path 1.63 +2 -2 src/include/stdlib.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 03:47:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6434A16A401; Mon, 30 Apr 2007 03:47:32 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3D89513C44C; Mon, 30 Apr 2007 03:47:32 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U3lWes057132; Mon, 30 Apr 2007 03:47:32 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U3lWcf057131; Mon, 30 Apr 2007 03:47:32 GMT (envelope-from ache) Message-Id: <200704300347.l3U3lWcf057131@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 03:47:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 03:47:32 -0000 ache 2007-04-30 03:47:32 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 setenv.c Log: Remove special case skipping initial '=' of the setenv() value "for compatibility with the different environment conventions" (man page). With the standards, we don't have them different anymore and IEEE Std 1003.1-2001 says that "The values that the environment variables may be assigned are not restricted except that they are considered to end with a null byte" Revision Changes Path 1.22 +0 -5 src/lib/libc/stdlib/getenv.3 1.12 +0 -2 src/lib/libc/stdlib/setenv.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 04:29:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ED7FF16A401; Mon, 30 Apr 2007 04:29:18 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 96E8113C480; Mon, 30 Apr 2007 04:29:18 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U4TIuF064884; Mon, 30 Apr 2007 04:29:18 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U4TIuO064883; Mon, 30 Apr 2007 04:29:18 GMT (envelope-from ache) Message-Id: <200704300429.l3U4TIuO064883@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 04:29:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/df df.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 04:29:19 -0000 ache 2007-04-30 04:29:18 UTC FreeBSD src repository Modified files: bin/df df.c Log: Eliminate error with -W* strict flags and make putenv() calls conforming to standard in the same way as f.e. gcc internal portable code does. Revision Changes Path 1.69 +4 -4 src/bin/df/df.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 05:14:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42D1016A400; Mon, 30 Apr 2007 05:14:30 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1D9F913C43E; Mon, 30 Apr 2007 05:14:30 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U5ETaw081993; Mon, 30 Apr 2007 05:14:29 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U5ETJS081992; Mon, 30 Apr 2007 05:14:29 GMT (envelope-from ache) Message-Id: <200704300514.l3U5ETJS081992@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 05:14:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/du du.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 05:14:30 -0000 ache 2007-04-30 05:14:29 UTC FreeBSD src repository Modified files: usr.bin/du du.c Log: Eliminate error with -W* strict flags and make putenv() calls conforming to standard and portable in the same way as f.e. gcc internal portable code does. Revision Changes Path 1.40 +3 -3 src/usr.bin/du/du.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 05:58:09 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D67016A400; Mon, 30 Apr 2007 05:58:09 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 18ED713C448; Mon, 30 Apr 2007 05:58:09 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U5w8dB088279; Mon, 30 Apr 2007 05:58:08 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U5w8JO088278; Mon, 30 Apr 2007 05:58:08 GMT (envelope-from yar) Message-Id: <200704300558.l3U5w8JO088278@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 30 Apr 2007 05:58:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/quota quota.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 05:58:09 -0000 yar 2007-04-30 05:58:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/quota quota.c Log: MFC rev. 1.30: Insert explicit space between the output fields to prevent them from running together when a field overflows. Revision Changes Path 1.24.2.2 +3 -3 src/usr.bin/quota/quota.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 07:38:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 680) id 5FF8916A402; Mon, 30 Apr 2007 07:38:56 +0000 (UTC) Date: Mon, 30 Apr 2007 07:38:56 +0000 From: Darren Reed To: Pawel Jakub Dawidek Message-ID: <20070430073856.GB42503@hub.freebsd.org> References: <200704142050.l3EKoFT7084281@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704142050.l3EKoFT7084281@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs vdev_raidz.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 07:38:56 -0000 On Sat, Apr 14, 2007 at 08:50:14PM +0000, Pawel Jakub Dawidek wrote: > pjd 2007-04-14 20:50:14 UTC > > FreeBSD src repository > > Modified files: > sys/contrib/opensolaris/uts/common/fs/zfs vdev_raidz.c > Log: > Fix RAID-Z resilvering. > > Obtained from: OpenSolaris In general, when you do this, is it possible to do either of these: 1) include a URL to the putback/commit message from OpenSolaris 2) include a URL/bug# from [Open]Solaris Cheers, Darren From owner-cvs-src@FreeBSD.ORG Mon Apr 30 09:26:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0C7F116A402; Mon, 30 Apr 2007 09:26:44 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id DBCE813C45B; Mon, 30 Apr 2007 09:26:43 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U9QhWQ039579; Mon, 30 Apr 2007 09:26:43 GMT (envelope-from thomas@repoman.freebsd.org) Received: (from thomas@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U9QhLe039578; Mon, 30 Apr 2007 09:26:43 GMT (envelope-from thomas) Message-Id: <200704300926.l3U9QhLe039578@repoman.freebsd.org> From: Thomas Quinot Date: Mon, 30 Apr 2007 09:26:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata atapi-cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 09:26:44 -0000 thomas 2007-04-30 09:26:43 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cam.c Log: (atapi_cb): Fix test for the presence of sense data. An incorrect condition was being tested, which would result in a system hang in some configurations. PR: kern/112119 Reviewed by: scottl MFC after: 3 days Revision Changes Path 1.52 +2 -2 src/sys/dev/ata/atapi-cam.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 09:33:57 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9399F16A404; Mon, 30 Apr 2007 09:33:57 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6E89F13C484; Mon, 30 Apr 2007 09:33:57 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3U9Xv0E040958; Mon, 30 Apr 2007 09:33:57 GMT (envelope-from thomas@repoman.freebsd.org) Received: (from thomas@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3U9XvRm040957; Mon, 30 Apr 2007 09:33:57 GMT (envelope-from thomas) Message-Id: <200704300933.l3U9XvRm040957@repoman.freebsd.org> From: Thomas Quinot Date: Mon, 30 Apr 2007 09:33:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata atapi-cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 09:33:57 -0000 thomas 2007-04-30 09:33:57 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cam.c Log: (atapi_action, case XPT_SCSI_IO): Enable DMA only for READ and WRITE commands as some combinations of chipset, controller and target do not behave correctly when DMA is enabled for other commands. PR: kern/103602 MFC after: 2 weeks Revision Changes Path 1.53 +19 -4 src/sys/dev/ata/atapi-cam.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 10:38:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D85D16A401; Mon, 30 Apr 2007 10:38:16 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 2FDDF13C489; Mon, 30 Apr 2007 10:38:16 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id F1F54456AB; Mon, 30 Apr 2007 12:38:14 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 888454569A; Mon, 30 Apr 2007 12:38:10 +0200 (CEST) Date: Mon, 30 Apr 2007 12:37:47 +0200 From: Pawel Jakub Dawidek To: Darren Reed Message-ID: <20070430103747.GB65475@garage.freebsd.pl> References: <200704142050.l3EKoFT7084281@repoman.freebsd.org> <20070430073856.GB42503@hub.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H1spWtNR+x+ondvy" Content-Disposition: inline In-Reply-To: <20070430073856.GB42503@hub.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs vdev_raidz.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 10:38:16 -0000 --H1spWtNR+x+ondvy Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 07:38:56AM +0000, Darren Reed wrote: > On Sat, Apr 14, 2007 at 08:50:14PM +0000, Pawel Jakub Dawidek wrote: > > pjd 2007-04-14 20:50:14 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/contrib/opensolaris/uts/common/fs/zfs vdev_raidz.c=20 > > Log: > > Fix RAID-Z resilvering. > > =20 > > Obtained from: OpenSolaris >=20 > In general, when you do this, is it possible to do either of these: > 1) include a URL to the putback/commit message from OpenSolaris > 2) include a URL/bug# from [Open]Solaris Yes, I actually started to do it (2). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --H1spWtNR+x+ondvy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGNcb7ForvXbEpPzQRAix/AKDQ4gO6kz+JkJEwYmY7/MVKhGyGtQCfQO99 MilQIIYLAblQOfeHsWmH2i0= =MO8s -----END PGP SIGNATURE----- --H1spWtNR+x+ondvy-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 10:50:54 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E80CF16A402; Mon, 30 Apr 2007 10:50:54 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BA07F13C455; Mon, 30 Apr 2007 10:50:54 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UAosbD058943; Mon, 30 Apr 2007 10:50:54 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UAorSC058942; Mon, 30 Apr 2007 10:50:54 GMT (envelope-from simokawa) Message-Id: <200704301050.l3UAorSC058942@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 10:50:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c firewirereg.h fwohci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 10:50:55 -0000 simokawa 2007-04-30 10:50:53 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c firewirereg.h fwohci.c Log: Initialize configuration ROM before a bus reset. MFC: after 3 days Revision Changes Path 1.87 +3 -2 src/sys/dev/firewire/firewire.c 1.42 +1 -1 src/sys/dev/firewire/firewirereg.h 1.87 +1 -1 src/sys/dev/firewire/fwohci.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 11:44:42 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EF74116A406; Mon, 30 Apr 2007 11:44:42 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C904E13C4C5; Mon, 30 Apr 2007 11:44:42 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UBigeU070088; Mon, 30 Apr 2007 11:44:42 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UBig50070087; Mon, 30 Apr 2007 11:44:42 GMT (envelope-from ache) Message-Id: <200704301144.l3UBig50070087@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 11:44:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 11:44:43 -0000 ache 2007-04-30 11:44:42 UTC FreeBSD src repository Modified files: bin/sh var.c Log: Put some safeguards: 1) Under POSIX unsetenv("foo=bar") is explicit error and not equal to unsetenv("foo") 2) Prepare for upcomig POSIXed putenv() rewrite: make putenv() calls portable and conforming to standard. Revision Changes Path 1.33 +9 -4 src/bin/sh/var.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 11:55:31 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD65416A404; Mon, 30 Apr 2007 11:55:31 +0000 (UTC) (envelope-from lulf@pvv.ntnu.no) Received: from signal.itea.ntnu.no (signal.itea.ntnu.no [129.241.190.231]) by mx1.freebsd.org (Postfix) with ESMTP id 6B8A313C455; Mon, 30 Apr 2007 11:55:31 +0000 (UTC) (envelope-from lulf@pvv.ntnu.no) Received: from localhost (localhost [127.0.0.1]) by signal.itea.ntnu.no (Postfix) with ESMTP id 8CCC2347D7; Mon, 30 Apr 2007 13:36:00 +0200 (CEST) Received: from twoflower.idi.ntnu.no (twoflower.idi.ntnu.no [129.241.104.169]) by signal.itea.ntnu.no (Postfix) with ESMTP; Mon, 30 Apr 2007 13:36:00 +0200 (CEST) Received: by twoflower.idi.ntnu.no (Postfix, from userid 1002) id 3BA3B1700C; Mon, 30 Apr 2007 13:36:00 +0200 (CEST) Date: Mon, 30 Apr 2007 13:36:00 +0200 From: Ulf Lilleengen To: Scott Long Message-ID: <20070430113600.GA36520@twoflower.idi.ntnu.no> References: <200704271423.l3REN6RG092921@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704271423.l3REN6RG092921@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Content-Scanned: with sophos and spamassassin at mailgw.ntnu.no. Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 11:55:31 -0000 On fre, apr 27, 2007 at 02:23:06pm +0000, Scott Long wrote: > scottl 2007-04-27 14:23:06 UTC > > FreeBSD src repository > > Modified files: > sys/cam cam_xpt.c > Log: > Only schedule the xpt_finishconfig_task once. This fixes some potential > panics on boot. > Thank you very much! I had a hard time debugging this. I got panic because of a non-existant CDROM in my laptop :) -- Ulf Lilleengen From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:26:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C4A7C16A400; Mon, 30 Apr 2007 12:26:30 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9E02913C43E; Mon, 30 Apr 2007 12:26:30 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCQUn7077737; Mon, 30 Apr 2007 12:26:30 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCQUUC077736; Mon, 30 Apr 2007 12:26:30 GMT (envelope-from simokawa) Message-Id: <200704301226.l3UCQUUC077736@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 12:26:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c firewirereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:26:30 -0000 simokawa 2007-04-30 12:26:30 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c firewirereg.h Log: MFp4: Simplify tlabel handling - Remove struct tl_label and runtime malloc() for it. - Include tl_lable list in struct fw_xfer. - Don't free unallocated tlabel. MFC after: 1 week Revision Changes Path 1.88 +27 -33 src/sys/dev/firewire/firewire.c 1.43 +3 -7 src/sys/dev/firewire/firewirereg.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:27:04 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6BDDE16A400; Mon, 30 Apr 2007 12:27:04 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 45C3F13C44B; Mon, 30 Apr 2007 12:27:04 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCR4fN077820; Mon, 30 Apr 2007 12:27:04 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCR4VC077819; Mon, 30 Apr 2007 12:27:04 GMT (envelope-from maxim) Message-Id: <200704301227.l3UCR4VC077819@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 12:27:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat inet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:27:04 -0000 maxim 2007-04-30 12:27:04 UTC FreeBSD src repository Modified files: usr.bin/netstat inet.c Log: o Fill the list of icmp types; make its size depend on ICMP_MAXTYPE. o Print "unknown ICMP" instead of "(null)" if we don't have a description for a icmp type. Based on code Submitted by: Christoph Weber-Fahr PR: misc/112126 MFC after: 2 weeks Revision Changes Path 1.75 +50 -20 src/usr.bin/netstat/inet.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:27:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F250F16A4E1; Mon, 30 Apr 2007 12:27:58 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C6B5613C45D; Mon, 30 Apr 2007 12:27:58 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCRwZN077865; Mon, 30 Apr 2007 12:27:58 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCRwao077864; Mon, 30 Apr 2007 12:27:58 GMT (envelope-from ache) Message-Id: <200704301227.l3UCRwao077864@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:27:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:27:59 -0000 ache 2007-04-30 12:27:58 UTC FreeBSD src repository Modified files: libexec/pppoed pppoed.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't allow putenv() arg be on the stack, replace putenv() with setenv() Revision Changes Path 1.25 +4 -4 src/libexec/pppoed/pppoed.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:30:22 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 747AD16A408; Mon, 30 Apr 2007 12:30:22 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 469B313C4C7; Mon, 30 Apr 2007 12:30:22 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCUM1r078046; Mon, 30 Apr 2007 12:30:22 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCUM31078045; Mon, 30 Apr 2007 12:30:22 GMT (envelope-from simokawa) Message-Id: <200704301230.l3UCUM31078045@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 12:30:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c firewirereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:30:22 -0000 simokawa 2007-04-30 12:30:22 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c firewirereg.h Log: MFp4: remove unused fw_asybusy(). MFC after: 1 week Revision Changes Path 1.89 +0 -14 src/sys/dev/firewire/firewire.c 1.44 +0 -1 src/sys/dev/firewire/firewirereg.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:38:51 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2F6D916A400; Mon, 30 Apr 2007 12:38:51 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0892013C480; Mon, 30 Apr 2007 12:38:51 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCcoV7079582; Mon, 30 Apr 2007 12:38:50 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCconl079581; Mon, 30 Apr 2007 12:38:50 GMT (envelope-from simokawa) Message-Id: <200704301238.l3UCconl079581@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 12:38:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire fwohci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:38:51 -0000 simokawa 2007-04-30 12:38:50 UTC FreeBSD src repository Modified files: sys/dev/firewire fwohci.c Log: MFp4: Add a sysctl knob to disable cycle master mode and add some comments. MFC after: 1 week Revision Changes Path 1.88 +9 -1 src/sys/dev/firewire/fwohci.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:44:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 03D0916A400; Mon, 30 Apr 2007 12:44:05 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D1BEC13C44B; Mon, 30 Apr 2007 12:44:04 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCi4sk081092; Mon, 30 Apr 2007 12:44:04 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCi42l081091; Mon, 30 Apr 2007 12:44:04 GMT (envelope-from ache) Message-Id: <200704301244.l3UCi42l081091@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:44:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/login login.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:44:05 -0000 ache 2007-04-30 12:44:04 UTC FreeBSD src repository Modified files: usr.bin/login login.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't free memory after putenv() Revision Changes Path 1.103 +1 -1 src/usr.bin/login/login.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:51:03 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7CC2F16A403; Mon, 30 Apr 2007 12:51:03 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4972013C489; Mon, 30 Apr 2007 12:51:03 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCp3IE090187; Mon, 30 Apr 2007 12:51:03 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCp3uq090185; Mon, 30 Apr 2007 12:51:03 GMT (envelope-from ache) Message-Id: <200704301251.l3UCp3uq090185@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:51:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:51:03 -0000 ache 2007-04-30 12:51:02 UTC FreeBSD src repository Modified files: usr.bin/su su.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't free memory after putenv() Revision Changes Path 1.84 +3 -2 src/usr.bin/su/su.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:54:03 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 34E2716A40B; Mon, 30 Apr 2007 12:54:03 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0E6D313C4F0; Mon, 30 Apr 2007 12:54:03 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCs2df091034; Mon, 30 Apr 2007 12:54:02 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCs28u091032; Mon, 30 Apr 2007 12:54:02 GMT (envelope-from ache) Message-Id: <200704301254.l3UCs28u091032@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:54:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/login login.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:54:03 -0000 ache 2007-04-30 12:54:02 UTC FreeBSD src repository Modified files: usr.bin/login login.c Log: Slightly tune previous fix: free memory if !export Revision Changes Path 1.104 +2 -2 src/usr.bin/login/login.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 12:55:04 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 436CD16A404; Mon, 30 Apr 2007 12:55:04 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 14DE913C44C; Mon, 30 Apr 2007 12:55:04 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UCt3di091292; Mon, 30 Apr 2007 12:55:03 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UCt3Ca091291; Mon, 30 Apr 2007 12:55:03 GMT (envelope-from simokawa) Message-Id: <200704301255.l3UCt3Ca091291@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 12:55:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 12:55:04 -0000 simokawa 2007-04-30 12:55:03 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c Log: MFp4: Fix typo in recv spd. MFC after: 1 week Revision Changes Path 1.90 +1 -1 src/sys/dev/firewire/firewire.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:03:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6647E16A404; Mon, 30 Apr 2007 13:03:36 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3272213C46A; Mon, 30 Apr 2007 13:03:36 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UD3Zho094090; Mon, 30 Apr 2007 13:03:35 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UD3ZND094089; Mon, 30 Apr 2007 13:03:35 GMT (envelope-from ache) Message-Id: <200704301303.l3UD3ZND094089@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 13:03:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sade variable.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:03:36 -0000 ache 2007-04-30 13:03:35 UTC FreeBSD src repository Modified files: usr.sbin/sade variable.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't allow putenv() arg be on the stack, use strdup() Revision Changes Path 1.40 +1 -1 src/usr.sbin/sade/variable.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:07:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D30AA16A402; Mon, 30 Apr 2007 13:07:34 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AC6CF13C487; Mon, 30 Apr 2007 13:07:34 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UD7YVp094495; Mon, 30 Apr 2007 13:07:34 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UD7YoW094493; Mon, 30 Apr 2007 13:07:34 GMT (envelope-from ache) Message-Id: <200704301307.l3UD7YoW094493@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 13:07:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall variable.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:07:34 -0000 ache 2007-04-30 13:07:34 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall variable.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't allow putenv() arg be on the stack, use strdup() Revision Changes Path 1.38 +1 -1 src/usr.sbin/sysinstall/variable.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:15:12 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4641E16A403; Mon, 30 Apr 2007 13:15:12 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id D69ED13C46E; Mon, 30 Apr 2007 13:15:11 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.66 (FreeBSD)) (envelope-from ) id 1HiVia-000Eg5-6W; Mon, 30 Apr 2007 14:15:04 +0100 Date: Mon, 30 Apr 2007 14:15:04 +0100 From: Ceri Davies To: Yar Tikhiy Message-ID: <20070430131503.GY77408@submonkey.net> References: <200704260639.l3Q6d1SH027885@repoman.freebsd.org> <20070426105458.GA98415@nevermind.kiev.ua> <20070426114638.GC77408@submonkey.net> <20070427160740.GF3991@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n95ggtiZmkwHBchJ" Content-Disposition: inline In-Reply-To: <20070427160740.GF3991@comp.chem.msu.su> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.15 (2007-04-06) Sender: Ceri Davies Cc: cvs-src@freebsd.org, Alexandr Kovalenko , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:15:12 -0000 --n95ggtiZmkwHBchJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 27, 2007 at 08:07:40PM +0400, Yar Tikhiy wrote: > On Thu, Apr 26, 2007 at 12:46:38PM +0100, Ceri Davies wrote: > > On Thu, Apr 26, 2007 at 01:54:59PM +0300, Alexandr Kovalenko wrote: > > > Hello, Yar Tikhiy! > > >=20 > > > On Thu, Apr 26, 2007 at 06:39:01AM +0000, you wrote: > > >=20 > > > > yar 2007-04-26 06:39:01 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: (Branch: RELENG_6) > > > > lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c=20 > > > > Log: > > > > MFC: > > > > pam_unix.c 1.52 > > > > pam_unix.8 1.13 > > > > =20 > > > > In account management, verify whether the account has been lock= ed > > > > with `pw lock', so that it's impossible to log into a locked ac= count > > > > using an alternative authentication mechanism, such as an ssh k= ey. > > > > This change affects only accounts locked with pw(8), i.e., havi= ng a > > > > `*LOCKED*' prefix in their password hash field, so people still= can > > > > use a different pattern to disable password authentication only. > > >=20 > > > Using the very same logic you should also add checking for '*', and f= or > > > any other string, which cannot be in password hash of different > > > algorithms. By the way, what if some crypto algorithm, which will be > > > used for password hashing can produce hash, which contains substring > > > '*LOCKED*' ? > >=20 > > We really need to grow the same mechanism for this as Solaris has. > > The way that this works is: > >=20 > > o If the password hash begins *NP* then the user has no password > > and password authentication will always fail. > >=20 > > o If the password hash begins *LK* then the account is considered > > locked and all authentication fails. Also, cron and at will > > not run jobs for that user. > >=20 > > o Anything else, the account is considered enabled (although of > > course, password checking can still fail if the hash is not > > valid). > >=20 > > I couldn't care less what the strings actually are, but we should > > probably use *LOCKED* for the locked case, although I can see that we > > may wish to use something else to provide a somewhat backward compatible > > route - those who have been using the string *LOCKED* as stated in the > > pw manual would get the same behaviour that they do now. > >=20 > > I am willing to work on this, but not without general agreement on the > > above. >=20 > I believe that general consensus in PR bin/71147 was that in FreeBSD > a *LOCKED* prefix means the account is totally locked out while a > single asterisk in the password field means password authentication > is disabled. And, it isn't unfounded. That practice has already > been supported by adduser(8) for quite a while. Now OpenSSH, too, > looks for *LOCKED* as the FreeBSD-specific indication of an account > being locked out if PAM isn't used. So I see my change to pam_unix(8) > just as a step in the direction we've already been moving in. To > match Solaris, we just need to document our practice well. Well, we currently have an *NP* case as per above, but not a *LK* case, so I disagree somewhat. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --n95ggtiZmkwHBchJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGNevXocfcwTS3JF8RAhnDAKCCBTjMb5PDrlLjc3IitPqd8ldWeACfcJl0 XhTijfZgj4bLfo1Uu6o9amA= =Q50P -----END PGP SIGNATURE----- --n95ggtiZmkwHBchJ-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:21:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3B4CA16A401; Mon, 30 Apr 2007 13:21:44 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2D51A13C458; Mon, 30 Apr 2007 13:21:44 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UDLimA096830; Mon, 30 Apr 2007 13:21:44 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UDLhSX096829; Mon, 30 Apr 2007 13:21:43 GMT (envelope-from yar) Message-Id: <200704301321.l3UDLhSX096829@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 30 Apr 2007 13:21:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mdmfs mdmfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:21:44 -0000 yar 2007-04-30 13:21:43 UTC FreeBSD src repository Modified files: sbin/mdmfs mdmfs.c Log: Fix a typo: argv -> argvp Rationale: We are interested in the current (last) element of the argv array there, not in its first element. The if construct is there because we want to avoid adding empty (zero-length) arguments to argv, so we just don't advance argvp if the current argument is empty, and it gets overwritten at the next iteration. Note that strsep(3) doesn't treat consecutive delim characters as a single separator, it returns empty fields between such characters, and it's up to the caller to handle them this or that way. Also add a comment that the argv array ends up null-terminated in any case (it's due to the design of the for loop) as an answer to a possible question why the whole argv isn't zero-filled. Submitted by: yongari Tested by: yongari MFC after: 3 days Revision Changes Path 1.32 +2 -1 src/sbin/mdmfs/mdmfs.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:41:41 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 60AED16A400; Mon, 30 Apr 2007 13:41:41 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 517C713C457; Mon, 30 Apr 2007 13:41:41 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UDffwD000752; Mon, 30 Apr 2007 13:41:41 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UDff99000751; Mon, 30 Apr 2007 13:41:41 GMT (envelope-from simokawa) Message-Id: <200704301341.l3UDff99000751@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 13:41:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c firewirereg.h fwdev.c if_fwip.c sbp.c sbp_targ.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:41:41 -0000 simokawa 2007-04-30 13:41:41 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c firewirereg.h fwdev.c if_fwip.c sbp.c sbp_targ.c Log: MFp4: Fix broken userland API for async packets. - Introduce fw_xferlist_add/remove(). - Introduce fw_read/write_async(). - Remove unused FWACT_CH. MFC after: 1 week Revision Changes Path 1.91 +45 -54 src/sys/dev/firewire/firewire.c 1.45 +9 -9 src/sys/dev/firewire/firewirereg.h 1.51 +184 -93 src/sys/dev/firewire/fwdev.c 1.15 +0 -1 src/sys/dev/firewire/if_fwip.c 1.91 +4 -20 src/sys/dev/firewire/sbp.c 1.12 +4 -19 src/sys/dev/firewire/sbp_targ.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:42:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 61BB516A400; Mon, 30 Apr 2007 13:42:32 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 7D54013C487; Mon, 30 Apr 2007 13:42:31 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l3UDgTMI036456; Mon, 30 Apr 2007 17:42:29 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l3UDgS4I036455; Mon, 30 Apr 2007 17:42:28 +0400 (MSD) (envelope-from yar) Date: Mon, 30 Apr 2007 17:42:28 +0400 From: Yar Tikhiy To: Ceri Davies Message-ID: <20070430134227.GG32601@comp.chem.msu.su> References: <200704260639.l3Q6d1SH027885@repoman.freebsd.org> <20070426105458.GA98415@nevermind.kiev.ua> <20070426114638.GC77408@submonkey.net> <20070427160740.GF3991@comp.chem.msu.su> <20070430131503.GY77408@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430131503.GY77408@submonkey.net> User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, Alexandr Kovalenko , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:42:32 -0000 On Mon, Apr 30, 2007 at 02:15:04PM +0100, Ceri Davies wrote: > On Fri, Apr 27, 2007 at 08:07:40PM +0400, Yar Tikhiy wrote: > > On Thu, Apr 26, 2007 at 12:46:38PM +0100, Ceri Davies wrote: > > > On Thu, Apr 26, 2007 at 01:54:59PM +0300, Alexandr Kovalenko wrote: > > > > Hello, Yar Tikhiy! > > > > > > > > On Thu, Apr 26, 2007 at 06:39:01AM +0000, you wrote: > > > > > > > > > yar 2007-04-26 06:39:01 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: (Branch: RELENG_6) > > > > > lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c > > > > > Log: > > > > > MFC: > > > > > pam_unix.c 1.52 > > > > > pam_unix.8 1.13 > > > > > > > > > > In account management, verify whether the account has been locked > > > > > with `pw lock', so that it's impossible to log into a locked account > > > > > using an alternative authentication mechanism, such as an ssh key. > > > > > This change affects only accounts locked with pw(8), i.e., having a > > > > > `*LOCKED*' prefix in their password hash field, so people still can > > > > > use a different pattern to disable password authentication only. > > > > > > > > Using the very same logic you should also add checking for '*', and for > > > > any other string, which cannot be in password hash of different > > > > algorithms. By the way, what if some crypto algorithm, which will be > > > > used for password hashing can produce hash, which contains substring > > > > '*LOCKED*' ? > > > > > > We really need to grow the same mechanism for this as Solaris has. > > > The way that this works is: > > > > > > o If the password hash begins *NP* then the user has no password > > > and password authentication will always fail. > > > > > > o If the password hash begins *LK* then the account is considered > > > locked and all authentication fails. Also, cron and at will > > > not run jobs for that user. > > > > > > o Anything else, the account is considered enabled (although of > > > course, password checking can still fail if the hash is not > > > valid). > > > > > > I couldn't care less what the strings actually are, but we should > > > probably use *LOCKED* for the locked case, although I can see that we > > > may wish to use something else to provide a somewhat backward compatible > > > route - those who have been using the string *LOCKED* as stated in the > > > pw manual would get the same behaviour that they do now. > > > > > > I am willing to work on this, but not without general agreement on the > > > above. > > > > I believe that general consensus in PR bin/71147 was that in FreeBSD > > a *LOCKED* prefix means the account is totally locked out while a > > single asterisk in the password field means password authentication > > is disabled. And, it isn't unfounded. That practice has already > > been supported by adduser(8) for quite a while. Now OpenSSH, too, > > looks for *LOCKED* as the FreeBSD-specific indication of an account > > being locked out if PAM isn't used. So I see my change to pam_unix(8) > > just as a step in the direction we've already been moving in. To > > match Solaris, we just need to document our practice well. > > Well, we currently have an *NP* case as per above, but not a *LK* case, > so I disagree somewhat. Why? Now *LOCKED* in FreeBSD is nearly the same as *LK* in Solaris with the only difference being that cron or at doesn't seem to care about it. And a single asterisk works for us as *NP* does in Solaris, although it isn't a prefix, it occupies the whole password field. Did I miss anything? -- Yar From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:46:24 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8688E16A406; Mon, 30 Apr 2007 13:46:24 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id 398B613C45E; Mon, 30 Apr 2007 13:46:24 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.66 (FreeBSD)) (envelope-from ) id 1HiWCo-000FxF-LQ; Mon, 30 Apr 2007 14:46:18 +0100 Date: Mon, 30 Apr 2007 14:46:18 +0100 From: Ceri Davies To: Yar Tikhiy Message-ID: <20070430134617.GZ77408@submonkey.net> References: <200704260639.l3Q6d1SH027885@repoman.freebsd.org> <20070426105458.GA98415@nevermind.kiev.ua> <20070426114638.GC77408@submonkey.net> <20070427160740.GF3991@comp.chem.msu.su> <20070430131503.GY77408@submonkey.net> <20070430134227.GG32601@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8tIZwPmdq+hd82jQ" Content-Disposition: inline In-Reply-To: <20070430134227.GG32601@comp.chem.msu.su> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.15 (2007-04-06) Sender: Ceri Davies Cc: cvs-src@freebsd.org, Alexandr Kovalenko , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:46:24 -0000 --8tIZwPmdq+hd82jQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 05:42:28PM +0400, Yar Tikhiy wrote: > On Mon, Apr 30, 2007 at 02:15:04PM +0100, Ceri Davies wrote: > >=20 > > Well, we currently have an *NP* case as per above, but not a *LK* case, > > so I disagree somewhat. >=20 > Why? Now *LOCKED* in FreeBSD is nearly the same as *LK* in Solaris > with the only difference being that cron or at doesn't seem to care > about it. And a single asterisk works for us as *NP* does in > Solaris, although it isn't a prefix, it occupies the whole password > field. Did I miss anything? Well, because of the cron thing :) Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --8tIZwPmdq+hd82jQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGNfMpocfcwTS3JF8RAhtEAJ4x+6gY9w9woiEEWoGNQS68iGJTnQCfeHgz Y89O5zVN6Cp1OTiUBdrTFHI= =qz6y -----END PGP SIGNATURE----- --8tIZwPmdq+hd82jQ-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 13:51:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC10516A401; Mon, 30 Apr 2007 13:51:13 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8549913C455; Mon, 30 Apr 2007 13:51:13 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UDpDoT002353; Mon, 30 Apr 2007 13:51:13 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UDpDnA002348; Mon, 30 Apr 2007 13:51:13 GMT (envelope-from simokawa) Message-Id: <200704301351.l3UDpDnA002348@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 13:51:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire firewire.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 13:51:13 -0000 simokawa 2007-04-30 13:51:13 UTC FreeBSD src repository Modified files: sys/dev/firewire firewire.c Log: MFp4: - Update state in fw_xferq_dorain() after removed from the send queue. - Remove unnecessary 'goto err;". MFC after: 1 week Revision Changes Path 1.92 +11 -9 src/sys/dev/firewire/firewire.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 14:06:31 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CDB3616A403; Mon, 30 Apr 2007 14:06:31 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id A6CB713C48C; Mon, 30 Apr 2007 14:06:31 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UE6VqM006295; Mon, 30 Apr 2007 14:06:31 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UE6VHE006294; Mon, 30 Apr 2007 14:06:31 GMT (envelope-from simokawa) Message-Id: <200704301406.l3UE6VHE006294@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Mon, 30 Apr 2007 14:06:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/firewire fwohci.c fwohcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 14:06:31 -0000 simokawa 2007-04-30 14:06:31 UTC FreeBSD src repository Modified files: sys/dev/firewire fwohci.c fwohcireg.h Log: MFp4: Improve asynchronous packet receive process. - Wake up DMA engine after adding a new receive buffer. - Skip buffers which have unknown state after error. - More rigid error detection. MFC after: 1 week Revision Changes Path 1.89 +68 -32 src/sys/dev/firewire/fwohci.c 1.23 +5 -0 src/sys/dev/firewire/fwohcireg.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 14:29:43 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACA7C16A402; Mon, 30 Apr 2007 14:29:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6B94B13C44B; Mon, 30 Apr 2007 14:29:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l3UEQXhH095448; Mon, 30 Apr 2007 08:26:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 30 Apr 2007 08:26:45 -0600 (MDT) Message-Id: <20070430.082645.270753761.imp@bsdimp.com> To: ache@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200704301144.l3UBig50070087@repoman.freebsd.org> References: <200704301144.l3UBig50070087@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 30 Apr 2007 08:26:34 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 14:29:43 -0000 In message: <200704301144.l3UBig50070087@repoman.freebsd.org> "Andrey A. Chernov" writes: : ache 2007-04-30 11:44:42 UTC : : FreeBSD src repository : : Modified files: : bin/sh var.c : Log: : Put some safeguards: : 1) Under POSIX unsetenv("foo=bar") is explicit error and not equal : to unsetenv("foo") : 2) Prepare for upcomig POSIXed putenv() rewrite: make putenv() calls : portable and conforming to standard. Andrey, Can you bump the __FreeBSD_version in sys/param.h for these changes and document it in the FreeBSD committer's handbook? Warner From owner-cvs-src@FreeBSD.ORG Mon Apr 30 14:48:08 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B89EC16A402; Mon, 30 Apr 2007 14:48:08 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 3998C13C457; Mon, 30 Apr 2007 14:48:07 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UEm2BG055748; Mon, 30 Apr 2007 18:48:02 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UEm2sY055747; Mon, 30 Apr 2007 18:48:02 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 18:48:02 +0400 From: Andrey Chernov To: "M. Warner Losh" Message-ID: <20070430144802.GA55665@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "M. Warner Losh" , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301144.l3UBig50070087@repoman.freebsd.org> <20070430.082645.270753761.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430.082645.270753761.imp@bsdimp.com> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 14:48:08 -0000 On Mon, Apr 30, 2007 at 08:26:45AM -0600, M. Warner Losh wrote: > Andrey, > > Can you bump the __FreeBSD_version in sys/param.h for these changes > and document it in the FreeBSD committer's handbook? Yes, of course, but a bit later. Currently changes are in progress, preparing to putenv() rewriting. Unlike portable soft like gcc, cvs, etc. FreeBSD have a bad habbit considering putenv() arg as safe to pass and forget (because putenv() was incorrecly implemented via setenv(), which copy the arg), there still a lot of places to fix, almost every putenv() usage in FreeBSD is unportable... :( -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 15:01:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 946E916A409; Mon, 30 Apr 2007 15:01:34 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6E57F13C45D; Mon, 30 Apr 2007 15:01:34 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UF1YL5015613; Mon, 30 Apr 2007 15:01:34 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UF1YP5015612; Mon, 30 Apr 2007 15:01:34 GMT (envelope-from ache) Message-Id: <200704301501.l3UF1YP5015612@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 15:01:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 15:01:34 -0000 ache 2007-04-30 15:01:34 UTC FreeBSD src repository Modified files: bin/sh var.c Log: Simplify previous fix and disallow VTEXTFIXED direct pass for putenv() too, just use savestr() Revision Changes Path 1.34 +3 -3 src/bin/sh/var.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 15:10:54 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9C20916A402; Mon, 30 Apr 2007 15:10:54 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 75DD913C43E; Mon, 30 Apr 2007 15:10:54 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UFAsgG017770; Mon, 30 Apr 2007 15:10:54 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UFAs4U017767; Mon, 30 Apr 2007 15:10:54 GMT (envelope-from ache) Message-Id: <200704301510.l3UFAs4U017767@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 15:10:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sade main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 15:10:54 -0000 ache 2007-04-30 15:10:53 UTC FreeBSD src repository Modified files: usr.sbin/sade main.c Log: Preparing for upcoming POSIXed putenv() rewrite: don't allow const as putenv() arg, dup it Revision Changes Path 1.78 +1 -1 src/usr.sbin/sade/main.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 15:14:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D77B16A400; Mon, 30 Apr 2007 15:14:25 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id DB91613C447; Mon, 30 Apr 2007 15:14:24 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UFEOeh019042; Mon, 30 Apr 2007 15:14:24 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UFEOBi019041; Mon, 30 Apr 2007 15:14:24 GMT (envelope-from ache) Message-Id: <200704301514.l3UFEOBi019041@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 15:14:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pstat pstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 15:14:25 -0000 ache 2007-04-30 15:14:24 UTC FreeBSD src repository Modified files: usr.sbin/pstat pstat.c Log: Preparing for upcoming POSIXed putenv() rewrite: don't allow const as putenv() arg, dup it Revision Changes Path 1.100 +3 -3 src/usr.sbin/pstat/pstat.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 15:16:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AE19E16A400; Mon, 30 Apr 2007 15:16:19 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 87A4C13C44B; Mon, 30 Apr 2007 15:16:19 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UFGJhX019163; Mon, 30 Apr 2007 15:16:19 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UFGJbu019162; Mon, 30 Apr 2007 15:16:19 GMT (envelope-from ache) Message-Id: <200704301516.l3UFGJbu019162@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 15:16:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 15:16:19 -0000 ache 2007-04-30 15:16:19 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall main.c Log: Preparing for upcoming POSIXed putenv() rewrite: don't allow const as putenv() arg, dup it Revision Changes Path 1.75 +1 -1 src/usr.sbin/sysinstall/main.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 15:41:01 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7D95E16A406; Mon, 30 Apr 2007 15:41:01 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 548A413C4B9; Mon, 30 Apr 2007 15:41:01 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UFf10L022771; Mon, 30 Apr 2007 15:41:01 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UFf1bB022766; Mon, 30 Apr 2007 15:41:01 GMT (envelope-from brueffer) Message-Id: <200704301541.l3UFf1bB022766@repoman.freebsd.org> From: Christian Brueffer Date: Mon, 30 Apr 2007 15:41:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 15:41:01 -0000 brueffer 2007-04-30 15:41:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: New release notes: - edsc(4) added Modified release notes: - ncurses was updated from version 5.2-20020615 - MSI-X supported as well, remove ref to pci(4) manpage, which is different from the kernel's PCI code Revision Changes Path 1.883.2.70 +7 -3 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:15:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E1DED16A403; Mon, 30 Apr 2007 16:15:19 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BB7CA13C45D; Mon, 30 Apr 2007 16:15:19 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UGFJUp030102; Mon, 30 Apr 2007 16:15:19 GMT (envelope-from takawata@repoman.freebsd.org) Received: (from takawata@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UGFJpX030101; Mon, 30 Apr 2007 16:15:19 GMT (envelope-from takawata) Message-Id: <200704301615.l3UGFJpX030101@repoman.freebsd.org> From: Takanori Watanabe Date: Mon, 30 Apr 2007 16:15:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb uftdi.c usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:15:20 -0000 takawata 2007-04-30 16:15:19 UTC FreeBSD src repository Modified files: sys/dev/usb uftdi.c usbdevs Log: Add MELCO PC-OP-RS Universal remote ID. Revision Changes Path 1.25 +15 -0 src/sys/dev/usb/uftdi.c 1.292 +1 -0 src/sys/dev/usb/usbdevs From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:29:25 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4608A16A400; Mon, 30 Apr 2007 16:29:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id E4C6513C484; Mon, 30 Apr 2007 16:29:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3UGTM55014957; Mon, 30 Apr 2007 12:29:23 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:29:20 -0400 User-Agent: KMail/1.9.6 References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> In-Reply-To: <200704301516.l3UFGJbu019162@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704301229.21190.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 30 Apr 2007 12:29:23 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3184/Mon Apr 30 09:51:57 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.3 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:29:25 -0000 On Monday 30 April 2007 11:16:19 am Andrey A. Chernov wrote: > ache 2007-04-30 15:16:19 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/sysinstall main.c > Log: > Preparing for upcoming POSIXed putenv() rewrite: > don't allow const as putenv() arg, dup it Have you coordinated at all with the guy on current@ who has patches to make setenv(3) not leak memory as bad? Also, given that we malloc a limited space for the string values, I don't see how you can make it so that one can always just overwrite the string pointed to by putenv(3)'s return value to change the value. If we malloc a buffer for length N and the user wants to set the length to M > N, we pretty much have to malloc a new buffer that will end up at a different address, so places holding onto the previous value returned from putenv(3) will stop seeing updates. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:34:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4A2DB16A400; Mon, 30 Apr 2007 16:34:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 245AF13C43E; Mon, 30 Apr 2007 16:34:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UGYBxO033095; Mon, 30 Apr 2007 16:34:11 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UGYAL9033094; Mon, 30 Apr 2007 16:34:10 GMT (envelope-from jhb) Message-Id: <200704301634.l3UGYAL9033094@repoman.freebsd.org> From: John Baldwin Date: Mon, 30 Apr 2007 16:34:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/i386/i386 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:34:11 -0000 jhb 2007-04-30 16:34:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/i386/i386 mp_machdep.c Log: MFC: Only treat logical CPUs as hyperthreads if they share the L1 cache. Revision Changes Path 1.115.2.28 +2 -2 src/sys/i386/i386/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:40:35 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3167716A400; Mon, 30 Apr 2007 16:40:35 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id A082413C4AE; Mon, 30 Apr 2007 16:40:34 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UGeXJu082424; Mon, 30 Apr 2007 20:40:33 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UGeW6m082422; Mon, 30 Apr 2007 20:40:32 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 20:40:31 +0400 From: Andrey Chernov To: John Baldwin Message-ID: <20070430164031.GA82368@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John Baldwin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704301229.21190.jhb@freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:40:35 -0000 On Mon, Apr 30, 2007 at 12:29:20PM -0400, John Baldwin wrote: > Have you coordinated at all with the guy on current@ who has patches to make > setenv(3) not leak memory as bad? No, I don't touch current allocation scheme at all. It isn't my goal. > Also, given that we malloc a limited space > for the string values, I don't see how you can make it so that one can always > just overwrite the string pointed to by putenv(3)'s return value to change > the value. If we malloc a buffer for length N and the user wants to set the > length to M > N, we pretty much have to malloc a new buffer that will end up > at a different address, so places holding onto the previous value returned > from putenv(3) will stop seeing updates. It isn't the issue. Putenv value supposed to live just up to the next putenv or setenv call, so setenv can legitimately overwrite it. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:55:05 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AF55916A400; Mon, 30 Apr 2007 16:55:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 32EC513C45D; Mon, 30 Apr 2007 16:55:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3UGt3qr015112; Mon, 30 Apr 2007 12:55:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 12:54:45 -0400 User-Agent: KMail/1.9.6 References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> In-Reply-To: <200704301229.21190.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704301254.45807.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 30 Apr 2007 12:55:03 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3184/Mon Apr 30 09:51:57 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.3 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:55:05 -0000 On Monday 30 April 2007 12:29:20 pm John Baldwin wrote: > On Monday 30 April 2007 11:16:19 am Andrey A. Chernov wrote: > > ache 2007-04-30 15:16:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/sysinstall main.c > > Log: > > Preparing for upcoming POSIXed putenv() rewrite: > > don't allow const as putenv() arg, dup it > > Have you coordinated at all with the guy on current@ who has patches to make > setenv(3) not leak memory as bad? Also, given that we malloc a limited space > for the string values, I don't see how you can make it so that one can always > just overwrite the string pointed to by putenv(3)'s return value to change > the value. If we malloc a buffer for length N and the user wants to set the > length to M > N, we pretty much have to malloc a new buffer that will end up > at a different address, so places holding onto the previous value returned > from putenv(3) will stop seeing updates. Hmm, I think I see that this is orthogonal to the setenv(3) fix, but still, if one does this: char *cp = strdup("FOO=bar"); putenv(cp); ... setenv("FOO", "baz"); ... setenv("FOO", "really_long_string"); ... printf("FOO: %s\n", cp + 4); You are going to get 'baz' in the printf output. Or if one does: char *cp = strdup("FOO=bar"); putenv(cp); ... setenv("FOO", "really_long_string"); ... strcpy(cp + 4, "baz"); ... printf("FOO: %s\n", getenv("FOO")); You are going to get 'really_long_string' in the printf output, and not 'baz'. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Apr 30 16:56:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4058716A401; Mon, 30 Apr 2007 16:56:19 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 325D213C44C; Mon, 30 Apr 2007 16:56:19 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UGuJXG048149; Mon, 30 Apr 2007 16:56:19 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UGuIqf048148; Mon, 30 Apr 2007 16:56:18 GMT (envelope-from ache) Message-Id: <200704301656.l3UGuIqf048148@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 16:56:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 16:56:19 -0000 ache 2007-04-30 16:56:18 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c Log: Make putenv() fully conforms to Open Group specs Issue 6 (also IEEE Std 1003.1-2001) The specs explicitly says that altering passed string should change the environment, i.e. putenv() directly puts its arg into environment (unlike setenv() which just copies it there). It means that putenv() can't be implemented via setenv() (like we have before) at all. Putenv() value lives (allows modifying) up to the next putenv() or setenv() call. Revision Changes Path 1.23 +13 -6 src/lib/libc/stdlib/getenv.3 1.7 +5 -2 src/lib/libc/stdlib/getenv.c 1.5 +34 -12 src/lib/libc/stdlib/putenv.c 1.13 +6 -6 src/lib/libc/stdlib/setenv.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:05:41 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B2DE816A403; Mon, 30 Apr 2007 17:05:41 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 3259613C448; Mon, 30 Apr 2007 17:05:40 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UH5dum082766; Mon, 30 Apr 2007 21:05:39 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UH5dqx082765; Mon, 30 Apr 2007 21:05:39 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 21:05:38 +0400 From: Andrey Chernov To: John Baldwin Message-ID: <20070430170537.GA82681@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John Baldwin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> <200704301254.45807.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704301254.45807.jhb@freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:05:41 -0000 On Mon, Apr 30, 2007 at 12:54:45PM -0400, John Baldwin wrote: > Hmm, I think I see that this is orthogonal to the setenv(3) fix, but still, if > one does this: > > char *cp = strdup("FOO=bar"); > putenv(cp); > ... > setenv("FOO", "baz"); cp value is undefined right here and can't be safely printed afterwards. Anything can happens at printf including core dump. > ... > setenv("FOO", "really_long_string"); > ... > printf("FOO: %s\n", cp + 4); > > You are going to get 'baz' in the printf output. Or if one does: > > char *cp = strdup("FOO=bar"); > putenv(cp); > ... > setenv("FOO", "really_long_string"); Again, cp value is undefined right here and can't be safely printed afterwards. > ... > strcpy(cp + 4, "baz"); > ... > printf("FOO: %s\n", getenv("FOO")); > > You are going to get 'really_long_string' in the printf output, and not 'baz'. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:37:53 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6400616A402; Mon, 30 Apr 2007 17:37:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 09C0113C457; Mon, 30 Apr 2007 17:37:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3UHbobR015350; Mon, 30 Apr 2007 13:37:50 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrey Chernov Date: Mon, 30 Apr 2007 12:56:14 -0400 User-Agent: KMail/1.9.6 References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> <20070430164031.GA82368@nagual.pp.ru> In-Reply-To: <20070430164031.GA82368@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704301256.15557.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 30 Apr 2007 13:37:50 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3184/Mon Apr 30 09:51:57 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.3 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:37:53 -0000 On Monday 30 April 2007 12:40:31 pm Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 12:29:20PM -0400, John Baldwin wrote: > > Have you coordinated at all with the guy on current@ who has patches to make > > setenv(3) not leak memory as bad? > > No, I don't touch current allocation scheme at all. It isn't my goal. > > > Also, given that we malloc a limited space > > for the string values, I don't see how you can make it so that one can always > > just overwrite the string pointed to by putenv(3)'s return value to change > > the value. If we malloc a buffer for length N and the user wants to set the > > length to M > N, we pretty much have to malloc a new buffer that will end up > > at a different address, so places holding onto the previous value returned > > from putenv(3) will stop seeing updates. > > It isn't the issue. Putenv value supposed to live just up to the next > putenv or setenv call, so setenv can legitimately overwrite it. Ok. FWIW, this seems like a ridiculous and gross hack just to provide a backdoor for updating the environment w/o making a fooenv() function call (either putenv, or setenv). -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:39:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8B91D16A400; Mon, 30 Apr 2007 17:39:30 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 7E47E13C455; Mon, 30 Apr 2007 17:39:30 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UHdU2Z055746; Mon, 30 Apr 2007 17:39:30 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UHdUQW055745; Mon, 30 Apr 2007 17:39:30 GMT (envelope-from maxim) Message-Id: <200704301739.l3UHdUQW055745@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 17:39:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:39:30 -0000 maxim 2007-04-30 17:39:30 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: o Make ipfw(8) show rules with mac/mac-type options correctly. Before: $ ipfw -n add 100 count icmp from any to any mac-type 0x01 00100 count icmp 0x0001 $ ipfw -n add 100 count icmp from any to any mac any any 00100 count icmp MAC any any any After: $ ipfw -n add 100 count icmp from any to any mac-type 0x01 00100 count icmp from any to any mac-type 0x0001 $ ipfw -n add 100 count icmp from any to any mac any any 00100 count icmp from any to any MAC any any PR: bin/112244 Submitted by: Andrey V. Elsukov MFC after: 1 month Revision Changes Path 1.103 +17 -36 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:43:13 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 301D416A406; Mon, 30 Apr 2007 17:43:13 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 9FDB513C4BD; Mon, 30 Apr 2007 17:43:12 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UHhBNU083098; Mon, 30 Apr 2007 21:43:11 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UHhAgJ083097; Mon, 30 Apr 2007 21:43:10 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 21:43:09 +0400 From: Andrey Chernov To: John Baldwin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070430174309.GA82975@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John Baldwin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> <200704301254.45807.jhb@freebsd.org> <20070430170537.GA82681@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430170537.GA82681@nagual.pp.ru> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:43:13 -0000 On Mon, Apr 30, 2007 at 09:05:38PM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 12:54:45PM -0400, John Baldwin wrote: > > Hmm, I think I see that this is orthogonal to the setenv(3) fix, but still, if > > one does this: > > > > char *cp = strdup("FOO=bar"); > > putenv(cp); > > ... > > setenv("FOO", "baz"); > > cp value is undefined right here and can't be safely printed afterwards. > Anything can happens at printf including core dump. To clarify things a bit. Standard says (setenv): "The strings described by envname and envval are copied by this function." Yes, if there is enough room into putenv arg, they are currently copied! But copying is impossible at all, if there is no room left in the putenv arg, so new string should be allocated in any case. Old putenv pointer even can't be realloc'ed because it is not supposed to be malloc'ed at all, it can be static buffer too. All it means that putenv room can become invalid just after first setenv call. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:45:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AABB016A403; Mon, 30 Apr 2007 17:45:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 83FFA13C447; Mon, 30 Apr 2007 17:45:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UHjjrC057195; Mon, 30 Apr 2007 17:45:45 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UHjjVw057194; Mon, 30 Apr 2007 17:45:45 GMT (envelope-from jhb) Message-Id: <200704301745.l3UHjjVw057194@repoman.freebsd.org> From: John Baldwin Date: Mon, 30 Apr 2007 17:45:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 vm_machdep.c src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:45:45 -0000 jhb 2007-04-30 17:45:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 vm_machdep.c sys/i386/i386 vm_machdep.c Log: MFC: Various fixes to cpu_reset_real() - Try to use the reset control register (I/O port 0xcf9) and the fast a20 and init register (I/O port 0x92) if the keyboard reset fails. - Fix the triple fault to actually work when PGE is enabled. Revision Changes Path 1.248.2.2 +38 -4 src/sys/amd64/amd64/vm_machdep.c 1.259.2.6 +40 -6 src/sys/i386/i386/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:47:41 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA81A16A473; Mon, 30 Apr 2007 17:47:41 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 69B1A13C480; Mon, 30 Apr 2007 17:47:41 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UHletq083156; Mon, 30 Apr 2007 21:47:40 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UHleGG083155; Mon, 30 Apr 2007 21:47:40 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 21:47:40 +0400 From: Andrey Chernov To: John Baldwin Message-ID: <20070430174740.GB82975@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John Baldwin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <200704301229.21190.jhb@freebsd.org> <20070430164031.GA82368@nagual.pp.ru> <200704301256.15557.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704301256.15557.jhb@freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:47:42 -0000 On Mon, Apr 30, 2007 at 12:56:14PM -0400, John Baldwin wrote: > Ok. FWIW, this seems like a ridiculous and gross hack just to provide a > backdoor for updating the environment w/o making a fooenv() function call > (either putenv, or setenv). It rather history issue. POSIX just precisely documents how putenv was originaly implemented. BSD implementation via setenv() is later innovation which becomes incompatible with POSIX trend. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 17:58:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D3FFB16A47C; Mon, 30 Apr 2007 17:58:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9F04D13C44B; Mon, 30 Apr 2007 17:58:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UHwNtf059020; Mon, 30 Apr 2007 17:58:23 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UHwNt7059019; Mon, 30 Apr 2007 17:58:23 GMT (envelope-from jhb) Message-Id: <200704301758.l3UHwNt7059019@repoman.freebsd.org> From: John Baldwin Date: Mon, 30 Apr 2007 17:58:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/pci pci.c pcireg.h src/usr.sbin/pciconf cap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 17:58:24 -0000 jhb 2007-04-30 17:58:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci.c pcireg.h usr.sbin/pciconf cap.c Log: MFC: Handle HyperTransport MSI mapping window fixed-window flag. Revision Changes Path 1.292.2.19 +12 -8 src/sys/dev/pci/pci.c 1.45.2.8 +2 -0 src/sys/dev/pci/pcireg.h 1.1.2.2 +12 -7 src/usr.sbin/pciconf/cap.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:00:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5A54416A402; Mon, 30 Apr 2007 18:00:12 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 469C013C487; Mon, 30 Apr 2007 18:00:12 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id A24CC1A4DB7; Mon, 30 Apr 2007 11:00:43 -0700 (PDT) Date: Mon, 30 Apr 2007 11:00:43 -0700 From: Alfred Perlstein To: "Andrey A. Chernov" Message-ID: <20070430180043.GK13868@elvis.mu.org> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704301516.l3UFGJbu019162@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:00:12 -0000 * Andrey A. Chernov [070430 08:17] wrote: > ache 2007-04-30 15:16:19 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/sysinstall main.c > Log: > Preparing for upcoming POSIXed putenv() rewrite: > don't allow const as putenv() arg, dup it > > Revision Changes Path > 1.75 +1 -1 src/usr.sbin/sysinstall/main.c Maybe this was mentioned on the lists, but couldn't there be some kind of define that old code could use like #define BSD_PUTENV? I'm concerned that all these changes could lead to security holes. Maybe I'm just paranoid. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:01:51 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EC7A116A400; Mon, 30 Apr 2007 18:01:51 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C6F7213C459; Mon, 30 Apr 2007 18:01:51 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UI1pA4059786; Mon, 30 Apr 2007 18:01:51 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UI1piM059785; Mon, 30 Apr 2007 18:01:51 GMT (envelope-from ache) Message-Id: <200704301801.l3UI1piM059785@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 18:01:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:01:52 -0000 ache 2007-04-30 18:01:51 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 Log: Add phrase "so altering the argument shall change the environment." into putenv description. Revision Changes Path 1.24 +2 -1 src/lib/libc/stdlib/getenv.3 From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:18:27 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 246A716A403; Mon, 30 Apr 2007 18:18:27 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 8072913C4C5; Mon, 30 Apr 2007 18:18:26 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UIIPOT083519; Mon, 30 Apr 2007 22:18:25 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UIIP5r083518; Mon, 30 Apr 2007 22:18:25 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 22:18:25 +0400 From: Andrey Chernov To: Alfred Perlstein Message-ID: <20070430181824.GA83415@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430180043.GK13868@elvis.mu.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:18:27 -0000 On Mon, Apr 30, 2007 at 11:00:43AM -0700, Alfred Perlstein wrote: > * Andrey A. Chernov [070430 08:17] wrote: > > ache 2007-04-30 15:16:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/sysinstall main.c > > Log: > > Preparing for upcoming POSIXed putenv() rewrite: > > don't allow const as putenv() arg, dup it > > > > Revision Changes Path > > 1.75 +1 -1 src/usr.sbin/sysinstall/main.c > > Maybe this was mentioned on the lists, but couldn't there be some > kind of define that old code could use like #define BSD_PUTENV? Why? We must follow standards to stay in line with possible concurrents, and we already are several years later with that. Even in case some applications will be found incompatible, they forced to follow standards too to continue works in the modern environment. > I'm concerned that all these changes could lead to security > holes. Please be specific. Which changes exactly you means? Changes to applications works with any putenv() kind, they are just portablility fixes, no holes there. Changes to the library aren't under the question too: you can just directly modify **environ variable from your own code bypassing any setenv and putenv - they are just convenient interface. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:29:37 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 630BC16A408; Mon, 30 Apr 2007 18:29:37 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3D48E13C447; Mon, 30 Apr 2007 18:29:37 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UITbxP065041; Mon, 30 Apr 2007 18:29:37 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UITbCd065040; Mon, 30 Apr 2007 18:29:37 GMT (envelope-from maxim) Message-Id: <200704301829.l3UITbCd065040@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 18:29:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:29:37 -0000 maxim 2007-04-30 18:29:36 UTC FreeBSD src repository Modified files: sbin/fdisk fdisk.8 fdisk.c Log: o Add -p flag: print a slice table in fdisk configuration file format. Now it is possible to do something like fdisk -p ad0 | fdisk -f - ad1. PR: bin/110182 Submitted by: Jukka A. Ukkonen MFC after: 1 month Revision Changes Path 1.39 +8 -2 src/sbin/fdisk/fdisk.8 1.83 +28 -2 src/sbin/fdisk/fdisk.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:36:27 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 13A9D16A402; Mon, 30 Apr 2007 18:36:27 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id C826B13C45A; Mon, 30 Apr 2007 18:36:26 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id 79BBC1CC0F4; Mon, 30 Apr 2007 20:36:25 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id E3C86B848; Mon, 30 Apr 2007 20:36:24 +0200 (CEST) Date: Mon, 30 Apr 2007 20:36:24 +0200 From: Henrik Brix Andersen To: "Andrey A. Chernov" Message-ID: <20070430183624.GA73050@tirith.brixandersen.dk> Mail-Followup-To: "Andrey A. Chernov" , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <200704301656.l3UGuIqf048148@repoman.freebsd.org> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:36:27 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Apr 30, 2007 at 04:56:18PM +0000, Andrey A. Chernov wrote: > ache 2007-04-30 16:56:18 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c=20 > Log: > Make putenv() fully conforms to Open Group specs Issue 6 > (also IEEE Std 1003.1-2001) > =20 > The specs explicitly says that altering passed string > should change the environment, i.e. putenv() directly puts its arg > into environment (unlike setenv() which just copies it there). > It means that putenv() can't be implemented via setenv() > (like we have before) at all. Putenv() value lives (allows modifying) > up to the next putenv() or setenv() call. Todays changes to *env() appears to have broken stuff (my -CURRENT box fails to build many ports after these changes, due to missing environment variables in the build environment). Here is a simple test-case: $ env -vi foo=3Dbar env #env clearing environ #env setenv: foo=3Dbar #env executing: env #env arg[0]=3D 'env' Notice that the second instance of env(1) doesn't see the $foo environment variable. This is the output of the same test on my RELENG_6 box: $ env -vi foo=3Dbar env #env clearing environ #env setenv: foo=3Dbar #env executing: env #env arg[0]=3D 'env' foo=3Dbar Regards, Brix --=20 Henrik Brix Andersen --envbJBWh7q8WU6mo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFGNjcov+Q4flTiePgRAvjEAKCmKY0pBDCu0adHHfwVEbDyu/5hSACcCrS2 lK421DHkNGWi2B+G+/kT//I= =NxSs -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:48:57 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0DB0516A404; Mon, 30 Apr 2007 18:48:57 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 8097813C44B; Mon, 30 Apr 2007 18:48:56 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UImthx087155; Mon, 30 Apr 2007 22:48:55 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UIms3K087154; Mon, 30 Apr 2007 22:48:54 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 22:48:54 +0400 From: Andrey Chernov To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430184854.GA87050@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <20070430183624.GA73050@tirith.brixandersen.dk> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:48:57 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 08:36:24PM +0200, Henrik Brix Andersen wrote: > Todays changes to *env() appears to have broken stuff (my -CURRENT box > fails to build many ports after these changes, due to missing > environment variables in the build environment). >=20 > Here is a simple test-case: >=20 > $ env -vi foo=3Dbar env > #env clearing environ > #env setenv: foo=3Dbar > #env executing: env > #env arg[0]=3D 'env' >=20 > Notice that the second instance of env(1) doesn't see the $foo > environment variable. >=20 > This is the output of the same test on my RELENG_6 box: >=20 > $ env -vi foo=3Dbar env > #env clearing environ > #env setenv: foo=3Dbar > #env executing: env > #env arg[0]=3D 'env' > foo=3Dbar Thanx for the report, but please be patient a bit, work in the progress and fix already planned soon. To the matter: env incorrectly calls setenv("name=3D...", ...) which is POSIX violation: "The setenv( ) function shall fail if: [EINVAL] The name argument is a null pointer, points to an empty string,=20 or points to a string containing an '=3D' character." --=20 http://ache.pp.ru/ --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNjoWVg5YK5ZEdN0RAgCgAJ9Ea+GVihetvk9E1AI+2VSoq0IOZgCgs2+W IEcVTmj9KW7Rh4FeUoGtKfI= =NGvN -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 18:58:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3201116A400; Mon, 30 Apr 2007 18:58:46 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id E715413C43E; Mon, 30 Apr 2007 18:58:45 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id 50E5F1CC0CC; Mon, 30 Apr 2007 20:58:45 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id C9453B848; Mon, 30 Apr 2007 20:58:44 +0200 (CEST) Date: Mon, 30 Apr 2007 20:58:44 +0200 From: Henrik Brix Andersen To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430185844.GD73050@tirith.brixandersen.dk> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rqzD5py0kzyFAOWN" Content-Disposition: inline In-Reply-To: <20070430184854.GA87050@nagual.pp.ru> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 18:58:46 -0000 --rqzD5py0kzyFAOWN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 10:48:54PM +0400, Andrey Chernov wrote: > Thanx for the report, but please be patient a bit, work in the progress > and fix already planned soon. I see. > To the matter: env incorrectly calls setenv("name=3D...", ...) which is > POSIX violation: Ok, so we can fix all in-tree occurrences that violate the above, but what about 3rd party software that relies on setenv("name=3D...", ...) working on FreeBSD? Regards, Brix --=20 Henrik Brix Andersen --rqzD5py0kzyFAOWN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFGNjxkv+Q4flTiePgRAkrRAKCYfxKiVxuKlBqIYo8qXVhz6oqPjQCeL6jt W1jwlx3xEs19cCwedyEON/A= =IBvU -----END PGP SIGNATURE----- --rqzD5py0kzyFAOWN-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:02:15 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 27C1616A404 for ; Mon, 30 Apr 2007 19:02:15 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.239]) by mx1.freebsd.org (Postfix) with ESMTP id DB80B13C46E for ; Mon, 30 Apr 2007 19:02:14 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so1555807wra for ; Mon, 30 Apr 2007 12:02:14 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=O2jdRlKKyl4YLFEJWlFtv4WNT3izmt2U+8XUhzmWPUImXUohSaKiCrsITTf+kRgyYXLFu1oA2hSye9trAX6mplFEoVI73RJ8MXsAmIIXUvd0u+m4pXoMAfH/6XMSErzdCHohgcDtxcUEZ4hHBh6rqhVeg08yIYkvf+yMlOldZbU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ieYV+a+darpBEe/BX2SCgr0UHky1eyYVroSjbyganZWJeUEuUU6U+isjovfezbN/wXQytJa5S4pGsT/qSv0jFRoLL49z2lNMupaJn6bOeZWaRGjXPS/RRpd3BrMW78v1JM5A2NNlP0J3WjLaTEObo1txkFB55KuOD2NmjUsICEo= Received: by 10.78.123.4 with SMTP id v4mr2177464huc.1177959733253; Mon, 30 Apr 2007 12:02:13 -0700 (PDT) Received: by 10.78.188.17 with HTTP; Mon, 30 Apr 2007 12:02:13 -0700 (PDT) Message-ID: <70e8236f0704301202s5d327586m981af2a3b6a87ac8@mail.gmail.com> Date: Mon, 30 Apr 2007 20:02:13 +0100 From: "Joao Barros" To: "Maxim Konovalov" In-Reply-To: <200704301829.l3UITbCd065040@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200704301829.l3UITbCd065040@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:02:15 -0000 On 4/30/07, Maxim Konovalov wrote: > maxim 2007-04-30 18:29:36 UTC > > FreeBSD src repository > > Modified files: > sbin/fdisk fdisk.8 fdisk.c > Log: > o Add -p flag: print a slice table in fdisk configuration file format. > Now it is possible to do something like fdisk -p ad0 | fdisk -f - ad1. > > PR: bin/110182 > Submitted by: Jukka A. Ukkonen > MFC after: 1 month > > Revision Changes Path > 1.39 +8 -2 src/sbin/fdisk/fdisk.8 > 1.83 +28 -2 src/sbin/fdisk/fdisk.c This comes very handy when setting up mirrors, thanks! -- Joao Barros From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:08:14 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F23E16A400; Mon, 30 Apr 2007 19:08:14 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1773813C44B; Mon, 30 Apr 2007 19:08:14 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UJ8DkJ072701; Mon, 30 Apr 2007 19:08:13 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UJ8DmI072700; Mon, 30 Apr 2007 19:08:13 GMT (envelope-from maxim) Message-Id: <200704301908.l3UJ8DmI072700@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 19:08:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/traceroute traceroute.c src/usr.sbin/traceroute6 traceroute6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:08:14 -0000 maxim 2007-04-30 19:08:13 UTC FreeBSD src repository Modified files: contrib/traceroute traceroute.c usr.sbin/traceroute6 traceroute6.c Log: o I failed to find a suitable explanation why traceroute(8) and traceroute6(8) force -w flag (wait time) to be > 1 sec. Make it possible to use 1 sec wait time. PR: bin/110933 Submitted by: Dmitry Marakasov Reviewed by: freebsd-net (silence) MFC after: 1 month Revision Changes Path 1.33 +1 -1 src/contrib/traceroute/traceroute.c 1.18 +2 -2 src/usr.sbin/traceroute6/traceroute6.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:11:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 56A9016A402; Mon, 30 Apr 2007 19:11:46 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 45F7313C44C; Mon, 30 Apr 2007 19:11:46 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id AB3871A4D80; Mon, 30 Apr 2007 12:12:17 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 8244251448; Mon, 30 Apr 2007 15:11:45 -0400 (EDT) Date: Mon, 30 Apr 2007 15:11:45 -0400 From: Kris Kennaway To: "Andrey A. Chernov" Message-ID: <20070430191144.GA66695@xor.obsecurity.org> References: <200704301227.l3UCRwao077864@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704301227.l3UCRwao077864@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:11:46 -0000 On Mon, Apr 30, 2007 at 12:27:58PM +0000, Andrey A. Chernov wrote: > ache 2007-04-30 12:27:58 UTC > > FreeBSD src repository > > Modified files: > libexec/pppoed pppoed.c > Log: > Prepare for upcoming POSIXed putenv() rewrite: > don't allow putenv() arg be on the stack, replace putenv() with setenv() What impact is this going to have on ports? Surely there are lots of them that use putenv(). Can I assume you're interested in fixing them? Kris From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:12:55 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39BBA16A401; Mon, 30 Apr 2007 19:12:55 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id AB55E13C44C; Mon, 30 Apr 2007 19:12:54 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UJCrGP087469; Mon, 30 Apr 2007 23:12:53 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UJCrlm087468; Mon, 30 Apr 2007 23:12:53 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 23:12:53 +0400 From: Andrey Chernov To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430191253.GA87375@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> <20070430185844.GD73050@tirith.brixandersen.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <20070430185844.GD73050@tirith.brixandersen.dk> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:12:55 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 08:58:44PM +0200, Henrik Brix Andersen wrote: > > To the matter: env incorrectly calls setenv("name=3D...", ...) which is > > POSIX violation: >=20 > Ok, so we can fix all in-tree occurrences that violate the above, but > what about 3rd party software that relies on setenv("name=3D...", ...) > working on FreeBSD? In case you mean some ports, they should be fixed, and I'll help. Such=20 fixes are backward compatible, so will works for older FreeBSD versions=20 too. We can't stay in the local BSD ghetto forever, we already later for=20 several years with the changes in question. Ether we implement standards=20 like others already do or we doomed to live with old rotten software=20 only forever. --=20 http://ache.pp.ru/ --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNj+1Vg5YK5ZEdN0RAkghAKCkqQZsxY4dC3CH7B92ApX/lNDDoACeM9nY uj0q4ixKuyCFan0LPpk0wPw= =e7S5 -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:15:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D893416A401; Mon, 30 Apr 2007 19:15:56 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 59BDE13C44B; Mon, 30 Apr 2007 19:15:56 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UJFtHQ087535; Mon, 30 Apr 2007 23:15:55 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UJFta1087534; Mon, 30 Apr 2007 23:15:55 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 23:15:55 +0400 From: Andrey Chernov To: Kris Kennaway Message-ID: <20070430191555.GB87375@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430191144.GA66695@xor.obsecurity.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:15:56 -0000 On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > What impact is this going to have on ports? Surely there are lots of > them that use putenv(). If they work under Linux, they already forced to do the right thing. Only those which are BSD-only may fail. > Can I assume you're interested in fixing them? Yes. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:21:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 53A9616A402; Mon, 30 Apr 2007 19:21:11 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id D28FC13C459; Mon, 30 Apr 2007 19:21:10 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 39C7345CD9; Mon, 30 Apr 2007 21:21:09 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 73B1645696; Mon, 30 Apr 2007 21:21:04 +0200 (CEST) Date: Mon, 30 Apr 2007 21:20:38 +0200 From: Pawel Jakub Dawidek To: Maxim Konovalov Message-ID: <20070430192038.GB67738@garage.freebsd.pl> References: <200704301829.l3UITbCd065040@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="St7VIuEGZ6dlpu13" Content-Disposition: inline In-Reply-To: <200704301829.l3UITbCd065040@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:21:11 -0000 --St7VIuEGZ6dlpu13 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 06:29:36PM +0000, Maxim Konovalov wrote: > maxim 2007-04-30 18:29:36 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sbin/fdisk fdisk.8 fdisk.c=20 > Log: > o Add -p flag: print a slice table in fdisk configuration file format. > Now it is possible to do something like fdisk -p ad0 | fdisk -f - ad1. As from what I heard, fdisk(8) is not user-friendly. While you are there maybe you could create EXAMPLES section and add this example there as well? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --St7VIuEGZ6dlpu13 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGNkGGForvXbEpPzQRAo8JAJkBNkoUz/vqPCYCEzYwWFRLlJy1DACgh873 zouGtMNhsx5COamJBPi/1OA= =MGaS -----END PGP SIGNATURE----- --St7VIuEGZ6dlpu13-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:22:47 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 653E616A401; Mon, 30 Apr 2007 19:22:47 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 2279913C468; Mon, 30 Apr 2007 19:22:47 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id 752EA1CC0FB; Mon, 30 Apr 2007 21:22:46 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id D56ADB848; Mon, 30 Apr 2007 21:22:45 +0200 (CEST) Date: Mon, 30 Apr 2007 21:22:45 +0200 From: Henrik Brix Andersen To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430192245.GE73050@tirith.brixandersen.dk> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> <20070430185844.GD73050@tirith.brixandersen.dk> <20070430191253.GA87375@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6Vw0j8UKbyX0bfpA" Content-Disposition: inline In-Reply-To: <20070430191253.GA87375@nagual.pp.ru> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:22:47 -0000 --6Vw0j8UKbyX0bfpA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 11:12:53PM +0400, Andrey Chernov wrote: > In case you mean some ports, they should be fixed, and I'll help. Such=20 > fixes are backward compatible, so will works for older FreeBSD versions= =20 > too. If the changes needed are backwards compatible wouldn't it have been better to at least fix all occurrences in our own src tree before breaking the API? :) Regards, Brix --=20 Henrik Brix Andersen --6Vw0j8UKbyX0bfpA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFGNkIFv+Q4flTiePgRAj63AJwK4cq+spbmEE/oLz7Mm4MgzsXBrgCgqWfJ 10OOgiWzNGJC7S3pHcYzY+w= =NTnW -----END PGP SIGNATURE----- --6Vw0j8UKbyX0bfpA-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:25:01 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7790B16A404; Mon, 30 Apr 2007 19:25:01 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 502CB13C4BA; Mon, 30 Apr 2007 19:25:01 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UJP1JZ075468; Mon, 30 Apr 2007 19:25:01 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UJP1H0075466; Mon, 30 Apr 2007 19:25:01 GMT (envelope-from ache) Message-Id: <200704301925.l3UJP1H0075466@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 19:25:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/env env.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:25:01 -0000 ache 2007-04-30 19:25:00 UTC FreeBSD src repository Modified files: usr.bin/env env.c Log: env calls setenv("name=value", "value", 1); which violates POSIX: "The setenv( ) function shall fail if: [EINVAL] The name argument is a null pointer, points to an empty string, or points to a string containing an '=' character." The fix (like all others in this subject) is backward-compatible. Revision Changes Path 1.17 +3 -3 src/usr.bin/env/env.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:32:35 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EF6F116A402; Mon, 30 Apr 2007 19:32:35 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 6AE9613C465; Mon, 30 Apr 2007 19:32:35 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UJWY9h087699; Mon, 30 Apr 2007 23:32:34 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UJWYvX087698; Mon, 30 Apr 2007 23:32:34 +0400 (MSD) (envelope-from ache) Date: Mon, 30 Apr 2007 23:32:33 +0400 From: Andrey Chernov To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430193233.GA87570@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> <20070430185844.GD73050@tirith.brixandersen.dk> <20070430191253.GA87375@nagual.pp.ru> <20070430192245.GE73050@tirith.brixandersen.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <20070430192245.GE73050@tirith.brixandersen.dk> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:32:36 -0000 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 09:22:45PM +0200, Henrik Brix Andersen wrote: > On Mon, Apr 30, 2007 at 11:12:53PM +0400, Andrey Chernov wrote: > > In case you mean some ports, they should be fixed, and I'll help. Such= =20 > > fixes are backward compatible, so will works for older FreeBSD versions= =20 > > too. >=20 > If the changes needed are backwards compatible wouldn't it have been > better to at least fix all occurrences in our own src tree before > breaking the API? :) You are right. I try to do this with putenv(), but remember about my tree= =20 branch with setenv() only afterwards due to small amount of fixes there,=20 so they crossed a bit. --=20 http://ache.pp.ru/ --jRHKVT23PllUwdXP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNkRRVg5YK5ZEdN0RAqiXAKCEAl+LbaT6uueJuynY0T/YiqzJ2wCgrpQC RrimPFwICuNN+0hqm4VJ6II= =/o46 -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP-- From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:37:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 31D6D16A407; Mon, 30 Apr 2007 19:37:11 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0BE1113C4AE; Mon, 30 Apr 2007 19:37:11 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UJbABN077560; Mon, 30 Apr 2007 19:37:10 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UJbAuO077559; Mon, 30 Apr 2007 19:37:10 GMT (envelope-from ache) Message-Id: <200704301937.l3UJbAuO077559@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 19:37:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:37:11 -0000 ache 2007-04-30 19:37:10 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 Log: Bump .Dd Suggested by: Henrik Brix Andersen Revision Changes Path 1.25 +1 -1 src/lib/libc/stdlib/getenv.3 From owner-cvs-src@FreeBSD.ORG Mon Apr 30 19:52:38 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 63B4B16A400; Mon, 30 Apr 2007 19:52:38 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 5218313C44B; Mon, 30 Apr 2007 19:52:38 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id BE3281A4D80; Mon, 30 Apr 2007 12:53:09 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 93209513C5; Mon, 30 Apr 2007 15:52:37 -0400 (EDT) Date: Mon, 30 Apr 2007 15:52:37 -0400 From: Kris Kennaway To: Andrey Chernov , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070430195237.GA67426@xor.obsecurity.org> References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430191555.GB87375@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 19:52:38 -0000 On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > What impact is this going to have on ports? Surely there are lots of > > them that use putenv(). > > If they work under Linux, they already forced to do the right thing. Only > those which are BSD-only may fail. > > > Can I assume you're interested in fixing them? > > Yes. Great, thanks! Kris From owner-cvs-src@FreeBSD.ORG Mon Apr 30 20:10:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82CD416A409; Mon, 30 Apr 2007 20:10:11 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 5CA8313C457; Mon, 30 Apr 2007 20:10:11 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UKAB3R084161; Mon, 30 Apr 2007 20:10:11 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UKABCI084160; Mon, 30 Apr 2007 20:10:11 GMT (envelope-from ache) Message-Id: <200704302010.l3UKABCI084160@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 20:10:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/limits limits.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 20:10:11 -0000 ache 2007-04-30 20:10:11 UTC FreeBSD src repository Modified files: usr.bin/limits limits.c Log: limits calls setenv("name=value", "value", 1); which violates POSIX: "The setenv( ) function shall fail if: [EINVAL] The name argument is a null pointer, points to an empty string, or points to a string containing an '=' character." The fix (like all others in this subject) is backward-compatible. Revision Changes Path 1.15 +2 -2 src/usr.bin/limits/limits.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 20:22:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E812016A403; Mon, 30 Apr 2007 20:22:11 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C1D2513C458; Mon, 30 Apr 2007 20:22:11 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UKMBgg091799; Mon, 30 Apr 2007 20:22:11 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UKMBGJ091798; Mon, 30 Apr 2007 20:22:11 GMT (envelope-from maxim) Message-Id: <200704302022.l3UKMBGJ091798@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 20:22:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet/libalias alias_proxy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 20:22:12 -0000 maxim 2007-04-30 20:22:11 UTC FreeBSD src repository Modified files: sys/netinet/libalias alias_proxy.c Log: o Fix strtoul() error conditions check. PR: kern/108211 Submitted by: Yong Tang MFC after: 2 weeks Revision Changes Path 1.30 +1 -1 src/sys/netinet/libalias/alias_proxy.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 20:26:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D464E16A400; Mon, 30 Apr 2007 20:26:12 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AE38D13C458; Mon, 30 Apr 2007 20:26:12 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UKQCmK092561; Mon, 30 Apr 2007 20:26:12 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UKQCVW092560; Mon, 30 Apr 2007 20:26:12 GMT (envelope-from maxim) Message-Id: <200704302026.l3UKQCVW092560@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 30 Apr 2007 20:26:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet/libalias alias_proxy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 20:26:12 -0000 maxim 2007-04-30 20:26:12 UTC FreeBSD src repository Modified files: sys/netinet/libalias alias_proxy.c Log: o Kill EOLWS while I'm here. Revision Changes Path 1.31 +2 -2 src/sys/netinet/libalias/alias_proxy.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 20:59:57 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9343116A403; Mon, 30 Apr 2007 20:59:57 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6D33213C447; Mon, 30 Apr 2007 20:59:57 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UKxvqr006557; Mon, 30 Apr 2007 20:59:57 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UKxvGY006556; Mon, 30 Apr 2007 20:59:57 GMT (envelope-from marius) Message-Id: <200704302059.l3UKxvGY006556@repoman.freebsd.org> From: Marius Strobl Date: Mon, 30 Apr 2007 20:59:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/mii brgphy.c miidevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 20:59:57 -0000 marius 2007-04-30 20:59:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mii brgphy.c miidevs Log: MFC: brgphy.c 1.67; miidevs 1.42 Let brgphy(4) attach for the Broadcom BCM5755 ASIC based chipsets as well. Obtained from: OpenBSD Revision Changes Path 1.34.2.14 +1 -0 src/sys/dev/mii/brgphy.c 1.30.2.9 +1 -0 src/sys/dev/mii/miidevs From owner-cvs-src@FreeBSD.ORG Mon Apr 30 21:14:54 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 417B116A400; Mon, 30 Apr 2007 21:14:54 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1B74C13C448; Mon, 30 Apr 2007 21:14:54 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3ULEraH011249; Mon, 30 Apr 2007 21:14:53 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3ULErKF011248; Mon, 30 Apr 2007 21:14:53 GMT (envelope-from ache) Message-Id: <200704302114.l3ULErKF011248@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 30 Apr 2007 21:14:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 21:14:54 -0000 ache 2007-04-30 21:14:53 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version after making setenv(), putenv(), getenv() and unsetenv() POSIXed Revision Changes Path 1.292 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 21:55:28 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5052F16A400; Mon, 30 Apr 2007 21:55:28 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 40C6A13C44B; Mon, 30 Apr 2007 21:55:28 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3ULtSH4019330; Mon, 30 Apr 2007 21:55:28 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3ULtRHI019329; Mon, 30 Apr 2007 21:55:27 GMT (envelope-from marius) Message-Id: <200704302155.l3ULtRHI019329@repoman.freebsd.org> From: Marius Strobl Date: Mon, 30 Apr 2007 21:55:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 21:55:28 -0000 marius 2007-04-30 21:55:27 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: - Add support/quirks for the on-board BGEs found in Sun Blade 1500 Blade 2500, Fire V210 and probably some other sparc64 machines. These chips are typically not fitted with an EEPROM which means that we have to obtain the MAC address via OFW and that some chip tests will just always fail. These changes are based on the respective code found in OpenBSD with some additional info obtained from OpenSolaris and some style suggestions by jkim@. They also have the desired side-effect of respecting the 'local-mac-address?' system configuration variable for the affected BGEs. - In bge_attach() factor out calling bge_release_resources() before going to the fail label into the fail label as well as replace a magic 6 with ETHER_ADDR_LEN. Reviewed by: yongari (before style changes), jkim Revision Changes Path 1.188 +92 -34 src/sys/dev/bge/if_bge.c 1.72 +6 -0 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Mon Apr 30 22:35:35 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1830C16A401; Mon, 30 Apr 2007 22:35:35 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0A58D13C459; Mon, 30 Apr 2007 22:35:35 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UMZYsO028387; Mon, 30 Apr 2007 22:35:34 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UMZYUD028386; Mon, 30 Apr 2007 22:35:34 GMT (envelope-from marius) Message-Id: <200704302235.l3UMZYUD028386@repoman.freebsd.org> From: Marius Strobl Date: Mon, 30 Apr 2007 22:35:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mii brgphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 22:35:35 -0000 marius 2007-04-30 22:35:33 UTC FreeBSD src repository Modified files: sys/dev/mii brgphy.c Log: - Take advantage of mii_phy_add_media() for adding media and setting sc->mii_anegticks according to whether the respective BGE chip supports Fast Ethernet only or also Gigabit Ethernet. - At least the BGE chips I've tested with wedge when isolating them so document this as the reason for setting MIIF_NOISOLATE and remove the unused (and partially even #ifdef'ed out) isolation related code. Add code that panics if we encounter a non-zero MII instance as generally there's no way a PHY requiring MIIF_NOISOLATE can be handled gracefully in a multi-PHY configuration (it's ok for the internal PHY of single-PHY-only-NIC to not support isolation though). - Additionally set MIIF_NOLOOP as loopback doesn't seem to work either and remove the #ifdef'ed out code for adding respective media. The MIIF_NOLOOP flag currently triggers nothing but hopefully will be respected by mii_phy_setmedia() later on. Reviewed by: jkim, yongari MFC after: 1 month Revision Changes Path 1.68 +13 -65 src/sys/dev/mii/brgphy.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 23:12:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C715516A400; Mon, 30 Apr 2007 23:12:05 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B74A613C469; Mon, 30 Apr 2007 23:12:05 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UNC5he035253; Mon, 30 Apr 2007 23:12:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UNC5Hq035252; Mon, 30 Apr 2007 23:12:05 GMT (envelope-from rwatson) Message-Id: <200704302312.l3UNC5Hq035252@repoman.freebsd.org> From: Robert Watson Date: Mon, 30 Apr 2007 23:12:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_subr.c udp_usrreq.c src/sys/netinet6 in6_pcb.c in6_src.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 23:12:05 -0000 rwatson 2007-04-30 23:12:05 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_subr.c udp_usrreq.c sys/netinet6 in6_pcb.c in6_src.c Log: Rename some fields of struct inpcbinfo to have the ipi_ prefix, consistent with the naming of other structure field members, and reducing improper grep matches. Clean up and comment structure fields in structure definition. Revision Changes Path 1.189 +20 -19 src/sys/netinet/in_pcb.c 1.96 +61 -31 src/sys/netinet/in_pcb.h 1.124 +5 -4 src/sys/netinet/ip_divert.c 1.171 +5 -4 src/sys/netinet/raw_ip.c 1.276 +8 -7 src/sys/netinet/tcp_subr.c 1.204 +6 -5 src/sys/netinet/udp_usrreq.c 1.76 +11 -11 src/sys/netinet6/in6_pcb.c 1.43 +3 -3 src/sys/netinet6/in6_src.c From owner-cvs-src@FreeBSD.ORG Mon Apr 30 23:18:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1EF0516A400; Mon, 30 Apr 2007 23:18:49 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.freebsd.org (Postfix) with ESMTP id D4E6413C44B; Mon, 30 Apr 2007 23:18:48 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.8/8.13.1) with ESMTP id l3UMvHrv007033; Mon, 30 Apr 2007 18:57:17 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.8/8.13.1/Submit) id l3UMvHrk007032; Mon, 30 Apr 2007 18:57:17 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Mon, 30 Apr 2007 18:57:17 -0400 From: David Schultz To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20070430225717.GA7008@VARK.MIT.EDU> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430181824.GA83415@nagual.pp.ru> Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 23:18:49 -0000 On Mon, Apr 30, 2007, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 11:00:43AM -0700, Alfred Perlstein wrote: > > * Andrey A. Chernov [070430 08:17] wrote: > > > ache 2007-04-30 15:16:19 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > usr.sbin/sysinstall main.c > > > Log: > > > Preparing for upcoming POSIXed putenv() rewrite: > > > don't allow const as putenv() arg, dup it > > > > > > Revision Changes Path > > > 1.75 +1 -1 src/usr.sbin/sysinstall/main.c > > > > Maybe this was mentioned on the lists, but couldn't there be some > > kind of define that old code could use like #define BSD_PUTENV? > > Why? We must follow standards to stay in line with possible concurrents, > and we already are several years later with that. Even in case some > applications will be found incompatible, they forced to follow standards > too to continue works in the modern environment. > > > I'm concerned that all these changes could lead to security > > holes. > > Please be specific. Which changes exactly you means? Changes to > applications works with any putenv() kind, they are just portablility > fixes, no holes there. Changes to the library aren't under the question > too: you can just directly modify **environ variable from your own code > bypassing any setenv and putenv - they are just convenient interface. I think Alfred is absolutely right, and this is a pretty major POLA violation. As a result of these changes, I've got two ports (so far) and some model checking software that won't build/run anymore. If we've been doing something right for years, changing it around in order to inherit SVR4 bugs seems like a bad plan. Holding up your POSIX banner doesn't really make things okay; POSIX wasn't written by God, and we choose to ignore various parts of it. And considering the way various setuid programs attempt to sanitize their environment before doing a fork/exec, the change may very well have security implications. That said, I have important deadlines and no time to deal with this now, so I'm just reverting to yesterday's sources until I do. From owner-cvs-src@FreeBSD.ORG Tue May 1 00:07:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B177616A404; Tue, 1 May 2007 00:07:25 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id B24F213C43E; Tue, 1 May 2007 00:02:44 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l4102hTg020401; Tue, 1 May 2007 04:02:43 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l4102g4s020400; Tue, 1 May 2007 04:02:42 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 04:02:42 +0400 From: Andrey Chernov To: Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070501000242.GA19510@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430225717.GA7008@VARK.MIT.EDU> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 00:07:25 -0000 On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: > I think Alfred is absolutely right, and this is a pretty major > POLA violation. That's -current for. Do you suggest to wait yet more N years to commit exact that stuff? > As a result of these changes, I've got two ports > (so far) and some model checking software that won't build/run > anymore. Please be specific, which ports exactly? Otherwise there is no useful information in your statement. > If we've been doing something right for years, changing > it around in order to inherit SVR4 bugs seems like a bad > plan. Holding up your POSIX banner doesn't really make things > okay; POSIX wasn't written by God, and we choose to ignore various > parts of it. There is no SVR4 bugs in this commit. Just more strict args checking (which really helps to catch poorly written things and have nothing common with SVR4) and clarifying that portable putenv() does not save arg. Please send all your possible complains to the Open Group, perhaps they change standard. Until that we (and software developers which try to make things portable) have no other alternative. Currrently we ignore just very minor things and don't need to increase that number without urgent needs. Other things are simple not implemented not ignored. > And considering the way various setuid programs > attempt to sanitize their environment before doing a fork/exec, > the change may very well have security implications. Sanitizing environment is completely unrelated to all of that. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 00:16:29 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 970AF16A406; Tue, 1 May 2007 00:16:29 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 161E713C448; Tue, 1 May 2007 00:16:28 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l410GRSp000862; Tue, 1 May 2007 04:16:27 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l410GRYt000861; Tue, 1 May 2007 04:16:27 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 04:16:27 +0400 From: Andrey Chernov To: Kris Kennaway Message-ID: <20070501001627.GA804@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Kris Kennaway , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> <20070430195237.GA67426@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430195237.GA67426@xor.obsecurity.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 00:16:29 -0000 On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote: > On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > > What impact is this going to have on ports? Surely there are lots of > > > them that use putenv(). > > > > If they work under Linux, they already forced to do the right thing. Only > > those which are BSD-only may fail. > > > > > Can I assume you're interested in fixing them? > > > > Yes. > > Great, thanks! Kris, could you please run test build for ports with all changes up to sys/param.h in? I want to see how many ports will failed if any. Personally me run lots of ports of my machine and didn't notice any bad side effect yet. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 00:28:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 47FBA16A400; Tue, 1 May 2007 00:28:20 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id B65A113C483; Tue, 1 May 2007 00:28:19 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l410SI4l000980; Tue, 1 May 2007 04:28:18 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l410SIWE000979; Tue, 1 May 2007 04:28:18 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 04:28:17 +0400 From: Andrey Chernov To: Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070501002817.GA887@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501000242.GA19510@nagual.pp.ru> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 00:28:20 -0000 On Tue, May 01, 2007 at 04:02:42AM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: > > I think Alfred is absolutely right, and this is a pretty major > > POLA violation. > > That's -current for. Do you suggest to wait yet more N years to commit > exact that stuff? Speaking about POLA, POLA says that valid call to setenv f.e. is in form setenv("name", "value", 1); it does not says that hacks like setenv("name=value", "value", 1); should be allowed and works. Moreover, putenv() isn't BSD own function, and was incorrectly implemented initially in BSD. BSD implementation just violates original POLA for putenv() all other use. Insisting to keep bug-to-bug compatibility forever leads to nowhere. And increase porting efforts greately. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 00:50:08 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F74716A400; Tue, 1 May 2007 00:50:08 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0A6D813C465; Tue, 1 May 2007 00:50:08 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id BA0AA1A4DBA; Mon, 30 Apr 2007 17:50:39 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 444E3513AD; Mon, 30 Apr 2007 20:50:07 -0400 (EDT) Date: Mon, 30 Apr 2007 20:50:07 -0400 From: Kris Kennaway To: Andrey Chernov , Kris Kennaway , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501005007.GA70549@xor.obsecurity.org> References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> <20070430195237.GA67426@xor.obsecurity.org> <20070501001627.GA804@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501001627.GA804@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 00:50:08 -0000 On Tue, May 01, 2007 at 04:16:27AM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote: > > On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > > > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > > > What impact is this going to have on ports? Surely there are lots of > > > > them that use putenv(). > > > > > > If they work under Linux, they already forced to do the right thing. Only > > > those which are BSD-only may fail. > > > > > > > Can I assume you're interested in fixing them? > > > > > > Yes. > > > > Great, thanks! > > Kris, could you please run test build for ports with all changes up to > sys/param.h in? I want to see how many ports will failed if any. > Personally me run lots of ports of my machine and didn't notice any bad > side effect yet. Will do. Kris From owner-cvs-src@FreeBSD.ORG Tue May 1 00:52:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7323A16A409; Tue, 1 May 2007 00:52:49 +0000 (UTC) (envelope-from rik@inse.ru) Received: from mail.inse.ru (inse.ru [144.206.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id 28F6013C45D; Tue, 1 May 2007 00:52:49 +0000 (UTC) (envelope-from rik@inse.ru) Received: from [127.0.0.1] (www.inse.ru [144.206.128.1]) by mail.inse.ru (Postfix) with ESMTP id 35A3933C4C; Tue, 1 May 2007 04:52:47 +0400 (MSD) Message-ID: <463690FE.9000209@inse.ru> Date: Tue, 01 May 2007 04:59:42 +0400 From: Roman Kurakin User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> In-Reply-To: <20070501002817.GA887@nagual.pp.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 00:52:49 -0000 Hi, Since there is some noise around this, could we just scream for a while that code should be fixed but allow it to still work? After some time than the majority of the buggy code will be fixed we will stick to the std behavior? IMHO this will be less painful. rik Andrey Chernov wrote: > On Tue, May 01, 2007 at 04:02:42AM +0400, Andrey Chernov wrote: > >> On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: >> >>> I think Alfred is absolutely right, and this is a pretty major >>> POLA violation. >>> >> That's -current for. Do you suggest to wait yet more N years to commit >> exact that stuff? >> > > Speaking about POLA, POLA says that valid call to setenv f.e. is in form > setenv("name", "value", 1); > it does not says that hacks like > setenv("name=value", "value", 1); > should be allowed and works. > > Moreover, putenv() isn't BSD own function, and was incorrectly implemented > initially in BSD. BSD implementation just violates original POLA for > putenv() all other use. > > Insisting to keep bug-to-bug compatibility forever leads to nowhere. > And increase porting efforts greately. > > From owner-cvs-src@FreeBSD.ORG Tue May 1 01:07:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 93FCF16A400; Tue, 1 May 2007 01:07:12 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 0228D13C447; Tue, 1 May 2007 01:07:11 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l4117AIY001410; Tue, 1 May 2007 05:07:10 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l4117AKC001409; Tue, 1 May 2007 05:07:10 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 05:07:09 +0400 From: Andrey Chernov To: Roman Kurakin Message-ID: <20070501010709.GA1304@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Roman Kurakin , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463690FE.9000209@inse.ru> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 01:07:12 -0000 On Tue, May 01, 2007 at 04:59:42AM +0400, Roman Kurakin wrote: > Hi, > > Since there is some noise around this, could we just scream for a while > that code should be fixed but allow it to still work? After some time than > the majority of the buggy code will be fixed we will stick to the std > behavior? IMHO this will be less painful. Nice idea, but depends of amount of problem reports I'll got. If the number will be small, there is no pain to be std. After my last commit I not get any report yet (excepting unclear "some two ports", without names). BTW, screaming can be only for args checking. For putenv() right or wrong usage can't be detected inside lib. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 01:39:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E7E8F16A400; Tue, 1 May 2007 01:39:25 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CFC1613C448; Tue, 1 May 2007 01:39:25 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 9C1C41A4DB3; Mon, 30 Apr 2007 18:39:57 -0700 (PDT) Date: Mon, 30 Apr 2007 18:39:57 -0700 From: Alfred Perlstein To: Andrey Chernov , Roman Kurakin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070501013957.GX13868@elvis.mu.org> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501010709.GA1304@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 01:39:26 -0000 Using the strategy "commit to -current then suffer the fallout" is pretty bogus. I don't understand why some form of compatibility or #define wasn't thought out before hand. This stands out like "fixing select" to record time elapsed into the timevals, POSIX'ly correct, but incorrect for FreeBSD, without more thought. * Andrey Chernov [070430 18:07] wrote: > On Tue, May 01, 2007 at 04:59:42AM +0400, Roman Kurakin wrote: > > Hi, > > > > Since there is some noise around this, could we just scream for a while > > that code should be fixed but allow it to still work? After some time than > > the majority of the buggy code will be fixed we will stick to the std > > behavior? IMHO this will be less painful. > > Nice idea, but depends of amount of problem reports I'll got. If the > number will be small, there is no pain to be std. After my last commit I > not get any report yet (excepting unclear "some two ports", without > names). > > BTW, screaming can be only for args checking. For putenv() right or > wrong usage can't be detected inside lib. > > -- > http://ache.pp.ru/ -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Tue May 1 03:01:17 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9060516A404; Tue, 1 May 2007 03:01:17 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6518F13C46A; Tue, 1 May 2007 03:01:17 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4131Hdv029507; Tue, 1 May 2007 03:01:17 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4131Hq1029498; Tue, 1 May 2007 03:01:17 GMT (envelope-from simokawa) Message-Id: <200705010301.l4131Hq1029498@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Tue, 1 May 2007 03:01:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/geom/uzip g_uzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 03:01:17 -0000 simokawa 2007-05-01 03:01:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/geom/uzip g_uzip.c Log: MFC: rev 1.12 If compressed length is zero, return a zero-filled block. Revision Changes Path 1.4.2.5 +7 -0 src/sys/geom/uzip/g_uzip.c From owner-cvs-src@FreeBSD.ORG Tue May 1 03:09:58 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6826D16A400; Tue, 1 May 2007 03:09:58 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3EB4513C44C; Tue, 1 May 2007 03:09:58 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4139w3A031734; Tue, 1 May 2007 03:09:58 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4139wch031733; Tue, 1 May 2007 03:09:58 GMT (envelope-from alc) Message-Id: <200705010309.l4139wch031733@repoman.freebsd.org> From: Alan Cox Date: Tue, 1 May 2007 03:09:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 03:09:58 -0000 alc 2007-05-01 03:09:57 UTC FreeBSD src repository Modified files: sys/compat/linprocfs linprocfs.c Log: Synchronize vm map and object accesses. Approved by: des@ Revision Changes Path 1.112 +26 -8 src/sys/compat/linprocfs/linprocfs.c From owner-cvs-src@FreeBSD.ORG Tue May 1 03:15:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1D54316A403; Tue, 1 May 2007 03:15:06 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E794B13C489; Tue, 1 May 2007 03:15:05 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l413F5Mv032855; Tue, 1 May 2007 03:15:05 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l413F5ci032854; Tue, 1 May 2007 03:15:05 GMT (envelope-from yongari) Message-Id: <200705010315.l413F5ci032854@repoman.freebsd.org> From: Pyun YongHyeon Date: Tue, 1 May 2007 03:15:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/stge if_stge.c if_stgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 03:15:06 -0000 yongari 2007-05-01 03:15:05 UTC FreeBSD src repository Modified files: sys/dev/stge if_stge.c if_stgereg.h Log: Use our own timer for watchdog instead of if_watchdog/if_timer interface. Revision Changes Path 1.7 +16 -11 src/sys/dev/stge/if_stge.c 1.2 +1 -0 src/sys/dev/stge/if_stgereg.h From owner-cvs-src@FreeBSD.ORG Tue May 1 03:35:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9FACD16A402; Tue, 1 May 2007 03:35:49 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 7536C13C457; Tue, 1 May 2007 03:35:49 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l413ZncY036381; Tue, 1 May 2007 03:35:49 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l413ZnW7036380; Tue, 1 May 2007 03:35:49 GMT (envelope-from yongari) Message-Id: <200705010335.l413ZnW7036380@repoman.freebsd.org> From: Pyun YongHyeon Date: Tue, 1 May 2007 03:35:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/stge if_stge.c if_stgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 03:35:49 -0000 yongari 2007-05-01 03:35:49 UTC FreeBSD src repository Modified files: sys/dev/stge if_stge.c if_stgereg.h Log: Honor link up/down state in stge_start(). While I'm here move MAC control settings to stge_link_task, a task queue which handles link state and duplex/flow controls. Revision Changes Path 1.8 +19 -24 src/sys/dev/stge/if_stge.c 1.3 +1 -0 src/sys/dev/stge/if_stgereg.h From owner-cvs-src@FreeBSD.ORG Tue May 1 03:40:57 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D528216A402; Tue, 1 May 2007 03:40:57 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AAD7B13C459; Tue, 1 May 2007 03:40:57 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l413evR6036679; Tue, 1 May 2007 03:40:57 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l413evh2036677; Tue, 1 May 2007 03:40:57 GMT (envelope-from yongari) Message-Id: <200705010340.l413evh2036677@repoman.freebsd.org> From: Pyun YongHyeon Date: Tue, 1 May 2007 03:40:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/stge if_stge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 03:40:57 -0000 yongari 2007-05-01 03:40:57 UTC FreeBSD src repository Modified files: sys/dev/stge if_stge.c Log: If we've got watchdog timeouts try to get more packets going after resetting the hardware. Revision Changes Path 1.9 +2 -0 src/sys/dev/stge/if_stge.c From owner-cvs-src@FreeBSD.ORG Tue May 1 04:14:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BD94616A400; Tue, 1 May 2007 04:14:06 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp6.server.rpi.edu (smtp6.server.rpi.edu [128.113.2.226]) by mx1.freebsd.org (Postfix) with ESMTP id 6239913C44C; Tue, 1 May 2007 04:14:06 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp6.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l4136e5U032706; Mon, 30 Apr 2007 23:06:42 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <20070430184854.GA87050@nagual.pp.ru> References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> Date: Mon, 30 Apr 2007 23:06:39 -0400 To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-RPI-SA-Score: undef - spam scanning disabled X-CanItPRO-Stream: default X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.226 Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 04:14:06 -0000 At 10:48 PM +0400 4/30/07, Andrey Chernov wrote: >On Mon, Apr 30, 2007 at 08:36:24PM +0200, Henrik Brix Andersen wrote: > > >> This is the output of the same test on my RELENG_6 box: >> >> $ env -vi foo=bar env >> #env clearing environ >> #env setenv: foo=bar >> #env executing: env >> #env arg[0]= 'env' >> foo=bar > >Thanx for the report, but please be patient a bit, work in the progress >and fix already planned soon. >To the matter: env incorrectly calls setenv("name=...", ...) which is >POSIX violation: > >"The setenv( ) function shall fail if: >[EINVAL] The name argument is a null pointer, points to an empty >string, or points to a string containing an '=' character." I can fix the 'env' command, if you want... (not sure I can get to it tonight, but I'll see) -- Garance Alistair Drosehn = drosehn@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Tue May 1 04:22:27 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E8E8916A400; Tue, 1 May 2007 04:22:27 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp8.server.rpi.edu (smtp8.server.rpi.edu [128.113.2.228]) by mx1.freebsd.org (Postfix) with ESMTP id 8DAF313C459; Tue, 1 May 2007 04:22:27 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp8.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l414MPPT021320; Tue, 1 May 2007 00:22:26 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <20070430184854.GA87050@nagual.pp.ru> References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk> <20070430184854.GA87050@nagual.pp.ru> Date: Tue, 1 May 2007 00:22:24 -0400 To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-RPI-SA-Score: undef - spam scanning disabled X-CanItPRO-Stream: default X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.228 Cc: Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 04:22:28 -0000 >At 10:48 PM +0400 4/30/07, Andrey Chernov wrote: >>To the matter: env incorrectly calls setenv("name=...", ...) >>which is POSIX violation: > >I can fix the 'env' command, if you want... >(not sure I can get to it tonight, but I'll see) Ah. I see you've already fixed it... -- Garance Alistair Drosehn = drosehn@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Tue May 1 04:33:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 680) id 20B3E16A403; Tue, 1 May 2007 04:33:19 +0000 (UTC) Date: Tue, 1 May 2007 04:33:19 +0000 From: Darren Reed To: "George V. Neville-Neil" Message-ID: <20070501043319.GA29539@hub.freebsd.org> References: <200704241142.l3OBggmW065495@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704241142.l3OBggmW065495@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6.h in6_proto.c route6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 04:33:19 -0000 On Tue, Apr 24, 2007 at 11:42:42AM +0000, George V. Neville-Neil wrote: > gnn 2007-04-24 11:42:42 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/netinet6 in6.h in6_proto.c route6.c > Log: > Add a new sysctl net.inet.ip6.rthdr0_allowed, which is default off, > to disable the processing of Route Header Type 0 options in IPv6. > This is not really an MFC because currently in HEAD the processing > of these options is disabled unilateraly pending discussion at the IETF > on the future of such headers. Given this direction came from the IETF, is there an internet draft or RFC or BCP that discusses or summarises this? Darren From owner-cvs-src@FreeBSD.ORG Tue May 1 05:13:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 142B716A9C8; Tue, 1 May 2007 05:13:20 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 65DB113C507; Tue, 1 May 2007 05:13:16 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l415DG7a062223; Tue, 1 May 2007 05:13:16 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l415DG0l062222; Tue, 1 May 2007 05:13:16 GMT (envelope-from scottl) Message-Id: <200705010513.l415DG0l062222@repoman.freebsd.org> From: Scott Long Date: Tue, 1 May 2007 05:13:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ciss ciss.c cissvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 05:13:20 -0000 scottl 2007-05-01 05:13:16 UTC FreeBSD src repository Modified files: sys/dev/ciss ciss.c cissvar.h Log: MPSAFE ciss driver Revision Changes Path 1.77 +44 -19 src/sys/dev/ciss/ciss.c 1.11 +2 -1 src/sys/dev/ciss/cissvar.h From owner-cvs-src@FreeBSD.ORG Tue May 1 06:35:55 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8246C16A402; Tue, 1 May 2007 06:35:55 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 57E2113C459; Tue, 1 May 2007 06:35:55 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l416ZtYC076190; Tue, 1 May 2007 06:35:55 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l416ZteG076189; Tue, 1 May 2007 06:35:55 GMT (envelope-from alc) Message-Id: <200705010635.l416ZteG076189@repoman.freebsd.org> From: Alan Cox Date: Tue, 1 May 2007 06:35:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 06:35:55 -0000 alc 2007-05-01 06:35:55 UTC FreeBSD src repository Modified files: sys/kern sys_generic.c Log: Remove unneeded include files. Revision Changes Path 1.156 +0 -2 src/sys/kern/sys_generic.c From owner-cvs-src@FreeBSD.ORG Tue May 1 06:48:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1ED2D16A401; Tue, 1 May 2007 06:48:32 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 7E02B13C45E; Tue, 1 May 2007 06:48:31 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l416mTfL003928; Tue, 1 May 2007 10:48:29 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l416mTel003927; Tue, 1 May 2007 10:48:29 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 10:48:28 +0400 From: Andrey Chernov To: Alfred Perlstein Message-ID: <20070501064828.GA3836@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501013957.GX13868@elvis.mu.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, Roman Kurakin , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 06:48:32 -0000 On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: > Using the strategy "commit to -current then suffer the fallout" > is pretty bogus. The only possible. Nobody can run all ports at once. Kris already promise all ports build results with those changes in, lets see. Speaking about you - you suffer of what? Still no single report from your side, just talks. > I don't understand why some form of compatibility or #define wasn't > thought out before hand. It could be possible, along with some env. variables providing old (or perhaps new) behaviour and so on, but depends on what whole picture is. > This stands out like "fixing select" to record time elapsed into > the timevals, POSIX'ly correct, but incorrect for FreeBSD, without > more thought. Apples and oranges. select is BSD own function unlike putenv which is not BSD own and initially adopted without too much care. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 08:30:33 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0556216A401; Tue, 1 May 2007 08:30:33 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.freebsd.org (Postfix) with ESMTP id CB8E113C489; Tue, 1 May 2007 08:30:32 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 2E35AA8E; Tue, 1 May 2007 03:30:32 -0500 (CDT) Date: Tue, 1 May 2007 03:30:32 -0500 To: Andrey Chernov , Alfred Perlstein , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501083032.GA9361@soaustin.net> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501064828.GA3836@nagual.pp.ru> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 08:30:33 -0000 On Tue, May 01, 2007 at 10:48:28AM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: > > Using the strategy "commit to -current then suffer the fallout" > > is pretty bogus. > > The only possible. Nobody can run all ports at once. Kris already promise > all ports build results with those changes in, lets see. There have been many runs, in the past, with src changes put into the cluster and then tested, before the src changes were committed. This is the process that is always used to get new versions of gcc into the tree, for instance. mcl From owner-cvs-src@FreeBSD.ORG Tue May 1 08:42:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F315B16A402; Tue, 1 May 2007 08:42:05 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CF80413C45D; Tue, 1 May 2007 08:42:05 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l418g5uE001610; Tue, 1 May 2007 08:42:05 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l418g5qm001609; Tue, 1 May 2007 08:42:05 GMT (envelope-from wilko) Message-Id: <200705010842.l418g5qm001609@repoman.freebsd.org> From: Wilko Bulte Date: Tue, 1 May 2007 08:42:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 08:42:06 -0000 wilko 2007-05-01 08:42:05 UTC FreeBSD src repository Modified files: . access Log: back home, re-enable commit mail Approved by: core (implicit) Revision Changes Path 1.824 +1 -1 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue May 1 08:45:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DA3D016A402; Tue, 1 May 2007 08:45:16 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4B36613C4B0; Tue, 1 May 2007 08:45:16 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l418jEqj005022; Tue, 1 May 2007 12:45:14 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l418jEQC005021; Tue, 1 May 2007 12:45:14 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 12:45:14 +0400 From: Andrey Chernov To: Mark Linimon Message-ID: <20070501084514.GA4889@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Mark Linimon , Alfred Perlstein , Roman Kurakin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501083032.GA9361@soaustin.net> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Roman Kurakin , src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 08:45:17 -0000 On Tue, May 01, 2007 at 03:30:32AM -0500, Mark Linimon wrote: > On Tue, May 01, 2007 at 10:48:28AM +0400, Andrey Chernov wrote: > > On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: > > > Using the strategy "commit to -current then suffer the fallout" > > > is pretty bogus. > > > > The only possible. Nobody can run all ports at once. Kris already promise > > all ports build results with those changes in, lets see. > > There have been many runs, in the past, with src changes put into the > cluster and then tested, before the src changes were committed. This is > the process that is always used to get new versions of gcc into the tree, > for instance. This ones are not such vital as gcc changes which can break all programs at once, so can't be ever nearly compared with. For what we have --current for, if every change will go to the cluster first? And the question remains: Is something currently broken _for_you_? I still have no reports. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 08:55:33 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B738516A406; Tue, 1 May 2007 08:55:33 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 7701913C455; Tue, 1 May 2007 08:55:33 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id 898DB1CC0DD; Tue, 1 May 2007 10:55:32 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id CE29EB838; Tue, 1 May 2007 10:55:31 +0200 (CEST) Date: Tue, 1 May 2007 10:55:31 +0200 From: Henrik Brix Andersen To: Kris Kennaway Message-ID: <20070501085531.GA82977@tirith.brixandersen.dk> Mail-Followup-To: Kris Kennaway , Andrey Chernov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> <20070430195237.GA67426@xor.obsecurity.org> <20070501001627.GA804@nagual.pp.ru> <20070501005007.GA70549@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline In-Reply-To: <20070501005007.GA70549@xor.obsecurity.org> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 08:55:33 -0000 --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2007 at 08:50:07PM -0400, Kris Kennaway wrote: > On Tue, May 01, 2007 at 04:16:27AM +0400, Andrey Chernov wrote: > > Kris, could you please run test build for ports with all changes up to= =20 > > sys/param.h in? I want to see how many ports will failed if any.=20 > > Personally me run lots of ports of my machine and didn't notice any bad= =20 > > side effect yet. >=20 > Will do. Perhaps I missed something - but as far as I can tell, just compiling the ports will not reveal problems related to these *env() changes? (It will, of course, help reveal any problems in our src tree.) That being said, I have not encountered any new problems related to the *env() changes. Regards, Brix --=20 Henrik Brix Andersen --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFGNwCDv+Q4flTiePgRAtG+AKC/1J6ffKPL5kVyzrtxDal3ctNV0wCgvr16 65eiVimhDuZewMU6SHbLXcw= =brFh -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx-- From owner-cvs-src@FreeBSD.ORG Tue May 1 09:02:18 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8875316A400; Tue, 1 May 2007 09:02:18 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 06F0613C489; Tue, 1 May 2007 09:02:17 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l4192G0C005469; Tue, 1 May 2007 13:02:16 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l4192Gab005468; Tue, 1 May 2007 13:02:16 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 13:02:16 +0400 From: Andrey Chernov To: Kris Kennaway , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501090216.GA5405@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Kris Kennaway , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> <20070430195237.GA67426@xor.obsecurity.org> <20070501001627.GA804@nagual.pp.ru> <20070501005007.GA70549@xor.obsecurity.org> <20070501085531.GA82977@tirith.brixandersen.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20070501085531.GA82977@tirith.brixandersen.dk> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 09:02:18 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 10:55:31AM +0200, Henrik Brix Andersen wrote: > Perhaps I missed something - but as far as I can tell, just compiling > the ports will not reveal problems related to these *env() changes? Yes, not all problems will be revealed by just compiling (running ports=20 will), but we'll have at least some real stats helping to decide what to=20 do next. See my reply to my HEADS UP with variants. > That being said, I have not encountered any new problems related to > the *env() changes. Ok. Previous one happens just because commit have many parts and was=20 unfinished at the moment you try. --=20 http://ache.pp.ru/ --envbJBWh7q8WU6mo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNwIYVg5YK5ZEdN0RAkLeAJ4yC7801KUDiPKpvvgO7GzFVqflhACgrQ+V lh1iUHv+Xps3jntNM2IKqE4= =KX/R -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo-- From owner-cvs-src@FreeBSD.ORG Tue May 1 10:06:44 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3A15716A401; Tue, 1 May 2007 10:06:44 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-3-125.belrs4.nsw.optusnet.com.au [220.239.3.125]) by mx1.freebsd.org (Postfix) with ESMTP id B863513C44C; Tue, 1 May 2007 10:06:43 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l41A6gvR001348; Tue, 1 May 2007 20:06:42 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l41A6gjU001347; Tue, 1 May 2007 20:06:42 +1000 (EST) (envelope-from peter) Date: Tue, 1 May 2007 20:06:42 +1000 From: Peter Jeremy To: Andrey Chernov , Alfred Perlstein , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501100642.GB823@turion.vk2pj.dyndns.org> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <20070501000242.GA19510@nagual.pp.ru> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.14 (2007-02-12) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:06:44 -0000 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-May-01 04:02:42 +0400, Andrey Chernov wrote: >On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: >> I think Alfred is absolutely right, and this is a pretty major >> POLA violation.=20 > >That's -current for. Do you suggest to wait yet more N years to commit=20 >exact that stuff? I would have expected this proposed change to get a heads-up in current@ first. _Especially_ since there is a current thread in current@ about fixing some long-standing memory leaks in our *env() functions. Implementing a major POLA violation without any warning whilst other changes to the same code are being discussed in one of the mailing lists could be seen as impolite. >There is no SVR4 bugs in this commit. The SVR4 behaviour (as documented in SUSv3) is a bug. Note that the C90 (ANSI X3.159-1989, ISO 9899:1990) does not include putenv() or setenv() due to the the lack of any concensus on how they should behave. FreeBSD does not and (AFAIK) has never claimed to be to-the-letter POSIX compliance by default. --=20 Peter Jeremy --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGNxEy/opHv/APuIcRAkWuAJ9dKg3/2gK8HFLfJ37TH7NLLef5yQCgv/8L iDGm1PtIKDBlfQyKZS5NPmE= =Ag6J -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- From owner-cvs-src@FreeBSD.ORG Tue May 1 10:26:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB6ED16A400; Tue, 1 May 2007 10:26:24 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4D7A213C457; Tue, 1 May 2007 10:26:24 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41AQMeg006105; Tue, 1 May 2007 14:26:22 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41AQMXB006104; Tue, 1 May 2007 14:26:22 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 14:26:22 +0400 From: Andrey Chernov To: Peter Jeremy Message-ID: <20070501102621.GA6002@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Jeremy , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501100642.GB823@turion.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20070501100642.GB823@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:26:25 -0000 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 08:06:42PM +1000, Peter Jeremy wrote: > I would have expected this proposed change to get a heads-up in > current@ first. _Especially_ since there is a current thread in > current@ about fixing some long-standing memory leaks in our *env() > functions. Implementing a major POLA violation without any warning > whilst other changes to the same code are being discussed in one of > the mailing lists could be seen as impolite. I see no POLA violations from my own.=20 1) POLA for those functions is well known while internal hacks can't be=20 called POLA. 2) Our putenv() itself is ist originating POLA violation since=20 implemented, so we just returning to original POLA. My changes are not related to fixing some long-standing memory leaks in=20 our *env() at all, I don't touch that code so can't change the same code=20 as other. > >There is no SVR4 bugs in this commit. >=20 > The SVR4 behaviour (as documented in SUSv3) is a bug. If you mean putenv() (I see no other things which can be called SVR4=20 behaviour there), it isn't BSD native function, so we must honor its=20 original implementation, if we decide to provide it. > Note that the C90 (ANSI X3.159-1989, ISO 9899:1990) does not include > putenv() or setenv() due to the the lack of any concensus on how they > should behave. =20 I know. > FreeBSD does not and (AFAIK) has never claimed to be to-the-letter POSIX= =20 > compliance by default. See and count our manpages, namely STANDARDS section. The question again: what isn't working currently _for_you? --=20 http://ache.pp.ru/ --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNxXNVg5YK5ZEdN0RAh2jAJ4vAHknCCV+WCXYqgIMzfH9NX40lgCeKOtP sPAdomcaEe6YIyC32iIGtQw= =Sc+j -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP-- From owner-cvs-src@FreeBSD.ORG Tue May 1 10:47:09 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A22D216A401; Tue, 1 May 2007 10:47:09 +0000 (UTC) (envelope-from wkoszek@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 816A313C43E; Tue, 1 May 2007 10:47:09 +0000 (UTC) (envelope-from wkoszek@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41Al9SQ032639; Tue, 1 May 2007 10:47:09 GMT (envelope-from wkoszek@repoman.freebsd.org) Received: (from wkoszek@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41Al939032638; Tue, 1 May 2007 10:47:09 GMT (envelope-from wkoszek) Message-Id: <200705011047.l41Al939032638@repoman.freebsd.org> From: "Wojciech A. Koszek" Date: Tue, 1 May 2007 10:47:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libgeom geom_getxml.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:47:09 -0000 wkoszek 2007-05-01 10:47:09 UTC FreeBSD src repository Modified files: lib/libgeom geom_getxml.c Log: Second call of sysctl() is used to gather a proper size of a memory chunk needed to hold the GEOM tree. At this point, pointer 'p' has an improper value (as it was used previously), and we're getting EFAULT. Fix this functionality by passing NULL instead of 'p'. This fixes mdconfig(8) -l output with high number of md(4) devices. Found by: kris Reviewed by: phk Revision Changes Path 1.2 +1 -1 src/lib/libgeom/geom_getxml.c From owner-cvs-src@FreeBSD.ORG Tue May 1 10:59:40 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1613516A403; Tue, 1 May 2007 10:59:40 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-3-125.belrs4.nsw.optusnet.com.au [220.239.3.125]) by mx1.freebsd.org (Postfix) with ESMTP id 6C47813C44C; Tue, 1 May 2007 10:59:39 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l41AxbF3001491; Tue, 1 May 2007 20:59:37 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l41AxbYJ001490; Tue, 1 May 2007 20:59:37 +1000 (EST) (envelope-from peter) Date: Tue, 1 May 2007 20:59:37 +1000 From: Peter Jeremy To: Andrey Chernov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501105937.GC823@turion.vk2pj.dyndns.org> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Content-Disposition: inline In-Reply-To: <20070501064828.GA3836@nagual.pp.ru> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.14 (2007-02-12) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:59:40 -0000 --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-May-01 10:48:28 +0400, Andrey Chernov wrote: >On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: >> Using the strategy "commit to -current then suffer the fallout" >> is pretty bogus. > >The only possible. Nobody can run all ports at once. Kris already promise= =20 >all ports build results with those changes in, lets see. Note that just building the ports with these changes will not demonstrate much. This change alters the functionality of putenv() rather than the API/ABI so testing the change requires exercising the ports. This is a much more difficult task. >Apples and oranges. select is BSD own function unlike putenv which is not= =20 >BSD own and initially adopted without too much care. Then someone needs to fix the "HISTORY" section of getenv(3). I've looked thru the TUHS and CSRG files and it didn't exist in V7 or any of the early BSDs. I'm not sure when it really did appear. getenv(3) in 4.3reno doesn't claim compliance to any standard for putenv(). --=20 Peter Jeremy --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGNx2Z/opHv/APuIcRApWQAJ9fl0FHp1DcIaUBOCvSf380U214UQCgl3se Wf3Z7hW83t50AD/Rh2luIwI= =QYrP -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv-- From owner-cvs-src@FreeBSD.ORG Tue May 1 11:17:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EDCDC16A401; Tue, 1 May 2007 11:17:29 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CE64213C458; Tue, 1 May 2007 11:17:29 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41BHTDQ038846; Tue, 1 May 2007 11:17:29 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41BHTC7038845; Tue, 1 May 2007 11:17:29 GMT (envelope-from brueffer) Message-Id: <200705011117.l41BHTC7038845@repoman.freebsd.org> From: Christian Brueffer Date: Tue, 1 May 2007 11:17:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_axe.c if_axereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:17:30 -0000 brueffer 2007-05-01 11:17:29 UTC FreeBSD src repository Modified files: sys/dev/usb if_axe.c if_axereg.h Log: Remove pre-5.0 compat cruft. Approved by: rwatson (mentor) MFC after: 1 week Revision Changes Path 1.43 +0 -23 src/sys/dev/usb/if_axe.c 1.11 +0 -2 src/sys/dev/usb/if_axereg.h From owner-cvs-src@FreeBSD.ORG Tue May 1 11:20:23 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0404F16A401; Tue, 1 May 2007 11:20:23 +0000 (UTC) (envelope-from rik@inse.ru) Received: from mail.inse.ru (inse.ru [144.206.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id B5B7F13C455; Tue, 1 May 2007 11:20:22 +0000 (UTC) (envelope-from rik@inse.ru) Received: from [127.0.0.1] (www.inse.ru [144.206.128.1]) by mail.inse.ru (Postfix) with ESMTP id 578EF33C4F; Tue, 1 May 2007 15:20:21 +0400 (MSD) Message-ID: <46372416.3020509@inse.ru> Date: Tue, 01 May 2007 15:27:18 +0400 From: Roman Kurakin User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Peter Jeremy References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> In-Reply-To: <20070501105937.GC823@turion.vk2pj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:20:23 -0000 Peter Jeremy wrote: > On 2007-May-01 10:48:28 +0400, Andrey Chernov wrote: > >> On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: >> >>> Using the strategy "commit to -current then suffer the fallout" >>> is pretty bogus. >>> >> The only possible. Nobody can run all ports at once. Kris already promise >> all ports build results with those changes in, lets see. >> > > Note that just building the ports with these changes will not demonstrate > much. This change alters the functionality of putenv() rather than the > API/ABI so testing the change requires exercising the ports. This is > a much more difficult task. > I suggest to install all ports sources and grep them at first. I am sure some of ports could be marked as bug-less and other should be marked for exec-check or probably for more accurate review not just grep. rik > >> Apples and oranges. select is BSD own function unlike putenv which is not >> BSD own and initially adopted without too much care. >> > > Then someone needs to fix the "HISTORY" section of getenv(3). I've > looked thru the TUHS and CSRG files and it didn't exist in V7 or any > of the early BSDs. I'm not sure when it really did appear. getenv(3) > in 4.3reno doesn't claim compliance to any standard for putenv(). > > From owner-cvs-src@FreeBSD.ORG Tue May 1 11:20:34 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2A39F16A400; Tue, 1 May 2007 11:20:34 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 876EC13C44C; Tue, 1 May 2007 11:20:32 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41BKVWU006593; Tue, 1 May 2007 15:20:31 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41BKVxL006592; Tue, 1 May 2007 15:20:31 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 15:20:31 +0400 From: Andrey Chernov To: Peter Jeremy Message-ID: <20070501112031.GA6442@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Jeremy , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <20070501105937.GC823@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:20:34 -0000 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 08:59:37PM +1000, Peter Jeremy wrote: > Note that just building the ports with these changes will not demonstrate > much. This change alters the functionality of putenv() rather than the > API/ABI so testing the change requires exercising the ports. This is > a much more difficult task. I agree, only running ports does. As I already answered elsewhere, that=20 way we'll have at least first real stats how it affects building system=20 instead of that endless BSD vs. POSIX speculation (I already tired of)=20 without any real ground of things affected. > >Apples and oranges. select is BSD own function unlike putenv which is no= t=20 > >BSD own and initially adopted without too much care. >=20 > Then someone needs to fix the "HISTORY" section of getenv(3). I've > looked thru the TUHS and CSRG files and it didn't exist in V7 or any > of the early BSDs. I'm not sure when it really did appear. getenv(3) > in 4.3reno doesn't claim compliance to any standard for putenv(). And I said so. We can't call POLA what is not belongs to us and poorly=20 implemented in our base later just because it stays in that form for a=20 long time. Moreover, having it in poorly implemented form will result that= =20 our soft will be unportable, so we lost possibility to attract potential=20 users. --=20 http://ache.pp.ru/ --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNyJ/Vg5YK5ZEdN0RAiesAJ99rTt/pK4LeejWRj8gfC8mnGsFvQCePWNj +QFPGsjs/XRmXNkpXH7kn0g= =+A6o -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm-- From owner-cvs-src@FreeBSD.ORG Tue May 1 11:29:25 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2ED9F16A402; Tue, 1 May 2007 11:29:25 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from liby.buh.tecnik93.com (liby.buh.tecnik93.com [81.196.204.101]) by mx1.freebsd.org (Postfix) with ESMTP id E2C5013C45B; Tue, 1 May 2007 11:29:24 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by liby.buh.tecnik93.com (Postfix) with ESMTP id 2B2391D8C02; Tue, 1 May 2007 14:10:47 +0300 (EEST) Date: Tue, 1 May 2007 14:10:46 +0300 From: Ion-Mihai Tetcu To: "Joao Barros" Message-ID: <20070501141046.22878dbd@localhost> In-Reply-To: <70e8236f0704301202s5d327586m981af2a3b6a87ac8@mail.gmail.com> References: <200704301829.l3UITbCd065040@repoman.freebsd.org> <70e8236f0704301202s5d327586m981af2a3b6a87ac8@mail.gmail.com> X-Mailer: Sylpheed-Claws 2.4.0 (GTK+ 2.8.20; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Maxim Konovalov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:29:25 -0000 On Mon, 30 Apr 2007 20:02:13 +0100 "Joao Barros" wrote: > On 4/30/07, Maxim Konovalov wrote: > > maxim 2007-04-30 18:29:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/fdisk fdisk.8 fdisk.c > > Log: > > o Add -p flag: print a slice table in fdisk configuration file > > format. Now it is possible to do something like fdisk -p ad0 | > > fdisk -f - ad1. THANK YOU ! -- IOnut From owner-cvs-src@FreeBSD.ORG Tue May 1 11:31:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0375716A408; Tue, 1 May 2007 11:31:24 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id A3DDC13C4BD; Tue, 1 May 2007 11:31:23 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id EB9861A4DA1; Tue, 1 May 2007 04:31:55 -0700 (PDT) Date: Tue, 1 May 2007 04:31:55 -0700 From: Alfred Perlstein To: Andrey Chernov , Mark Linimon , Roman Kurakin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070501113155.GD13868@elvis.mu.org> References: <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> <20070501084514.GA4889@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501084514.GA4889@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:31:24 -0000 Andrey, If the fallout from your changes broke a bunch of things in -current, then we can expect the fallout in -stable to be even worse. Your query about bug reports is a straw man as anticipating a lot of fallout which has already occured does not require that I actually have a bug report. The end result is more users being bitten because a discussion regarding this has obviously not taken place. And yes, you're being a jerk. :) -Alfred * Andrey Chernov [070501 01:45] wrote: > On Tue, May 01, 2007 at 03:30:32AM -0500, Mark Linimon wrote: > > On Tue, May 01, 2007 at 10:48:28AM +0400, Andrey Chernov wrote: > > > On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: > > > > Using the strategy "commit to -current then suffer the fallout" > > > > is pretty bogus. > > > > > > The only possible. Nobody can run all ports at once. Kris already promise > > > all ports build results with those changes in, lets see. > > > > There have been many runs, in the past, with src changes put into the > > cluster and then tested, before the src changes were committed. This is > > the process that is always used to get new versions of gcc into the tree, > > for instance. > > This ones are not such vital as gcc changes which can break all programs > at once, so can't be ever nearly compared with. For what we have --current > for, if every change will go to the cluster first? > > And the question remains: > Is something currently broken _for_you_? I still have no reports. > > -- > http://ache.pp.ru/ -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Tue May 1 11:40:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1562216A400; Tue, 1 May 2007 11:40:45 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id EAB9C13C44C; Tue, 1 May 2007 11:40:44 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41Bei55042530; Tue, 1 May 2007 11:40:44 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41Beijv042529; Tue, 1 May 2007 11:40:44 GMT (envelope-from yar) Message-Id: <200705011140.l41Beijv042529@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 1 May 2007 11:40:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/libexec/ftpd ftpcmd.y ftpd.8 ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:40:45 -0000 yar 2007-05-01 11:40:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) libexec/ftpd ftpcmd.y ftpd.8 ftpd.c Log: MFC: ftpd.c 1.212 ftpcmd.y 1.66 ftpd.8 1.72-1.73 Add support for RFC 2389 (FEAT) and RFC 2640 (UTF8) to ftpd(8). PR: bin/111714 Revision Changes Path 1.64.2.2 +22 -1 src/libexec/ftpd/ftpcmd.y 1.69.2.2 +17 -2 src/libexec/ftpd/ftpd.8 1.206.2.3 +6 -1 src/libexec/ftpd/ftpd.c From owner-cvs-src@FreeBSD.ORG Tue May 1 11:46:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B730016A403; Tue, 1 May 2007 11:46:30 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 97D9F13C45B; Tue, 1 May 2007 11:46:30 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41BkUs4044590; Tue, 1 May 2007 11:46:30 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41BkUWx044589; Tue, 1 May 2007 11:46:30 GMT (envelope-from yar) Message-Id: <200705011146.l41BkUWx044589@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 1 May 2007 11:46:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/libexec/ftpd ftpd.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:46:30 -0000 yar 2007-05-01 11:46:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) libexec/ftpd ftpd.8 Log: MFC rev. 1.74: Remove references to S/Key and list OPIE. Revision Changes Path 1.69.2.3 +7 -8 src/libexec/ftpd/ftpd.8 From owner-cvs-src@FreeBSD.ORG Tue May 1 11:50:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 955F016A400; Tue, 1 May 2007 11:50:12 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6FE8E13C455; Tue, 1 May 2007 11:50:12 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41BoCY7044849; Tue, 1 May 2007 11:50:12 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41BoChR044848; Tue, 1 May 2007 11:50:12 GMT (envelope-from marius) Message-Id: <200705011150.l41BoChR044848@repoman.freebsd.org> From: Marius Strobl Date: Tue, 1 May 2007 11:50:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:50:12 -0000 marius 2007-05-01 11:50:12 UTC FreeBSD src repository Modified files: sys/dev/hme if_hme.c Log: Remove invalid BUS_DMA_ALLOCNOW when creating a tag which is used for a "static" memory allocation only. Revision Changes Path 1.53 +1 -1 src/sys/dev/hme/if_hme.c From owner-cvs-src@FreeBSD.ORG Tue May 1 11:51:37 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4ADE816A407; Tue, 1 May 2007 11:51:37 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 8DF7C13C459; Tue, 1 May 2007 11:51:36 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41BpZ8p006894; Tue, 1 May 2007 15:51:35 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41BpYf6006893; Tue, 1 May 2007 15:51:34 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 15:51:33 +0400 From: Andrey Chernov To: Alfred Perlstein Message-ID: <20070501115133.GA6634@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> <20070501084514.GA4889@nagual.pp.ru> <20070501113155.GD13868@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501113155.GD13868@elvis.mu.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:51:37 -0000 On Tue, May 01, 2007 at 04:31:55AM -0700, Alfred Perlstein wrote: > If the fallout from your changes broke a bunch of things in > -current, then we can expect the fallout in -stable to be > even worse. They are not planning to go into -stable any soon until the moment when 7.x becomes -stable, when libc version number will be bumped. Do you mean under "bunch of things" few programs either mainly unchanged from V7 hacks time or suffering just because we have unportable poorly implemented putenv() in our libc which breaks its original SysV POLA? If yes, such changes are surely for good: backward-compatible, eliminating hacks and making our soft more portable. > Your query about bug reports is a straw man as anticipating > a lot of fallout which has already occured does not require > that I actually have a bug report. What you calls "fallouts" I call "portablity". > The end result is more users being bitten because a discussion > regarding this has obviously not taken place. It happens now, so they don't miss anything. At any moment those changes can be made non-default, under some sort of env. variable or old bug-to-bug functionality will be made by env. variable or some other ways. It depends on problem reports I hit, but I don't see any yet. > And yes, you're being a jerk. :) Thanx, I hope that streak will help me to improve our code. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 11:57:19 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C1BD16A415; Tue, 1 May 2007 11:57:19 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id B20F013C45D; Tue, 1 May 2007 11:57:18 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41BvDj4006980; Tue, 1 May 2007 15:57:13 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41BvD3f006979; Tue, 1 May 2007 15:57:13 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 15:57:12 +0400 From: Andrey Chernov To: Roman Kurakin Message-ID: <20070501115712.GB6634@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Roman Kurakin , Peter Jeremy , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> <46372416.3020509@inse.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46372416.3020509@inse.ru> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:57:19 -0000 On Tue, May 01, 2007 at 03:27:18PM +0400, Roman Kurakin wrote: > I suggest to install all ports sources and grep them at first. I am sure > some of ports > could be marked as bug-less and other should be marked for exec-check or > probably > for more accurate review not just grep. Interesting idea but I simple not have any machine which fits to that task. Is our ports cluster have whole ports tree unpacked, by chance? -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 12:09:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2511F16A400; Tue, 1 May 2007 12:09:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0436413C448; Tue, 1 May 2007 12:09:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41C9jQX049397; Tue, 1 May 2007 12:09:45 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41C9jow049396; Tue, 1 May 2007 12:09:45 GMT (envelope-from pjd) Message-Id: <200705011209.l41C9jow049396@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 1 May 2007 12:09:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 12:09:46 -0000 pjd 2007-05-01 12:09:45 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: Add a comment explaining why we call dmu_write() unconditionally, even if uiomove() fails, especially that it is different from what OpenSolaris does (I'm not entirely sure they are right). Suggested by: darrenr Revision Changes Path 1.15 +9 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Tue May 1 12:15:03 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0F1F416A40D; Tue, 1 May 2007 12:15:03 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr8.xs4all.nl (smtp-vbr8.xs4all.nl [194.109.24.28]) by mx1.freebsd.org (Postfix) with ESMTP id 7897D13C4BB; Tue, 1 May 2007 12:15:02 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (obsolete.xs4all.nl [82.95.250.254]) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id l41C0cII090512; Tue, 1 May 2007 14:00:38 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.8/8.13.3) with ESMTP id l41C0b47056298; Tue, 1 May 2007 14:00:37 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.8/8.13.6/Submit) id l41C0b8B056297; Tue, 1 May 2007 14:00:37 +0200 (CEST) (envelope-from wb) Date: Tue, 1 May 2007 14:00:37 +0200 From: Wilko Bulte To: Ion-Mihai Tetcu Message-ID: <20070501120037.GA56284@freebie.xs4all.nl> References: <200704301829.l3UITbCd065040@repoman.freebsd.org> <70e8236f0704301202s5d327586m981af2a3b6a87ac8@mail.gmail.com> <20070501141046.22878dbd@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501141046.22878dbd@localhost> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Maxim Konovalov , cvs-src@FreeBSD.org, Joao Barros , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 12:15:03 -0000 On Tue, May 01, 2007 at 02:10:46PM +0300, Ion-Mihai Tetcu wrote.. > On Mon, 30 Apr 2007 20:02:13 +0100 > "Joao Barros" wrote: > > > On 4/30/07, Maxim Konovalov wrote: > > > maxim 2007-04-30 18:29:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sbin/fdisk fdisk.8 fdisk.c > > > Log: > > > o Add -p flag: print a slice table in fdisk configuration file > > > format. Now it is possible to do something like fdisk -p ad0 | > > > fdisk -f - ad1. > > THANK YOU ! Very nice indeed :-) -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue May 1 12:22:49 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5279916A403; Tue, 1 May 2007 12:22:49 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id AA7CE13C469; Tue, 1 May 2007 12:22:48 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41CMl40007224; Tue, 1 May 2007 16:22:47 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41CMlN4007223; Tue, 1 May 2007 16:22:47 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 16:22:46 +0400 From: Andrey Chernov To: Alfred Perlstein , Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501122246.GA7178@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> <20070501084514.GA4889@nagual.pp.ru> <20070501113155.GD13868@elvis.mu.org> <20070501115133.GA6634@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501115133.GA6634@nagual.pp.ru> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 12:22:49 -0000 On Tue, May 01, 2007 at 03:51:33PM +0400, Andrey Chernov wrote: > > Your query about bug reports is a straw man as anticipating > > a lot of fallout which has already occured does not require > > that I actually have a bug report. I can add that I expect _much_less_ fallouts from the ports since that soft is already maked portable by their developers and is not local V7 hacks rotten for years without touching, but you may disagree. That's why we need some real stats first. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 12:59:21 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0030816A407; Tue, 1 May 2007 12:59:20 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D055B13C483; Tue, 1 May 2007 12:59:20 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41CxKoj066462; Tue, 1 May 2007 12:59:20 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41CxKGD066461; Tue, 1 May 2007 12:59:20 GMT (envelope-from des) Message-Id: <200705011259.l41CxKGD066461@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Tue, 1 May 2007 12:59:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/procfs procfs_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 12:59:21 -0000 des 2007-05-01 12:59:20 UTC FreeBSD src repository Modified files: sys/fs/procfs procfs_ioctl.c Log: The process lock is held when procfs_ioctl() is called. Assert that this is so, and PHOLD the process while sleeping since msleep() will release the lock. Revision Changes Path 1.17 +8 -2 src/sys/fs/procfs/procfs_ioctl.c From owner-cvs-src@FreeBSD.ORG Tue May 1 13:14:38 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E3AF416A404; Tue, 1 May 2007 13:14:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CB5EB13C4B9; Tue, 1 May 2007 13:14:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 0FE591A4DA1; Tue, 1 May 2007 06:15:11 -0700 (PDT) Date: Tue, 1 May 2007 06:15:11 -0700 From: Alfred Perlstein To: Andrey Chernov , Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501131511.GF13868@elvis.mu.org> References: <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> <20070501084514.GA4889@nagual.pp.ru> <20070501113155.GD13868@elvis.mu.org> <20070501115133.GA6634@nagual.pp.ru> <20070501122246.GA7178@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501122246.GA7178@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:14:39 -0000 * Andrey Chernov [070501 05:25] wrote: > On Tue, May 01, 2007 at 03:51:33PM +0400, Andrey Chernov wrote: > > > Your query about bug reports is a straw man as anticipating > > > a lot of fallout which has already occured does not require > > > that I actually have a bug report. > > I can add that I expect _much_less_ fallouts from the ports since that > soft is already maked portable by their developers and is not local V7 > hacks rotten for years without touching, but you may disagree. That's why > we need some real stats first. Yes, however, typically(*) this is done pre-commit as a courtesy to the community both developer and consumer. (*) in my mind where people think about preserving some form of source/binary compatibility so that developing apps doesn't resemble some form of kangaroo court. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Tue May 1 13:21:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F5AF16A400; Tue, 1 May 2007 13:21:34 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from istc.kiev.ua (wolf.istc.kiev.ua [193.108.236.1]) by mx1.freebsd.org (Postfix) with ESMTP id CF42013C459; Tue, 1 May 2007 13:21:33 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from localhost ([127.0.0.1] helo=ravenloft.kiev.ua) by istc.kiev.ua with esmtp (Exim 4.52) id 1Hiruz-0002nG-FQ; Tue, 01 May 2007 15:57:21 +0300 Received: from kozlov by ravenloft.kiev.ua with local (Exim 4.66 (FreeBSD)) (envelope-from ) id 1Hiruf-00059t-2c; Tue, 01 May 2007 15:57:01 +0300 Date: Tue, 1 May 2007 15:57:01 +0300 From: Alex Kozlov To: Maxim Konovalov , cvs-src@FreeBSD.org, spam@rm-rf.kiev.ua Message-ID: <20070501125701.GA19741@ravenloft.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.14 (2007-02-12) X-Spam-Score: 0.0 (/) X-Spam-Report: Content analysis detailz: (0.0 points, 10.0 required) Cc: Subject: Re: cvs commit: src/sbin/fdisk fdisk.8 fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:21:34 -0000 > FreeBSD src repository > > Modified files: > sbin/fdisk fdisk.8 fdisk.c > Log: > o Add -p flag: print a slice table in fdisk configuration file format. > Now it is possible to do something like fdisk -p ad0 | fdisk -f - ad1. By the way, about fdisk user friendliness. Can you also check pr 68312? Thank you. -- Adios From owner-cvs-src@FreeBSD.ORG Tue May 1 13:31:33 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EF0D016A404; Tue, 1 May 2007 13:31:33 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E143813C468; Tue, 1 May 2007 13:31:33 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41DVXjA073049; Tue, 1 May 2007 13:31:33 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41DVXMM073048; Tue, 1 May 2007 13:31:33 GMT (envelope-from marius) Message-Id: <200705011331.l41DVXMM073048@repoman.freebsd.org> From: Marius Strobl Date: Tue, 1 May 2007 13:31:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sparc64/pci psycho.c psychoreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:31:34 -0000 marius 2007-05-01 13:31:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sparc64/pci psycho.c psychoreg.h Log: MFC: psycho.c 1.61; psychoreg.h 1.12 o Changes to psycho_attach(): [1] - Clear the PCI AFSR and status error bits as previous errors still might be indicated. - Set up the PCI control and diagnostic registers according to the capabilities, workarounds, etc of/for specific revisions of the supported bridges. This includes no longer setting Hummingbird-/ Sabre-specific bits in the PCI control register but preserving what the firmware has initialized them to like OpenSolaris does. Previously we were setting these bits according to the example in the Sabre documentation, which I doubt is appropriate for all Sabre based designs and especially not for Hummingbirds. This also includes not enabling bus parking unless the firmware tells us to. - Set the PCI latency timer register as this isn't always done by the firmware. o Remove a redundant argument from psycho_set_intr() and in this function check the return value of bus_setup_intr(). [2] o Let psycho_setup_intr() return ENOMEM instead of 0 when it can't allocate memory for the interrupt wrapper stub and EINVAL instead of 0 if it can't find the interrupt vector in the interrupt map. o Add a workaround for a bug of the Sabre-APB-combination where it doesn't drain DMA write data for devices behind additional PCI-PCI bridges underneath the APB PCI-PCI bridge. This workaround (do things necessary in order to achieve a manual drain when coherency is required) is currently implemented in psycho_setup_intr() and psycho_intr_stub() due to lack of a real BUS_GET_DMA_TAG() and psycho(4)-specific bus_dma_tag_create() and bus_dmamap_sync() methods, respectively, in RELENG_6 and therefore is only applied for interrupt handlers but not for polling(4) callbacks. [3] o Fix some minor style issues. Info from: OpenSolaris [1] Info from: Linux, OpenBSD, OpenSolaris [3] Suggested by: Coverity Prevent (CID 682) [2] Revision Changes Path 1.53.2.3 +189 -55 src/sys/sparc64/pci/psycho.c 1.9.2.2 +36 -9 src/sys/sparc64/pci/psychoreg.h From owner-cvs-src@FreeBSD.ORG Tue May 1 13:32:22 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 89CFF16A402; Tue, 1 May 2007 13:32:22 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 7CAB213C457; Tue, 1 May 2007 13:32:22 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41DWMwg073351; Tue, 1 May 2007 13:32:22 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41DWMPd073348; Tue, 1 May 2007 13:32:22 GMT (envelope-from pjd) Message-Id: <200705011332.l41DWMPd073348@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 1 May 2007 13:32:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs dmu_send.c zfs_ctldir.c zfs_vfsops.c zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:32:22 -0000 pjd 2007-05-01 13:32:22 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs dmu_send.c zfs_ctldir.c zfs_vfsops.c zfs_vnops.c Log: White space fixes. Revision Changes Path 1.2 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c 1.3 +21 -21 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c 1.8 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c 1.16 +12 -12 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Tue May 1 13:46:28 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F2D2C16A400; Tue, 1 May 2007 13:46:27 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CDE6213C43E; Tue, 1 May 2007 13:46:27 +0000 (UTC) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41DkRfc075669; Tue, 1 May 2007 13:46:27 GMT (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41DkRCa075668; Tue, 1 May 2007 13:46:27 GMT (envelope-from deischen) Message-Id: <200705011346.l41DkRCa075668@repoman.freebsd.org> From: Daniel Eischen Date: Tue, 1 May 2007 13:46:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:46:28 -0000 deischen 2007-05-01 13:46:27 UTC FreeBSD src repository Modified files: libexec/rtld-elf Symbol.map Log: Catch up with the private namespace change (s/FBSDprivate/FBSDprivate_1.0). Revision Changes Path 1.4 +1 -1 src/libexec/rtld-elf/Symbol.map From owner-cvs-src@FreeBSD.ORG Tue May 1 13:58:58 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 25C6E16A400; Tue, 1 May 2007 13:58:58 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 008B213C469; Tue, 1 May 2007 13:58:58 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41DwvVp077479; Tue, 1 May 2007 13:58:57 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41DwvMv077478; Tue, 1 May 2007 13:58:57 GMT (envelope-from pjd) Message-Id: <200705011358.l41DwvMv077478@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 1 May 2007 13:58:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 13:58:58 -0000 pjd 2007-05-01 13:58:57 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: MFp4: Remove LK_RETRY flag when locking vnode in zfs_lookup, we don't want dead vnodes here. Suggested by: kib Revision Changes Path 1.17 +6 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Tue May 1 14:09:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F223416A401; Tue, 1 May 2007 14:09:01 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from opus.cse.buffalo.edu (opus.cse.Buffalo.EDU [128.205.32.4]) by mx1.freebsd.org (Postfix) with ESMTP id B457813C44B; Tue, 1 May 2007 14:09:01 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from [127.0.0.1] (localhost.cse.buffalo.edu [127.0.0.1]) by opus.cse.buffalo.edu (8.13.8/8.12.4) with ESMTP id l41DtbvU001501; Tue, 1 May 2007 09:55:37 -0400 (EDT) From: Ken Smith To: Andrey Chernov In-Reply-To: <20070501001627.GA804@nagual.pp.ru> References: <200704301227.l3UCRwao077864@repoman.freebsd.org> <20070430191144.GA66695@xor.obsecurity.org> <20070430191555.GB87375@nagual.pp.ru> <20070430195237.GA67426@xor.obsecurity.org> <20070501001627.GA804@nagual.pp.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rG7YuwxssxcpvGqXrTou" Organization: U. Buffalo CSE Department Date: Tue, 01 May 2007 09:55:37 -0400 Message-Id: <1178027737.1134.16.camel@opus.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.10.0 FreeBSD GNOME Team Port Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/libexec/pppoed pppoed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 14:09:02 -0000 --=-rG7YuwxssxcpvGqXrTou Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2007-05-01 at 04:16 +0400, Andrey Chernov wrote: > Kris, could you please run test build for ports with all changes up to=20 > sys/param.h in? I want to see how many ports will failed if any.=20 > Personally me run lots of ports of my machine and didn't notice any bad=20 > side effect yet.=20 For future reference this was a big enough change that having HEAD in a CODE SLUSH means you should have contacted RE with your intentions. Minimally we would have asked you to coordinate this sort of testing BEFORE the changes got committed.=20 --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-rG7YuwxssxcpvGqXrTou Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGN0bN/G14VSmup/YRAo79AJ95STokHhePI+QPwd8Ue+Ci9IMQbgCfTFgh rC++MRy/u1mmYUQeTQrna+U= =vYWV -----END PGP SIGNATURE----- --=-rG7YuwxssxcpvGqXrTou-- From owner-cvs-src@FreeBSD.ORG Tue May 1 14:14:53 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7489616A400; Tue, 1 May 2007 14:14:53 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4DAF713C4AD; Tue, 1 May 2007 14:14:53 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41EErKf081579; Tue, 1 May 2007 14:14:53 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41EErZ3081578; Tue, 1 May 2007 14:14:53 GMT (envelope-from marius) Message-Id: <200705011414.l41EErZ3081578@repoman.freebsd.org> From: Marius Strobl Date: Tue, 1 May 2007 14:14:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/uart uart_kbd_sun.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 14:14:53 -0000 marius 2007-05-01 14:14:52 UTC FreeBSD src repository Modified files: sys/dev/uart uart_kbd_sun.c Log: Fix bugs in the Sun -> AT keycode translation table which caused the Props key to act as Again and the Paste and Copy keys to be inverted. Revision Changes Path 1.13 +3 -3 src/sys/dev/uart/uart_kbd_sun.c From owner-cvs-src@FreeBSD.ORG Tue May 1 14:26:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4489D16A401; Tue, 1 May 2007 14:26:36 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id AC84E13C45A; Tue, 1 May 2007 14:26:35 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 04B026905F2; Tue, 1 May 2007 15:27:20 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id B7D2B6907D5; Tue, 1 May 2007 15:27:19 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local.fnop.net (87-196-57-75.net.novis.pt [87.196.57.75]) by core.fnop.net (Postfix) with ESMTP id 1722F6905F2; Tue, 1 May 2007 15:27:19 +0100 (WEST) Date: Tue, 01 May 2007 15:26:20 +0100 Message-ID: <861wi0mxgz.wl%rpaulo@fnop.net> From: Rui Paulo To: Darren Reed In-Reply-To: <20070501043319.GA29539@hub.freebsd.org> References: <200704241142.l3OBggmW065495@repoman.freebsd.org> <20070501043319.GA29539@hub.freebsd.org> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: ClamAV using ClamSMTP Cc: "George V. Neville-Neil" , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6.h in6_proto.c route6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 14:26:36 -0000 At Tue, 1 May 2007 04:33:19 +0000, Darren Reed wrote: > > On Tue, Apr 24, 2007 at 11:42:42AM +0000, George V. Neville-Neil wrote: > > gnn 2007-04-24 11:42:42 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/netinet6 in6.h in6_proto.c route6.c > > Log: > > Add a new sysctl net.inet.ip6.rthdr0_allowed, which is default off, > > to disable the processing of Route Header Type 0 options in IPv6. > > This is not really an MFC because currently in HEAD the processing > > of these options is disabled unilateraly pending discussion at the IETF > > on the future of such headers. > > Given this direction came from the IETF, is there an internet draft > or RFC or BCP that discusses or summarises this? No, I don't think there is one yet. From owner-cvs-src@FreeBSD.ORG Tue May 1 14:47:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6984716A402; Tue, 1 May 2007 14:47:36 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 43E7113C45D; Tue, 1 May 2007 14:47:36 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41ElaA1087940; Tue, 1 May 2007 14:47:36 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41ElaQw087939; Tue, 1 May 2007 14:47:36 GMT (envelope-from matteo) Message-Id: <200705011447.l41ElaQw087939@repoman.freebsd.org> From: Matteo Riondato Date: Tue, 1 May 2007 14:47:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/rpcbind rpcbind.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 14:47:36 -0000 matteo 2007-05-01 14:47:36 UTC FreeBSD src repository Modified files: usr.sbin/rpcbind rpcbind.c Log: Correctly inizialize local/unix transport. I broke it in rev.1.15. PR: bin/1122566 MFC after: 1 week Revision Changes Path 1.16 +162 -97 src/usr.sbin/rpcbind/rpcbind.c From owner-cvs-src@FreeBSD.ORG Tue May 1 15:02:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F31DD16A401; Tue, 1 May 2007 15:02:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CD77E13C447; Tue, 1 May 2007 15:02:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41F2I0o090717; Tue, 1 May 2007 15:02:18 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41F2IVA090716; Tue, 1 May 2007 15:02:18 GMT (envelope-from marius) Message-Id: <200705011502.l41F2IVA090716@repoman.freebsd.org> From: Marius Strobl Date: Tue, 1 May 2007 15:02:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sparc64/sparc64 upa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 15:02:19 -0000 marius 2007-05-01 15:02:18 UTC FreeBSD src repository Modified files: sys/sparc64/sparc64 upa.c Log: Make the rman(9) workaround actually work. The main problem was that the UPA_IMR2 resource is also shared with/a subset of the Schizo PCI bus B CSR bank. I'm not entirely sure how this previously managed to escape testing... Revision Changes Path 1.8 +31 -26 src/sys/sparc64/sparc64/upa.c From owner-cvs-src@FreeBSD.ORG Tue May 1 15:44:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 734D416A400; Tue, 1 May 2007 15:44:20 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6507D13C457; Tue, 1 May 2007 15:44:20 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41FiK1c000247; Tue, 1 May 2007 15:44:20 GMT (envelope-from rafan@repoman.freebsd.org) Received: (from rafan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41FiK1F000244; Tue, 1 May 2007 15:44:20 GMT (envelope-from rafan) Message-Id: <200705011544.l41FiK1F000244@repoman.freebsd.org> From: Rong-En Fan Date: Tue, 1 May 2007 15:44:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/top commands.c machine.h top.X top.c src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 15:44:20 -0000 rafan 2007-05-01 15:44:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/top commands.c machine.h top.X top.c usr.bin/top machine.c Log: MFC the top -j switch: - Add a new 'j' switch and runtime option to toggle display jail id for each process. src/contrib/top/commands.c: 1.13 src/contrib/top/machine.h: 1.8 src/contrib/top/top.X: 1.18 src/contrib/top/top.c: 1.21 and 1.22 (-j part) src/usr.bin/top/machine.c: 1.80 PR: 98489, 99631 Submitted by: clsung Approved by: delphij (mentor) Revision Changes Path 1.12.2.1 +3 -2 src/contrib/top/commands.c 1.7.2.1 +2 -1 src/contrib/top/machine.h 1.12.2.3 +17 -4 src/contrib/top/top.X 1.17.2.2 +21 -6 src/contrib/top/top.c 1.74.2.2 +48 -10 src/usr.bin/top/machine.c From owner-cvs-src@FreeBSD.ORG Tue May 1 16:02:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A1E0E16A407; Tue, 1 May 2007 16:02:44 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9126513C48C; Tue, 1 May 2007 16:02:44 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41G2irF003627; Tue, 1 May 2007 16:02:44 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41G2iRx003626; Tue, 1 May 2007 16:02:44 GMT (envelope-from ache) Message-Id: <200705011602.l41G2iRx003626@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Tue, 1 May 2007 16:02:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat pstat.c src/usr.sbin/sade main.c variable.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 16:02:44 -0000 ache 2007-05-01 16:02:44 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c sys/sys param.h usr.bin/limits limits.c usr.bin/env env.c usr.sbin/sysinstall main.c variable.c usr.sbin/pstat pstat.c usr.sbin/sade main.c variable.c bin/sh var.c usr.bin/login login.c usr.bin/su su.c libexec/pppoed pppoed.c usr.bin/du du.c bin/df df.c include stdlib.h Log: Back out all POSIXified *env() changes. Not because I admit they are technically wrong and not because of bug reports (I receive nothing). But because I surprisingly meets so strong opposition and resistance so lost any desire to continue that. Anyone who interested in POSIX can dig out what changes and how through cvs diffs. Revision Changes Path 1.70 +4 -4 src/bin/df/df.c 1.35 +4 -9 src/bin/sh/var.c 1.64 +2 -2 src/include/stdlib.h 1.26 +18 -35 src/lib/libc/stdlib/getenv.3 1.8 +2 -5 src/lib/libc/stdlib/getenv.c 1.6 +11 -37 src/lib/libc/stdlib/putenv.c 1.14 +10 -19 src/lib/libc/stdlib/setenv.c 1.26 +4 -4 src/libexec/pppoed/pppoed.c 1.293 +1 -1 src/sys/sys/param.h 1.41 +3 -3 src/usr.bin/du/du.c 1.18 +3 -3 src/usr.bin/env/env.c 1.16 +2 -2 src/usr.bin/limits/limits.c 1.105 +2 -2 src/usr.bin/login/login.c 1.85 +2 -3 src/usr.bin/su/su.c 1.101 +3 -3 src/usr.sbin/pstat/pstat.c 1.79 +1 -1 src/usr.sbin/sade/main.c 1.41 +1 -1 src/usr.sbin/sade/variable.c 1.76 +1 -1 src/usr.sbin/sysinstall/main.c 1.39 +1 -1 src/usr.sbin/sysinstall/variable.c From owner-cvs-src@FreeBSD.ORG Tue May 1 16:19:28 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8DD1F16A400; Tue, 1 May 2007 16:19:28 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6814B13C458; Tue, 1 May 2007 16:19:28 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41GJS4f008710; Tue, 1 May 2007 16:19:28 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41GJSmi008709; Tue, 1 May 2007 16:19:28 GMT (envelope-from marius) Message-Id: <200705011619.l41GJSmi008709@repoman.freebsd.org> From: Marius Strobl Date: Tue, 1 May 2007 16:19:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sparc64/sparc64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 16:19:28 -0000 marius 2007-05-01 16:19:28 UTC FreeBSD src repository Modified files: sys/sparc64/sparc64 machdep.c Log: Use the VIS-based Spitfire version of the page copying and zeroing functions with CPUs they apply to only, otherwise default to the plain C functions. This is modeled in a way so that f.e. a Cheetah version of these functions can be inserted easily. Revision Changes Path 1.135 +12 -5 src/sys/sparc64/sparc64/machdep.c From owner-cvs-src@FreeBSD.ORG Tue May 1 16:31:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DCC8516A400; Tue, 1 May 2007 16:31:02 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CD32013C45A; Tue, 1 May 2007 16:31:02 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41GV2MO010940; Tue, 1 May 2007 16:31:02 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41GV2Pw010927; Tue, 1 May 2007 16:31:02 GMT (envelope-from rwatson) Message-Id: <200705011631.l41GV2Pw010927@repoman.freebsd.org> From: Robert Watson Date: Tue, 1 May 2007 16:31:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_usrreq.c udp_usrreq.c src/sys/netinet6 in6_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 16:31:03 -0000 rwatson 2007-05-01 16:31:02 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_usrreq.c udp_usrreq.c sys/netinet6 in6_pcb.c Log: Remove unused pcbinfo arguments to in_setsockaddr() and in_setpeeraddr(). Revision Changes Path 1.190 +2 -4 src/sys/netinet/in_pcb.c 1.97 +2 -2 src/sys/netinet/in_pcb.h 1.125 +2 -2 src/sys/netinet/ip_divert.c 1.172 +2 -2 src/sys/netinet/raw_ip.c 1.151 +2 -2 src/sys/netinet/tcp_usrreq.c 1.205 +2 -2 src/sys/netinet/udp_usrreq.c 1.77 +2 -2 src/sys/netinet6/in6_pcb.c From owner-cvs-src@FreeBSD.ORG Tue May 1 16:50:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 46A5C16A40A; Tue, 1 May 2007 16:50:06 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 18EB213C46E; Tue, 1 May 2007 16:50:05 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41Go4XG022565; Tue, 1 May 2007 16:50:04 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41Go32T022564; Tue, 1 May 2007 16:50:03 GMT (envelope-from emax) Message-Id: <200705011650.l41Go32T022564@repoman.freebsd.org> From: Maksim Yevmenkin Date: Tue, 1 May 2007 16:50:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src ObsoleteFiles.inc src/share/examples Makefile src/share/examples/netgraph/bluetooth rc.bluetooth X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 16:50:06 -0000 emax 2007-05-01 16:50:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) . ObsoleteFiles.inc share/examples Makefile Removed files: (Branch: RELENG_6) share/examples/netgraph/bluetooth rc.bluetooth Log: MFC: Retire /usr/share/examples/netgraph/bluetooth/rc.bluetooth. Revision Changes Path 1.25.2.16 +2 -0 src/ObsoleteFiles.inc 1.48.2.1 +0 -1 src/share/examples/Makefile 1.2.2.1 +0 -267 src/share/examples/netgraph/bluetooth/rc.bluetooth (dead) From owner-cvs-src@FreeBSD.ORG Tue May 1 17:10:03 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ED2B416A401; Tue, 1 May 2007 17:10:03 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C740C13C458; Tue, 1 May 2007 17:10:03 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41HA3Qd026957; Tue, 1 May 2007 17:10:03 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41HA3Gt026955; Tue, 1 May 2007 17:10:03 GMT (envelope-from alc) Message-Id: <200705011710.l41HA3Gt026955@repoman.freebsd.org> From: Alan Cox Date: Tue, 1 May 2007 17:10:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 17:10:04 -0000 alc 2007-05-01 17:10:02 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_misc.c Log: Eliminate the use of Giant from ia64-specific code in freebsd32_mmap(). Revision Changes Path 1.63 +1 -6 src/sys/compat/freebsd32/freebsd32_misc.c From owner-cvs-src@FreeBSD.ORG Tue May 1 17:31:33 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7887A16A403; Tue, 1 May 2007 17:31:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 34BB613C4C1; Tue, 1 May 2007 17:31:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.14.0/8.14.0/NETPLEX) with ESMTP id l41HCChW004897; Tue, 1 May 2007 13:12:12 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.ntplx.net [204.213.176.10]); Tue, 01 May 2007 13:12:12 -0400 (EDT) Date: Tue, 1 May 2007 13:12:12 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "Andrey A. Chernov" In-Reply-To: <200705011602.l41G2iRx003626@repoman.freebsd.org> Message-ID: References: <200705011602.l41G2iRx003626@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat pstat.c src/usr.sbin/sade main.c variable.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 17:31:33 -0000 On Tue, 1 May 2007, Andrey A. Chernov wrote: > ache 2007-05-01 16:02:44 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c > sys/sys param.h > usr.bin/limits limits.c > usr.bin/env env.c > usr.sbin/sysinstall main.c variable.c > usr.sbin/pstat pstat.c > usr.sbin/sade main.c variable.c > bin/sh var.c > usr.bin/login login.c > usr.bin/su su.c > libexec/pppoed pppoed.c > usr.bin/du du.c > bin/df df.c > include stdlib.h > Log: > Back out all POSIXified *env() changes. > > Not because I admit they are technically wrong and not because of bug > reports (I receive nothing). But because I surprisingly meets so > strong opposition and resistance so lost any desire to continue that. Uh, please put them back in. This is -current and we do want to be conformant with POSIX where possible. -- DE From owner-cvs-src@FreeBSD.ORG Tue May 1 17:53:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 27E5E16A400; Tue, 1 May 2007 17:53:24 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp7.server.rpi.edu (smtp7.server.rpi.edu [128.113.2.227]) by mx1.freebsd.org (Postfix) with ESMTP id DABE613C459; Tue, 1 May 2007 17:53:21 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp7.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l41HrIM7012271; Tue, 1 May 2007 13:53:19 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <200705011602.l41G2iRx003626@repoman.freebsd.org> Date: Tue, 1 May 2007 13:53:17 -0400 To: Daniel Eischen , "Andrey A. Chernov" From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-RPI-SA-Score: undef - spam scanning disabled X-CanItPRO-Stream: default X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.227 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 17:53:24 -0000 At 1:12 PM -0400 5/1/07, Daniel Eischen wrote: >On Tue, 1 May 2007, Andrey A. Chernov wrote: >> >> Modified files: >> lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c >> sys/sys param.h >> usr.bin/limits limits.c >> usr.bin/env env.c >> usr.sbin/sysinstall main.c variable.c >> usr.sbin/pstat pstat.c >> usr.sbin/sade main.c variable.c >> bin/sh var.c >> usr.bin/login login.c >> usr.bin/su su.c >> libexec/pppoed pppoed.c >> usr.bin/du du.c >> bin/df df.c >> include stdlib.h >> Log: >> Back out all POSIXified *env() changes. > >Uh, please put them back in. This is -current and we do want >to be conformant with POSIX where possible. I know you (Andrey) have gotten a lot of flak about the changes to getenv/putenv, and I do think the changes to those routines could have been phased in a better way than they were. But I expect the fixes to *other* programs (such as usr.bin/env) could be committed without causing any trouble for anyone. If that's true, then we might as well leave those changes in. -- Garance Alistair Drosehn = drosehn@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Tue May 1 18:07:28 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BB80416A46C; Tue, 1 May 2007 18:07:28 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 943EC13C489; Tue, 1 May 2007 18:07:28 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41I7S1p038965; Tue, 1 May 2007 18:07:28 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41I7Spe038964; Tue, 1 May 2007 18:07:28 GMT (envelope-from marcel) Message-Id: <200705011807.l41I7Spe038964@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:07:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/powerpc/powermac uninorth.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:07:28 -0000 marcel 2007-05-01 18:07:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/powerpc/powermac uninorth.c Log: MFC rev 1.15: When writing to PCI configuration registers, don't immediately read the same register back. Revision Changes Path 1.13.2.1 +0 -3 src/sys/powerpc/powermac/uninorth.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:08:51 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E159E16A408; Tue, 1 May 2007 18:08:51 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B8B5C13C480; Tue, 1 May 2007 18:08:51 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41I8p2C039080; Tue, 1 May 2007 18:08:51 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41I8p5E039079; Tue, 1 May 2007 18:08:51 GMT (envelope-from marcel) Message-Id: <200705011808.l41I8p5E039079@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:08:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/uart uart_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:08:52 -0000 marcel 2007-05-01 18:08:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/uart uart_core.c Log: MFC rev 1.21: match all system-devices; don't stop after the first match. Revision Changes Path 1.13.2.2 +1 -1 src/sys/dev/uart/uart_core.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:19:34 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B780916A400; Tue, 1 May 2007 18:19:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id DF68E13C484; Tue, 1 May 2007 18:19:33 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l41IJV34024391; Tue, 1 May 2007 14:19:31 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Peter Jeremy Date: Tue, 1 May 2007 12:10:11 -0400 User-Agent: KMail/1.9.6 References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070501000242.GA19510@nagual.pp.ru> <20070501100642.GB823@turion.vk2pj.dyndns.org> In-Reply-To: <20070501100642.GB823@turion.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200705011210.12839.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 01 May 2007 14:19:31 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3189/Tue May 1 12:02:13 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Alfred Perlstein , Andrey Chernov , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:19:34 -0000 On Tuesday 01 May 2007 06:06:42 am Peter Jeremy wrote: > On 2007-May-01 04:02:42 +0400, Andrey Chernov wrote: > >On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: > >> I think Alfred is absolutely right, and this is a pretty major > >> POLA violation. > > > >That's -current for. Do you suggest to wait yet more N years to commit > >exact that stuff? > > I would have expected this proposed change to get a heads-up in > current@ first. _Especially_ since there is a current thread in > current@ about fixing some long-standing memory leaks in our *env() > functions. Implementing a major POLA violation without any warning > whilst other changes to the same code are being discussed in one of > the mailing lists could be seen as impolite. I already talked with ache@ about that, and his changes are completely orthogonal to the setenv(3) fixes. Now, that said, apparently some folks on this list CAN'T READ. Linux has the new putenv() algorithm already, so if any software breaks with this, it is _ALREADY_ broken on Linux. Please consider that before ripping ache@ a new one here. As much as BSD wants to feel really important, in truth, most of the software in ports probably runs more often on Linux than on BSD, so I think the chances of non-trivial real-world breakage are fairly small. So with all that said, it seems we have four groups of usage with respect to putenv(3): - give it a stack allocated or otherwise non-persistent buffer (note that string constants are persistent, even if they are read-only) as the first argument. This violates POSIX I guess, and would break on at least Linux and Solaris (judging by Open Solaris's putenv() implementation). - pass in a persistent buffer (constant, allocated memory, etc.) and change the contents later expecting that changing the buffer won't change the environment. This breaks Linux and Solaris and POSIX as well. - pass in a persistent buffer and don't change it afterwards (at least not until after a later call to putenv or setenv for the same variable). This works for both impls and is probably the vast majority of usage. - pass in a persistent buffer and change the contents expecting that it will change the value returned from getenv(). This doesn't work on BSD, but does on Linux + Solaris + POSIX + FreeBSD 7. So we have four groups: 1, 2, 3 (likely the vast majority), and 4. (4) is fixed by this commit, and works on Linux, Solaris, and POSIX. (1 + 2) are broken by this commit, but they also don't work on Linux, Solaris, or POSIX. So the question seems to be, which set is larger, programs that depend on (1 + 2), or programs that depend on (4)? Also, which set is going to get larger as time moves on given Linux's implementation? If you assume (as I do), that most programs fall into (3) anyway, then it really isn't all that important anyway. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue May 1 18:21:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B977A16A401; Tue, 1 May 2007 18:21:25 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 924B113C483; Tue, 1 May 2007 18:21:25 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41ILPsm041485; Tue, 1 May 2007 18:21:25 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41ILPUX041482; Tue, 1 May 2007 18:21:25 GMT (envelope-from marcel) Message-Id: <200705011821.l41ILPUX041482@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:21:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mii mii.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:21:25 -0000 marcel 2007-05-01 18:21:24 UTC FreeBSD src repository Modified files: sys/dev/mii mii.c Log: Define the miibus ivars as a structure, instead of as a vector of pointers. A structure is more readable and less error-prone. It also avoids problems when a function pointer doesn't have the same width as a void pointer. Revision Changes Path 1.29 +15 -14 src/sys/dev/mii/mii.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:26:22 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8B2E416A401; Tue, 1 May 2007 18:26:22 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 643FF13C44C; Tue, 1 May 2007 18:26:22 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41IQM7F042429; Tue, 1 May 2007 18:26:22 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41IQMjM042428; Tue, 1 May 2007 18:26:22 GMT (envelope-from marcel) Message-Id: <200705011826.l41IQMjM042428@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:26:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Cc: Subject: cvs commit: src/contrib/gdb/gdb ppcfbsd-nat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:26:22 -0000 marcel 2007-05-01 18:26:22 UTC FreeBSD src repository Modified files: (Branch: FSF) contrib/gdb/gdb ppcfbsd-nat.c Log: Define supply_gregset() and supply_fpregset(). They are needed by our threading support. Revision Changes Path 1.1.1.2 +12 -0 src/contrib/gdb/gdb/ppcfbsd-nat.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:28:08 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7503B16A40E; Tue, 1 May 2007 18:28:08 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4DF8113C4C7; Tue, 1 May 2007 18:28:08 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41IS8bq042552; Tue, 1 May 2007 18:28:08 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41IS8BU042551; Tue, 1 May 2007 18:28:08 GMT (envelope-from marcel) Message-Id: <200705011828.l41IS8BU042551@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:28:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthread_db/arch/powerpc libpthread_md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:28:08 -0000 marcel 2007-05-01 18:28:08 UTC FreeBSD src repository Modified files: lib/libthread_db/arch/powerpc libpthread_md.c Log: Roughly implement libpthread support. Revision Changes Path 1.2 +19 -1 src/lib/libthread_db/arch/powerpc/libpthread_md.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:29:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BDA7D16A406; Tue, 1 May 2007 18:29:34 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9568013C44B; Tue, 1 May 2007 18:29:34 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41ITYoU042661; Tue, 1 May 2007 18:29:34 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41ITYZW042660; Tue, 1 May 2007 18:29:34 GMT (envelope-from marcel) Message-Id: <200705011829.l41ITYZW042660@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 May 2007 18:29:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/arch/powerpc Makefile init.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:29:34 -0000 marcel 2007-05-01 18:29:34 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/arch/powerpc Makefile init.c Log: Add threading support. Revision Changes Path 1.2 +1 -1 src/gnu/usr.bin/gdb/arch/powerpc/Makefile 1.2 +2 -0 src/gnu/usr.bin/gdb/arch/powerpc/init.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:34:07 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C580A16A40A; Tue, 1 May 2007 18:34:07 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 716D313C48C; Tue, 1 May 2007 18:34:07 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5FF4A.dip.t-dialin.net [84.165.255.74]) by redbull.bpaserver.net (Postfix) with ESMTP id AB96D2E12E; Tue, 1 May 2007 20:33:59 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id C0C0B5B48A0; Tue, 1 May 2007 20:33:44 +0200 (CEST) Date: Tue, 1 May 2007 20:33:56 +0200 From: Alexander Leidinger To: Roman Kurakin Message-ID: <20070501203356.739710f8@deskjail> In-Reply-To: <46372416.3020509@inse.ru> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> <46372416.3020509@inse.ru> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.11; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: Peter Jeremy , src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:34:07 -0000 Quoting Roman Kurakin (Tue, 01 May 2007 15:27:18 +0400): > Peter Jeremy wrote: > > Note that just building the ports with these changes will not demonstrate > > much. This change alters the functionality of putenv() rather than the > > API/ABI so testing the change requires exercising the ports. This is > > a much more difficult task. > > > I suggest to install all ports sources and grep them at first. I am sure > some of ports > could be marked as bug-less and other should be marked for exec-check or > probably > for more accurate review not just grep. I can not remember to have seen something like this in the past 5 years since I'm a committer or since the last ... maybe 8 or 10 years since I follow current@ and cvs-all@. And there where a lot of changes which affected the ports. And may I remind you that we talk about following POSIX so most of the programs we have in the ports should be ok? I agree that it may have been more nice if there was a HEADS-UP first (the age old behavior changes), and I agree that re@ should have had a chance to voice their opinion, but after reading all the mails so far I would say a lot of people are exaggerating. Andrey, if it helps, here are some virtual hugs from me. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Tue May 1 18:47:31 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 37D5F16A401; Tue, 1 May 2007 18:47:31 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id D579A13C45A; Tue, 1 May 2007 18:47:30 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.66 (FreeBSD)) (envelope-from ) id 1HixAQ-0002Xs-TM; Tue, 01 May 2007 19:33:38 +0100 Date: Tue, 1 May 2007 19:33:38 +0100 From: Ceri Davies To: "Andrey A. Chernov" Message-ID: <20070501183338.GB77408@submonkey.net> References: <200705011602.l41G2iRx003626@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QUAc4O4i7jPlU8jt" Content-Disposition: inline In-Reply-To: <200705011602.l41G2iRx003626@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.15 (2007-04-06) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat pstat.c src/usr.sbin/sade main.c variable.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:47:31 -0000 --QUAc4O4i7jPlU8jt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 04:02:44PM +0000, Andrey A. Chernov wrote: > ache 2007-05-01 16:02:44 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c=20 > sys/sys param.h=20 > usr.bin/limits limits.c=20 > usr.bin/env env.c=20 > usr.sbin/sysinstall main.c variable.c=20 > usr.sbin/pstat pstat.c=20 > usr.sbin/sade main.c variable.c=20 > bin/sh var.c=20 > usr.bin/login login.c=20 > usr.bin/su su.c=20 > libexec/pppoed pppoed.c=20 > usr.bin/du du.c=20 > bin/df df.c=20 > include stdlib.h=20 > Log: > Back out all POSIXified *env() changes. > =20 > Not because I admit they are technically wrong and not because of bug > reports (I receive nothing). But because I surprisingly meets so > strong opposition and resistance so lost any desire to continue that. I'm sorry that you have backed this out and I don't wish to add to any annoyances you have at the moment, but I'm slightly uncomfortable about __FreeBSD_version going backwards. Shouldn't it rather be bumped to 700039? Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --QUAc4O4i7jPlU8jt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGN4gCocfcwTS3JF8RApoNAKCBEFnOXtkGICqWHZb5/3Sy7S5ZVgCggCdR 5RILBzmYEd8MheUyBeGiJW8= =pUr/ -----END PGP SIGNATURE----- --QUAc4O4i7jPlU8jt-- From owner-cvs-src@FreeBSD.ORG Tue May 1 18:48:17 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E4C9816A407; Tue, 1 May 2007 18:48:17 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from smtp2.yandex.ru (smtp2.yandex.ru [213.180.200.18]) by mx1.freebsd.org (Postfix) with ESMTP id 03BC313C45B; Tue, 1 May 2007 18:48:16 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from [195.151.56.187] ([195.151.56.187]:14315 "EHLO nx7400.local.domain" smtp-auth: "cvs-src" TLS-CIPHER: TLS-PEER-CN1: ) by mail.yandex.ru with ESMTP id S3375580AbXEASg6 (ORCPT + 1 other); Tue, 1 May 2007 22:36:58 +0400 X-Comment: RFC 2476 MSA function at smtp2.yandex.ru logged sender identity as: cvs-src Message-ID: <4637C0B0.70000@yandex.ru> Date: Tue, 01 May 2007 22:35:28 +0000 From: "R.Mahmatkhanov" User-Agent: Thunderbird 2.0.0.0 (X11/20070421) MIME-Version: 1.0 To: Maxim Konovalov References: <200704282031.l3SKVVEV024819@repoman.freebsd.org> In-Reply-To: <200704282031.l3SKVVEV024819@repoman.freebsd.org> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org Subject: Re: [OBORONA-SPAM] cvs commit: src/sys/dev/usb uplcom.c usb_quirks.c usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:48:18 -0000 Maxim Konovalov ïèøạ̊: > maxim 2007-04-28 20:31:31 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/usb uplcom.c usb_quirks.c usbdevs > Log: > MFC revs. 1.289, 1.291 usbdevs, rev. 1.58 usb_quirks.c: add several > CDMA-2000 terminals. > MFC rev. 1.290 usbdevs, rev. 1.41 uplcom.c: add a quirk for Sagem > USB-Serial controller. > > Revision Changes Path > 1.29.2.4 +2 -0 src/sys/dev/usb/uplcom.c > 1.41.2.8 +12 -1 src/sys/dev/usb/usb_quirks.c > 1.232.2.23 +13 -1 src/sys/dev/usb/usbdevs Much thanks! You can close PR 81191 ("Support for Curitel HX-550C USB modem to 5.4 RELEASE") by merging it into RELENG_5 ;) From owner-cvs-src@FreeBSD.ORG Tue May 1 18:50:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 173D316A40A; Tue, 1 May 2007 18:50:34 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E414B13C4CA; Tue, 1 May 2007 18:50:33 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41IoXOn047381; Tue, 1 May 2007 18:50:33 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41IoXKO047380; Tue, 1 May 2007 18:50:33 GMT (envelope-from yar) Message-Id: <200705011850.l41IoXKO047380@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 1 May 2007 18:50:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libutil login_class.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:50:34 -0000 yar 2007-05-01 18:50:33 UTC FreeBSD src repository Modified files: lib/libutil login_class.c Log: Fix one kind of style(9) bug and a typo in a comment. Tested with: md5(1) Revision Changes Path 1.25 +5 -5 src/lib/libutil/login_class.c From owner-cvs-src@FreeBSD.ORG Tue May 1 18:52:50 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6492516A401; Tue, 1 May 2007 18:52:50 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id BD10013C480; Tue, 1 May 2007 18:52:49 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41IqmDS011020; Tue, 1 May 2007 22:52:48 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41Iqmwo011019; Tue, 1 May 2007 22:52:48 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 22:52:48 +0400 From: Andrey Chernov To: Daniel Eischen Message-ID: <20070501185248.GA10323@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Daniel Eischen , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200705011602.l41G2iRx003626@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat pstat.c src/usr.sbin/sade main.c variable.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:52:50 -0000 On Tue, May 01, 2007 at 01:12:12PM -0400, Daniel Eischen wrote: > > Not because I admit they are technically wrong and not because of bug > > reports (I receive nothing). But because I surprisingly meets so > > strong opposition and resistance so lost any desire to continue that. > > Uh, please put them back in. This is -current and we do want > to be conformant with POSIX where possible. And I think exacly so, but read others negative opinions and my answers explaining why I disagree with each point respectively, if you wish. There is lots of strange things like people falsely accuse me that I stamp to other shoes changing the code even without reading my code, treating putenv() like BSD POLA even not looking first where it appearse and so on. Then imagine what happens in case first broken port will be ever found. The same wave again, with new persons added with the same points, I can't. I perefer technical concrete real reasons (like "what is broken?") and to write/fix soft, not to talk and feel pressure. Especially when talk is so uneasy. I really have bad luck because this changes are nothing compared to f.e. objformat disaster we hit (and still not recovered until now), but strangely I don't saw such strong resistance or opposition to objformat removing or strong demands to return it back (in the matter of question, I think objformat removal is good). I almost agree with two opinions only: 1) We are in the code slush, changes must be reviewed by re@ 2) We need to discuss/test that before commit. And Backout will be good for this two. Now changes are in the cvs diffs form and re@ or anyone other are able to review/test, if they wish. In case changes will be found acceptable at some moment, anybody is free to commit them too, I can't. If someone will be lacky enough to restore them in any form I promise my help fixing software bugs in case they appearse. Back to the matter - why I don't do that initially? I never thought that minimal code (most files are 1 line changes) cleanly implementing standards conformance may require special re@ attention or before-discussion because I already fix all base and expect only few ports failing (if any, because ports are usually portable or Linux supported). -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 18:59:47 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6FC3E16A400; Tue, 1 May 2007 18:59:47 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id E198813C4BD; Tue, 1 May 2007 18:59:46 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41IxjNE011105; Tue, 1 May 2007 22:59:45 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41Ixjgv011104; Tue, 1 May 2007 22:59:45 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 22:59:45 +0400 From: Andrey Chernov To: Garance A Drosehn Message-ID: <20070501185945.GB10323@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Garance A Drosehn , Daniel Eischen , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200705011602.l41G2iRx003626@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Daniel Eischen , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:59:47 -0000 On Tue, May 01, 2007 at 01:53:17PM -0400, Garance A Drosehn wrote: > But I expect the fixes to *other* programs (such as usr.bin/env) > could be committed without causing any trouble for anyone. If > that's true, then we might as well leave those changes in. Yes, they could, they are backward-compatible. But I can't (read my answer to Daniel in this thread, why). I fear more people comes tempting to say like they are unneccessary or they leak memory or I can't imagine what. Feel free to restore what you like, perhaps you have better luck (or better communication skills?) than me. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 19:03:42 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B270716A404; Tue, 1 May 2007 19:03:42 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8A73713C4C7; Tue, 1 May 2007 19:03:42 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41J3g7k051367; Tue, 1 May 2007 19:03:42 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41J3g3X051366; Tue, 1 May 2007 19:03:42 GMT (envelope-from ache) Message-Id: <200705011903.l41J3g3X051366@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Tue, 1 May 2007 19:03:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:03:42 -0000 ache 2007-05-01 19:03:42 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump FreeBSD_version to not have it going backwards. Asked by: Ceri Davies Revision Changes Path 1.294 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Tue May 1 19:07:47 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 454A016A406; Tue, 1 May 2007 19:07:47 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 9E08413C465; Tue, 1 May 2007 19:07:46 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l41J7h1L055834; Tue, 1 May 2007 23:07:43 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l41J7gYs055829; Tue, 1 May 2007 23:07:42 +0400 (MSD) (envelope-from yar) Date: Tue, 1 May 2007 23:07:42 +0400 From: Yar Tikhiy To: Ceri Davies Message-ID: <20070501190742.GC51428@comp.chem.msu.su> References: <200704260639.l3Q6d1SH027885@repoman.freebsd.org> <20070426105458.GA98415@nevermind.kiev.ua> <20070426114638.GC77408@submonkey.net> <20070427160740.GF3991@comp.chem.msu.su> <20070430131503.GY77408@submonkey.net> <20070430134227.GG32601@comp.chem.msu.su> <20070430134617.GZ77408@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430134617.GZ77408@submonkey.net> User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, Alexandr Kovalenko , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:07:47 -0000 On Mon, Apr 30, 2007 at 02:46:18PM +0100, Ceri Davies wrote: > On Mon, Apr 30, 2007 at 05:42:28PM +0400, Yar Tikhiy wrote: > > On Mon, Apr 30, 2007 at 02:15:04PM +0100, Ceri Davies wrote: > > > > > > Well, we currently have an *NP* case as per above, but not a *LK* case, > > > so I disagree somewhat. > > > > Why? Now *LOCKED* in FreeBSD is nearly the same as *LK* in Solaris > > with the only difference being that cron or at doesn't seem to care > > about it. And a single asterisk works for us as *NP* does in > > Solaris, although it isn't a prefix, it occupies the whole password > > field. Did I miss anything? > > Well, because of the cron thing :) If we want to propagate account locking semantics to cron and atrun, which is a good idea IMHO, we should avoid code duplication. I haven't yet found a suitable place in src/lib to put the check at, but we need to find one as more checks can be done there, e.g., that for expired account because expired accounts shouldn't run scheduled jobs either. Any ideas? Of course, the most obvious way is to add the respective function to libutil, but I'm still unsure if it's the best way. -- Yar From owner-cvs-src@FreeBSD.ORG Tue May 1 19:10:39 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4DF1516A400; Tue, 1 May 2007 19:10:39 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id BC61413C448; Tue, 1 May 2007 19:10:38 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41JAbuw011322; Tue, 1 May 2007 23:10:37 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41JAbVO011321; Tue, 1 May 2007 23:10:37 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 23:10:37 +0400 From: Andrey Chernov To: Alexander Leidinger Message-ID: <20070501191037.GC10323@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , Roman Kurakin , Peter Jeremy , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> <46372416.3020509@inse.ru> <20070501203356.739710f8@deskjail> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501203356.739710f8@deskjail> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Peter Jeremy , Roman Kurakin , cvs-all@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:10:39 -0000 On Tue, May 01, 2007 at 08:33:56PM +0200, Alexander Leidinger wrote: > And may I remind you that we talk about following POSIX so most of the > programs we have in the ports should be ok? I think so too. > I agree that it may have been more nice if there was a HEADS-UP first > (the age old behavior changes), and I agree that re@ should have had a > chance to voice their opinion, but after reading all the mails so far I > would say a lot of people are exaggerating. Read my answer to Daniel in backout commit message thread where I already address this issue. > Andrey, if it helps, here are some virtual hugs from me. Thank you very much! -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 19:18:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C05D16A401; Tue, 1 May 2007 19:18:13 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0457C13C484; Tue, 1 May 2007 19:18:13 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41JICUn053745; Tue, 1 May 2007 19:18:12 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41JICFl053744; Tue, 1 May 2007 19:18:12 GMT (envelope-from jkim) Message-Id: <200705011918.l41JICFl053744@repoman.freebsd.org> From: Jung-uk Kim Date: Tue, 1 May 2007 19:18:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:18:13 -0000 jkim 2007-05-01 19:18:12 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Reflect MFC of pci_find_extcap(). MFC after: 3 days Revision Changes Path 1.189 +1 -1 src/sys/dev/bge/if_bge.c From owner-cvs-src@FreeBSD.ORG Tue May 1 19:26:14 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F11FC16A402; Tue, 1 May 2007 19:26:13 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id D75F713C468; Tue, 1 May 2007 19:26:13 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 943961A4DA4; Tue, 1 May 2007 12:26:46 -0700 (PDT) Date: Tue, 1 May 2007 12:26:46 -0700 From: Alfred Perlstein To: Andrey Chernov , Mark Linimon , Roman Kurakin , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501192646.GA67243@elvis.mu.org> References: <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501083032.GA9361@soaustin.net> <20070501084514.GA4889@nagual.pp.ru> <20070501113155.GD13868@elvis.mu.org> <20070501115133.GA6634@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501115133.GA6634@nagual.pp.ru> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:26:14 -0000 * Andrey Chernov [070501 04:52] wrote: > On Tue, May 01, 2007 at 04:31:55AM -0700, Alfred Perlstein wrote: > > If the fallout from your changes broke a bunch of things in > > -current, then we can expect the fallout in -stable to be > > even worse. > > They are not planning to go into -stable any soon until the moment when > 7.x becomes -stable, when libc version number will be bumped. I had forgotten about that. Look, Andrey. Here's what I saw: Change of functionality of a foundation of libc. Change of how a bunch of userland programs treat the environment (major security issues have been found over the years in how the environment is treated). Little (being generous here) discussion. Hard pushback on questions "can you show me any breaks". Broken head. A bunch of people complaining about ports being broken. A bunch of people complaining about current being broken. Truth be told your argument would have stood on it's own sans the "prove to me that there's breakage" as in "prove to me that there are no WMDs in Iraq". It basically seems like something that could have used some thought and discussion which would have proved helpful had it happened prior to the commit. Had a discussion taken place, and I still piped up, a "shut up Alfred, read the lists" would have sufficed. Either that, or a more lighthanded response would have been nice, "I know things are hosed, I'm going to fix and explain a bit better shortly." Your track record (a good one) would have spoken for itself. That said, sorry for giving you such a hard time, for being "one of those committers", and making you miserable for the past 12 hours. -Alfred From owner-cvs-src@FreeBSD.ORG Tue May 1 19:31:17 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9970216A402 for ; Tue, 1 May 2007 19:31:17 +0000 (UTC) (envelope-from SRS0=1e018337347624e7fd82d95b6f1736786aed428d=322=es.net=oberman@es.net) Received: from postal1.es.net (postal1.es.net [198.128.3.205]) by mx1.freebsd.org (Postfix) with ESMTP id 3871213C4E5 for ; Tue, 1 May 2007 19:31:16 +0000 (UTC) (envelope-from SRS0=1e018337347624e7fd82d95b6f1736786aed428d=322=es.net=oberman@es.net) Received: from ptavv.es.net (ptavv.es.net [198.128.4.29]) by postal1.es.net (Postal Node 1) with ESMTP (SSL) id GYQ48522; Tue, 01 May 2007 12:15:22 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id CF83F45076; Tue, 1 May 2007 12:15:21 -0700 (PDT) To: Rui Paulo In-Reply-To: Your message of "Tue, 01 May 2007 15:26:20 BST." <861wi0mxgz.wl%rpaulo@fnop.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1178046921_75116P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 01 May 2007 12:15:21 -0700 From: "Kevin Oberman" Message-Id: <20070501191521.CF83F45076@ptavv.es.net> Cc: "George V. Neville-Neil" , Darren Reed , cvs-all@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6.h in6_proto.c route6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:31:17 -0000 --==_Exmh_1178046921_75116P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Date: Tue, 01 May 2007 15:26:20 +0100 > From: Rui Paulo > Sender: owner-cvs-all@freebsd.org > > At Tue, 1 May 2007 04:33:19 +0000, > Darren Reed wrote: > > > > On Tue, Apr 24, 2007 at 11:42:42AM +0000, George V. Neville-Neil wrote: > > > gnn 2007-04-24 11:42:42 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/netinet6 in6.h in6_proto.c route6.c > > > Log: > > > Add a new sysctl net.inet.ip6.rthdr0_allowed, which is default off, > > > to disable the processing of Route Header Type 0 options in IPv6. > > > This is not really an MFC because currently in HEAD the processing > > > of these options is disabled unilateraly pending discussion at the IETF > > > on the future of such headers. > > > > Given this direction came from the IETF, is there an internet draft > > or RFC or BCP that discusses or summarises this? > > No, I don't think there is one yet. While it may take a while to get out an RFC, you can read the reasons for this change. It is the result of a presentation at CanSecWest on April 18 by Biondi and Ebalard. The PDF is available at: http://www.secdev.org/conf/IPv6_RH_security-csw07.pdf -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751 --==_Exmh_1178046921_75116P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Exmh version 2.5 06/03/2002 iD8DBQFGN5HJkn3rs5h7N1ERAm1tAJ96D3lk7uzCtpr8kbcHrKa1e5cnRQCgl/k/ A53kBVsWRrSEmzP9S4VA+Ck= =oLcr -----END PGP SIGNATURE----- --==_Exmh_1178046921_75116P-- From owner-cvs-src@FreeBSD.ORG Tue May 1 19:31:48 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1D8CE16A406; Tue, 1 May 2007 19:31:48 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 9DF9F13C448; Tue, 1 May 2007 19:31:47 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41JVkBh011480; Tue, 1 May 2007 23:31:46 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41JVkMr011479; Tue, 1 May 2007 23:31:46 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 23:31:46 +0400 From: Andrey Chernov To: John Baldwin Message-ID: <20070501193146.GD10323@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John Baldwin , Peter Jeremy , Alfred Perlstein , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070501000242.GA19510@nagual.pp.ru> <20070501100642.GB823@turion.vk2pj.dyndns.org> <200705011210.12839.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705011210.12839.jhb@freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: Peter Jeremy , Alfred Perlstein , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:31:48 -0000 On Tue, May 01, 2007 at 12:10:11PM -0400, John Baldwin wrote: > Now, that said, apparently some folks on this list CAN'T READ. > > Linux has the new putenv() algorithm already, so if any software breaks with > this, it is _ALREADY_ broken on Linux. Please consider that before ripping > ache@ a new one here. As much as BSD wants to feel really important, in > truth, most of the software in ports probably runs more often on Linux than > on BSD, so I think the chances of non-trivial real-world breakage are fairly > small. And I already tell exactly so about Linux and ports already portable in the threads. Perhaps they will hear you better, but the changes in question are already backed out and I can't work on them under such pressure. In case anyone brave will be found, feel free to restore, and then I'll promise my help dealing with all bugs they may cause. > So with all that said, it seems we have four groups of usage with respect to > putenv(3): > > - give it a stack allocated or otherwise non-persistent buffer (note that > string constants are persistent, even if they are read-only) as the first > argument. This violates POSIX I guess, and would break on at least Linux and > Solaris (judging by Open Solaris's putenv() implementation). Agreed. > - pass in a persistent buffer (constant, allocated memory, etc.) and change > the contents later expecting that changing the buffer won't change the > environment. This breaks Linux and Solaris and POSIX as well. Agreed. > - pass in a persistent buffer and don't change it afterwards (at least not > until after a later call to putenv or setenv for the same variable). This > works for both impls and is probably the vast majority of usage. Agreed. Most programs don't use the modify-env-on-the-fly feature, but it is at the current moment, just because several putenv() implementations was hanging around when no one standartized. When POSIX explicitly standartize modify-env-on-the-fly feature, more programs will tend to try it at time. > - pass in a persistent buffer and change the contents expecting that it will > change the value returned from getenv(). This doesn't work on BSD, but does > on Linux + Solaris + POSIX + FreeBSD 7. Agreed (but not for FreeBSD7 now). > So we have four groups: 1, 2, 3 (likely the vast majority), and 4. (4) is > fixed by this commit, and works on Linux, Solaris, and POSIX. (1 + 2) are > broken by this commit, but they also don't work on Linux, Solaris, or POSIX. > So the question seems to be, which set is larger, programs that depend on (1 + > 2), or programs that depend on (4)? Also, which set is going to get larger > as time moves on given Linux's implementation? If you assume (as I do), that > most programs fall into (3) anyway, then it really isn't all that important > anyway. Set 3 is larger now, but popularity of set 4 perhaps will be increased in the future because it is standard. Set 1 is small and will be decreased. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 1 19:35:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B7D4B16A404; Tue, 1 May 2007 19:35:23 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.freebsd.org (Postfix) with ESMTP id 73F2513C4C5; Tue, 1 May 2007 19:35:23 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.8/8.13.1) with ESMTP id l41JZMcN001561; Tue, 1 May 2007 15:35:22 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.8/8.13.1/Submit) id l41JZMLO001560; Tue, 1 May 2007 15:35:22 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 1 May 2007 15:35:22 -0400 From: David Schultz To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20070501193522.GA1480@VARK.MIT.EDU> Mail-Followup-To: Andrey Chernov , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070430225717.GA7008@VARK.MIT.EDU> Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:35:23 -0000 On Mon, Apr 30, 2007, David Schultz wrote: > I think Alfred is absolutely right, and this is a pretty major > POLA violation. As a result of these changes, I've got two ports > (so far) and some model checking software that won't build/run > anymore. If we've been doing something right for years, changing > it around in order to inherit SVR4 bugs seems like a bad > plan. Holding up your POSIX banner doesn't really make things > okay; POSIX wasn't written by God, and we choose to ignore various > parts of it. And considering the way various setuid programs > attempt to sanitize their environment before doing a fork/exec, > the change may very well have security implications. FWIW, the env(1) change fixes at least one of these problems (in MOPS), but I'm still rebuilding ports. I'm still a little dubious of this change nevertheless. With any luck I'll have some time to look into it this weekend and plow through some of the PRs that have been tossed my way in the past few months. From owner-cvs-src@FreeBSD.ORG Tue May 1 19:47:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9629416A401; Tue, 1 May 2007 19:47:18 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6CF3113C44B; Tue, 1 May 2007 19:47:18 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41JlIww059705; Tue, 1 May 2007 19:47:18 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41JlIoW059704; Tue, 1 May 2007 19:47:18 GMT (envelope-from maxim) Message-Id: <200705011947.l41JlIoW059704@repoman.freebsd.org> From: Maxim Konovalov Date: Tue, 1 May 2007 19:47:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 19:47:18 -0000 maxim 2007-05-01 19:47:18 UTC FreeBSD src repository Modified files: share/misc bsd-family-tree Log: o OpenBSD 4.1 added. Revision Changes Path 1.112 +2 -0 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Tue May 1 21:19:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D607916A400; Tue, 1 May 2007 21:19:59 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mrout1-b.corp.dcn.yahoo.com (mrout1-b.corp.dcn.yahoo.com [216.109.112.27]) by mx1.freebsd.org (Postfix) with ESMTP id 740E913C44B; Tue, 1 May 2007 21:19:56 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from 104.32.61.10.in-addr.arpa.neville-neil.com (proxy8.corp.yahoo.com [216.145.48.13]) by mrout1-b.corp.dcn.yahoo.com (8.13.8/8.13.8/y.out) with ESMTP id l41L9a9l035971; Tue, 1 May 2007 14:09:37 -0700 (PDT) Date: Tue, 01 May 2007 14:09:27 -0700 Message-ID: From: "George V. Neville-Neil" To: "Kevin Oberman" In-Reply-To: <20070501191521.CF83F45076@ptavv.es.net> References: <861wi0mxgz.wl%rpaulo@fnop.net> <20070501191521.CF83F45076@ptavv.es.net> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.0.95 (i386-apple-darwin8.8.2) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Rui Paulo , cvs-src@FreeBSD.org, Darren Reed , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 in6.h in6_proto.c route6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 21:19:59 -0000 At Tue, 01 May 2007 12:15:21 -0700, Kevin Oberman wrote: > > While it may take a while to get out an RFC, you can read the reasons > for this change. It is the result of a presentation at CanSecWest on > April 18 by Biondi and Ebalard. The PDF is available at: > http://www.secdev.org/conf/IPv6_RH_security-csw07.pdf This is currently being discussed on the IPv6 mailing list (see ietf.org for more info on that.) Best, George From owner-cvs-src@FreeBSD.ORG Tue May 1 22:32:28 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A94F416A40E; Tue, 1 May 2007 22:32:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 43ADC13C468; Tue, 1 May 2007 22:32:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l41MUtwL015347; Tue, 1 May 2007 16:30:55 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 01 May 2007 16:31:06 -0600 (MDT) Message-Id: <20070501.163106.1159135672.imp@bsdimp.com> To: deischen@freebsd.org From: "M. Warner Losh" In-Reply-To: References: <200705011602.l41G2iRx003626@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Tue, 01 May 2007 16:30:56 -0600 (MDT) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ache@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat pstat.c src/usr.sbin/sade main.c variable.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 22:32:28 -0000 In message: Daniel Eischen writes: : On Tue, 1 May 2007, Andrey A. Chernov wrote: : : > ache 2007-05-01 16:02:44 UTC : > : > FreeBSD src repository : > : > Modified files: : > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c : > sys/sys param.h : > usr.bin/limits limits.c : > usr.bin/env env.c : > usr.sbin/sysinstall main.c variable.c : > usr.sbin/pstat pstat.c : > usr.sbin/sade main.c variable.c : > bin/sh var.c : > usr.bin/login login.c : > usr.bin/su su.c : > libexec/pppoed pppoed.c : > usr.bin/du du.c : > bin/df df.c : > include stdlib.h : > Log: : > Back out all POSIXified *env() changes. : > : > Not because I admit they are technically wrong and not because of bug : > reports (I receive nothing). But because I surprisingly meets so : > strong opposition and resistance so lost any desire to continue that. : : Uh, please put them back in. This is -current and we do want : to be conformant with POSIX where possible. PLEASE! Let's have a discussion on arch@ about the issues with doing this before we make more changes! Warner From owner-cvs-src@FreeBSD.ORG Tue May 1 23:33:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BF53B16A400; Tue, 1 May 2007 23:33:13 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9635313C457; Tue, 1 May 2007 23:33:13 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l41NXD5D012710; Tue, 1 May 2007 23:33:13 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l41NXDMq012708; Tue, 1 May 2007 23:33:13 GMT (envelope-from pjd) Message-Id: <200705012333.l41NXDMq012708@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 1 May 2007 23:33:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/geom/class/eli geom_eli.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 23:33:13 -0000 pjd 2007-05-01 23:33:12 UTC FreeBSD src repository Modified files: sbin/geom/class/eli geom_eli.c Log: Do some cleanups (like freeing memory and closing file descriptors) before leaving the functions. Revision Changes Path 1.22 +6 -6 src/sbin/geom/class/eli/geom_eli.c From owner-cvs-src@FreeBSD.ORG Wed May 2 00:09:34 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B83DD16A402; Wed, 2 May 2007 00:09:34 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 90D6A13C44B; Wed, 2 May 2007 00:09:34 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4209Yks019365; Wed, 2 May 2007 00:09:34 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4209Ybs019364; Wed, 2 May 2007 00:09:34 GMT (envelope-from pjd) Message-Id: <200705020009.l4209Ybs019364@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 00:09:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:09:34 -0000 pjd 2007-05-02 00:09:34 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vfsops.c Log: - Lock vnode with flags passed in as argument in zfs_vget() and zfs_root(). Pointed out by: ups Also reported by: kris - Add comments where I'm not sure if LK_RETRY should be used. Revision Changes Path 1.9 +4 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Wed May 2 00:18:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5EB7816A400; Wed, 2 May 2007 00:18:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 374A313C44B; Wed, 2 May 2007 00:18:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l420INgb021409; Wed, 2 May 2007 00:18:23 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l420INTJ021408; Wed, 2 May 2007 00:18:23 GMT (envelope-from pjd) Message-Id: <200705020018.l420INTJ021408@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 00:18:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c zfs_znode.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:18:23 -0000 pjd 2007-05-02 00:18:22 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c zfs_znode.c Log: ZFS should update timestamps upon the creat() of an existing file. Obtained from: OpenSolaris Bug: http://bugs.opensolaris.org/view_bug.do?bug_id=6465105 Revision Changes Path 1.18 +2 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.6 +3 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c From owner-cvs-src@FreeBSD.ORG Wed May 2 00:22:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 45DD616A400; Wed, 2 May 2007 00:22:13 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1E49513C469; Wed, 2 May 2007 00:22:13 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l420MCsj022323; Wed, 2 May 2007 00:22:13 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l420MCLv022322; Wed, 2 May 2007 00:22:12 GMT (envelope-from pjd) Message-Id: <200705020022.l420MCLv022322@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 00:22:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_znode.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:22:13 -0000 pjd 2007-05-02 00:22:12 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_znode.c Log: The getnewvnode() function sets LK_NOSHARE by default, so if we want to support shared vnodes locking, we need to remove that flag. Also add LK_CANRECURSE flag as found in nfsclient. Revision Changes Path 1.7 +9 -3 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c From owner-cvs-src@FreeBSD.ORG Wed May 2 00:33:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 312F016A400; Wed, 2 May 2007 00:33:46 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id C8A6F13C43E; Wed, 2 May 2007 00:33:44 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 87352487F5; Wed, 2 May 2007 02:33:43 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 4D15A48A27; Wed, 2 May 2007 02:33:38 +0200 (CEST) Date: Wed, 2 May 2007 02:33:07 +0200 From: Pawel Jakub Dawidek To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070502003307.GF71308@garage.freebsd.pl> References: <200705020018.l420INTJ021408@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dgjlcl3Tl+kb3YDk" Content-Disposition: inline In-Reply-To: <200705020018.l420INTJ021408@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: Subject: Re: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c zfs_znode.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:33:46 -0000 --dgjlcl3Tl+kb3YDk Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 02, 2007 at 12:18:22AM +0000, Pawel Jakub Dawidek wrote: > pjd 2007-05-02 00:18:22 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c=20 > zfs_znode.c=20 > Log: > ZFS should update timestamps upon the creat() of an existing file. > =20 > Obtained from: OpenSolaris > Bug: http://bugs.opensolaris.org/view_bug.do?bug_id=3D6465105 Not related to FreeBSD, just to keep the source in sync. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --dgjlcl3Tl+kb3YDk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGN9xDForvXbEpPzQRAj7nAKCq8EbeJY+k+8/qCiZxLyq0GZ6UtQCfdag3 RpgmudGzujNet6ORTyVd1XI= =Wt81 -----END PGP SIGNATURE----- --dgjlcl3Tl+kb3YDk-- From owner-cvs-src@FreeBSD.ORG Wed May 2 00:39:52 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B0BC216A402; Wed, 2 May 2007 00:39:52 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8A95D13C457; Wed, 2 May 2007 00:39:52 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l420dqRB025766; Wed, 2 May 2007 00:39:52 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l420dqDG025765; Wed, 2 May 2007 00:39:52 GMT (envelope-from pjd) Message-Id: <200705020039.l420dqDG025765@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 00:39:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:39:52 -0000 pjd 2007-05-02 00:39:52 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: Lock vnode using cn_lkflags in case the caller wants the vnode to be shared-locked. Revision Changes Path 1.19 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 2 00:41:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E7A616A402; Wed, 2 May 2007 00:41:45 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id DC82213C45A; Wed, 2 May 2007 00:41:44 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l420fiCm026683; Wed, 2 May 2007 00:41:44 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l420fiDo026682; Wed, 2 May 2007 00:41:44 GMT (envelope-from pjd) Message-Id: <200705020041.l420fiDo026682@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 00:41:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 00:41:45 -0000 pjd 2007-05-02 00:41:44 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Log: When parent directory has to be unlocked, lock it back with the same lock type. Before this change, if directory was shared-locked, it was relocked exclusively. Revision Changes Path 1.20 +6 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 2 01:03:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E665616A404; Wed, 2 May 2007 01:03:12 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BFE1B13C457; Wed, 2 May 2007 01:03:12 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4213CCC040028; Wed, 2 May 2007 01:03:12 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4213CMZ040025; Wed, 2 May 2007 01:03:12 GMT (envelope-from pjd) Message-Id: <200705020103.l4213CMZ040025@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 2 May 2007 01:03:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 01:03:13 -0000 pjd 2007-05-02 01:03:10 UTC FreeBSD src repository Modified files: sys/compat/opensolaris/kern opensolaris_vfs.c opensolaris_kobj.c sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c Log: Share-lock a vnode where possible. Revision Changes Path 1.3 +3 -3 src/sys/compat/opensolaris/kern/opensolaris_kobj.c 1.5 +2 -2 src/sys/compat/opensolaris/kern/opensolaris_vfs.c 1.4 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c From owner-cvs-src@FreeBSD.ORG Wed May 2 04:44:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C0E116A401; Wed, 2 May 2007 04:44:32 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 5D53013C448; Wed, 2 May 2007 04:44:32 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l424iW5j090925; Wed, 2 May 2007 04:44:32 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l424iWoK090924; Wed, 2 May 2007 04:44:32 GMT (envelope-from scottl) Message-Id: <200705020444.l424iWoK090924@repoman.freebsd.org> From: Scott Long Date: Wed, 2 May 2007 04:44:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ciss ciss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 04:44:32 -0000 scottl 2007-05-02 04:44:31 UTC FreeBSD src repository Modified files: sys/dev/ciss ciss.c Log: Streamline locking in ciss_free() Revision Changes Path 1.78 +27 -26 src/sys/dev/ciss/ciss.c From owner-cvs-src@FreeBSD.ORG Wed May 2 05:29:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A455716A402; Wed, 2 May 2007 05:29:56 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 861CC13C48C; Wed, 2 May 2007 05:29:56 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l425TuQr007306; Wed, 2 May 2007 05:29:56 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l425TucQ007305; Wed, 2 May 2007 05:29:56 GMT (envelope-from cperciva) Message-Id: <200705020529.l425TucQ007305@repoman.freebsd.org> From: Colin Percival Date: Wed, 2 May 2007 05:29:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive Makefile archive.h.in X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 05:29:56 -0000 cperciva 2007-05-02 05:29:56 UTC FreeBSD src repository Modified files: lib/libarchive Makefile archive.h.in Log: s/@VERSION@/@ARCHIVE_VERSION@/ This is a no-op as far as FreeBSD is concerned, but makes libarchive more autoconf-friendly. Approved by: kientzle Revision Changes Path 1.71 +1 -1 src/lib/libarchive/Makefile 1.43 +2 -2 src/lib/libarchive/archive.h.in From owner-cvs-src@FreeBSD.ORG Wed May 2 06:15:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E58C416A400; Wed, 2 May 2007 06:15:13 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C51A113C45A; Wed, 2 May 2007 06:15:13 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l426FDGI015875; Wed, 2 May 2007 06:15:13 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l426FDo7015874; Wed, 2 May 2007 06:15:13 GMT (envelope-from njl) Message-Id: <200705020615.l426FDo7015874@repoman.freebsd.org> From: Nate Lawson Date: Wed, 2 May 2007 06:15:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 06:15:14 -0000 njl 2007-05-02 06:15:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_intr.c sys/sys interrupt.h Log: MFC: rate-check the interrupt storm message and bump the counter 500 -> 1000 Revision Changes Path 1.124.2.7 +4 -4 src/sys/kern/kern_intr.c 1.30.2.4 +2 -1 src/sys/sys/interrupt.h From owner-cvs-src@FreeBSD.ORG Wed May 2 07:07:07 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 680) id 3842D16A407; Wed, 2 May 2007 07:07:07 +0000 (UTC) Date: Wed, 2 May 2007 07:07:07 +0000 From: Darren Reed To: Nate Lawson Message-ID: <20070502070707.GA68774@hub.freebsd.org> References: <200705020615.l426FDo7015874@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705020615.l426FDo7015874@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 07:07:07 -0000 On Wed, May 02, 2007 at 06:15:13AM +0000, Nate Lawson wrote: > njl 2007-05-02 06:15:13 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/kern kern_intr.c > sys/sys interrupt.h > Log: > MFC: rate-check the interrupt storm message and bump the counter 500 -> 1000 Is this number, "500" or "1000" somehow "magical" for modern hardware? If I had a 500MHZ, 1GHz, 1.5GHz, 2GHz, 2.5GHz machines, each with the appropriate architecture, what would the correct value for this be? Is i always 1000 or should it be calculated? Darren From owner-cvs-src@FreeBSD.ORG Wed May 2 07:52:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2977A16A403; Wed, 2 May 2007 07:52:56 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0387013C458; Wed, 2 May 2007 07:52:56 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l427qteU032473; Wed, 2 May 2007 07:52:55 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l427qt5b032471; Wed, 2 May 2007 07:52:55 GMT (envelope-from thompsa) Message-Id: <200705020752.l427qt5b032471@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 May 2007 07:52:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ieee8023ad_lacp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 07:52:56 -0000 thompsa 2007-05-02 07:52:55 UTC FreeBSD src repository Modified files: sys/net ieee8023ad_lacp.c Log: Test for IFM_FDX rather than IFM_HDX as the half-duplex bit may not be set even if the link is not full-duplex. Revision Changes Path 1.3 +1 -1 src/sys/net/ieee8023ad_lacp.c From owner-cvs-src@FreeBSD.ORG Wed May 2 08:58:28 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 828D216A401; Wed, 2 May 2007 08:58:28 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 5CB0C13C447; Wed, 2 May 2007 08:58:28 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l428wSDP052367; Wed, 2 May 2007 08:58:28 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l428wS9I052366; Wed, 2 May 2007 08:58:28 GMT (envelope-from thompsa) Message-Id: <200705020858.l428wS9I052366@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 May 2007 08:58:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_lagg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 08:58:28 -0000 thompsa 2007-05-02 08:58:28 UTC FreeBSD src repository Modified files: sys/net if_lagg.c Log: Set the master flag on the right variable. Revision Changes Path 1.2 +1 -1 src/sys/net/if_lagg.c From owner-cvs-src@FreeBSD.ORG Wed May 2 09:21:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CFA3B16A400; Wed, 2 May 2007 09:21:16 +0000 (UTC) (envelope-from rik@inse.ru) Received: from mail.inse.ru (inse.ru [144.206.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id 8A00413C4B0; Wed, 2 May 2007 09:21:16 +0000 (UTC) (envelope-from rik@inse.ru) Received: from [127.0.0.1] (www.inse.ru [144.206.128.1]) by mail.inse.ru (Postfix) with ESMTP id 77E1033C4C; Wed, 2 May 2007 13:21:15 +0400 (MSD) Message-ID: <463859B0.3020305@inse.ru> Date: Wed, 02 May 2007 13:28:16 +0400 From: Roman Kurakin User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Darren Reed References: <200705020615.l426FDo7015874@repoman.freebsd.org> <20070502070707.GA68774@hub.freebsd.org> In-Reply-To: <20070502070707.GA68774@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Nate Lawson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 09:21:16 -0000 Darren Reed wrote: > On Wed, May 02, 2007 at 06:15:13AM +0000, Nate Lawson wrote: > >> njl 2007-05-02 06:15:13 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_6) >> sys/kern kern_intr.c >> sys/sys interrupt.h >> Log: >> MFC: rate-check the interrupt storm message and bump the counter 500 -> 1000 >> > > Is this number, "500" or "1000" somehow "magical" for modern hardware? > > If I had a 500MHZ, 1GHz, 1.5GHz, 2GHz, 2.5GHz machines, each with the > appropriate architecture, what would the correct value for this be? > Is i always 1000 or should it be calculated? > It is hard to calculate. You need to take into account also the particular BUS that the set of devices is attached to, not only the speed of CPU that will serve this interrupt rate. rik > Darren > From owner-cvs-src@FreeBSD.ORG Wed May 2 10:26:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E629416A401; Wed, 2 May 2007 10:26:32 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C102713C448; Wed, 2 May 2007 10:26:32 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42AQWKu068887; Wed, 2 May 2007 10:26:32 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42AQWX1068886; Wed, 2 May 2007 10:26:32 GMT (envelope-from yar) Message-Id: <200705021026.l42AQWX1068886@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 2 May 2007 10:26:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 vlan.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 10:26:33 -0000 yar 2007-05-02 10:26:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 vlan.4 Log: MFC rev. 1.35-1.41: Clean up and update the HARDWARE section. Revision Changes Path 1.23.2.9 +24 -68 src/share/man/man4/vlan.4 From owner-cvs-src@FreeBSD.ORG Wed May 2 10:51:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68C8316A400; Wed, 2 May 2007 10:51:49 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 434AF13C44B; Wed, 2 May 2007 10:51:49 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42ApnRl072741; Wed, 2 May 2007 10:51:49 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42ApnbA072740; Wed, 2 May 2007 10:51:49 GMT (envelope-from yar) Message-Id: <200705021051.l42ApnbA072740@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 2 May 2007 10:51:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 vlan.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 10:51:49 -0000 yar 2007-05-02 10:51:48 UTC FreeBSD src repository Modified files: share/man/man4 vlan.4 Log: Update info on VLAN support in hardware: - bce(4) and cxgb(4) can do hardware acceleration; - fwe(4) and nfe(4) can handle long frames. Revision Changes Path 1.42 +4 -0 src/share/man/man4/vlan.4 From owner-cvs-src@FreeBSD.ORG Wed May 2 11:13:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F77616A400; Wed, 2 May 2007 11:13:49 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1A93213C455; Wed, 2 May 2007 11:13:49 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42BDmiC077554; Wed, 2 May 2007 11:13:48 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42BDmI8077553; Wed, 2 May 2007 11:13:48 GMT (envelope-from yar) Message-Id: <200705021113.l42BDmI8077553@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 2 May 2007 11:13:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 11:13:49 -0000 yar 2007-05-02 11:13:48 UTC FreeBSD src repository Modified files: sys/net if.h Log: Fix a couple of typos in a comment. Revision Changes Path 1.106 +2 -2 src/sys/net/if.h From owner-cvs-src@FreeBSD.ORG Wed May 2 12:50:14 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3921316A406; Wed, 2 May 2007 12:50:14 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 112B813C4AE; Wed, 2 May 2007 12:50:14 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42CoDMG004658; Wed, 2 May 2007 12:50:13 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42CoDVN004657; Wed, 2 May 2007 12:50:13 GMT (envelope-from rrs) Message-Id: <200705021250.l42CoDVN004657@repoman.freebsd.org> From: Randall Stewart Date: Wed, 2 May 2007 12:50:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp.h sctp_auth.c sctp_bsd_addr.c sctp_constants.h sctp_header.h sctp_indata.c sctp_indata.h sctp_input.c sctp_os_bsd.h sctp_output.c sctp_output.h sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_usrreq.c sctputil.c sctputil.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 12:50:14 -0000 rrs 2007-05-02 12:50:13 UTC FreeBSD src repository Modified files: sys/netinet sctp.h sctp_auth.c sctp_bsd_addr.c sctp_constants.h sctp_header.h sctp_indata.c sctp_indata.h sctp_input.c sctp_os_bsd.h sctp_output.c sctp_output.h sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_usrreq.c sctputil.c sctputil.h sys/netinet6 sctp6_usrreq.c Log: - Somehow the disable fragment option got lost. We could set/clear it but would not do it. Now we will. - Moved to latest socket api for extended sndrcv info struct. - Moved to support all new levels of fragment interleave (0-2). - Codenomicon security test updates - length checks and such. - Bug in stream reset (2 actually). - setpeerprimary could unlock a null pointer, fixed. - Added a flag in the pcb so netstat can see if we are listening easier. Obtained from: (some of the Listen changes from Weongyo Jeong) Revision Changes Path 1.5 +1 -0 src/sys/netinet/sctp.h 1.7 +5 -5 src/sys/netinet/sctp_auth.c 1.6 +39 -49 src/sys/netinet/sctp_bsd_addr.c 1.12 +4 -1 src/sys/netinet/sctp_constants.h 1.3 +10 -1 src/sys/netinet/sctp_header.h 1.19 +52 -24 src/sys/netinet/sctp_indata.c 1.5 +3 -2 src/sys/netinet/sctp_indata.h 1.21 +103 -18 src/sys/netinet/sctp_input.c 1.14 +6 -1 src/sys/netinet/sctp_os_bsd.h 1.21 +205 -137 src/sys/netinet/sctp_output.c 1.5 +0 -5 src/sys/netinet/sctp_output.h 1.22 +109 -54 src/sys/netinet/sctp_pcb.c 1.13 +2 -2 src/sys/netinet/sctp_pcb.h 1.7 +2 -2 src/sys/netinet/sctp_peeloff.c 1.20 +4 -4 src/sys/netinet/sctp_usrreq.c 1.23 +10 -47 src/sys/netinet/sctputil.c 1.15 +9 -4 src/sys/netinet/sctputil.h 1.16 +2 -0 src/sys/netinet6/sctp6_usrreq.c From owner-cvs-src@FreeBSD.ORG Wed May 2 13:49:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 34D2D16A407; Wed, 2 May 2007 13:49:29 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 286B513C459; Wed, 2 May 2007 13:49:29 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42DnTrT016173; Wed, 2 May 2007 13:49:29 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42DnSRZ016172; Wed, 2 May 2007 13:49:28 GMT (envelope-from bde) Message-Id: <200705021349.l42DnSRZ016172@repoman.freebsd.org> From: Bruce Evans Date: Wed, 2 May 2007 13:49:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/msun/bsdsrc b_tgamma.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 13:49:29 -0000 bde 2007-05-02 13:49:28 UTC FreeBSD src repository Modified files: lib/msun/bsdsrc b_tgamma.c Log: Document (in a comment) the current (slightly broken) handling of special values in more detail, and change the style of this comment to be closer to fdlibm and C99: - tgamma(-Inf) was undocumented and is wrong (+Inf, should be NaN) - tgamma(negative integer) is as intended (+Inf) but not best for IEEE-754 (NaN) - tgamma(-0) was documented as being wrong (+Inf) but was correct (-Inf) - documentation of setting of exceptions (overflow, etc.) was more complete here than in most of libm, but was further from matching the actual setting than in most of libm, due to various bugs here (primarily, always evaluating +Inf one/zero and getting unwanted divide-by-zero exceptions from this). Now the actual behaviour with gcc -O0 is documented. Optimization still breaks setting of exceptions all over libm, so nothing can depend on this working. - tgamma(NaN)'s exception was documented as being wrong (invalid) but was correct (no exception with IEEEish NaNs). Finish (?) rev.1.5. gamma was not renamed to tgamma in one place. Finish (?) rev.1.6. errno.h was not completely removed. Revision Changes Path 1.8 +9 -6 src/lib/msun/bsdsrc/b_tgamma.c From owner-cvs-src@FreeBSD.ORG Wed May 2 15:15:52 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D48016A403; Wed, 2 May 2007 15:15:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 17ACD13C447; Wed, 2 May 2007 15:15:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FFpZa032228; Wed, 2 May 2007 15:15:51 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FFpxD032227; Wed, 2 May 2007 15:15:51 GMT (envelope-from jhb) Message-Id: <200705021515.l42FFpxD032227@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 15:15:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/nfsclient nfs_bio.c nfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:15:52 -0000 jhb 2007-05-02 15:15:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfsclient nfs_bio.c nfs_vnops.c Log: MFC: Various fixes to NFS DirectIO support. Revision Changes Path 1.152.2.4 +9 -7 src/sys/nfsclient/nfs_bio.c 1.258.2.14 +4 -0 src/sys/nfsclient/nfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 2 15:22:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ECD4C16A401; Wed, 2 May 2007 15:22:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C787013C45E; Wed, 2 May 2007 15:22:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FMKfC033233; Wed, 2 May 2007 15:22:20 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FMKH6033232; Wed, 2 May 2007 15:22:20 GMT (envelope-from jhb) Message-Id: <200705021522.l42FMKH6033232@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 15:22:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 apic_vector.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:22:21 -0000 jhb 2007-05-02 15:22:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 apic_vector.S Log: MFC: Comment fixes in 1.106 and 1.107. Revision Changes Path 1.103.2.1 +2 -7 src/sys/amd64/amd64/apic_vector.S From owner-cvs-src@FreeBSD.ORG Wed May 2 15:24:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EF6E516A401; Wed, 2 May 2007 15:24:49 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E204413C4D3; Wed, 2 May 2007 15:24:49 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FOn01033761; Wed, 2 May 2007 15:24:49 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FOnXp033760; Wed, 2 May 2007 15:24:49 GMT (envelope-from bde) Message-Id: <200705021524.l42FOnXp033760@repoman.freebsd.org> From: Bruce Evans Date: Wed, 2 May 2007 15:24:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/msun/bsdsrc b_tgamma.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:24:50 -0000 bde 2007-05-02 15:24:49 UTC FreeBSD src repository Modified files: lib/msun/bsdsrc b_tgamma.c Log: Fix tgamma() on some special args: (1) tgamma(-Inf) returned +Inf and failed to raise any exception, but should always have raised an exception, and should behave like tgamma(negative integer). (2) tgamma(negative integer) returned +Inf and raised divide-by-zero, but should return NaN and raise "invalid" on any IEEEish system. (3) About half of the 2**52 negative intgers between -2**53 and -2**52 were misclassified as non-integers by using floor(x + 0.5) to round to nearest, so tgamma(x) was wrong (+-0 instead of +Inf and now NaN) on these args. The floor() expression is hard to use since rounding of (x + 0.5) may give x or x + 1, depending on |x| and the current rounding mode. The fixed version uses ceil(x) to classify x before operating on x and ends up being more efficient since ceil(x) is needed anyway. (4) On at least the problematic args in (3), tgamma() raised a spurious inexact. (5) tgamma(large positive) raised divide-by-zero but should raise overflow. (6) tgamma(+Inf) raised divide-by-zero but should not raise any exception. (7) Raise inexact for tiny |x| in a way that has some chance of not being optimized away. The fix for (5) and (6), and probably for (2), also prevents -O optimizing away the exception. PR: 112180 (2) Standards: Annex F in C99 (IEC 60559 binding) requires (1), (2) and (6). Revision Changes Path 1.9 +15 -14 src/lib/msun/bsdsrc/b_tgamma.c From owner-cvs-src@FreeBSD.ORG Wed May 2 15:27:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F305C16A401; Wed, 2 May 2007 15:27:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CDCEA13C447; Wed, 2 May 2007 15:27:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FROLi033899; Wed, 2 May 2007 15:27:24 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FROdC033898; Wed, 2 May 2007 15:27:24 GMT (envelope-from jhb) Message-Id: <200705021527.l42FROdC033898@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 15:27:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/i386 apic_vector.s X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:27:25 -0000 jhb 2007-05-02 15:27:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/i386 apic_vector.s Log: MFC: Comment fix in 1.110. Revision Changes Path 1.103.2.2 +1 -2 src/sys/i386/i386/apic_vector.s From owner-cvs-src@FreeBSD.ORG Wed May 2 15:30:26 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CFFAE16A40F; Wed, 2 May 2007 15:30:26 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AB04613C4BF; Wed, 2 May 2007 15:30:26 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FUQ28034110; Wed, 2 May 2007 15:30:26 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FUQfn034105; Wed, 2 May 2007 15:30:26 GMT (envelope-from scottl) Message-Id: <200705021530.l42FUQfn034105@repoman.freebsd.org> From: Scott Long Date: Wed, 2 May 2007 15:30:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata atapi-cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:30:26 -0000 scottl 2007-05-02 15:30:25 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cam.c Log: MPSAFE atapi-cam Revision Changes Path 1.54 +23 -28 src/sys/dev/ata/atapi-cam.c From owner-cvs-src@FreeBSD.ORG Wed May 2 15:32:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D0B6016A403; Wed, 2 May 2007 15:32:05 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AAB8313C4B9; Wed, 2 May 2007 15:32:05 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FW5De034817; Wed, 2 May 2007 15:32:05 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FW5mp034816; Wed, 2 May 2007 15:32:05 GMT (envelope-from mtm) Message-Id: <200705021532.l42FW5mp034816@repoman.freebsd.org> From: Mike Makonnen Date: Wed, 2 May 2007 15:32:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d netoptions X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:32:06 -0000 mtm 2007-05-02 15:32:05 UTC FreeBSD src repository Modified files: etc/rc.d netoptions Log: When rc.d/NETWORKING included this script in its REQUIRE line, a circular dependency was introduced because this script had rc.d/localpkg (which is *after* rc.d/NETWORKING) in its REQUIRE line. From an examination of its contents it seems that only the availability of a local filesystem is necessary for this script to function properly. Revision Changes Path 1.143 +1 -1 src/etc/rc.d/netoptions From owner-cvs-src@FreeBSD.ORG Wed May 2 15:40:15 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A411516A407; Wed, 2 May 2007 15:40:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 946E413C4B8; Wed, 2 May 2007 15:40:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FeFpg035900; Wed, 2 May 2007 15:40:15 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FeF0m035899; Wed, 2 May 2007 15:40:15 GMT (envelope-from jhb) Message-Id: <200705021540.l42FeF0m035899@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 15:40:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 apic_vector.S mp_machdep.c pmap.c src/sys/amd64/include apicvar.h pmap.h smp.h src/sys/i386/i386 apic_vector.s mp_machdep.c pmap.c src/sys/i386/include apicvar.h pmap.h smp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:40:15 -0000 jhb 2007-05-02 15:40:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 apic_vector.S mp_machdep.c pmap.c sys/amd64/include apicvar.h pmap.h smp.h sys/i386/i386 apic_vector.s mp_machdep.c pmap.c sys/i386/include apicvar.h pmap.h smp.h Log: MFC: Add 'pmap_invalidate_cache()'. Revision Changes Path 1.103.2.2 +19 -0 src/sys/amd64/amd64/apic_vector.S 1.260.2.9 +12 -1 src/sys/amd64/amd64/mp_machdep.c 1.516.2.11 +31 -0 src/sys/amd64/amd64/pmap.c 1.13.2.5 +3 -2 src/sys/amd64/include/apicvar.h 1.127.2.2 +1 -0 src/sys/amd64/include/pmap.h 1.84.2.1 +2 -0 src/sys/amd64/include/smp.h 1.103.2.3 +33 -0 src/sys/i386/i386/apic_vector.s 1.252.2.10 +14 -1 src/sys/i386/i386/mp_machdep.c 1.523.2.18 +17 -0 src/sys/i386/i386/pmap.c 1.13.2.5 +4 -3 src/sys/i386/include/apicvar.h 1.117.2.1 +1 -0 src/sys/i386/include/pmap.h 1.82.2.1 +2 -0 src/sys/i386/include/smp.h From owner-cvs-src@FreeBSD.ORG Wed May 2 15:49:31 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0141816A403; Wed, 2 May 2007 15:49:31 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CEF7B13C46E; Wed, 2 May 2007 15:49:30 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42FnUT6037381; Wed, 2 May 2007 15:49:30 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42FnUoi037380; Wed, 2 May 2007 15:49:30 GMT (envelope-from mtm) Message-Id: <200705021549.l42FnUoi037380@repoman.freebsd.org> From: Mike Makonnen Date: Wed, 2 May 2007 15:49:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d netoptions routing X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:49:31 -0000 mtm 2007-05-02 15:49:30 UTC FreeBSD src repository Modified files: etc/rc.d netoptions routing Log: Move options that do not have anything to do with routing out of rc.d/routing and in to rc.d/netoptions. Also instead of saying "TCP options" say "IP options". Revision Changes Path 1.144 +43 -1 src/etc/rc.d/netoptions 1.143 +0 -41 src/etc/rc.d/routing From owner-cvs-src@FreeBSD.ORG Wed May 2 16:16:58 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4553E16A404; Wed, 2 May 2007 16:16:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 35E9513C45A; Wed, 2 May 2007 16:16:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42GGwTl043448; Wed, 2 May 2007 16:16:58 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42GGwhT043447; Wed, 2 May 2007 16:16:58 GMT (envelope-from jhb) Message-Id: <200705021616.l42GGwhT043447@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 16:16:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c pmap.c src/sys/amd64/include pmap.h specialreg.h src/sys/i386/i386 mp_machdep.c pmap.c src/sys/i386/include pmap.h specialreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 16:16:58 -0000 jhb 2007-05-02 16:16:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 mp_machdep.c pmap.c sys/amd64/include pmap.h specialreg.h sys/i386/i386 mp_machdep.c pmap.c sys/i386/include pmap.h specialreg.h Log: MFC: Add various constants for the PAT MSR and the PAT PTE and PDE flags and initialize the PAT MSR during boot. Revision Changes Path 1.260.2.10 +3 -0 src/sys/amd64/amd64/mp_machdep.c 1.516.2.12 +45 -0 src/sys/amd64/amd64/pmap.c 1.127.2.3 +3 -0 src/sys/amd64/include/pmap.h 1.30.8.2 +12 -0 src/sys/amd64/include/specialreg.h 1.252.2.11 +3 -0 src/sys/i386/i386/mp_machdep.c 1.523.2.19 +45 -0 src/sys/i386/i386/pmap.c 1.117.2.2 +3 -0 src/sys/i386/include/pmap.h 1.27.8.3 +13 -0 src/sys/i386/include/specialreg.h From owner-cvs-src@FreeBSD.ORG Wed May 2 16:21:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 787EE16A400; Wed, 2 May 2007 16:21:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 52EC113C459; Wed, 2 May 2007 16:21:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42GLJXI044169; Wed, 2 May 2007 16:21:19 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42GLJGC044161; Wed, 2 May 2007 16:21:19 GMT (envelope-from jhb) Message-Id: <200705021621.l42GLJGC044161@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 16:21:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 16:21:19 -0000 jhb 2007-05-02 16:21:18 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c Log: Use more specific local variable pointers to narrow some expressions. MFC after: 1 week Revision Changes Path 1.350 +72 -73 src/sys/dev/pci/pci.c From owner-cvs-src@FreeBSD.ORG Wed May 2 16:22:40 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 773C916A407 for ; Wed, 2 May 2007 16:22:40 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 52ACD13C46C for ; Wed, 2 May 2007 16:22:40 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 95603 invoked from network); 2 May 2007 16:22:40 -0000 Received: from ppp-71-139-7-60.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.7.60) by root.org with ESMTPA; 2 May 2007 16:22:40 -0000 Message-ID: <4638BAC9.7000603@root.org> Date: Wed, 02 May 2007 09:22:33 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070424) MIME-Version: 1.0 To: John Baldwin References: <200705020615.l426FDo7015874@repoman.freebsd.org> <20070502070707.GA68774@hub.freebsd.org> <200705021056.34887.jhb@freebsd.org> In-Reply-To: <200705021056.34887.jhb@freebsd.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Darren Reed , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 16:22:40 -0000 John Baldwin wrote: > On Wednesday 02 May 2007 03:07:07 am Darren Reed wrote: >> On Wed, May 02, 2007 at 06:15:13AM +0000, Nate Lawson wrote: >>> njl 2007-05-02 06:15:13 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: (Branch: RELENG_6) >>> sys/kern kern_intr.c >>> sys/sys interrupt.h >>> Log: >>> MFC: rate-check the interrupt storm message and bump the counter 500 -> > 1000 >> Is this number, "500" or "1000" somehow "magical" for modern hardware? >> >> If I had a 500MHZ, 1GHz, 1.5GHz, 2GHz, 2.5GHz machines, each with the >> appropriate architecture, what would the correct value for this be? >> Is i always 1000 or should it be calculated? > > It's a SWAG and tunable for machines where it doesn't work. In practice the > old setting seemed to be a bit too trigger-happy as I know my printer always > triggered it, for example. > There's more to it than just your Ghz number. It's a counter of the number of times an interrupt has triggered while the previous one was being serviced. The faster your kernel, the lower the number could be. I have a slow early SMP Celeron system with a dc(4) adapter with 4 ports sharing an irq with my ata. At 3 am, the nightly script kicks off enough IO that it triggers a bug in my dc(4) card that causes it to mask the interrupt too long. Then, the irq storm suppression logic kicked in, causing ata to timeout the request. The drive is on a mirror so I'd lose half the mirror, then rebuild in the morning. With this value bumped, I don't have that problem any more but the real issue is why dc(4) is being so quirky under heavy shared irq load. -- Nate From owner-cvs-src@FreeBSD.ORG Wed May 2 16:37:05 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 51D7E16A401 for ; Wed, 2 May 2007 16:37:05 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 2622213C44B for ; Wed, 2 May 2007 16:37:05 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 96979 invoked from network); 2 May 2007 16:37:04 -0000 Received: from ppp-71-139-7-60.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.7.60) by root.org with ESMTPA; 2 May 2007 16:37:04 -0000 Message-ID: <4638BE29.1020505@root.org> Date: Wed, 02 May 2007 09:36:57 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070424) MIME-Version: 1.0 To: John Baldwin References: <200705020615.l426FDo7015874@repoman.freebsd.org> <20070502070707.GA68774@hub.freebsd.org> <200705021056.34887.jhb@freebsd.org> <4638BAC9.7000603@root.org> In-Reply-To: <4638BAC9.7000603@root.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Darren Reed , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 16:37:05 -0000 Nate Lawson wrote: > John Baldwin wrote: >> On Wednesday 02 May 2007 03:07:07 am Darren Reed wrote: >>> On Wed, May 02, 2007 at 06:15:13AM +0000, Nate Lawson wrote: >>>> njl 2007-05-02 06:15:13 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: (Branch: RELENG_6) >>>> sys/kern kern_intr.c >>>> sys/sys interrupt.h >>>> Log: >>>> MFC: rate-check the interrupt storm message and bump the counter 500 -> >> 1000 >>> Is this number, "500" or "1000" somehow "magical" for modern hardware? >>> >>> If I had a 500MHZ, 1GHz, 1.5GHz, 2GHz, 2.5GHz machines, each with the >>> appropriate architecture, what would the correct value for this be? >>> Is i always 1000 or should it be calculated? >> It's a SWAG and tunable for machines where it doesn't work. In practice the >> old setting seemed to be a bit too trigger-happy as I know my printer always >> triggered it, for example. >> > > There's more to it than just your Ghz number. It's a counter of the > number of times an interrupt has triggered while the previous one was > being serviced. The faster your kernel, the lower the number could be. > > I have a slow early SMP Celeron system with a dc(4) adapter with 4 ports > sharing an irq with my ata. At 3 am, the nightly script kicks off > enough IO that it triggers a bug in my dc(4) card that causes it to mask > the interrupt too long. Then, the irq storm suppression logic kicked > in, causing ata to timeout the request. The drive is on a mirror so I'd > lose half the mirror, then rebuild in the morning. With this value > bumped, I don't have that problem any more but the real issue is why > dc(4) is being so quirky under heavy shared irq load. > This is on 6.x btw. Is there any reason why our retries is so low? sys/dev/ata/ata-disk.c: request->retries = 2; Here are the dc(4) and ata devices, note that they're sharing irq 18: dc0: port 0xc000-0xc07f mem 0xd5000000-0xd50003ff irq 19 at device 4.0 on pci2 miibus0: on dc0 ukphy0: on miibus0 ukphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto dc0: Ethernet address: 00:80:c8:cd:36:85 dc1: port 0xc400-0xc47f mem 0xd5001000-0xd50013ff irq 16 at device 5.0 on pci2 miibus1: on dc1 ukphy1: on miibus1 ukphy1: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto dc1: Ethernet address: 00:80:c8:cd:36:86 dc2: port 0xc800-0xc87f mem 0xd5002000-0xd50023ff irq 17 at device 6.0 on pci2 miibus2: on dc2 ukphy2: on miibus2 ukphy2: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto dc2: Ethernet address: 00:80:c8:cd:36:87 dc3: port 0xcc00-0xcc7f mem 0xd5003000-0xd50033ff irq 18 at device 7.0 on pci2 miibus3: on dc3 ukphy3: on miibus3 ukphy3: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto dc3: Ethernet address: 00:80:c8:cd:36:88 pci0: at device 15.0 (no driver attached) atapci1: port 0xd400-0xd407,0xd800-0xd803,0xdc00-0xdcff irq 18 at device 19.0 on pci0 ata2: on atapci1 atapci2: port 0xe000-0xe007,0xe400-0xe403,0xe800-0xe8ff irq 18 at device 19.1 on pci0 ata3: on atapci2 And here are the error messages: Apr 27 03:03:56 bento kernel: dc0: TX underrun -- increasing TX threshold Apr 27 03:05:01 bento kernel: Interrupt storm detected on "irq18:"; throttling interrupt source Apr 27 03:05:16 bento kernel: ad6: TIMEOUT - READ_DMA48 retrying (1 retry left) LBA=294226271 Apr 27 03:05:16 bento kernel: ad6: TIMEOUT - READ_DMA48 retrying (0 retries left) LBA=294226271 Apr 27 03:05:16 bento kernel: ad6: FAILURE - READ_DMA48 timed out LBA=294226271 Apr 27 03:05:16 bento kernel: GEOM_MIRROR: Request failed (error=5). ad6[READ(offset=150643850752, length=8192)] Apr 27 03:05:16 bento kernel: GEOM_MIRROR: Device gm0: provider ad6 disconnected. There appears to be no delay between resubmitting the requests each time the TIMEOUT message occurs. It all happens in 1 second. Would it be possible to schedule retries from a callout or thread to allow more delay before failing them a second time? I then rebuilt the array: Apr 27 17:25:43 bento kernel: GEOM_MIRROR: Device gm0: provider ad6 detected. Apr 27 17:25:43 bento kernel: GEOM_MIRROR: Device gm0: rebuilding provider ad6. Apr 27 17:36:58 bento kernel: dc0: TX underrun -- increasing TX threshold Apr 27 18:12:25 bento kernel: dc0: TX underrun -- increasing TX threshold Apr 27 18:20:59 bento kernel: dc1: TX underrun -- increasing TX threshold Apr 27 19:41:32 bento kernel: GEOM_MIRROR: Device gm0: rebuilding provider ad6 finished. Apr 27 19:41:32 bento kernel: GEOM_MIRROR: Device gm0: provider ad6 activated. Apr 28 04:22:04 bento kernel: ad6: TIMEOUT - READ_DMA retrying (1 retry left) LBA=9894431 Note that I still got a timeout but it succeeded without error. I think this is a combination of the dc(4) and highpoint hpt366 driver interaction. dc(4) is probably holding Giant or something too long and ata is being too sensitive to the slow hw. Comments? -- Nate From owner-cvs-src@FreeBSD.ORG Wed May 2 16:54:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7AB2B16A406; Wed, 2 May 2007 16:54:23 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6CE4913C48A; Wed, 2 May 2007 16:54:23 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42GsNxu058355; Wed, 2 May 2007 16:54:23 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42GsNdk058354; Wed, 2 May 2007 16:54:23 GMT (envelope-from bde) Message-Id: <200705021654.l42GsNdk058354@repoman.freebsd.org> From: Bruce Evans Date: Wed, 2 May 2007 16:54:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/msun/src e_lgamma_r.c e_lgammaf_r.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 16:54:23 -0000 bde 2007-05-02 16:54:23 UTC FreeBSD src repository Modified files: lib/msun/src e_lgamma_r.c e_lgammaf_r.c Log: Don't assume that int is signed 32-bits in one place. Keep assuming that ints have >= 31 value bits elsewhere. s/int/int32_t/ seems to have been done too globally for all other files in msun/src before msun/ was imported into FreeBSD. Minor fixes in comments. e_lgamma_r.c: Describe special cases in more detail: - exception for lgamma(0) and lgamma(neg.integer) - lgamma(-Inf) = Inf. This is wrong but is required by C99 Annex F. I hope to change this. Revision Changes Path 1.9 +8 -6 src/lib/msun/src/e_lgamma_r.c 1.10 +3 -2 src/lib/msun/src/e_lgammaf_r.c From owner-cvs-src@FreeBSD.ORG Wed May 2 17:28:41 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 000EE16A401; Wed, 2 May 2007 17:28:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 7516213C4AE; Wed, 2 May 2007 17:28:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l42HSbmM033056; Wed, 2 May 2007 13:28:38 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Wed, 2 May 2007 13:14:14 -0400 User-Agent: KMail/1.9.6 References: <200705020615.l426FDo7015874@repoman.freebsd.org> <4638BAC9.7000603@root.org> <4638BE29.1020505@root.org> In-Reply-To: <4638BE29.1020505@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705021314.15733.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 02 May 2007 13:28:38 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3195/Wed May 2 05:34:51 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Darren Reed , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 17:28:41 -0000 On Wednesday 02 May 2007 12:36:57 pm Nate Lawson wrote: > Nate Lawson wrote: > > John Baldwin wrote: > >> On Wednesday 02 May 2007 03:07:07 am Darren Reed wrote: > >>> On Wed, May 02, 2007 at 06:15:13AM +0000, Nate Lawson wrote: > >>>> njl 2007-05-02 06:15:13 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: (Branch: RELENG_6) > >>>> sys/kern kern_intr.c > >>>> sys/sys interrupt.h > >>>> Log: > >>>> MFC: rate-check the interrupt storm message and bump the counter 500 -> > >> 1000 > >>> Is this number, "500" or "1000" somehow "magical" for modern hardware? > >>> > >>> If I had a 500MHZ, 1GHz, 1.5GHz, 2GHz, 2.5GHz machines, each with the > >>> appropriate architecture, what would the correct value for this be? > >>> Is i always 1000 or should it be calculated? > >> It's a SWAG and tunable for machines where it doesn't work. In practice the > >> old setting seemed to be a bit too trigger-happy as I know my printer always > >> triggered it, for example. > >> > > > > There's more to it than just your Ghz number. It's a counter of the > > number of times an interrupt has triggered while the previous one was > > being serviced. The faster your kernel, the lower the number could be. > > > > I have a slow early SMP Celeron system with a dc(4) adapter with 4 ports > > sharing an irq with my ata. At 3 am, the nightly script kicks off > > enough IO that it triggers a bug in my dc(4) card that causes it to mask > > the interrupt too long. Then, the irq storm suppression logic kicked > > in, causing ata to timeout the request. The drive is on a mirror so I'd > > lose half the mirror, then rebuild in the morning. With this value > > bumped, I don't have that problem any more but the real issue is why > > dc(4) is being so quirky under heavy shared irq load. > > > > This is on 6.x btw. Is there any reason why our retries is so low? > > sys/dev/ata/ata-disk.c: request->retries = 2; At work we up the timeout from 5 to 30, but we leave retries at 2. > Note that I still got a timeout but it succeeded without error. I think > this is a combination of the dc(4) and highpoint hpt366 driver > interaction. dc(4) is probably holding Giant or something too long and > ata is being too sensitive to the slow hw. Neither dc(4) nor ata(4) hold Giant, FWIW. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed May 2 17:50:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AFA9516A402; Wed, 2 May 2007 17:50:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 93B2213C447; Wed, 2 May 2007 17:50:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42HoaIr067788; Wed, 2 May 2007 17:50:36 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42HoaMj067787; Wed, 2 May 2007 17:50:36 GMT (envelope-from jhb) Message-Id: <200705021750.l42HoaMj067787@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 17:50:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 17:50:36 -0000 jhb 2007-05-02 17:50:36 UTC FreeBSD src repository Modified files: sys/amd64/amd64 mptable_pci.c msi.c nexus.c sys/amd64/include intr_machdep.h sys/amd64/pci pci_bus.c sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m pcib_private.h pcivar.h sys/i386/i386 mptable_pci.c msi.c nexus.c sys/i386/include intr_machdep.h sys/i386/pci pci_bus.c Log: Revamp the MSI/MSI-X code a bit to achieve two main goals: - Simplify the amount of work that has be done for each architecture by pushing more of the truly MI code down into the PCI bus driver. - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map multiple MSI-X messages into a single IRQ when handling a message shortage. The changes include: - Add a new pcib_if method: PCIB_MAP_MSI() which is called by the PCI bus to calculate the address and data values for a given MSI/MSI-X IRQ. The x86 nexus drivers map this into a call to a new 'msi_map()' function in msi.c that does the mapping. - Retire the pcib_if method PCIB_REMAP_MSIX() and remove the 'index' parameter from PCIB_ALLOC_MSIX(). MD code no longer has any knowledge of the MSI-X index for a given MSI-X IRQ. - The PCI bus driver now stores more MSI-X state in a child's ivars. Specifically, it now stores an array of IRQs (called "message vectors" in the code) that have associated address and data values, and a small virtual version of the MSI-X table that specifies the message vector that a given MSI-X table entry uses. Sparse mappings are permitted in the virtual table. - The PCI bus driver now configures the MSI and MSI-X address/data registers directly via custom bus_setup_intr() and bus_teardown_intr() methods. pci_setup_intr() invokes PCIB_MAP_MSI() to determine the address and data values for a given message as needed. The MD code no longer has to call back down into the PCI bus code to set these values from the nexus' bus_setup_intr() handler. - The PCI bus code provides a callout (pci_remap_msi_irq()) that the MD code can call to force the PCI bus to re-invoke PCIB_MAP_MSI() to get new values of the address and data fields for a given IRQ. The x86 MSI code uses this when an MSI IRQ is moved to a different CPU, requiring a new value of the 'address' field. - The x86 MSI psuedo-driver loses a lot of code, and in fact the separate MSI/MSI-X pseudo-PICs are collapsed down into a single MSI PIC driver since the only remaining diff between the two is a substring in a bootverbose printf. - The PCI bus driver will now restore MSI-X state (including programming entries in the MSI-X table) on device resume. - The interface for pci_remap_msix() has changed. Instead of accepting indices for the allocated vectors, it accepts a mini-virtual table (with a new length parameter). This table is an array of u_ints, where each value specifies which allocated message vector to use for the corresponding MSI-X message. A vector of 0 forces a message to not have an associated IRQ. The device may choose to only use some of the IRQs assigned, in which case the unused IRQs must be at the "end" and will be released back to the system. This allows a driver to use the same remap table for different shortage values. For example, if a driver wants 4 messages, it can use the same remap table (which only uses the first two messages) for the cases when it only gets 2 or 3 messages and in the latter case the PCI bus will release the 3rd IRQ back to the system. MFC after: 1 month Revision Changes Path 1.8 +15 -5 src/sys/amd64/amd64/mptable_pci.c 1.5 +59 -109 src/sys/amd64/amd64/msi.c 1.76 +12 -12 src/sys/amd64/amd64/nexus.c 1.17 +2 -2 src/sys/amd64/include/intr_machdep.h 1.121 +14 -4 src/sys/amd64/pci/pci_bus.c 1.54 +16 -4 src/sys/dev/acpica/acpi_pcib_acpi.c 1.17 +1 -1 src/sys/dev/acpica/acpi_pcib_pci.c 1.351 +437 -90 src/sys/dev/pci/pci.c 1.12 +2 -1 src/sys/dev/pci/pci_if.m 1.48 +12 -11 src/sys/dev/pci/pci_pci.c 1.23 +6 -1 src/sys/dev/pci/pci_private.h 1.11 +9 -8 src/sys/dev/pci/pcib_if.m 1.12 +2 -2 src/sys/dev/pci/pcib_private.h 1.79 +27 -10 src/sys/dev/pci/pcivar.h 1.8 +15 -5 src/sys/i386/i386/mptable_pci.c 1.5 +59 -109 src/sys/i386/i386/msi.c 1.72 +12 -12 src/sys/i386/i386/nexus.c 1.19 +2 -2 src/sys/i386/include/intr_machdep.h 1.127 +15 -5 src/sys/i386/pci/pci_bus.c From owner-cvs-src@FreeBSD.ORG Wed May 2 18:16:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6B02B16A404; Wed, 2 May 2007 18:16:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id E7C8113C459; Wed, 2 May 2007 18:16:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l42IGTO5033325; Wed, 2 May 2007 14:16:30 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Wed, 2 May 2007 14:16:22 -0400 User-Agent: KMail/1.9.6 References: <200705021750.l42HoaMj067787@repoman.freebsd.org> In-Reply-To: <200705021750.l42HoaMj067787@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705021416.22715.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 02 May 2007 14:16:30 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3195/Wed May 2 05:34:51 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 18:16:32 -0000 On Wednesday 02 May 2007 01:50:36 pm John Baldwin wrote: > jhb 2007-05-02 17:50:36 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 mptable_pci.c msi.c nexus.c > sys/amd64/include intr_machdep.h > sys/amd64/pci pci_bus.c > sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c > sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h > pcib_if.m pcib_private.h pcivar.h > sys/i386/i386 mptable_pci.c msi.c nexus.c > sys/i386/include intr_machdep.h > sys/i386/pci pci_bus.c > Log: > Revamp the MSI/MSI-X code a bit to achieve two main goals: > - Simplify the amount of work that has be done for each architecture by > pushing more of the truly MI code down into the PCI bus driver. > - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map > multiple MSI-X messages into a single IRQ when handling a message > shortage. > > The changes include: > - Add a new pcib_if method: PCIB_MAP_MSI() which is called by the PCI bus > to calculate the address and data values for a given MSI/MSI-X IRQ. > The x86 nexus drivers map this into a call to a new 'msi_map()' function > in msi.c that does the mapping. Another benefit to this change is that we can let PCI bridge drivers futz with the address and data values if needed. One case where this is needed is the HT2000 chipset which apparently is too brain-damaged to use the default MSI address window on x86. We can patch pcib_map_msi() to update the address value for the workaround address window given in the errata so that devices behind those bridges can now work. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed May 2 18:42:47 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CCCFA16A401; Wed, 2 May 2007 18:42:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id ACC7D13C43E; Wed, 2 May 2007 18:42:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42Igljo078154; Wed, 2 May 2007 18:42:47 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42Igl5m078153; Wed, 2 May 2007 18:42:47 GMT (envelope-from jhb) Message-Id: <200705021842.l42Igl5m078153@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 18:42:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/acpica madt.c src/sys/amd64/amd64 pmap.c src/sys/amd64/include pmap.h src/sys/dev/acpica/Osd OsdMemory.c src/sys/dev/ipmi ipmi_smbios.c src/sys/i386/acpica acpi_machdep.c madt.c src/sys/i386/i386 pmap.c src/sys/i386/include pmap.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 18:42:47 -0000 jhb 2007-05-02 18:42:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/acpica madt.c sys/amd64/amd64 pmap.c sys/amd64/include pmap.h sys/dev/acpica/Osd OsdMemory.c sys/dev/ipmi ipmi_smbios.c sys/i386/acpica acpi_machdep.c madt.c sys/i386/i386 pmap.c sys/i386/include pmap.h sys/ia64/include pmap.h sys/sys param.h Log: MFC: Initial PAT support including the following: - New pmap_mapdev_attr() function for amd64 and i386. - pmap_mapdev() on i386 and amd64 uses UC now rather than WB. - New pmap_mapbios()/pmap_unmapbios() functions to map firmware tables. - New pmap_change_attr() function for amd64 and i386. - Bump __FreeBSD_version. Revision Changes Path 1.16.2.3 +5 -5 src/sys/amd64/acpica/madt.c 1.516.2.13 +216 -6 src/sys/amd64/amd64/pmap.c 1.127.2.4 +5 -0 src/sys/amd64/include/pmap.h 1.11.8.3 +2 -2 src/sys/dev/acpica/Osd/OsdMemory.c 1.1.2.3 +1 -1 src/sys/dev/ipmi/ipmi_smbios.c 1.28.2.4 +2 -2 src/sys/i386/acpica/acpi_machdep.c 1.19.2.3 +5 -5 src/sys/i386/acpica/madt.c 1.523.2.20 +165 -4 src/sys/i386/i386/pmap.c 1.117.2.3 +5 -0 src/sys/i386/include/pmap.h 1.24.2.2 +2 -0 src/sys/ia64/include/pmap.h 1.244.2.27 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Wed May 2 18:43:51 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E2A0C16A400; Wed, 2 May 2007 18:43:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BCE5A13C484; Wed, 2 May 2007 18:43:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42Ihp9h078452; Wed, 2 May 2007 18:43:51 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42Ihpv4078448; Wed, 2 May 2007 18:43:51 GMT (envelope-from jhb) Message-Id: <200705021843.l42Ihpv4078448@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 18:43:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ipmi ipmi_smbios.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 18:43:52 -0000 jhb 2007-05-02 18:43:51 UTC FreeBSD src repository Modified files: sys/dev/ipmi ipmi_smbios.c Log: Update __FreeBSD_version check for MFC of pmap_mapbios(). Revision Changes Path 1.4 +1 -1 src/sys/dev/ipmi/ipmi_smbios.c From owner-cvs-src@FreeBSD.ORG Wed May 2 18:48:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1B1E416A400; Wed, 2 May 2007 18:48:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E88AF13C459; Wed, 2 May 2007 18:48:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42ImIss078737; Wed, 2 May 2007 18:48:18 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42ImIKH078736; Wed, 2 May 2007 18:48:18 GMT (envelope-from jhb) Message-Id: <200705021848.l42ImIKH078736@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 18:48:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 busdma_machdep.c src/sys/i386/i386 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 18:48:19 -0000 jhb 2007-05-02 18:48:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 busdma_machdep.c sys/i386/i386 busdma_machdep.c Log: MFC: Honor the BUS_DMA_NOCACHE flag to bus_dmamem_alloc() on amd64 and i386 by mapping the pages as UC (uncacheable) using pmap_change_attr(). Requested by: ariff Revision Changes Path 1.70.2.6 +5 -0 src/sys/amd64/amd64/busdma_machdep.c 1.74.2.5 +5 -0 src/sys/i386/i386/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Wed May 2 20:16:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5AFD216A400; Wed, 2 May 2007 20:16:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 34FB113C455; Wed, 2 May 2007 20:16:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l42KGU03095041; Wed, 2 May 2007 20:16:30 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l42KGUbk095040; Wed, 2 May 2007 20:16:30 GMT (envelope-from jhb) Message-Id: <200705022016.l42KGUbk095040@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 May 2007 20:16:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 20:16:30 -0000 jhb 2007-05-02 20:16:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/i386 pmap.c Log: Argh, fix a mis-merge. Reported by: kib Revision Changes Path 1.523.2.21 +2 -2 src/sys/i386/i386/pmap.c From owner-cvs-src@FreeBSD.ORG Thu May 3 03:31:12 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3097A16A409 for ; Thu, 3 May 2007 03:31:12 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.177]) by mx1.freebsd.org (Postfix) with ESMTP id E3A2F13C484 for ; Thu, 3 May 2007 03:31:11 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by py-out-1112.google.com with SMTP id f31so289917pyh for ; Wed, 02 May 2007 20:31:11 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r5DPSNK/QSzpQxwNRLB8W2IcSq7H9AkcI0xI3g9fPqWprMdNG0pE+AsqqSS8j5JiDiSFijwIyEmdJOj+Rm4QlMe9j4K48RpMrUVkmLSA7wCRtsOeRgBZXH8aZyuSstWjxxPRAhOYzjLmbJTOTtDPXJxxHTCCH7A/BLTXyG2wC18= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k+cBOlzhPZ5StNJ8K1QFQwq2a6UdaNWHGmG5MjWPrFC8fuB+nHvJIdvjWKtWXTpXzJhndfBTlNlrC4jczohd6CDD/BVFngwl3/pm1+gW6GHW0A20gQPoBxw7p9WfiHws0QHX5lVYVrJMX7u7oj8gSD2eLkXf3bGwYTGF6AnVT74= Received: by 10.64.10.2 with SMTP id 2mr2543586qbj.1178163070956; Wed, 02 May 2007 20:31:10 -0700 (PDT) Received: by 10.64.196.16 with HTTP; Wed, 2 May 2007 20:31:10 -0700 (PDT) Message-ID: <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> Date: Thu, 3 May 2007 11:31:10 +0800 From: "Rong-en Fan" To: "Colin Percival" , kientzle@freebsd.org, portmgr@freebsd.org In-Reply-To: <200703151011.l2FABc9Z013002@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 03:31:12 -0000 On 3/15/07, Colin Percival wrote: > cperciva 2007-03-15 10:11:38 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tar write.c > Log: > Don't consider an lstat(2) failure to be an error (in the sense of > affecting the return value from bsdtar), since (a) it usually occurs > due to a perfectly innocent (and unavoidable) race condition where a > user deletes a file in the window between bsdtar reading a directory > and attempting to read the file; and (b) aside from printing a warning > message, bsdtar behaves exactly as if the file had been deleted prior > to bsdtar reading its parent directory. This commit makes 'make package' successfully even if the plist is wrong, i.e. it contains ``ghost'' files. Basically, $ tar zcvf a.tgz /aaa tar: /aaa: Cannot stat: No such file or directory It returns 0, so make package will be considered successful. That's why I only get chinese/CJK build failure on 5.x (this is merged to 6.x). I'm CC'ing kientzle@ and portmgr@ (since it affects our package building). Regards, Rong-En Fan. > > Reviewed by: kientzle > MFC after: 6 days > > Revision Changes Path > 1.57 +0 -1 src/usr.bin/tar/write.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > From owner-cvs-src@FreeBSD.ORG Thu May 3 04:33:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AAE1416A403; Thu, 3 May 2007 04:33:11 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8531313C457; Thu, 3 May 2007 04:33:11 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l434XB3T005734; Thu, 3 May 2007 04:33:11 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l434XBvW005733; Thu, 3 May 2007 04:33:11 GMT (envelope-from cperciva) Message-Id: <200705030433.l434XBvW005733@repoman.freebsd.org> From: Colin Percival Date: Thu, 3 May 2007 04:33:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 04:33:11 -0000 cperciva 2007-05-03 04:33:11 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: If lstat(2) fails, have bsdtar return a non-zero exit code if the failed path is one which was specified on the command line. This is a compromise between the situation prior to revision 1.57 (where a race between tar(1) and rm(1) could cause tar(1) to spuriously report an error) and the situation after revision 1.57 (where "tar -c /no/such/path" prints a warning but returns with an exit code of zero). Inspired by: rafan MFC after: 1 week Revision Changes Path 1.62 +10 -0 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Thu May 3 05:05:06 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A0C6216A401 for ; Thu, 3 May 2007 05:05:06 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from rm-rstar.sfu.ca (spamdamme.sfu.ca [142.58.101.10]) by mx1.freebsd.org (Postfix) with ESMTP id 812DA13C45A for ; Thu, 3 May 2007 05:05:06 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from hexahedron.daemonology.net (cperciva@fraser.sfu.ca [142.58.101.25]) by rm-rstar.sfu.ca (8.13.6/8.13.4/SFU-5.0H) with SMTP id l434Y6ce011106 for ; Wed, 2 May 2007 21:34:06 -0700 (PDT) X-Spam-Level: Spam-Level Received: (qmail 1788 invoked from network); 3 May 2007 04:34:05 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 3 May 2007 04:34:05 -0000 Message-ID: <4639663D.1020308@freebsd.org> Date: Wed, 02 May 2007 21:34:05 -0700 From: Colin Percival User-Agent: Thunderbird 1.5.0.9 (X11/20061227) MIME-Version: 1.0 To: Rong-en Fan References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> In-Reply-To: <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by antibody.sfu.ca running antivirus scanner Cc: cvs-src@freebsd.org, kientzle@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 05:05:06 -0000 Rong-en Fan wrote: > On 3/15/07, Colin Percival wrote: >> Modified files: >> usr.bin/tar write.c >> Log: >> Don't consider an lstat(2) failure to be an error (in the sense of >> affecting the return value from bsdtar) [...] > > This commit makes 'make package' successfully even if the plist is > wrong, i.e. it contains ``ghost'' files. Basically, > > $ tar zcvf a.tgz /aaa > tar: /aaa: Cannot stat: No such file or directory > > It returns 0, so make package will be considered successful. I've fixed this in revision 1.62. Colin Percival From owner-cvs-src@FreeBSD.ORG Thu May 3 05:16:38 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 486F616A401; Thu, 3 May 2007 05:16:38 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id 256A513C459; Thu, 3 May 2007 05:16:38 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from [10.0.0.222] (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id l435GbH7044558; Wed, 2 May 2007 22:16:37 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <46397035.7000606@freebsd.org> Date: Wed, 02 May 2007 22:16:37 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Colin Percival References: <200705030433.l434XBvW005733@repoman.freebsd.org> In-Reply-To: <200705030433.l434XBvW005733@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 05:16:38 -0000 Colin Percival wrote: > cperciva 2007-05-03 04:33:11 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tar write.c > Log: > If lstat(2) fails, have bsdtar return a non-zero exit code if the > failed path is one which was specified on the command line. This looks like a nice compromise. I wonder if it would be simpler to set non-zero exit only if this is the first path returned from tree_next() (which should be the path given on the command line). That would avoid the headache of having to perform a textual path comparison. A simple flag to indicate if this is the first time through the loop should suffice, I think. Tim From owner-cvs-src@FreeBSD.ORG Thu May 3 06:24:39 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 874FE16A403; Thu, 3 May 2007 06:24:39 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 71D8713C45B; Thu, 3 May 2007 06:24:39 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 0CA541A4D87; Wed, 2 May 2007 23:25:14 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id A8F0F513C5; Thu, 3 May 2007 02:24:38 -0400 (EDT) Date: Thu, 3 May 2007 02:24:38 -0400 From: Kris Kennaway To: Colin Percival Message-ID: <20070503062438.GA50698@xor.obsecurity.org> References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <4639663D.1020308@freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Rong-en Fan , cvs-all@freebsd.org, mi@FreeBSD.org, kientzle@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 06:24:39 -0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > Rong-en Fan wrote: > > On 3/15/07, Colin Percival wrote: > >> Modified files: > >> usr.bin/tar write.c > >> Log: > >> Don't consider an lstat(2) failure to be an error (in the sense of > >> affecting the return value from bsdtar) [...] > >=20 > > This commit makes 'make package' successfully even if the plist is > > wrong, i.e. it contains ``ghost'' files. Basically, > >=20 > > $ tar zcvf a.tgz /aaa > > tar: /aaa: Cannot stat: No such file or directory > >=20 > > It returns 0, so make package will be considered successful. >=20 > I've fixed this in revision 1.62. >=20 > Colin Percival Thanks, I think mi@ ran into this recently too. Kris --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD4DBQFGOYAmWry0BWjoQKURAmxKAJdgKCQPbO82f/Kx0yOrSmiz5VdlAKC1R5Vq 3EP40/sK1NLfprkX0mInPg== =UZJV -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY-- From owner-cvs-src@FreeBSD.ORG Thu May 3 07:06:31 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7917A16A403 for ; Thu, 3 May 2007 07:06:31 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.233]) by mx1.freebsd.org (Postfix) with ESMTP id 09FE413C458 for ; Thu, 3 May 2007 07:06:30 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by nz-out-0506.google.com with SMTP id s1so428464nze for ; Thu, 03 May 2007 00:06:30 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XWLhkPhRA34UBtarYZ3VTnkzl7JkO92m0kL0a1AOKc0FA9GVWOMs8hwE9ZL0qrJVT0bZRU9vaH2XdgyWKsbn1Z5DizkRo5OCP8XZBgBEiF5HglaCNaRsZ8d10QIpuCOmI8E30vorhLMK3pkr10xZw5jC/ARJhVtOg+zRgM8cRvE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=D4WgkDmpskBqujMlJkO/+CoGHFybj8fv3oeACMrTmImCfDa/TedJWmst4kVY2akppp5LtpQJP+ze5xRJzCd7+PBTB3olHQ5K3qkOm9MAaP4bxnaFFnIimjTPcGBnz0Nd8A2G1JKHMrm2/O7JaJoaESvpMhzwuBUQrLYZmSc3qXA= Received: by 10.65.114.11 with SMTP id r11mr2812149qbm.1178175990437; Thu, 03 May 2007 00:06:30 -0700 (PDT) Received: by 10.64.196.16 with HTTP; Thu, 3 May 2007 00:06:30 -0700 (PDT) Message-ID: <6eb82e0705030006hf7ea643q56ff66a86b3d6424@mail.gmail.com> Date: Thu, 3 May 2007 15:06:30 +0800 From: "Rong-en Fan" To: "Colin Percival" In-Reply-To: <4639663D.1020308@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> Cc: cvs-src@freebsd.org, kientzle@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 07:06:31 -0000 On 5/3/07, Colin Percival wrote: > Rong-en Fan wrote: > > On 3/15/07, Colin Percival wrote: > >> Modified files: > >> usr.bin/tar write.c > >> Log: > >> Don't consider an lstat(2) failure to be an error (in the sense of > >> affecting the return value from bsdtar) [...] > > > > This commit makes 'make package' successfully even if the plist is > > wrong, i.e. it contains ``ghost'' files. Basically, > > > > $ tar zcvf a.tgz /aaa > > tar: /aaa: Cannot stat: No such file or directory > > > > It returns 0, so make package will be considered successful. > > I've fixed this in revision 1.62. Thank you! > > Colin Percival > From owner-cvs-src@FreeBSD.ORG Thu May 3 08:56:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EDC5E16A400; Thu, 3 May 2007 08:56:20 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C7FA313C447; Thu, 3 May 2007 08:56:20 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l438uKDv087637; Thu, 3 May 2007 08:56:20 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l438uKo7087636; Thu, 3 May 2007 08:56:20 GMT (envelope-from thompsa) Message-Id: <200705030856.l438uKo7087636@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 3 May 2007 08:56:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 08:56:21 -0000 thompsa 2007-05-03 08:56:20 UTC FreeBSD src repository Modified files: sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h Log: - Add a disabled state for ports that can not be aggregated - Refine check for lacp links, set to disabled if not suitable Revision Changes Path 1.4 +18 -5 src/sys/net/ieee8023ad_lacp.c 1.3 +1 -0 src/sys/net/if_lagg.c 1.2 +2 -1 src/sys/net/if_lagg.h From owner-cvs-src@FreeBSD.ORG Thu May 3 09:07:37 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2CC7316A403; Thu, 3 May 2007 09:07:37 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0290C13C46E; Thu, 3 May 2007 09:07:37 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4397aNN091330; Thu, 3 May 2007 09:07:36 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4397aOq091329; Thu, 3 May 2007 09:07:36 GMT (envelope-from thompsa) Message-Id: <200705030907.l4397aOq091329@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 3 May 2007 09:07:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:07:37 -0000 thompsa 2007-05-03 09:07:36 UTC FreeBSD src repository Modified files: sys/net if_lagg.h Log: Fix flag descriptions. Revision Changes Path 1.3 +2 -2 src/sys/net/if_lagg.h From owner-cvs-src@FreeBSD.ORG Thu May 3 09:13:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 73E7616A40B for ; Thu, 3 May 2007 09:13:32 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id CA73F13C4BD for ; Thu, 3 May 2007 09:13:31 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 40820 invoked from network); 3 May 2007 08:34:34 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 3 May 2007 08:34:34 -0000 Message-ID: <4639A7BF.1010405@freebsd.org> Date: Thu, 03 May 2007 11:13:35 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Andrew Thompson References: <200705030856.l438uKo7087636@repoman.freebsd.org> In-Reply-To: <200705030856.l438uKo7087636@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:13:32 -0000 Andrew Thompson wrote: > thompsa 2007-05-03 08:56:20 UTC > > FreeBSD src repository > > Modified files: > sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h > Log: > - Add a disabled state for ports that can not be aggregated > - Refine check for lacp links, set to disabled if not suitable Andrew, would you be interested to implement the link bonding of 802.3ah EFM (Ethernet First Mile) as well? -- Andre From owner-cvs-src@FreeBSD.ORG Thu May 3 09:20:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D656916A401; Thu, 3 May 2007 09:20:16 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz [203.109.251.39]) by mx1.freebsd.org (Postfix) with ESMTP id 76D7E13C448; Thu, 3 May 2007 09:20:16 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: by heff.fud.org.nz (Postfix, from userid 1001) id 3FF0C1CC5A; Thu, 3 May 2007 21:20:15 +1200 (NZST) Date: Thu, 3 May 2007 21:20:15 +1200 From: Andrew Thompson To: Andre Oppermann Message-ID: <20070503092015.GC95099@heff.fud.org.nz> References: <200705030856.l438uKo7087636@repoman.freebsd.org> <4639A7BF.1010405@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4639A7BF.1010405@freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:20:16 -0000 On Thu, May 03, 2007 at 11:13:35AM +0200, Andre Oppermann wrote: > Andrew Thompson wrote: > >thompsa 2007-05-03 08:56:20 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h > > Log: > > - Add a disabled state for ports that can not be aggregated > > - Refine check for lacp links, set to disabled if not suitable > > Andrew, > > would you be interested to implement the link bonding of 802.3ah > EFM (Ethernet First Mile) as well? Certainly. I'll read the document on it soon but maybe you could describe it a bit more. Andrew From owner-cvs-src@FreeBSD.ORG Thu May 3 09:38:55 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6B1BE16A404; Thu, 3 May 2007 09:38:55 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 459A713C447; Thu, 3 May 2007 09:38:55 +0000 (UTC) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l439ctRd098235; Thu, 3 May 2007 09:38:55 GMT (envelope-from thomas@repoman.freebsd.org) Received: (from thomas@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l439cta9098234; Thu, 3 May 2007 09:38:55 GMT (envelope-from thomas) Message-Id: <200705030938.l439cta9098234@repoman.freebsd.org> From: Thomas Quinot Date: Thu, 3 May 2007 09:38:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/ata atapi-cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:38:55 -0000 thomas 2007-05-03 09:38:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ata atapi-cam.c Log: MFC rev. 1.52: (atapi_cb): Fix test for the presence of sense data. An incorrect condition was being tested, which would result in a system hang in some configurations. PR: kern/112119 Revision Changes Path 1.42.2.4 +2 -2 src/sys/dev/ata/atapi-cam.c From owner-cvs-src@FreeBSD.ORG Thu May 3 09:51:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D918416A40A; Thu, 3 May 2007 09:51:12 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B28C213C4AE; Thu, 3 May 2007 09:51:12 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l439pCE6001344; Thu, 3 May 2007 09:51:12 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l439pC6x001343; Thu, 3 May 2007 09:51:12 GMT (envelope-from kevlo) Message-Id: <200705030951.l439pC6x001343@repoman.freebsd.org> From: Kevin Lo Date: Thu, 3 May 2007 09:51:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c src/sys/arm/xscale/ixp425 avila_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:51:13 -0000 kevlo 2007-05-03 09:51:12 UTC FreeBSD src repository Modified files: sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/arm/xscale/ixp425 avila_machdep.c Log: Remove sa1_cache_clean_addr. It isn't needed. Revision Changes Path 1.6 +0 -2 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.27 +0 -2 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.4 +0 -2 src/sys/arm/xscale/ixp425/avila_machdep.c From owner-cvs-src@FreeBSD.ORG Thu May 3 09:52:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8897D16A400 for ; Thu, 3 May 2007 09:52:32 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id E3D0013C46A for ; Thu, 3 May 2007 09:52:31 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 41301 invoked from network); 3 May 2007 09:13:34 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 3 May 2007 09:13:34 -0000 Message-ID: <4639B0E3.1060109@freebsd.org> Date: Thu, 03 May 2007 11:52:35 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Andrew Thompson References: <200705030856.l438uKo7087636@repoman.freebsd.org> <4639A7BF.1010405@freebsd.org> <20070503092015.GC95099@heff.fud.org.nz> In-Reply-To: <20070503092015.GC95099@heff.fud.org.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:52:32 -0000 Andrew Thompson wrote: > On Thu, May 03, 2007 at 11:13:35AM +0200, Andre Oppermann wrote: >> Andrew Thompson wrote: >>> thompsa 2007-05-03 08:56:20 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/net ieee8023ad_lacp.c if_lagg.c if_lagg.h >>> Log: >>> - Add a disabled state for ports that can not be aggregated >>> - Refine check for lacp links, set to disabled if not suitable >> Andrew, >> >> would you be interested to implement the link bonding of 802.3ah >> EFM (Ethernet First Mile) as well? > > Certainly. I'll read the document on it soon but maybe you could > describe it a bit more. The most interesting feature of 802.3ah are: OAM - Operations and maintenance: o detailed link failure indication o MAC layer ping (Ethernet ping on layer2) o remote loopback control for diagnostics purposes o link monitoring x this is applicable to the generic ethernet layer Ethernet Link aggregation o aggregation of links with differing speeds and latency o ordered delivery of frames o dynamic discovery and addition/removal of links o http://www.ieee802.org/3/efm/baseline/fosmark_1_0302.pdf -- Andre From owner-cvs-src@FreeBSD.ORG Thu May 3 09:56:53 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E2FF16A404; Thu, 3 May 2007 09:56:53 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 587B313C480; Thu, 3 May 2007 09:56:53 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l439ureT002807; Thu, 3 May 2007 09:56:53 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l439urXG002806; Thu, 3 May 2007 09:56:53 GMT (envelope-from yar) Message-Id: <200705030956.l439urXG002806@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 3 May 2007 09:56:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/mdmfs mdmfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 09:56:53 -0000 yar 2007-05-03 09:56:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/mdmfs mdmfs.c Log: MFC rev. 1.32: Fix a typo: argv -> argvp. Rationale: We are interested in the current (last) element of the argv array there, not in its first element. [...] Also add a comment that the argv array ends up null-terminated in any case (it's due to the design of the for loop) as an answer to a possible question why the whole argv isn't zero-filled. Revision Changes Path 1.23.2.4 +2 -1 src/sbin/mdmfs/mdmfs.c From owner-cvs-src@FreeBSD.ORG Thu May 3 11:13:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A0F2316A400; Thu, 3 May 2007 11:13:59 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 79F7913C459; Thu, 3 May 2007 11:13:59 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43BDxwP018852; Thu, 3 May 2007 11:13:59 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43BDxMs018851; Thu, 3 May 2007 11:13:59 GMT (envelope-from sobomax) Message-Id: <200705031113.l43BDxMs018851@repoman.freebsd.org> From: Maxim Sobolev Date: Thu, 3 May 2007 11:13:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/ia32 ia32_signal.c src/sys/ia64/ia32 ia32_signal.c src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 11:13:59 -0000 sobomax 2007-05-03 11:13:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/ia32 ia32_signal.c sys/ia64/ia32 ia32_signal.c sys/compat/freebsd32 syscalls.master Log: MFC: Implement 32 bit getcontext/setcontext/swapcontext on amd64. Still stubs for ia64 to keep it compiling. These are used by 32 bit apps such as gdb. Revision Changes Path 1.10.8.1 +163 -0 src/sys/amd64/ia32/ia32_signal.c 1.50.2.11 +7 -6 src/sys/compat/freebsd32/syscalls.master 1.7.8.2 +21 -0 src/sys/ia64/ia32/ia32_signal.c From owner-cvs-src@FreeBSD.ORG Thu May 3 11:18:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68E2116A403; Thu, 3 May 2007 11:18:45 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 41E8713C44C; Thu, 3 May 2007 11:18:45 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43BIj4s019232; Thu, 3 May 2007 11:18:45 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43BIjjx019231; Thu, 3 May 2007 11:18:45 GMT (envelope-from sobomax) Message-Id: <200705031118.l43BIjjx019231@repoman.freebsd.org> From: Maxim Sobolev Date: Thu, 3 May 2007 11:18:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 11:18:45 -0000 sobomax 2007-05-03 11:18:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regen after addition of 32bit versons of getcontext, setcontext and swapcontext. Revision Changes Path 1.38.2.12 +14 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.38.2.12 +4 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.29.2.12 +4 -4 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.39.2.12 +4 -4 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Thu May 3 11:34:37 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 995E716A400; Thu, 3 May 2007 11:34:37 +0000 (UTC) (envelope-from benjsc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 72DCE13C44B; Thu, 3 May 2007 11:34:37 +0000 (UTC) (envelope-from benjsc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43BYboT022229; Thu, 3 May 2007 11:34:37 GMT (envelope-from benjsc@repoman.freebsd.org) Received: (from benjsc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43BYb4m022228; Thu, 3 May 2007 11:34:37 GMT (envelope-from benjsc) Message-Id: <200705031134.l43BYb4m022228@repoman.freebsd.org> From: Benjamin Close Date: Thu, 3 May 2007 11:34:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar/calendars calendar.freebsd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 11:34:37 -0000 benjsc 2007-05-03 11:34:36 UTC FreeBSD src repository Modified files: usr.bin/calendar/calendars calendar.freebsd Log: Add myself Approved by: mlaier (mentor) Revision Changes Path 1.215 +1 -0 src/usr.bin/calendar/calendars/calendar.freebsd From owner-cvs-src@FreeBSD.ORG Thu May 3 13:40:54 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39BA716A401; Thu, 3 May 2007 13:40:54 +0000 (UTC) (envelope-from mi+metlife@aldan.algebra.com) Received: from bonkers.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by mx1.freebsd.org (Postfix) with ESMTP id D114313C45B; Thu, 3 May 2007 13:40:53 +0000 (UTC) (envelope-from mi+metlife@aldan.algebra.com) Received: from [127.0.0.1] (localhost [127.0.0.1]) by bonkers.video-collage.com (8.14.1/8.14.1) with ESMTP id l43DTrtU048612; Thu, 3 May 2007 09:29:53 -0400 (EDT) (envelope-from mi+metlife@aldan.algebra.com) Message-ID: <4639E3D0.1050208@aldan.algebra.com> Date: Thu, 03 May 2007 09:29:52 -0400 From: "Mikhail T." User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Kris Kennaway , Rong-en Fan , kientzle@freebsd.org, portmgr@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> <20070503062438.GA50698@xor.obsecurity.org> In-Reply-To: <20070503062438.GA50698@xor.obsecurity.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.88.7/3200/Thu May 3 07:42:47 2007 on bonkers.video-collage.com X-Virus-Status: Clean Cc: Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 13:40:54 -0000 Kris Kennaway wrote: > On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > >> Rong-en Fan wrote: >> >>> On 3/15/07, Colin Percival wrote: >>> >>>> Modified files: >>>> usr.bin/tar write.c >>>> Log: >>>> Don't consider an lstat(2) failure to be an error (in the sense of >>>> affecting the return value from bsdtar) [...] >>>> >>> This commit makes 'make package' successfully even if the plist is >>> wrong, i.e. it contains ``ghost'' files. Basically, >>> >>> $ tar zcvf a.tgz /aaa >>> tar: /aaa: Cannot stat: No such file or directory >>> >>> It returns 0, so make package will be considered successful. >>> >> I've fixed this in revision 1.62. >> >> Colin Percival >> > > Thanks, I think mi@ ran into this recently too. > So, this is fixed now? I guess, the fears, that fixing it would require fixing multitude of ports, were somewhat ungrounded. -mi From owner-cvs-src@FreeBSD.ORG Thu May 3 13:57:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E23E16A401; Thu, 3 May 2007 13:57:20 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id DAEDF13C45D; Thu, 3 May 2007 13:57:19 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43DvJ6S055780; Thu, 3 May 2007 13:57:19 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43DvJcf055779; Thu, 3 May 2007 13:57:19 GMT (envelope-from dwmalone) Message-Id: <200705031357.l43DvJcf055779@repoman.freebsd.org> From: David Malone Date: Thu, 3 May 2007 13:57:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/lastcomm Makefile lastcomm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 13:57:20 -0000 dwmalone 2007-05-03 13:57:19 UTC FreeBSD src repository Modified files: usr.bin/lastcomm Makefile lastcomm.c Log: Initialise variable size so that reading stdin works deterministically. Add missing include. Default to WARNS=6. Revision Changes Path 1.4 +1 -0 src/usr.bin/lastcomm/Makefile 1.25 +4 -2 src/usr.bin/lastcomm/lastcomm.c From owner-cvs-src@FreeBSD.ORG Thu May 3 14:42:42 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C3F0A16A401; Thu, 3 May 2007 14:42:42 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B415313C458; Thu, 3 May 2007 14:42:42 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43EggKZ064070; Thu, 3 May 2007 14:42:42 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43Egggi064069; Thu, 3 May 2007 14:42:42 GMT (envelope-from rwatson) Message-Id: <200705031442.l43Egggi064069@repoman.freebsd.org> From: Robert Watson Date: Thu, 3 May 2007 14:42:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 14:42:42 -0000 rwatson 2007-05-03 14:42:42 UTC FreeBSD src repository Modified files: sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c sys/netinet sctputil.c sys/sys socketvar.h Log: sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK flags on each socket buffer with the socket buffer's mutex. This sleep lock is used to serialize I/O on sockets in order to prevent I/O interlacing. This change replaces the custom sleep lock with an sx(9) lock, which results in marginally better performance, better handling of contention during simultaneous socket I/O across multiple threads, and a cleaner separation between the different layers of locking in socket buffers. Specifically, the socket buffer mutex is now solely responsible for serializing simultaneous operation on the socket buffer data structure, and not for I/O serialization. While here, fix two historic bugs: (1) a bug allowing I/O to be occasionally interlaced during long I/O operations (discovere by Isilon). (2) a bug in which failed non-blocking acquisition of the socket buffer I/O serialization lock might be ignored (discovered by sam). SCTP portion of this patch submitted by rrs. Revision Changes Path 1.2 +0 -8 src/sys/kern/uipc_debug.c 1.169 +16 -19 src/sys/kern/uipc_sockbuf.c 1.298 +68 -61 src/sys/kern/uipc_socket.c 1.254 +0 -4 src/sys/kern/uipc_syscalls.c 1.24 +10 -15 src/sys/netinet/sctputil.c 1.158 +4 -22 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Thu May 3 15:34:44 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E015F16A40E; Thu, 3 May 2007 15:34:44 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-5.cisco.com (sj-iport-5.cisco.com [171.68.10.87]) by mx1.freebsd.org (Postfix) with ESMTP id 7303C13C48A; Thu, 3 May 2007 15:34:42 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-7.cisco.com ([171.68.10.88]) by sj-iport-5.cisco.com with ESMTP; 03 May 2007 08:34:38 -0700 X-IronPort-AV: i="4.14,486,1170662400"; d="scan'208"; a="418277213:sNHT8905652246" Received: from sj-core-3.cisco.com (sj-core-3.cisco.com [171.68.223.137]) by sj-dkim-7.cisco.com (8.12.11/8.12.11) with ESMTP id l43FYbMi029759; Thu, 3 May 2007 08:34:37 -0700 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-3.cisco.com (8.12.10/8.12.6) with ESMTP id l43FYNAi017244; Thu, 3 May 2007 15:34:37 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 3 May 2007 08:34:32 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 3 May 2007 08:34:32 -0700 Message-ID: <463A0198.3040507@cisco.com> Date: Thu, 03 May 2007 11:36:56 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 FreeBSD/i386 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Robert Watson References: <200705031442.l43Egggi064069@repoman.freebsd.org> In-Reply-To: <200705031442.l43Egggi064069@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 May 2007 15:34:32.0222 (UTC) FILETIME=[8BBB93E0:01C78D98] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1914; t=1178206477; x=1179070477; c=relaxed/simple; s=sjdkim7002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/kern=20uipc_debug.c=20uipc_ sockbuf.c=20uipc_socket.c=0A=20=20=20=20=20=20=20=20=20uipc_syscalls.c=20s rc/sys/netinet=20sctputil.c=20src/sys/sys=20socketvar.h |Sender:=20; bh=LPtDY1euVNg3n6Bi2cIJHASmqQDNJSMpQEVlXZkXhZM=; b=Aho234mb55MRlknoB/j5SikCTXIehVfSwMnmxaLsFWjT/NeGbw/d1I8f/H15FTMceOoLfYnT UoUzNQY+GaGC4wnQk8D8TkMZHwabp8IfllF3AHbq6J9WLRiGQ6RLo5eG; Authentication-Results: sj-dkim-7; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim7002 verified; ); Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 15:34:45 -0000 Robert Watson wrote: > rwatson 2007-05-03 14:42:42 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c > uipc_syscalls.c > sys/netinet sctputil.c > sys/sys socketvar.h > Log: > sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK flags > on each socket buffer with the socket buffer's mutex. This sleep lock is > used to serialize I/O on sockets in order to prevent I/O interlacing. > > This change replaces the custom sleep lock with an sx(9) lock, which > results in marginally better performance, better handling of contention > during simultaneous socket I/O across multiple threads, and a cleaner > separation between the different layers of locking in socket buffers. > Specifically, the socket buffer mutex is now solely responsible for > serializing simultaneous operation on the socket buffer data structure, > and not for I/O serialization. > > While here, fix two historic bugs: > > (1) a bug allowing I/O to be occasionally interlaced during long I/O > operations (discovere by Isilon). > > (2) a bug in which failed non-blocking acquisition of the socket buffer > I/O serialization lock might be ignored (discovered by sam). > > SCTP portion of this patch submitted by rrs. > > Revision Changes Path > 1.2 +0 -8 src/sys/kern/uipc_debug.c > 1.169 +16 -19 src/sys/kern/uipc_sockbuf.c > 1.298 +68 -61 src/sys/kern/uipc_socket.c > 1.254 +0 -4 src/sys/kern/uipc_syscalls.c > 1.24 +10 -15 src/sys/netinet/sctputil.c > 1.158 +4 -22 src/sys/sys/socketvar.h > Cool .. great work Robert!!! R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell) From owner-cvs-src@FreeBSD.ORG Thu May 3 16:03:38 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C53316A410; Thu, 3 May 2007 16:03:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 633D913C489; Thu, 3 May 2007 16:03:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 560381A4DA3; Thu, 3 May 2007 09:04:13 -0700 (PDT) Date: Thu, 3 May 2007 09:04:13 -0700 From: Alfred Perlstein To: Randall Stewart Message-ID: <20070503160413.GL67243@elvis.mu.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> <463A0198.3040507@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463A0198.3040507@cisco.com> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 16:03:38 -0000 * Randall Stewart [070503 08:35] wrote: > Robert Watson wrote: > >rwatson 2007-05-03 14:42:42 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c > > uipc_syscalls.c > > sys/netinet sctputil.c > > sys/sys socketvar.h > > Log: > > sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK > > flags > > on each socket buffer with the socket buffer's mutex. This sleep lock is > > used to serialize I/O on sockets in order to prevent I/O interlacing. I'm looking at the diff... it looks like you dropped signal handling from sblock? Is that true and if so was that intentional? I'm worried that the following situation can happen: process A: init large write to socket. process A: gets sblock process A: fills socketbuffer process A: waits for space. process B: tries to write to socket Now process B is in an uninterruptable wait until the remote side drains the pipe. The same problem might happen (even easier to reproduce) when there are multiple readers. Of course this all depends on me missing something. Can you explain? -Alfred From owner-cvs-src@FreeBSD.ORG Thu May 3 16:23:12 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8145516A403; Thu, 3 May 2007 16:23:12 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-5.cisco.com (sj-iport-5.cisco.com [171.68.10.87]) by mx1.freebsd.org (Postfix) with ESMTP id 4371A13C43E; Thu, 3 May 2007 16:23:12 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-6.cisco.com ([171.68.10.81]) by sj-iport-5.cisco.com with ESMTP; 03 May 2007 09:23:12 -0700 X-IronPort-AV: i="4.14,486,1170662400"; d="scan'208"; a="418300332:sNHT59738470" Received: from sj-core-3.cisco.com (sj-core-3.cisco.com [171.68.223.137]) by sj-dkim-6.cisco.com (8.12.11/8.12.11) with ESMTP id l43GNBbt002683; Thu, 3 May 2007 09:23:11 -0700 Received: from xbh-sjc-231.amer.cisco.com (xbh-sjc-231.cisco.com [128.107.191.100]) by sj-core-3.cisco.com (8.12.10/8.12.6) with ESMTP id l43GNBA8011323; Thu, 3 May 2007 16:23:11 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-231.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 3 May 2007 09:23:11 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 3 May 2007 09:23:11 -0700 Message-ID: <463A0CFF.60600@cisco.com> Date: Thu, 03 May 2007 12:25:35 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 FreeBSD/i386 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Alfred Perlstein , Robert Watson References: <200705031442.l43Egggi064069@repoman.freebsd.org> <463A0198.3040507@cisco.com> <20070503160413.GL67243@elvis.mu.org> In-Reply-To: <20070503160413.GL67243@elvis.mu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 May 2007 16:23:11.0284 (UTC) FILETIME=[57A11740:01C78D9F] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1962; t=1178209391; x=1179073391; c=relaxed/simple; s=sjdkim6002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/kern=20uipc_debug.c=20uipc_ sockbuf.c=20uipc_socket.c=0A=20uipc_syscalls.c=20src/sys/netinet=20sctputi l.c=20src/sys/sys=20socketvar.h |Sender:=20; bh=+FT/a8yXnR8d/yTZ+KpDVClJmqc3YLxtiYRJF4Zd+cs=; b=Ni4kyOoJKsh5sDZUThlXWwN9z+wEcqch/pDoIxKDGUUblAFjx2CeEoeaVWGRubaqRtvcJXHD 4RxlJh9YA3GvoN0XoRy1FsR03A4epNmb8Et2BPj+A/chv92Fv/TjNvSg; Authentication-Results: sj-dkim-6; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim6002 verified; ); Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 16:23:12 -0000 Alfred Perlstein wrote: > * Randall Stewart [070503 08:35] wrote: >> Robert Watson wrote: >>> rwatson 2007-05-03 14:42:42 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c >>> uipc_syscalls.c >>> sys/netinet sctputil.c >>> sys/sys socketvar.h >>> Log: >>> sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK >>> flags >>> on each socket buffer with the socket buffer's mutex. This sleep lock is >>> used to serialize I/O on sockets in order to prevent I/O interlacing. > > I'm looking at the diff... it looks like you dropped signal handling > from sblock? Is that true and if so was that intentional? > > I'm worried that the following situation can happen: > > process A: init large write to socket. > process A: gets sblock > process A: fills socketbuffer > process A: waits for space. > process B: tries to write to socket > > Now process B is in an uninterruptable wait until the remote > side drains the pipe. > > The same problem might happen (even easier to reproduce) when there > are multiple readers. > > Of course this all depends on me missing something. > > Can you explain? > > -Alfred > Well.. I can't.. I just did a small part of this.. I did not look at the code that Robert did on the socket buffer side of things.. I only did the sblock() stuff that Robert wanted in the sctputil.c Now looking at the sx_lock code (for the first time).. I too don't see how it is interrupted.. but I am sure Robert thought of this.. I am chasing another SCTP bug right now and have a huge integration project going on as well ... so I don't have time to look at this.. Robert, what do you think of this scenario? R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell) From owner-cvs-src@FreeBSD.ORG Thu May 3 17:08:17 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4B6EC16A407; Thu, 3 May 2007 17:08:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0A8B913C480; Thu, 3 May 2007 17:08:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 7AE4347534; Thu, 3 May 2007 13:08:16 -0400 (EDT) Date: Thu, 3 May 2007 18:08:16 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20070503160413.GL67243@elvis.mu.org> Message-ID: <20070503180707.D30997@fledge.watson.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> <463A0198.3040507@cisco.com> <20070503160413.GL67243@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Randall Stewart , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:08:17 -0000 On Thu, 3 May 2007, Alfred Perlstein wrote: > * Randall Stewart [070503 08:35] wrote: >> Robert Watson wrote: >>> rwatson 2007-05-03 14:42:42 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c >>> uipc_syscalls.c >>> sys/netinet sctputil.c >>> sys/sys socketvar.h >>> Log: >>> sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK >>> flags >>> on each socket buffer with the socket buffer's mutex. This sleep lock is >>> used to serialize I/O on sockets in order to prevent I/O interlacing. > > I'm looking at the diff... it looks like you dropped signal handling from > sblock? Is that true and if so was that intentional? > > I'm worried that the following situation can happen: > > process A: init large write to socket. > process A: gets sblock > process A: fills socketbuffer > process A: waits for space. > process B: tries to write to socket > > Now process B is in an uninterruptable wait until the remote side drains the > pipe. > > The same problem might happen (even easier to reproduce) when there are > multiple readers. > > Of course this all depends on me missing something. > > Can you explain? You are entirely right -- I'm not sure how I missed the SB_NOINTR flag semantics in sb_lock(), but apparently I did. I'm talking to Attilio right now about adding an interruptible version of the sleeping exclusive lock acquire and will follow up on this shortly. Thanks for pointing this out! Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Thu May 3 17:10:03 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E42DC16A402; Thu, 3 May 2007 17:10:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CF89513C48C; Thu, 3 May 2007 17:10:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id F28F61A4D82; Thu, 3 May 2007 10:10:38 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 17A685138E; Thu, 3 May 2007 13:10:03 -0400 (EDT) Date: Thu, 3 May 2007 13:10:02 -0400 From: Kris Kennaway To: "Mikhail T." Message-ID: <20070503171002.GA86430@xor.obsecurity.org> References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> <20070503062438.GA50698@xor.obsecurity.org> <4639E3D0.1050208@aldan.algebra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4639E3D0.1050208@aldan.algebra.com> User-Agent: Mutt/1.4.2.2i Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Kris Kennaway , Rong-en Fan , cvs-all@freebsd.org, kientzle@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:10:04 -0000 On Thu, May 03, 2007 at 09:29:52AM -0400, Mikhail T. wrote: > Kris Kennaway wrote: > >On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > > > >>Rong-en Fan wrote: > >> > >>>On 3/15/07, Colin Percival wrote: > >>> > >>>> Modified files: > >>>> usr.bin/tar write.c > >>>> Log: > >>>> Don't consider an lstat(2) failure to be an error (in the sense of > >>>> affecting the return value from bsdtar) [...] > >>>> > >>>This commit makes 'make package' successfully even if the plist is > >>>wrong, i.e. it contains ``ghost'' files. Basically, > >>> > >>>$ tar zcvf a.tgz /aaa > >>>tar: /aaa: Cannot stat: No such file or directory > >>> > >>>It returns 0, so make package will be considered successful. > >>> > >>I've fixed this in revision 1.62. > >> > >>Colin Percival > >> > > > >Thanks, I think mi@ ran into this recently too. > > > So, this is fixed now? A bug is fixed, dunno off-hand it's the one you ran into. > I guess, the fears, that fixing it would require > fixing multitude of ports, were somewhat ungrounded. Relax, it was just a guess. Kris From owner-cvs-src@FreeBSD.ORG Thu May 3 17:27:08 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FF0116A404 for ; Thu, 3 May 2007 17:27:08 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from rm-rstar.sfu.ca (rm-rstar.sfu.ca [142.58.101.21]) by mx1.freebsd.org (Postfix) with ESMTP id 399EF13C46E for ; Thu, 3 May 2007 17:27:08 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from hexahedron.daemonology.net (cperciva@fraser.sfu.ca [142.58.101.25]) by rm-rstar.sfu.ca (8.13.6/8.13.4/SFU-5.0H) with SMTP id l43HR46R007023 for ; Thu, 3 May 2007 10:27:05 -0700 (PDT) X-Spam-Level: Spam-Level Received: (qmail 5146 invoked from network); 3 May 2007 17:20:23 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 3 May 2007 17:20:23 -0000 Message-ID: <463A19D6.6070400@freebsd.org> Date: Thu, 03 May 2007 10:20:22 -0700 From: Colin Percival User-Agent: Thunderbird 1.5.0.9 (X11/20061227) MIME-Version: 1.0 To: Tim Kientzle References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org> In-Reply-To: <46397035.7000606@freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by antibody.sfu.ca running antivirus scanner Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:27:08 -0000 Tim Kientzle wrote: > I wonder if it would be simpler to set non-zero exit only > if this is the first path returned from tree_next() (which > should be the path given on the command line). That > would avoid the headache of having to perform a textual > path comparison. > > A simple flag to indicate if this is the first time > through the loop should suffice, I think. Hmm... I considered this, but I wasn't sure if there were any edge cases where the first path returned by tree_next might not be the path passed to tree_open; so I decided to take the route which I knew would always work. If you're sure that a first-time-through-the-loop flag will work, feel free to change this. :-) Colin Percival From owner-cvs-src@FreeBSD.ORG Thu May 3 17:30:08 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 202E816A404; Thu, 3 May 2007 17:30:08 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0A40013C447; Thu, 3 May 2007 17:30:08 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 480261A4D93; Thu, 3 May 2007 10:30:43 -0700 (PDT) Date: Thu, 3 May 2007 10:30:43 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20070503173043.GM67243@elvis.mu.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> <463A0198.3040507@cisco.com> <20070503160413.GL67243@elvis.mu.org> <20070503180707.D30997@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070503180707.D30997@fledge.watson.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, Randall Stewart , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:30:08 -0000 * Robert Watson [070503 10:08] wrote: > > > > >Now process B is in an uninterruptable wait until the remote side drains > >the pipe. > > > >The same problem might happen (even easier to reproduce) when there are > >multiple readers. > > > >Of course this all depends on me missing something. > > > >Can you explain? > > You are entirely right -- I'm not sure how I missed the SB_NOINTR flag > semantics in sb_lock(), but apparently I did. I'm talking to Attilio right > now about adding an interruptible version of the sleeping exclusive lock > acquire and will follow up on this shortly. Thanks for pointing this out! OK, please do your usual awesome benchmarking though so that this potential fix doesn't wind up being a performance pessimizing stopgap. I'm somewhat surprised that an attempt to move from sleep to cv based rendevous wasn't attempted first. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Thu May 3 20:30:17 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5C9F616A404; Thu, 3 May 2007 20:30:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 9E1F513C46E; Thu, 3 May 2007 20:30:16 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 5678346B80; Thu, 3 May 2007 16:30:15 -0400 (EDT) Date: Thu, 3 May 2007 21:30:15 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20070503173043.GM67243@elvis.mu.org> Message-ID: <20070503212712.C32808@fledge.watson.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> <463A0198.3040507@cisco.com> <20070503160413.GL67243@elvis.mu.org> <20070503180707.D30997@fledge.watson.org> <20070503173043.GM67243@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Randall Stewart , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 20:30:17 -0000 On Thu, 3 May 2007, Alfred Perlstein wrote: > * Robert Watson [070503 10:08] wrote: > >>> Now process B is in an uninterruptable wait until the remote side drains >>> the pipe. >>> >>> The same problem might happen (even easier to reproduce) when there are >>> multiple readers. >>> >>> Of course this all depends on me missing something. >>> >>> Can you explain? >> >> You are entirely right -- I'm not sure how I missed the SB_NOINTR flag >> semantics in sb_lock(), but apparently I did. I'm talking to Attilio right >> now about adding an interruptible version of the sleeping exclusive lock >> acquire and will follow up on this shortly. Thanks for pointing this out! > > OK, please do your usual awesome benchmarking though so that this potential > fix doesn't wind up being a performance pessimizing stopgap. Certainly. Attilio is working on producing patches to add signal-aware versions of the two sleeping locking primitives (sx_xlock and sx_slock) used here. Assuming this goes into CVS in the next day or so, I'll fix up the changes as-is; otherwise, I'll back them out until the necessary sx(9) extensions are in place. > I'm somewhat surprised that an attempt to move from sleep to cv based > rendevous wasn't attempted first. The goal of the exercise was to move from a custom locking primitive to a standard locking primitive. Replacing a hacked together lock constructed with signal and msleep with a hacked together lock constructed with condition variables and mutexes wouldn't improve the world a whole lot. Unfortunately, I overlooked the signal interruption bit of it, which requires minor extensions to sx(9) in order to address. Hopefully that will be done shortly. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Thu May 3 22:17:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CE8716A403; Thu, 3 May 2007 22:17:36 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6644B13C455; Thu, 3 May 2007 22:17:36 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43MHaUN070995; Thu, 3 May 2007 22:17:36 GMT (envelope-from stas@repoman.freebsd.org) Received: (from stas@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43MHajY070991; Thu, 3 May 2007 22:17:36 GMT (envelope-from stas) Message-Id: <200705032217.l43MHajY070991@repoman.freebsd.org> From: Stanislav Sedov Date: Thu, 3 May 2007 22:17:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/top commands.c top.X X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 22:17:36 -0000 stas 2007-05-03 22:17:36 UTC FreeBSD src repository (ports committer) Modified files: contrib/top commands.c top.X Log: - Add documentation notes for the 'a' option, forgotten in the previous commit. commands.c [1] top.X Suggested by: rafan [1] Revision Changes Path 1.14 +1 -0 src/contrib/top/commands.c 1.19 +3 -0 src/contrib/top/top.X From owner-cvs-src@FreeBSD.ORG Thu May 3 22:39:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 32C2916A401; Thu, 3 May 2007 22:39:25 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0C7C313C447; Thu, 3 May 2007 22:39:25 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43MdOGU074279; Thu, 3 May 2007 22:39:24 GMT (envelope-from stas@repoman.freebsd.org) Received: (from stas@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43MdOR6074278; Thu, 3 May 2007 22:39:24 GMT (envelope-from stas) Message-Id: <200705032239.l43MdOR6074278@repoman.freebsd.org> From: Stanislav Sedov Date: Thu, 3 May 2007 22:39:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc services X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 22:39:25 -0000 stas 2007-05-03 22:39:24 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_6) etc services Log: - MFC up to 1.106: * add hpiod and hpssd (1.106) * add amanda control tcp port (1.105) * sync xmmp service names with IANA (1.104). Revision Changes Path 1.102.8.2 +9 -4 src/etc/services From owner-cvs-src@FreeBSD.ORG Thu May 3 22:39:53 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3123316A406; Thu, 3 May 2007 22:39:53 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0A73B13C44C; Thu, 3 May 2007 22:39:53 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l43Mdqwp074311; Thu, 3 May 2007 22:39:52 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l43Mdqc2074310; Thu, 3 May 2007 22:39:52 GMT (envelope-from thompsa) Message-Id: <200705032239.l43Mdqc2074310@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 3 May 2007 22:39:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_softdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 22:39:53 -0000 thompsa 2007-05-03 22:39:52 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_softdep.c Log: Add a newline to the printf message. Revision Changes Path 1.210 +1 -1 src/sys/ufs/ffs/ffs_softdep.c From owner-cvs-src@FreeBSD.ORG Fri May 4 00:00:12 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CACB416A416; Fri, 4 May 2007 00:00:12 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B8A6F13C44C; Fri, 4 May 2007 00:00:12 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4400CuK088088; Fri, 4 May 2007 00:00:12 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4400CtD088050; Fri, 4 May 2007 00:00:12 GMT (envelope-from jfv) Message-Id: <200705040000.l4400CtD088050@repoman.freebsd.org> From: Jack F Vogel Date: Fri, 4 May 2007 00:00:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE README e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 00:00:13 -0000 jfv 2007-05-04 00:00:12 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk sys/dev/em LICENSE README if_em.c if_em.h sys/modules/em Makefile Added files: sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c e1000_82575.h e1000_api.c e1000_api.h e1000_defines.h e1000_hw.h e1000_ich8lan.c e1000_ich8lan.h e1000_mac.c e1000_mac.h e1000_manage.c e1000_manage.h e1000_nvm.c e1000_nvm.h e1000_osdep.h e1000_phy.c e1000_phy.h e1000_regs.h Removed files: sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h Log: Merge in the new driver (6.5.0) of Intel. This has a new shared code infrastructure that is family specific and modular. There is also support for our latest gigabit nic, the 82575 that is MSI/X and multiqueue capable. The new shared code changes some interfaces to the core code but testing at Intel has been going on for months, it is fairly stable. I have attempted to be careful in retaining any fixes that CURRENT had and we did not, I apologize in advance if any thing gets clobbered, I'm sure I'll hear about it :) Approved by pdeuskar Revision Changes Path 1.1199 +26 -2 src/sys/conf/files 1.82 +3 -0 src/sys/conf/kern.pre.mk 1.6 +28 -28 src/sys/dev/em/LICENSE 1.14 +81 -37 src/sys/dev/em/README 1.1 +1383 -0 src/sys/dev/em/e1000_80003es2lan.c (new) 1.1 +96 -0 src/sys/dev/em/e1000_80003es2lan.h (new) 1.1 +677 -0 src/sys/dev/em/e1000_82540.c (new) 1.1 +1312 -0 src/sys/dev/em/e1000_82541.c (new) 1.1 +93 -0 src/sys/dev/em/e1000_82541.h (new) 1.1 +558 -0 src/sys/dev/em/e1000_82542.c (new) 1.1 +1650 -0 src/sys/dev/em/e1000_82543.c (new) 1.1 +52 -0 src/sys/dev/em/e1000_82543.h (new) 1.1 +1340 -0 src/sys/dev/em/e1000_82571.c (new) 1.1 +49 -0 src/sys/dev/em/e1000_82571.h (new) 1.1 +1528 -0 src/sys/dev/em/e1000_82575.c (new) 1.1 +284 -0 src/sys/dev/em/e1000_82575.h (new) 1.1 +1213 -0 src/sys/dev/em/e1000_api.c (new) 1.1 +163 -0 src/sys/dev/em/e1000_api.h (new) 1.1 +1403 -0 src/sys/dev/em/e1000_defines.h (new) 1.1 +724 -0 src/sys/dev/em/e1000_hw.h (new) 1.1 +2482 -0 src/sys/dev/em/e1000_ich8lan.c (new) 1.1 +117 -0 src/sys/dev/em/e1000_ich8lan.h (new) 1.1 +1987 -0 src/sys/dev/em/e1000_mac.c (new) 1.1 +93 -0 src/sys/dev/em/e1000_mac.h (new) 1.1 +391 -0 src/sys/dev/em/e1000_manage.c (new) 1.1 +90 -0 src/sys/dev/em/e1000_manage.h (new) 1.1 +900 -0 src/sys/dev/em/e1000_nvm.c (new) 1.1 +68 -0 src/sys/dev/em/e1000_nvm.h (new) 1.1 +188 -0 src/sys/dev/em/e1000_osdep.h (new) 1.1 +2022 -0 src/sys/dev/em/e1000_phy.c (new) 1.1 +168 -0 src/sys/dev/em/e1000_phy.h (new) 1.1 +455 -0 src/sys/dev/em/e1000_regs.h (new) 1.172 +1620 -807 src/sys/dev/em/if_em.c 1.58 +77 -80 src/sys/dev/em/if_em.h 1.26 +0 -9154 src/sys/dev/em/if_em_hw.c (dead) 1.26 +0 -3379 src/sys/dev/em/if_em_hw.h (dead) 1.22 +0 -177 src/sys/dev/em/if_em_osdep.h (dead) 1.6 +19 -5 src/sys/modules/em/Makefile From owner-cvs-src@FreeBSD.ORG Fri May 4 02:34:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6BE5C16A404; Fri, 4 May 2007 02:34:18 +0000 (UTC) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 45C5413C45E; Fri, 4 May 2007 02:34:18 +0000 (UTC) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l442YIJw034377; Fri, 4 May 2007 02:34:18 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l442YISf034376; Fri, 4 May 2007 02:34:18 GMT (envelope-from suz) Message-Id: <200705040234.l442YISf034376@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 4 May 2007 02:34:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 nd6.c nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 02:34:18 -0000 suz 2007-05-04 02:34:18 UTC FreeBSD src repository Modified files: sys/netinet6 nd6.c nd6_nbr.c Log: fixed a memory leak in unresolved ND queue processing Obtained from: KAME MFC after: 1 week Revision Changes Path 1.76 +4 -11 src/sys/netinet6/nd6.c 1.43 +4 -11 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Fri May 4 04:05:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B235416A400; Fri, 4 May 2007 04:05:49 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [192.147.25.65]) by mx1.freebsd.org (Postfix) with ESMTP id 84CF013C4C7; Fri, 4 May 2007 04:05:49 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from ppp-70-244-120-15.dsl.austtx.swbell.net ([70.244.120.15]:49668 helo=[192.168.200.104]) by thebighonker.lerctr.org with esmtpa (Exim 4.67 (FreeBSD)) (envelope-from ) id 1Hjp3D-0003cx-NY; Thu, 03 May 2007 23:05:49 -0500 In-Reply-To: <200705040000.l4400CtD088050@repoman.freebsd.org> References: <200705040000.l4400CtD088050@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-1-228356702" Message-Id: Content-Transfer-Encoding: 7bit From: Larry Rosenman Date: Thu, 3 May 2007 23:05:35 -0500 To: Jack F Vogel X-Pgp-Agent: GPGMail 1.1.2 (Tiger) X-Mailer: Apple Mail (2.752.2) X-Spam-Score: -2.5 (--) X-LERCTR-Spam-Score: -2.5 (--) X-Spam-Report: SpamScore (-2.5/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, DKIM_POLICY_SIGNSOME=0.001, FM_MULTI_ODD2=1.1, FM_MULTI_ODD3=0.7, TW_JF=0.077 X-LERCTR-Spam-Report: SpamScore (-2.5/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, DKIM_POLICY_SIGNSOME=0.001, FM_MULTI_ODD2=1.1, FM_MULTI_ODD3=0.7, TW_JF=0.077 DomainKey-Status: no signature Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE README e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 04:05:49 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-1-228356702 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Jack, I think somethings broke here: /usr/obj/usr/src/make.amd64/make -V CFILES -V SYSTEM_CFILES -V GEN_CFILES | MKDEP_CPP="cc -E" CC="cc" xargs mkdep -a -f .newdep -O2 -frename-registers -pipe -fno-strict-aliasing -std=c99 -g -Wall - Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing- prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat- extensions -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/ altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/ src/sys/dev/ath -I/usr/src/sys/contrib/ngatm -I/usr/src/sys/dev/twa - I/usr/src/sys/dev/em -I/usr/src/sys/gnu/fs/xfs/FreeBSD -I/usr/src/sys/ gnu/fs/xfs/FreeBSD/support -I/usr/src/sys/gnu/fs/xfs -D_KERNEL - DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common - finline-limit=8000 --param inline-unit-growth=100 --param large- function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel -mno- red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft- float -fno-asynchronous-unwind-tables -ffreestanding cc: /usr/src/sys/dev/em/if_e1000.c: No such file or directory mkdep: compile failed *** Error code 1 Stop in /usr/obj/usr/src/sys/BORG. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. On May 3, 2007, at 7:00 PM, Jack F Vogel wrote: > jfv 2007-05-04 00:00:12 UTC > > FreeBSD src repository > > Modified files: > sys/conf files kern.pre.mk > sys/dev/em LICENSE README if_em.c if_em.h > sys/modules/em Makefile > Added files: > sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h > e1000_82540.c e1000_82541.c e1000_82541.h > e1000_82542.c e1000_82543.c e1000_82543.h > e1000_82571.c e1000_82571.h e1000_82575.c > e1000_82575.h e1000_api.c e1000_api.h > e1000_defines.h e1000_hw.h > e1000_ich8lan.c e1000_ich8lan.h > e1000_mac.c e1000_mac.h e1000_manage.c > e1000_manage.h e1000_nvm.c e1000_nvm.h > e1000_osdep.h e1000_phy.c e1000_phy.h > e1000_regs.h > Removed files: > sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h > Log: > Merge in the new driver (6.5.0) of Intel. This has a new > shared code infrastructure that is family specific and > modular. There is also support for our latest gigabit > nic, the 82575 that is MSI/X and multiqueue capable. > > The new shared code changes some interfaces to the core > code but testing at Intel has been going on for months, > it is fairly stable. > > I have attempted to be careful in retaining any fixes that > CURRENT had and we did not, I apologize in advance if any > thing gets clobbered, I'm sure I'll hear about it :) > > Approved by pdeuskar > > Revision Changes Path > 1.1199 +26 -2 src/sys/conf/files > 1.82 +3 -0 src/sys/conf/kern.pre.mk > 1.6 +28 -28 src/sys/dev/em/LICENSE > 1.14 +81 -37 src/sys/dev/em/README > 1.1 +1383 -0 src/sys/dev/em/e1000_80003es2lan.c (new) > 1.1 +96 -0 src/sys/dev/em/e1000_80003es2lan.h (new) > 1.1 +677 -0 src/sys/dev/em/e1000_82540.c (new) > 1.1 +1312 -0 src/sys/dev/em/e1000_82541.c (new) > 1.1 +93 -0 src/sys/dev/em/e1000_82541.h (new) > 1.1 +558 -0 src/sys/dev/em/e1000_82542.c (new) > 1.1 +1650 -0 src/sys/dev/em/e1000_82543.c (new) > 1.1 +52 -0 src/sys/dev/em/e1000_82543.h (new) > 1.1 +1340 -0 src/sys/dev/em/e1000_82571.c (new) > 1.1 +49 -0 src/sys/dev/em/e1000_82571.h (new) > 1.1 +1528 -0 src/sys/dev/em/e1000_82575.c (new) > 1.1 +284 -0 src/sys/dev/em/e1000_82575.h (new) > 1.1 +1213 -0 src/sys/dev/em/e1000_api.c (new) > 1.1 +163 -0 src/sys/dev/em/e1000_api.h (new) > 1.1 +1403 -0 src/sys/dev/em/e1000_defines.h (new) > 1.1 +724 -0 src/sys/dev/em/e1000_hw.h (new) > 1.1 +2482 -0 src/sys/dev/em/e1000_ich8lan.c (new) > 1.1 +117 -0 src/sys/dev/em/e1000_ich8lan.h (new) > 1.1 +1987 -0 src/sys/dev/em/e1000_mac.c (new) > 1.1 +93 -0 src/sys/dev/em/e1000_mac.h (new) > 1.1 +391 -0 src/sys/dev/em/e1000_manage.c (new) > 1.1 +90 -0 src/sys/dev/em/e1000_manage.h (new) > 1.1 +900 -0 src/sys/dev/em/e1000_nvm.c (new) > 1.1 +68 -0 src/sys/dev/em/e1000_nvm.h (new) > 1.1 +188 -0 src/sys/dev/em/e1000_osdep.h (new) > 1.1 +2022 -0 src/sys/dev/em/e1000_phy.c (new) > 1.1 +168 -0 src/sys/dev/em/e1000_phy.h (new) > 1.1 +455 -0 src/sys/dev/em/e1000_regs.h (new) > 1.172 +1620 -807 src/sys/dev/em/if_em.c > 1.58 +77 -80 src/sys/dev/em/if_em.h > 1.26 +0 -9154 src/sys/dev/em/if_em_hw.c (dead) > 1.26 +0 -3379 src/sys/dev/em/if_em_hw.h (dead) > 1.22 +0 -177 src/sys/dev/em/if_em_osdep.h (dead) > 1.6 +19 -5 src/sys/modules/em/Makefile > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" --Apple-Mail-1-228356702 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGOrEPrRNGhTxJvdYRApiGAJ9qUU0wxg9ahFili2ytRYDGCqcgvgCfSiLb P8yrh5sdcJSKV/20TqtC514= =5kue -----END PGP SIGNATURE----- --Apple-Mail-1-228356702-- From owner-cvs-src@FreeBSD.ORG Fri May 4 05:58:48 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1846516A402; Fri, 4 May 2007 05:58:48 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E685B13C457; Fri, 4 May 2007 05:58:47 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l445wlDx072538; Fri, 4 May 2007 05:58:47 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l445wlbs072537; Fri, 4 May 2007 05:58:47 GMT (envelope-from jfv) Message-Id: <200705040558.l445wlbs072537@repoman.freebsd.org> From: Jack F Vogel Date: Fri, 4 May 2007 05:58:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 05:58:48 -0000 jfv 2007-05-04 05:58:47 UTC FreeBSD src repository Modified files: sys/conf files Log: Last minute mistake crept in, old file name. Approved by:pdeuskar Revision Changes Path 1.1200 +1 -1 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Fri May 4 07:21:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C88716A401; Fri, 4 May 2007 07:21:02 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 5653913C45E; Fri, 4 May 2007 07:21:02 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l447L2i0089845; Fri, 4 May 2007 07:21:02 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l447L2Dm089842; Fri, 4 May 2007 07:21:02 GMT (envelope-from jfv) Message-Id: <200705040721.l447L2Dm089842@repoman.freebsd.org> From: Jack F Vogel Date: Fri, 4 May 2007 07:21:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/em Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 07:21:02 -0000 jfv 2007-05-04 07:21:02 UTC FreeBSD src repository Modified files: sys/modules/em Makefile Log: Absolute pathname in the Makefile was broken, this version should work correctly. Revision Changes Path 1.7 +1 -3 src/sys/modules/em/Makefile From owner-cvs-src@FreeBSD.ORG Fri May 4 07:37:29 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68B9E16A400 for ; Fri, 4 May 2007 07:37:29 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.228]) by mx1.freebsd.org (Postfix) with ESMTP id 28CD313C455 for ; Fri, 4 May 2007 07:37:29 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nz-out-0506.google.com with SMTP id s1so814707nze for ; Fri, 04 May 2007 00:37:28 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Z+gdpWvEDoYrFckvFA9S56b6vxf+BYau9LkzBFY/KOfnZEvzuYrnAqlCse3jgh1t1EO7Zta6OhjxXZzJddGQDMMzlABLeWAhYwujlU7bfNTSl5eEDo/qxiMwVMlQqaxp+sC8cm3BXB4+l5KlpStvDoEVuaJtoQXjQ7A9hfwbPOE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ISp9pPON4Uk3ucGHs76YroH4Se21qzbwQ3QIXbL+P7UMzo3pAO+PqMtqw89Riw4Dbma3AsXsqFsZLRLcJTIeJxhcJu7ai6cpWkiASsNkKzHXe5dYLAuqKIbT6ulq1umDgzHSu/mNbp7QPsn9CeTS3FKJzyyomT3nsgug+VMGUlQ= Received: by 10.114.92.2 with SMTP id p2mr135326wab.1178262720273; Fri, 04 May 2007 00:12:00 -0700 (PDT) Received: by 10.114.103.18 with HTTP; Fri, 4 May 2007 00:12:00 -0700 (PDT) Message-ID: <2a41acea0705040012h6670a432ke31a2043c38cb18b@mail.gmail.com> Date: Fri, 4 May 2007 00:12:00 -0700 From: "Jack Vogel" To: "Jack F Vogel" In-Reply-To: <200705040558.l445wlbs072537@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200705040558.l445wlbs072537@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 07:37:29 -0000 There is still a problem with my checkin, the sys/modules/em/Makefile has a CFLAGS with an absolute path which i realize is not going to work. I will try to figure out the right way to fix this tomorrow. I think at one point I tried the form I see in kern.pre.mk, it uses -I$S/dev/em, and it did not seem to work in this Makefile. Anyone have a suggestion of the right way to fix this? Sorry bout the disruption, Jack On 5/3/07, Jack F Vogel wrote: > jfv 2007-05-04 05:58:47 UTC > > FreeBSD src repository > > Modified files: > sys/conf files > Log: > Last minute mistake crept in, old file name. > > Approved by:pdeuskar > > Revision Changes Path > 1.1200 +1 -1 src/sys/conf/files > From owner-cvs-src@FreeBSD.ORG Fri May 4 09:03:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CA3E716A403; Fri, 4 May 2007 09:03:29 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id A3CB413C447; Fri, 4 May 2007 09:03:29 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4493Txe016889; Fri, 4 May 2007 09:03:29 GMT (envelope-from roam@repoman.freebsd.org) Received: (from roam@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4493ToP016888; Fri, 4 May 2007 09:03:29 GMT (envelope-from roam) Message-Id: <200705040903.l4493ToP016888@repoman.freebsd.org> From: Peter Pentchev Date: Fri, 4 May 2007 09:03:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/sys send.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 09:03:29 -0000 roam 2007-05-04 09:03:29 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) lib/libc/sys send.2 Log: MFC rev. 1.35 - remove MSG_PEEK from the description of the send(2) syscall; it is only relevant for incoming data. Revision Changes Path 1.32.2.2 +0 -1 src/lib/libc/sys/send.2 From owner-cvs-src@FreeBSD.ORG Fri May 4 09:06:21 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E0D216A409; Fri, 4 May 2007 09:06:21 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 76DCA13C4AD; Fri, 4 May 2007 09:06:21 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4496LYk017050; Fri, 4 May 2007 09:06:21 GMT (envelope-from roam@repoman.freebsd.org) Received: (from roam@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4496L1C017049; Fri, 4 May 2007 09:06:21 GMT (envelope-from roam) Message-Id: <200705040906.l4496L1C017049@repoman.freebsd.org> From: Peter Pentchev Date: Fri, 4 May 2007 09:06:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/lib/libc/sys send.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 09:06:21 -0000 roam 2007-05-04 09:06:20 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_5) lib/libc/sys send.2 Log: MFC rev. 1.35 - remove MSG_PEEK from the description of the send(2) syscall; it is only relevant for incoming data. Revision Changes Path 1.27.2.2 +0 -1 src/lib/libc/sys/send.2 From owner-cvs-src@FreeBSD.ORG Fri May 4 09:06:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B0EE716A403; Fri, 4 May 2007 09:06:59 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8A44D13C4B8; Fri, 4 May 2007 09:06:59 +0000 (UTC) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4496xpP017111; Fri, 4 May 2007 09:06:59 GMT (envelope-from roam@repoman.freebsd.org) Received: (from roam@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4496xDi017110; Fri, 4 May 2007 09:06:59 GMT (envelope-from roam) Message-Id: <200705040906.l4496xDi017110@repoman.freebsd.org> From: Peter Pentchev Date: Fri, 4 May 2007 09:06:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/lib/libc/sys send.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 09:06:59 -0000 roam 2007-05-04 09:06:59 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_4) lib/libc/sys send.2 Log: MFC rev. 1.35 - remove MSG_PEEK from the description of the send(2) syscall; it is only relevant for incoming data. Revision Changes Path 1.10.2.8 +0 -1 src/lib/libc/sys/send.2 From owner-cvs-src@FreeBSD.ORG Fri May 4 11:15:42 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C20AD16A402; Fri, 4 May 2007 11:15:42 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9B90113C48C; Fri, 4 May 2007 11:15:42 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44BFgsH039108; Fri, 4 May 2007 11:15:42 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44BFghx039106; Fri, 4 May 2007 11:15:42 GMT (envelope-from bz) Message-Id: <200705041115.l44BFghx039106@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Fri, 4 May 2007 11:15:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c src/sys/netinet ip_fw.h ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 11:15:42 -0000 bz 2007-05-04 11:15:42 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c ipfw.8 sys/netinet ip_fw.h ip_fw2.c Log: Add support for filtering on Routing Header Type 0 and Mobile IPv6 Routing Header Type 2 in addition to filter on the non-differentiated presence of any Routing Header. MFC after: 3 weeks Revision Changes Path 1.200 +7 -3 src/sbin/ipfw/ipfw.8 1.104 +18 -0 src/sbin/ipfw/ipfw2.c 1.110 +2 -0 src/sys/netinet/ip_fw.h 1.164 +4 -0 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Fri May 4 12:06:35 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 680) id 9D84716A408; Fri, 4 May 2007 12:06:35 +0000 (UTC) Date: Fri, 4 May 2007 12:06:35 +0000 From: Darren Reed To: Robert Watson Message-ID: <20070504120635.GA3390@hub.freebsd.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705031442.l43Egggi064069@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 12:06:35 -0000 On Thu, May 03, 2007 at 02:42:42PM +0000, Robert Watson wrote: > While here, fix two historic bugs: > > (1) a bug allowing I/O to be occasionally interlaced during long I/O > operations (discovere by Isilon). > > (2) a bug in which failed non-blocking acquisition of the socket buffer > I/O serialization lock might be ignored (discovered by sam). Did either of these have bug id's? Darren From owner-cvs-src@FreeBSD.ORG Fri May 4 12:16:09 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AA05E16A402; Fri, 4 May 2007 12:16:09 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 4AEA513C447; Fri, 4 May 2007 12:16:09 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5EFC6.dip.t-dialin.net [84.165.239.198]) by redbull.bpaserver.net (Postfix) with ESMTP id 0F5112E0AE; Fri, 4 May 2007 14:16:01 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id ED3825B48A3; Fri, 4 May 2007 14:15:45 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l44CFjr6056547; Fri, 4 May 2007 14:15:45 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Fri, 04 May 2007 14:15:45 +0200 Message-ID: <20070504141545.8mis6w94gocw8408@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Fri, 04 May 2007 14:15:45 +0200 From: Alexander Leidinger To: Colin Percival References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org> <463A19D6.6070400@freebsd.org> In-Reply-To: <463A19D6.6070400@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 12:16:09 -0000 Quoting Colin Percival (from Thu, 03 May 2007 10:20:22 -0700): > Tim Kientzle wrote: >> I wonder if it would be simpler to set non-zero exit only >> if this is the first path returned from tree_next() (which >> should be the path given on the command line). That >> would avoid the headache of having to perform a textual >> path comparison. >> >> A simple flag to indicate if this is the first time >> through the loop should suffice, I think. > > Hmm... I considered this, but I wasn't sure if there were any edge > cases where the first path returned by tree_next might not be the > path passed to tree_open; so I decided to take the route which I > knew would always work. What if someone gives more than one path to tar? Bye, Alexander. -- Put no trust in cryptic comments. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Fri May 4 12:35:10 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 83FFB16A401; Fri, 4 May 2007 12:35:10 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5699313C447; Fri, 4 May 2007 12:35:10 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 01BF947036; Fri, 4 May 2007 08:35:10 -0400 (EDT) Date: Fri, 4 May 2007 13:35:09 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Darren Reed In-Reply-To: <20070504120635.GA3390@hub.freebsd.org> Message-ID: <20070504133305.D32808@fledge.watson.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org> <20070504120635.GA3390@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 12:35:10 -0000 On Fri, 4 May 2007, Darren Reed wrote: > On Thu, May 03, 2007 at 02:42:42PM +0000, Robert Watson wrote: >> While here, fix two historic bugs: >> >> (1) a bug allowing I/O to be occasionally interlaced during long I/O >> operations (discovere by Isilon). >> >> (2) a bug in which failed non-blocking acquisition of the socket buffer >> I/O serialization lock might be ignored (discovered by sam). > > Did either of these have bug id's? Not that I know of. Isilon directly submitted their local patch (one appropriate for MFC, as it's based on the previous locking) a few weeks ago, and Sam bumped into the other bug while doing the socket locking work several years ago. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Fri May 4 12:38:47 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8A14916A400; Fri, 4 May 2007 12:38:47 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 643D813C447; Fri, 4 May 2007 12:38:47 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44Ccl8H062134; Fri, 4 May 2007 12:38:47 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44Cclbv062133; Fri, 4 May 2007 12:38:47 GMT (envelope-from ariff) Message-Id: <200705041238.l44Cclbv062133@repoman.freebsd.org> From: Ariff Abdullah Date: Fri, 4 May 2007 12:38:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci emu10kx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 12:38:47 -0000 ariff 2007-05-04 12:38:47 UTC FreeBSD src repository Modified files: sys/dev/sound/pci emu10kx.c Log: Fix use-after-free for DMA tag. Destroy DMA tag later. Submitted by: Yuriy Tsibizov Revision Changes Path 1.10 +4 -3 src/sys/dev/sound/pci/emu10kx.c From owner-cvs-src@FreeBSD.ORG Fri May 4 13:29:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EAB5316A404; Fri, 4 May 2007 13:29:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C4B5513C45B; Fri, 4 May 2007 13:29:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44DTjFO013920; Fri, 4 May 2007 13:29:45 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44DTjSI013919; Fri, 4 May 2007 13:29:45 GMT (envelope-from rwatson) Message-Id: <200705041329.l44DTjSI013919@repoman.freebsd.org> From: Robert Watson Date: Fri, 4 May 2007 13:29:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 13:29:46 -0000 rwatson 2007-05-04 13:29:45 UTC FreeBSD src repository Modified files: sys/conf files Log: Add missing e1000_82575.c entry to build in order to improve chances of kernel compilation due to missing symbols in em driver. Revision Changes Path 1.1201 +2 -0 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Fri May 4 13:30:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 960D316A401; Fri, 4 May 2007 13:30:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 849E713C43E; Fri, 4 May 2007 13:30:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44DUjo9014670; Fri, 4 May 2007 13:30:45 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44DUjpG014669; Fri, 4 May 2007 13:30:45 GMT (envelope-from rwatson) Message-Id: <200705041330.l44DUjpG014669@repoman.freebsd.org> From: Robert Watson Date: Fri, 4 May 2007 13:30:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c e1000_82575.h e1000_api.c e1000_api.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 13:30:45 -0000 rwatson 2007-05-04 13:30:45 UTC FreeBSD src repository Modified files: sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c e1000_82575.h e1000_api.c e1000_api.h e1000_defines.h e1000_hw.h e1000_ich8lan.c e1000_ich8lan.h e1000_mac.c e1000_mac.h e1000_manage.c e1000_manage.h e1000_nvm.c e1000_nvm.h e1000_osdep.h e1000_phy.c e1000_phy.h e1000_regs.h if_em.c if_em.h Log: $FreeBSD$ tags are not compilable C code; wrap in either __FBSDID() or in comments for .c and .h files respectively. Jack may want to clean up style or other aspects once he's up and about again, but this gets the kernel compiling. Revision Changes Path 1.2 +3 -1 src/sys/dev/em/e1000_80003es2lan.c 1.2 +4 -1 src/sys/dev/em/e1000_80003es2lan.h 1.2 +3 -1 src/sys/dev/em/e1000_82540.c 1.2 +3 -1 src/sys/dev/em/e1000_82541.c 1.2 +4 -1 src/sys/dev/em/e1000_82541.h 1.2 +3 -1 src/sys/dev/em/e1000_82542.c 1.2 +3 -1 src/sys/dev/em/e1000_82543.c 1.2 +4 -1 src/sys/dev/em/e1000_82543.h 1.2 +3 -1 src/sys/dev/em/e1000_82571.c 1.2 +4 -1 src/sys/dev/em/e1000_82571.h 1.2 +3 -1 src/sys/dev/em/e1000_82575.c 1.2 +4 -1 src/sys/dev/em/e1000_82575.h 1.2 +3 -1 src/sys/dev/em/e1000_api.c 1.2 +4 -1 src/sys/dev/em/e1000_api.h 1.2 +4 -1 src/sys/dev/em/e1000_defines.h 1.2 +4 -1 src/sys/dev/em/e1000_hw.h 1.2 +3 -1 src/sys/dev/em/e1000_ich8lan.c 1.2 +4 -1 src/sys/dev/em/e1000_ich8lan.h 1.2 +3 -1 src/sys/dev/em/e1000_mac.c 1.2 +4 -1 src/sys/dev/em/e1000_mac.h 1.2 +3 -1 src/sys/dev/em/e1000_manage.c 1.2 +4 -1 src/sys/dev/em/e1000_manage.h 1.2 +3 -1 src/sys/dev/em/e1000_nvm.c 1.2 +4 -1 src/sys/dev/em/e1000_nvm.h 1.2 +4 -1 src/sys/dev/em/e1000_osdep.h 1.2 +3 -1 src/sys/dev/em/e1000_phy.c 1.2 +4 -1 src/sys/dev/em/e1000_phy.h 1.2 +4 -1 src/sys/dev/em/e1000_regs.h 1.173 +2 -1 src/sys/dev/em/if_em.c 1.59 +4 -1 src/sys/dev/em/if_em.h From owner-cvs-src@FreeBSD.ORG Fri May 4 13:34:33 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7EF3D16A400; Fri, 4 May 2007 13:34:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 58BCC13C44B; Fri, 4 May 2007 13:34:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44DYXS7017908; Fri, 4 May 2007 13:34:33 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44DYXpc017907; Fri, 4 May 2007 13:34:33 GMT (envelope-from rwatson) Message-Id: <200705041334.l44DYXpc017907@repoman.freebsd.org> From: Robert Watson Date: Fri, 4 May 2007 13:34:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/em Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 13:34:33 -0000 rwatson 2007-05-04 13:34:33 UTC FreeBSD src repository Modified files: sys/modules/em Makefile Log: Place a '#' at the front of the line holding a $FreeBSD$ ID tag. While it actually compiles without this, it's still a good idea. Revision Changes Path 1.8 +1 -1 src/sys/modules/em/Makefile From owner-cvs-src@FreeBSD.ORG Fri May 4 14:23:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AA87516A400; Fri, 4 May 2007 14:23:29 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9C2C513C457; Fri, 4 May 2007 14:23:29 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44ENTNH055140; Fri, 4 May 2007 14:23:29 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44ENTRv055136; Fri, 4 May 2007 14:23:29 GMT (envelope-from kib) Message-Id: <200705041423.l44ENTRv055136@repoman.freebsd.org> From: Konstantin Belousov Date: Fri, 4 May 2007 14:23:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_descrip.c vfs_syscalls.c src/sys/sys filedesc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 14:23:29 -0000 kib 2007-05-04 14:23:29 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c vfs_syscalls.c sys/sys filedesc.h Log: Mark the filedescriptor table entries with VOP_OPEN being performed for them as UF_OPENING. Disable closing of that entries. This should fix the crashes caused by devfs_open() (and fifo_open()) dereferencing struct file * by index, while the filedescriptor is closed by parallel thread. Idea by: tegge Reviewed by: tegge (previous version of patch) Tested by: Peter Holm Approved by: re (kensmith) MFC after: 3 weeks Revision Changes Path 1.309 +7 -3 src/sys/kern/kern_descrip.c 1.438 +12 -0 src/sys/kern/vfs_syscalls.c 1.77 +1 -0 src/sys/sys/filedesc.h From owner-cvs-src@FreeBSD.ORG Fri May 4 14:43:51 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A646C16A400; Fri, 4 May 2007 14:43:51 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 806F713C448; Fri, 4 May 2007 14:43:51 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44Ehpan070892; Fri, 4 May 2007 14:43:51 GMT (envelope-from fjoe@repoman.freebsd.org) Received: (from fjoe@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44EhpRD070891; Fri, 4 May 2007 14:43:51 GMT (envelope-from fjoe) Message-Id: <200705041443.l44EhpRD070891@repoman.freebsd.org> From: Max Khon Date: Fri, 4 May 2007 14:43:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc committers-ports.dot X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 14:43:51 -0000 fjoe 2007-05-04 14:43:51 UTC FreeBSD src repository Modified files: share/misc committers-ports.dot Log: Add osa@FreeBSD.org. Revision Changes Path 1.55 +2 -0 src/share/misc/committers-ports.dot From owner-cvs-src@FreeBSD.ORG Fri May 4 14:51:40 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6128A16A400; Fri, 4 May 2007 14:51:40 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3A62513C45B; Fri, 4 May 2007 14:51:40 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44EpeT6076076; Fri, 4 May 2007 14:51:40 GMT (envelope-from fjoe@repoman.freebsd.org) Received: (from fjoe@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44EpeXe076073; Fri, 4 May 2007 14:51:40 GMT (envelope-from fjoe) Message-Id: <200705041451.l44EpeXe076073@repoman.freebsd.org> From: Max Khon Date: Fri, 4 May 2007 14:51:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc committers-src.dot X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 14:51:40 -0000 fjoe 2007-05-04 14:51:39 UTC FreeBSD src repository Modified files: share/misc committers-src.dot Log: Add jdp@ and myself. Revision Changes Path 1.62 +4 -0 src/share/misc/committers-src.dot From owner-cvs-src@FreeBSD.ORG Fri May 4 14:51:57 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4E53616A402; Fri, 4 May 2007 14:51:57 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2868813C4B0; Fri, 4 May 2007 14:51:57 +0000 (UTC) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44EpvKJ076325; Fri, 4 May 2007 14:51:57 GMT (envelope-from fjoe@repoman.freebsd.org) Received: (from fjoe@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44EpvrS076324; Fri, 4 May 2007 14:51:57 GMT (envelope-from fjoe) Message-Id: <200705041451.l44EpvrS076324@repoman.freebsd.org> From: Max Khon Date: Fri, 4 May 2007 14:51:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc committers-ports.dot X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 14:51:57 -0000 fjoe 2007-05-04 14:51:57 UTC FreeBSD src repository Modified files: share/misc committers-ports.dot Log: Correct osa@ full name. Revision Changes Path 1.56 +1 -1 src/share/misc/committers-ports.dot From owner-cvs-src@FreeBSD.ORG Fri May 4 14:56:31 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AA98B16A401; Fri, 4 May 2007 14:56:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 521D913C448; Fri, 4 May 2007 14:56:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l44EuIi6048792; Fri, 4 May 2007 10:56:19 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Jack Vogel" Date: Fri, 4 May 2007 10:56:05 -0400 User-Agent: KMail/1.9.6 References: <200705040558.l445wlbs072537@repoman.freebsd.org> <2a41acea0705040012h6670a432ke31a2043c38cb18b@mail.gmail.com> In-Reply-To: <2a41acea0705040012h6670a432ke31a2043c38cb18b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200705041056.07390.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 May 2007 10:56:19 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3205/Fri May 4 06:50:21 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 14:56:31 -0000 On Friday 04 May 2007 03:12:00 am Jack Vogel wrote: > There is still a problem with my checkin, the sys/modules/em/Makefile > has a CFLAGS with an absolute path which i realize is not going to work. > I will try to figure out the right way to fix this tomorrow. >=20 > I think at one point I tried the form I see in kern.pre.mk, it uses > -I$S/dev/em, and it did not seem to work in this Makefile. Anyone > have a suggestion of the right way to fix this? =46rom acpi/acpi/Makefile: CFLAGS+=3D -I${.CURDIR}/../../../contrib/dev/acpica You would probably do: CFLAGS+=3D -I${.CURDIR}/../../dev/em >=20 > Sorry bout the disruption, >=20 > Jack >=20 >=20 > On 5/3/07, Jack F Vogel wrote: > > jfv 2007-05-04 05:58:47 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files > > Log: > > Last minute mistake crept in, old file name. > > > > Approved by:pdeuskar > > > > Revision Changes Path > > 1.1200 +1 -1 src/sys/conf/files > > >=20 =2D-=20 John Baldwin From owner-cvs-src@FreeBSD.ORG Fri May 4 15:03:29 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3003E16A402; Fri, 4 May 2007 15:03:29 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id D148413C469; Fri, 4 May 2007 15:03:28 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from [10.0.0.222] (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id l44F3NH7054308; Fri, 4 May 2007 08:03:24 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <463B4B3B.8080209@freebsd.org> Date: Fri, 04 May 2007 08:03:23 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alexander Leidinger References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org> <463A19D6.6070400@freebsd.org> <20070504141545.8mis6w94gocw8408@webmail.leidinger.net> In-Reply-To: <20070504141545.8mis6w94gocw8408@webmail.leidinger.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:03:29 -0000 >>> I wonder if it would be simpler to set non-zero exit only >>> if this is the first path returned from tree_next() ... >> >> Hmm... I considered this, but I wasn't sure if there were any edge >> cases where the first path returned by tree_next might not be the >> path passed to tree_open; so I decided to take the route which I >> knew would always work. > > What if someone gives more than one path to tar? The function in question (write_heirarchy) is called once for each command-line argument. Tim Kientzle From owner-cvs-src@FreeBSD.ORG Fri May 4 15:19:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 18D2B16A403; Fri, 4 May 2007 15:19:11 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id E73D813C448; Fri, 4 May 2007 15:19:10 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FJA9C095909; Fri, 4 May 2007 15:19:10 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FJAOO095908; Fri, 4 May 2007 15:19:10 GMT (envelope-from rrs) Message-Id: <200705041519.l44FJAOO095908@repoman.freebsd.org> From: Randall Stewart Date: Fri, 4 May 2007 15:19:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp_pcb.c sctp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:19:11 -0000 rrs 2007-05-04 15:19:10 UTC FreeBSD src repository Modified files: sys/netinet sctp_pcb.c sctp_usrreq.c Log: Fixes a missing unlock in the one-2-one hash table, if it was full and a collision occured, then we would leave a inp locked. Also fixes a missing inp unlock if IPSEC was on and it failed during the attach. Bug found by Weongyo Jeong. Revision Changes Path 1.23 +1 -0 src/sys/netinet/sctp_pcb.c 1.21 +3 -0 src/sys/netinet/sctp_usrreq.c From owner-cvs-src@FreeBSD.ORG Fri May 4 15:23:48 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2282016A402; Fri, 4 May 2007 15:23:48 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id EFF1113C458; Fri, 4 May 2007 15:23:47 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FNlvJ099165; Fri, 4 May 2007 15:23:47 GMT (envelope-from rafan@repoman.freebsd.org) Received: (from rafan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FNlGY099164; Fri, 4 May 2007 15:23:47 GMT (envelope-from rafan) Message-Id: <200705041523.l44FNlGY099164@repoman.freebsd.org> From: Rong-En Fan Date: Fri, 4 May 2007 15:23:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:23:48 -0000 rafan 2007-05-04 15:23:47 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: - Add top '-j' switch Reviewed by: brueffer Approved by: delphij (mentor, implicit), brueffer Revision Changes Path 1.1027 +3 -0 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Fri May 4 15:25:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0451D16A400; Fri, 4 May 2007 15:25:06 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D2C5E13C45B; Fri, 4 May 2007 15:25:05 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FP5KU099912; Fri, 4 May 2007 15:25:05 GMT (envelope-from rafan@repoman.freebsd.org) Received: (from rafan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FP5LJ099911; Fri, 4 May 2007 15:25:05 GMT (envelope-from rafan) Message-Id: <200705041525.l44FP5LJ099911@repoman.freebsd.org> From: Rong-En Fan Date: Fri, 4 May 2007 15:25:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:25:06 -0000 rafan 2007-05-04 15:25:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: - Add top '-j' switch Reviewed by: brueffer Approved by: delphij (mentor, implicit), brueffer Revision Changes Path 1.883.2.71 +3 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri May 4 15:41:50 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5039916A400; Fri, 4 May 2007 15:41:50 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2A5F713C457; Fri, 4 May 2007 15:41:50 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FfnWC011603; Fri, 4 May 2007 15:41:50 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FfnGq011599; Fri, 4 May 2007 15:41:49 GMT (envelope-from mav) Message-Id: <200705041541.l44FfnGq011599@repoman.freebsd.org> From: Alexander Motin Date: Fri, 4 May 2007 15:41:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_mppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:41:50 -0000 mav 2007-05-04 15:41:49 UTC FreeBSD src repository Modified files: sys/netgraph ng_mppc.c Log: Remove unneded bzero(). SHA1Final() does not require clean buffer. Approved by: glebius (mentor) Revision Changes Path 1.25 +0 -1 src/sys/netgraph/ng_mppc.c From owner-cvs-src@FreeBSD.ORG Fri May 4 15:42:58 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C824616A403; Fri, 4 May 2007 15:42:58 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id A192813C457; Fri, 4 May 2007 15:42:58 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44Fgwpa012514; Fri, 4 May 2007 15:42:58 GMT (envelope-from rafan@repoman.freebsd.org) Received: (from rafan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44Fgwsq012507; Fri, 4 May 2007 15:42:58 GMT (envelope-from rafan) Message-Id: <200705041542.l44Fgwsq012507@repoman.freebsd.org> From: Rong-En Fan Date: Fri, 4 May 2007 15:42:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/top commands.c machine.h top.X top.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:42:58 -0000 rafan 2007-05-04 15:42:58 UTC FreeBSD src repository Modified files: contrib/top commands.c machine.h top.X top.c Log: - s/jail id/jail ID/, acronyms should be in uppercase in general. Also, it is written this way in jail(8). Suggested by: brueffer Approved by: delphij (mentor, implicit) Revision Changes Path 1.15 +1 -1 src/contrib/top/commands.c 1.9 +1 -1 src/contrib/top/machine.h 1.20 +2 -2 src/contrib/top/top.X 1.23 +1 -1 src/contrib/top/top.c From owner-cvs-src@FreeBSD.ORG Fri May 4 15:44:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3825D16A400; Fri, 4 May 2007 15:44:23 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 128A013C447; Fri, 4 May 2007 15:44:23 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FiMPp013568; Fri, 4 May 2007 15:44:22 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FiMTi013567; Fri, 4 May 2007 15:44:22 GMT (envelope-from mav) Message-Id: <200705041544.l44FiMTi013567@repoman.freebsd.org> From: Alexander Motin Date: Fri, 4 May 2007 15:44:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_mppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:44:23 -0000 mav 2007-05-04 15:44:22 UTC FreeBSD src repository Modified files: sys/netgraph ng_mppc.c Log: Fix small mistake (sizeof(pad2) instead of sizeof(pad1)) Approved by: glebius (mentor) Revision Changes Path 1.26 +1 -1 src/sys/netgraph/ng_mppc.c From owner-cvs-src@FreeBSD.ORG Fri May 4 15:45:14 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 72EF116A403; Fri, 4 May 2007 15:45:14 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4CB3813C468; Fri, 4 May 2007 15:45:14 +0000 (UTC) (envelope-from rafan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44FjEnx014137; Fri, 4 May 2007 15:45:14 GMT (envelope-from rafan@repoman.freebsd.org) Received: (from rafan@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44FjELt014136; Fri, 4 May 2007 15:45:14 GMT (envelope-from rafan) Message-Id: <200705041545.l44FjELt014136@repoman.freebsd.org> From: Rong-En Fan Date: Fri, 4 May 2007 15:45:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/top commands.c machine.h top.X top.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:45:14 -0000 rafan 2007-05-04 15:45:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/top commands.c machine.h top.X top.c Log: MFC: s/jail id/jail ID/ in top - s/jail id/jail ID/, acronyms should be in uppercase in general. Also, it is written this way in jail(8). Suggested by: brueffer Approved by: delphij (mentor, implicit) Revision Changes Path 1.12.2.2 +2 -2 src/contrib/top/commands.c 1.7.2.2 +2 -2 src/contrib/top/machine.h 1.12.2.4 +3 -3 src/contrib/top/top.X 1.17.2.3 +2 -2 src/contrib/top/top.c From owner-cvs-src@FreeBSD.ORG Fri May 4 15:50:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 267B216A401; Fri, 4 May 2007 15:50:25 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id CF00013C448; Fri, 4 May 2007 15:50:24 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id CB37D69027B; Fri, 4 May 2007 16:50:53 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 8C7506904C4; Fri, 4 May 2007 16:50:53 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO autolearn=ham version=3.1.7 Received: from epsilon.local.fnop.net (87-196-157-79.net.novis.pt [87.196.157.79]) by core.fnop.net (Postfix) with ESMTP id 2A2E669027B; Fri, 4 May 2007 16:50:11 +0100 (WEST) Date: Fri, 04 May 2007 16:49:35 +0100 Message-ID: <86hcqs612o.wl%rpaulo@fnop.net> From: Rui Paulo To: John Baldwin In-Reply-To: <200705021750.l42HoaMj067787@repoman.freebsd.org> References: <200705021750.l42HoaMj067787@repoman.freebsd.org> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: ClamAV using ClamSMTP Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 15:50:25 -0000 At Wed, 2 May 2007 17:50:36 +0000 (UTC), John Baldwin wrote: > > jhb 2007-05-02 17:50:36 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 mptable_pci.c msi.c nexus.c > sys/amd64/include intr_machdep.h > sys/amd64/pci pci_bus.c > sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c > sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h > pcib_if.m pcib_private.h pcivar.h > sys/i386/i386 mptable_pci.c msi.c nexus.c > sys/i386/include intr_machdep.h > sys/i386/pci pci_bus.c > Log: > Revamp the MSI/MSI-X code a bit to achieve two main goals: > - Simplify the amount of work that has be done for each architecture by > pushing more of the truly MI code down into the PCI bus driver. > - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map > multiple MSI-X messages into a single IRQ when handling a message > shortage. With this change, I think, I get a WITNESS panic when booting the second core on my MacBook After SMP: AP #1 Launched, I get this panic: panic: blockable sleep lock (sx) msi @ i386/i386/msi.c:374 The backtrace is: witness_checkorder() _sx_lock() msi_map() nexus_map_msi() acpi_pcib_map_msi() pcib_map_msi() pci_remap_msi_irq() msi_assign_cpu() Any idea why? From owner-cvs-src@FreeBSD.ORG Fri May 4 16:01:08 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8AFC316A401; Fri, 4 May 2007 16:01:08 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 640C913C447; Fri, 4 May 2007 16:01:08 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44G18Nl022094; Fri, 4 May 2007 16:01:08 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44G18LJ022087; Fri, 4 May 2007 16:01:08 GMT (envelope-from gabor) Message-Id: <200705041601.l44G18LJ022087@repoman.freebsd.org> From: Gabor Kovesdan Date: Fri, 4 May 2007 16:01:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/locale isdigit.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 16:01:08 -0000 gabor 2007-05-04 16:01:08 UTC FreeBSD src repository (doc,ports committer) Modified files: lib/libc/locale isdigit.3 Log: - Fix typo Approved by: keramida (mentor) MFC after: 3 days Revision Changes Path 1.23 +2 -2 src/lib/libc/locale/isdigit.3 From owner-cvs-src@FreeBSD.ORG Fri May 4 16:05:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0BFEF16A400; Fri, 4 May 2007 16:05:59 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BB15A13C46C; Fri, 4 May 2007 16:05:58 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44G5wbQ024407; Fri, 4 May 2007 16:05:58 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44G5wCZ024406; Fri, 4 May 2007 16:05:58 GMT (envelope-from mav) Message-Id: <200705041605.l44G5wCZ024406@repoman.freebsd.org> From: Alexander Motin Date: Fri, 4 May 2007 16:05:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_mppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 16:05:59 -0000 mav 2007-05-04 16:05:58 UTC FreeBSD src repository Modified files: sys/netgraph ng_mppc.c Log: Make coherency counter 12bit as it should Approved by: glebius (mentor) Revision Changes Path 1.27 +6 -4 src/sys/netgraph/ng_mppc.c From owner-cvs-src@FreeBSD.ORG Fri May 4 16:06:10 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8318116A500; Fri, 4 May 2007 16:06:10 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id E8E3413C4BA; Fri, 4 May 2007 16:06:09 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 635126904C4; Fri, 4 May 2007 17:06:39 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 24A086904CE; Fri, 4 May 2007 17:06:39 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_00, FORGED_RCVD_HELO, RCVD_IN_NJABL_DUL,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local.fnop.net (87-196-157-79.net.novis.pt [87.196.157.79]) by core.fnop.net (Postfix) with ESMTP id 9C1396904C4; Fri, 4 May 2007 17:06:38 +0100 (WEST) Date: Fri, 04 May 2007 17:06:07 +0100 Message-ID: <86k5vozi8g.wl%rpaulo@fnop.net> From: Rui Paulo To: John Baldwin , Pyun YongHyeon In-Reply-To: <86hcqs612o.wl%rpaulo@fnop.net> References: <200705021750.l42HoaMj067787@repoman.freebsd.org> <86hcqs612o.wl%rpaulo@fnop.net> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: ClamAV using ClamSMTP Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 16:06:10 -0000 At Fri, 04 May 2007 16:49:35 +0100, Rui Paulo wrote: > With this change, I think, I get a WITNESS panic when booting the > second core on my MacBook > > After SMP: AP #1 Launched, I get this panic: > panic: blockable sleep lock (sx) msi @ i386/i386/msi.c:374 > > The backtrace is: > witness_checkorder() > _sx_lock() > msi_map() > nexus_map_msi() > acpi_pcib_map_msi() > pcib_map_msi() > pci_remap_msi_irq() > msi_assign_cpu() BTW the source of the problem is related to msk(4). If I disable MSI only on the msk device (via hw.msk.msi_disable=1 tunable), everything works fine. From owner-cvs-src@FreeBSD.ORG Fri May 4 16:12:55 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6624C16A401; Fri, 4 May 2007 16:12:55 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4081613C458; Fri, 4 May 2007 16:12:55 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44GCtQ5025642; Fri, 4 May 2007 16:12:55 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44GCtD9025640; Fri, 4 May 2007 16:12:55 GMT (envelope-from mav) Message-Id: <200705041612.l44GCtD9025640@repoman.freebsd.org> From: Alexander Motin Date: Fri, 4 May 2007 16:12:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_mppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 16:12:55 -0000 mav 2007-05-04 16:12:54 UTC FreeBSD src repository Modified files: sys/netgraph ng_mppc.c Log: Compact code a bit Approved by: glebius (mentor) Revision Changes Path 1.28 +3 -5 src/sys/netgraph/ng_mppc.c From owner-cvs-src@FreeBSD.ORG Fri May 4 16:20:48 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C84A16A403; Fri, 4 May 2007 16:20:48 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0701E13C468; Fri, 4 May 2007 16:20:48 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44GKlis026274; Fri, 4 May 2007 16:20:47 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44GKlOY026273; Fri, 4 May 2007 16:20:47 GMT (envelope-from mav) Message-Id: <200705041620.l44GKlOY026273@repoman.freebsd.org> From: Alexander Motin Date: Fri, 4 May 2007 16:20:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_mppc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 16:20:48 -0000 mav 2007-05-04 16:20:47 UTC FreeBSD src repository Modified files: sys/netgraph ng_mppc.c Log: Avoid extra rc4_init() when ng_mppc_updatekey() going to do it anyway. Approved by: glebius (mentor) Revision Changes Path 1.29 +7 -5 src/sys/netgraph/ng_mppc.c From owner-cvs-src@FreeBSD.ORG Fri May 4 17:17:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3431616A401; Fri, 4 May 2007 17:17:25 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0E3F813C448; Fri, 4 May 2007 17:17:25 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44HHOCv044757; Fri, 4 May 2007 17:17:24 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44HHOhk044756; Fri, 4 May 2007 17:17:24 GMT (envelope-from le) Message-Id: <200705041717.l44HHOhk044756@repoman.freebsd.org> From: Lukas Ertl Date: Fri, 4 May 2007 17:17:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/adduser adduser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 17:17:25 -0000 le 2007-05-04 17:17:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/adduser adduser.sh Log: MFC 1.28: Check if the new user already exists right after entering the username instead of watching the final call to pw(8) fail. Revision Changes Path 1.26.2.2 +8 -2 src/usr.sbin/adduser/adduser.sh From owner-cvs-src@FreeBSD.ORG Fri May 4 17:22:26 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA9E716A402; Fri, 4 May 2007 17:22:26 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C4CB513C447; Fri, 4 May 2007 17:22:26 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44HMQbp045981; Fri, 4 May 2007 17:22:26 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44HMQEn045980; Fri, 4 May 2007 17:22:26 GMT (envelope-from le) Message-Id: <200705041722.l44HMQEn045980@repoman.freebsd.org> From: Lukas Ertl Date: Fri, 4 May 2007 17:22:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/pw cpdir.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 17:22:27 -0000 le 2007-05-04 17:22:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pw cpdir.c Log: MFC 1.8: Do the right thing with symlinks in the skeleton directory. PR: bin/63659 Revision Changes Path 1.7.2.1 +7 -1 src/usr.sbin/pw/cpdir.c From owner-cvs-src@FreeBSD.ORG Fri May 4 17:33:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 64EF716A402; Fri, 4 May 2007 17:33:05 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3E4CE13C455; Fri, 4 May 2007 17:33:05 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44HX5g5047682; Fri, 4 May 2007 17:33:05 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44HX5Co047681; Fri, 4 May 2007 17:33:05 GMT (envelope-from le) Message-Id: <200705041733.l44HX5Co047681@repoman.freebsd.org> From: Lukas Ertl Date: Fri, 4 May 2007 17:33:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/pw pw.8 pw.c pw.conf.5 pw.h pw_conf.c pw_user.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 17:33:05 -0000 le 2007-05-04 17:33:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pw pw.8 pw.c pw.conf.5 pw.h pw_conf.c pw_user.c Log: MFC all changes regarding new option -M. Revision Changes Path 1.37.2.2 +15 -1 src/usr.sbin/pw/pw.8 1.27.8.2 +5 -3 src/usr.sbin/pw/pw.c 1.15.10.1 +10 -1 src/usr.sbin/pw/pw.conf.5 1.14.2.1 +1 -0 src/usr.sbin/pw/pw.h 1.14.14.1 +16 -1 src/usr.sbin/pw/pw_conf.c 1.57.8.2 +17 -4 src/usr.sbin/pw/pw_user.c From owner-cvs-src@FreeBSD.ORG Fri May 4 17:36:38 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A176816A400; Fri, 4 May 2007 17:36:38 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 7B87D13C45B; Fri, 4 May 2007 17:36:38 +0000 (UTC) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44Hacjn048202; Fri, 4 May 2007 17:36:38 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44HacSa048201; Fri, 4 May 2007 17:36:38 GMT (envelope-from le) Message-Id: <200705041736.l44HacSa048201@repoman.freebsd.org> From: Lukas Ertl Date: Fri, 4 May 2007 17:36:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/pw pw_user.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 17:36:38 -0000 le 2007-05-04 17:36:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pw pw_user.c Log: MFC 1.61: Accept passwords which contain whitespace. PR: bin/53434 Revision Changes Path 1.57.8.3 +1 -1 src/usr.sbin/pw/pw_user.c From owner-cvs-src@FreeBSD.ORG Fri May 4 17:45:54 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 27B1516A400; Fri, 4 May 2007 17:45:54 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0187C13C447; Fri, 4 May 2007 17:45:54 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44Hjrl0049730; Fri, 4 May 2007 17:45:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44HjrGa049729; Fri, 4 May 2007 17:45:53 GMT (envelope-from rwatson) Message-Id: <200705041745.l44HjrGa049729@repoman.freebsd.org> From: Robert Watson Date: Fri, 4 May 2007 17:45:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 17:45:54 -0000 rwatson 2007-05-04 17:45:53 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tweak comment at end of tcp_input() when calling into tcp_do_segment(): the pcbinfo lock will be released as well, not just the pcb lock. Revision Changes Path 1.342 +3 -3 src/sys/netinet/tcp_input.c From owner-cvs-src@FreeBSD.ORG Fri May 4 19:15:30 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD74C16A401; Fri, 4 May 2007 19:15:30 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9E90313C45E; Fri, 4 May 2007 19:15:30 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44JFUjc069304; Fri, 4 May 2007 19:15:30 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44JFUDI069303; Fri, 4 May 2007 19:15:30 GMT (envelope-from phk) Message-Id: <200705041915.l44JFUDI069303@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 4 May 2007 19:15:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/gem if_gem.c if_gem_pci.c if_gemvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 19:15:30 -0000 phk 2007-05-04 19:15:29 UTC FreeBSD src repository Modified files: sys/dev/gem if_gem.c if_gem_pci.c if_gemvar.h Log: Since if_gem is being touted as one of our more architecturally correct network drivers with respect to busmaster DMA, go over it with at duster to make other aspects of it a role model: Eliminate the pci specific softc, it serves no rational purpose. Use convenience resource allocation/deallocation functions to save code and errorhandling. Switch from bus_space_{read|write}_%u() to bus_{read|write}_%u() functions and forget about tags and handles, the resource will know about those, should they be needed. This also eliminates a number of inconsistently named local variables. Revision Changes Path 1.41 +112 -141 src/sys/dev/gem/if_gem.c 1.22 +27 -52 src/sys/dev/gem/if_gem_pci.c 1.13 +2 -2 src/sys/dev/gem/if_gemvar.h From owner-cvs-src@FreeBSD.ORG Fri May 4 19:47:05 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C983A16A400; Fri, 4 May 2007 19:47:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 50E6213C489; Fri, 4 May 2007 19:47:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l44Jkvpv050250; Fri, 4 May 2007 15:46:59 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Rui Paulo Date: Fri, 4 May 2007 15:45:08 -0400 User-Agent: KMail/1.9.6 References: <200705021750.l42HoaMj067787@repoman.freebsd.org> <86hcqs612o.wl%rpaulo@fnop.net> In-Reply-To: <86hcqs612o.wl%rpaulo@fnop.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705041545.09141.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 May 2007 15:46:59 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3205/Fri May 4 06:50:21 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c src/sys/amd64/include intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 19:47:05 -0000 On Friday 04 May 2007 11:49:35 am Rui Paulo wrote: > At Wed, 2 May 2007 17:50:36 +0000 (UTC), > John Baldwin wrote: > > > > jhb 2007-05-02 17:50:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 mptable_pci.c msi.c nexus.c > > sys/amd64/include intr_machdep.h > > sys/amd64/pci pci_bus.c > > sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c > > sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h > > pcib_if.m pcib_private.h pcivar.h > > sys/i386/i386 mptable_pci.c msi.c nexus.c > > sys/i386/include intr_machdep.h > > sys/i386/pci pci_bus.c > > Log: > > Revamp the MSI/MSI-X code a bit to achieve two main goals: > > - Simplify the amount of work that has be done for each architecture by > > pushing more of the truly MI code down into the PCI bus driver. > > - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map > > multiple MSI-X messages into a single IRQ when handling a message > > shortage. > > > With this change, I think, I get a WITNESS panic when booting the > second core on my MacBook > > After SMP: AP #1 Launched, I get this panic: > panic: blockable sleep lock (sx) msi @ i386/i386/msi.c:374 > > The backtrace is: > witness_checkorder() > _sx_lock() > msi_map() > nexus_map_msi() > acpi_pcib_map_msi() > pcib_map_msi() > pci_remap_msi_irq() > msi_assign_cpu() > > Any idea why? Hmm, I know why, I'll look at it. I think msi_assign_cpu() is called while holding a lock and that is leading to the problem. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri May 4 21:53:54 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5744316A400; Fri, 4 May 2007 21:53:54 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.freebsd.org (Postfix) with ESMTP id 1B09213C459; Fri, 4 May 2007 21:53:53 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.8/8.13.1) with ESMTP id l44Lrf2C020578; Fri, 4 May 2007 17:53:41 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.8/8.13.1/Submit) id l44LrfxY020577; Fri, 4 May 2007 17:53:41 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Fri, 4 May 2007 17:53:41 -0400 From: David Schultz To: Bruce Evans Message-ID: <20070504215341.GA20478@VARK.MIT.EDU> Mail-Followup-To: Bruce Evans , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200705021524.l42FOnXp033760@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705021524.l42FOnXp033760@repoman.freebsd.org> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/msun/bsdsrc b_tgamma.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 21:53:54 -0000 On Wed, May 02, 2007, Bruce Evans wrote: > bde 2007-05-02 15:24:49 UTC > > FreeBSD src repository > > Modified files: > lib/msun/bsdsrc b_tgamma.c > Log: > Fix tgamma() on some special args: Nice. Personally, I've never had a reason to compute tgamma() on negative inputs anyway, so it's no surprise to me that nobody noticed the problem in the last 20 years! Sorry I've been out of the loop a bit. I'm hoping to have some time this summer, but may wind up at MSR instead... From owner-cvs-src@FreeBSD.ORG Fri May 4 22:04:41 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F0B0716A408; Fri, 4 May 2007 22:04:41 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CA17713C484; Fri, 4 May 2007 22:04:41 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44M4fqK008461; Fri, 4 May 2007 22:04:41 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44M4fZa008460; Fri, 4 May 2007 22:04:41 GMT (envelope-from njl) Message-Id: <200705042204.l44M4fZa008460@repoman.freebsd.org> From: Nate Lawson Date: Fri, 4 May 2007 22:04:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files.amd64 src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 22:04:42 -0000 njl 2007-05-04 22:04:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files.amd64 sys/modules/agp Makefile Log: MFC: enable i810 (including i915, i945, etc) on amd64 Revision Changes Path 1.71.2.12 +1 -0 src/sys/conf/files.amd64 1.14.2.2 +1 -1 src/sys/modules/agp/Makefile From owner-cvs-src@FreeBSD.ORG Fri May 4 23:14:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F7FB16A401; Fri, 4 May 2007 23:14:20 +0000 (UTC) (envelope-from davidch@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 310B013C448; Fri, 4 May 2007 23:14:20 +0000 (UTC) (envelope-from davidch@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44NEK7A020549; Fri, 4 May 2007 23:14:20 GMT (envelope-from davidch@repoman.freebsd.org) Received: (from davidch@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44NEKLm020548; Fri, 4 May 2007 23:14:20 GMT (envelope-from davidch) Message-Id: <200705042314.l44NEKLm020548@repoman.freebsd.org> From: David Christensen Date: Fri, 4 May 2007 23:14:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 23:14:20 -0000 davidch 2007-05-04 23:14:19 UTC FreeBSD src repository Modified files: sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h Log: MFC after: 2 weeks Updated copyright date to 2007. Tested with BCM5706 A3. Added ID for BCM5708 B2. Removed unused driver version string. Modified BCE_PRINTF macro to automatically fill-in the sc pointer. Fixed a kernel panic when the driver was loaded as a module from the command-line because the MII bus pointer was null (i.e. the MII bus hadn't been enumerated yet). Added fix proposed by Vladimir Ivanov to prevent driver state corruption when releasing the lock during the ISR in bce_rx_intr() to send packets up the stack. Added new TX chain and register read sysctl interfaces for debugging. Cleaned up formatting for various other debug routines. Added a new statistic maintained by firmware which tracks the number of received packets dropped because no receive buffers are available. Revision Changes Path 1.30 +500 -302 src/sys/dev/bce/if_bce.c 1.2 +1 -1 src/sys/dev/bce/if_bcefw.h 1.12 +14 -9 src/sys/dev/bce/if_bcereg.h From owner-cvs-src@FreeBSD.ORG Fri May 4 23:43:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CB8716A403; Fri, 4 May 2007 23:43:19 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6694213C458; Fri, 4 May 2007 23:43:19 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44NhJK7025162; Fri, 4 May 2007 23:43:19 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44NhJed025161; Fri, 4 May 2007 23:43:19 GMT (envelope-from rwatson) Message-Id: <200705042343.l44NhJed025161@repoman.freebsd.org> From: Robert Watson Date: Fri, 4 May 2007 23:43:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_debug.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 23:43:19 -0000 rwatson 2007-05-04 23:43:19 UTC FreeBSD src repository Modified files: sys/netinet tcp_debug.c tcp_var.h Log: Add global mutex tcp_debug_mtx, which will protect global TCP debugging state tcp_debug, tcp_debx. Acquire and drop as required in tcp_trace(). Move to ANSI C function header, correct prototype types so that short TCP state is no longer promoted to int unnecessarily. Add comments. MFC after: 3 weeks Revision Changes Path 1.27 +31 -12 src/sys/netinet/tcp_debug.c 1.145 +1 -1 src/sys/netinet/tcp_var.h From owner-cvs-src@FreeBSD.ORG Sat May 5 04:24:02 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5E60816A404; Sat, 5 May 2007 04:24:02 +0000 (UTC) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 37D1813C455; Sat, 5 May 2007 04:24:02 +0000 (UTC) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l454O2OU082130; Sat, 5 May 2007 04:24:02 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l454O275082128; Sat, 5 May 2007 04:24:02 GMT (envelope-from suz) Message-Id: <200705050424.l454O275082128@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Sat, 5 May 2007 04:24:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 nd6.c nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 04:24:02 -0000 suz 2007-05-05 04:24:01 UTC FreeBSD src repository Modified files: sys/netinet6 nd6.c nd6_nbr.c Log: some minor modification to the previous commit to sys/netinet6/nd6.c and nd6_nbr.c. - added some clarification comments - removed an unnecesary code Obtained from: KAME MFC after: 1 week Revision Changes Path 1.77 +6 -1 src/sys/netinet6/nd6.c 1.44 +5 -0 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Sat May 5 08:10:38 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D47916A402; Sat, 5 May 2007 08:10:38 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1673213C44B; Sat, 5 May 2007 08:10:38 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l458AbdB028686; Sat, 5 May 2007 08:10:37 GMT (envelope-from takawata@repoman.freebsd.org) Received: (from takawata@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l458AbQQ028685; Sat, 5 May 2007 08:10:37 GMT (envelope-from takawata) Message-Id: <200705050810.l458AbQQ028685@repoman.freebsd.org> From: Takanori Watanabe Date: Sat, 5 May 2007 08:10:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 uftdi.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 08:10:38 -0000 takawata 2007-05-05 08:10:37 UTC FreeBSD src repository Modified files: share/man/man4 uftdi.4 Log: Document devices that can drivea . Obtained from: [FreeBSD-users-jp 90628](uftdi.c rev 1.25 also) Revision Changes Path 1.10 +2 -0 src/share/man/man4/uftdi.4 From owner-cvs-src@FreeBSD.ORG Sat May 5 08:23:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 990D916A400; Sat, 5 May 2007 08:23:06 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3990C13C487; Sat, 5 May 2007 08:23:06 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l458N6sk031278; Sat, 5 May 2007 08:23:06 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l458N6RB031277; Sat, 5 May 2007 08:23:06 GMT (envelope-from phk) Message-Id: <200705050823.l458N6RB031277@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 5 May 2007 08:23:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 uftdi.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 08:23:06 -0000 phk 2007-05-05 08:23:06 UTC FreeBSD src repository Modified files: share/man/man4 uftdi.4 Log: Add Prologix GPIB-USB Controller (Highly recommended btw) Revision Changes Path 1.11 +2 -0 src/share/man/man4/uftdi.4 From owner-cvs-src@FreeBSD.ORG Sat May 5 08:45:00 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6564A16A401; Sat, 5 May 2007 08:45:00 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 3EF2E13C44B; Sat, 5 May 2007 08:45:00 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l458j0XM034619; Sat, 5 May 2007 08:45:00 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l458j0jQ034610; Sat, 5 May 2007 08:45:00 GMT (envelope-from davidxu) Message-Id: <200705050845.l458j0jQ034610@repoman.freebsd.org> From: David Xu Date: Sat, 5 May 2007 08:44:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 08:45:00 -0000 davidxu 2007-05-05 08:44:59 UTC FreeBSD src repository Modified files: libexec/rtld-elf rtld.c Log: Fix a TLS memory leak. PR: threads/112297 MFC: 1 week Revision Changes Path 1.123 +1 -0 src/libexec/rtld-elf/rtld.c From owner-cvs-src@FreeBSD.ORG Sat May 5 09:17:36 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E095E16A401; Sat, 5 May 2007 09:17:36 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id D248F13C448; Sat, 5 May 2007 09:17:36 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l459HaKr048814; Sat, 5 May 2007 09:17:36 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l459Haou048813; Sat, 5 May 2007 09:17:36 GMT (envelope-from ariff) Message-Id: <200705050917.l459Haou048813@repoman.freebsd.org> From: Ariff Abdullah Date: Sat, 5 May 2007 09:17:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci/hda hdac.c hdac_private.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 09:17:37 -0000 ariff 2007-05-05 09:17:36 UTC FreeBSD src repository Modified files: sys/dev/sound/pci/hda hdac.c hdac_private.h Log: Miscellaneous changes and fix: - Remove explicit call to pmap_change_attr(), since we now have proper and functional definition of BUS_DMA_NOCACHE. - Enable PCI(e) bus snooping for non i386/amd64 as an alternative for uncacheable DMA. - Codecs changes: * Analag Device -> Analog Devices, AD1988. * New codec: VIA VT1708 and VT1709, Realtek ALC262, ALC861-VD and ALC885. * Various fixups for Conexant Waikiki, fix recording (read: microphone) on various Analog Devices codecs due to vendor BIOS mess, various quirks for several ASUS laptops/boards. - Fix connection list handling, closely following the specification to handle range of nids. - Basic Jack sense polling infrastructure for possible hardwares with broken unsolicited response interrupt. Ideas/Submitted/Tested by: Andriy Gapon , #freebsd-azalia, many. Revision Changes Path 1.35 +992 -312 src/sys/dev/sound/pci/hda/hdac.c 1.6 +7 -0 src/sys/dev/sound/pci/hda/hdac_private.h From owner-cvs-src@FreeBSD.ORG Sat May 5 09:18:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6E43616A401; Sat, 5 May 2007 09:18:05 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6073913C448; Sat, 5 May 2007 09:18:05 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l459I5FV048856; Sat, 5 May 2007 09:18:05 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l459I5rY048855; Sat, 5 May 2007 09:18:05 GMT (envelope-from ariff) Message-Id: <200705050918.l459I5rY048855@repoman.freebsd.org> From: Ariff Abdullah Date: Sat, 5 May 2007 09:18:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci ich.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 09:18:05 -0000 ariff 2007-05-05 09:18:05 UTC FreeBSD src repository Modified files: sys/dev/sound/pci ich.c Log: Fix (or rather workaround) Intel 440MX Errata #36 - http://www.intel.com/design/chipsets/specupdt/245051.htm AC97 Soft Audio and Soft Modem Master Abort Errata Issue: Use of either soft audio or soft modem on an Intel® 82443MX PCISet based platform running a 100 MHz Processor System Bus and an AC97 codec may result in failures. The system continues to function normally while the AC97 hardware may not resume and may require a cold-boot to recover. As a result of the failure, the Master Abort Status bit will be set in the audio or modem function PCI header space. Workaround: Force uncacheable DMA on both BDL and pcm buffers. Tested by: Emil Holmstr|m Revision Changes Path 1.75 +116 -58 src/sys/dev/sound/pci/ich.c From owner-cvs-src@FreeBSD.ORG Sat May 5 10:33:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4DD4C16A402; Sat, 5 May 2007 10:33:29 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 28BDA13C44C; Sat, 5 May 2007 10:33:29 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45AXTv0061850; Sat, 5 May 2007 10:33:29 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45AXSao061849; Sat, 5 May 2007 10:33:28 GMT (envelope-from joel) Message-Id: <200705051033.l45AXSao061849@repoman.freebsd.org> From: Joel Dahl Date: Sat, 5 May 2007 10:33:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 snd_hda.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 10:33:29 -0000 joel 2007-05-05 10:33:28 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 snd_hda.4 Log: Document more quirks and supported codecs. Revision Changes Path 1.9 +27 -1 src/share/man/man4/snd_hda.4 From owner-cvs-src@FreeBSD.ORG Sat May 5 10:36:58 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 87DB516A400; Sat, 5 May 2007 10:36:58 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 628D413C447; Sat, 5 May 2007 10:36:58 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45AawbU062163; Sat, 5 May 2007 10:36:58 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45Aaweu062158; Sat, 5 May 2007 10:36:58 GMT (envelope-from joel) Message-Id: <200705051036.l45Aaweu062158@repoman.freebsd.org> From: Joel Dahl Date: Sat, 5 May 2007 10:36:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 snd_hda.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 10:36:58 -0000 joel 2007-05-05 10:36:57 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 snd_hda.4 Log: Forgot to bump .Dd Revision Changes Path 1.10 +1 -1 src/share/man/man4/snd_hda.4 From owner-cvs-src@FreeBSD.ORG Sat May 5 11:07:52 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C296816A406; Sat, 5 May 2007 11:07:52 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9D95313C44B; Sat, 5 May 2007 11:07:52 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45B7qOx067871; Sat, 5 May 2007 11:07:52 GMT (envelope-from sephe@repoman.freebsd.org) Received: (from sephe@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45B7qfE067870; Sat, 5 May 2007 11:07:52 GMT (envelope-from sephe) Message-Id: <200705051107.l45B7qfE067870@repoman.freebsd.org> From: Sepherosa Ziehau Date: Sat, 5 May 2007 11:07:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net80211 ieee80211_amrr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 11:07:52 -0000 sephe 2007-05-05 11:07:52 UTC FreeBSD src repository Modified files: sys/net80211 ieee80211_amrr.c Log: - Nuke unnecessary header. - Make wlan_amrr depend on wlan, so that it can find various symbols in wlan module if wlan is not compiled into kernel. Approved by: sam (mentor) Tested by: kevlo Revision Changes Path 1.2 +1 -1 src/sys/net80211/ieee80211_amrr.c From owner-cvs-src@FreeBSD.ORG Sat May 5 15:14:31 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 117F616A402; Sat, 5 May 2007 15:14:31 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id C534513C44C; Sat, 5 May 2007 15:14:30 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id D81D72093; Sat, 5 May 2007 17:14:26 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id CA072208C; Sat, 5 May 2007 17:14:26 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id A7ABE4899; Sat, 5 May 2007 17:14:26 +0200 (CEST) From: des@des.no (Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?=) To: Nate Lawson References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> Date: Sat, 05 May 2007 17:14:26 +0200 In-Reply-To: <462CD3FD.6080300@root.org> (Nate Lawson's message of "Mon, 23 Apr 2007 08:42:53 -0700") Message-ID: <86tzurqp4d.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 15:14:31 -0000 Nate Lawson writes: > Dag-Erling Sm=C3=B8rgrav writes: > > I'm going to set up a ports fetch run with FTP_COMBINE_CWDS enabled to > > see how it works out in the ugly, real world. If it works out well, I > > might replace the #ifdef with a command-line option or environment > > variable for "strict RFC conformance". > Thanks for doing the testing. Still on-going. I forgot to add BATCH=3DYES to the make command line and had to start over. I expect it will take several more days to run to completion. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Sat May 5 15:21:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E901B16A403; Sat, 5 May 2007 15:21:25 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id A621113C455; Sat, 5 May 2007 15:21:25 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id C7E2C2093; Sat, 5 May 2007 17:21:21 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 3FDFB208C; Sat, 5 May 2007 17:21:21 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 0FD36489B; Sat, 5 May 2007 17:21:21 +0200 (CEST) From: des@des.no (Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?=) To: Yar Tikhiy References: <200704260639.l3Q6d1SH027885@repoman.freebsd.org> <20070426105458.GA98415@nevermind.kiev.ua> <20070427162614.GG3991@comp.chem.msu.su> <20070428131748.GA51455@nevermind.kiev.ua> <20070428140247.GC14847@comp.chem.msu.su> Date: Sat, 05 May 2007 17:21:20 +0200 In-Reply-To: <20070428140247.GC14847@comp.chem.msu.su> (Yar Tikhiy's message of "Sat, 28 Apr 2007 18:02:47 +0400") Message-ID: <86ps5fqosv.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.ORG, Alexandr Kovalenko , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.8 pam_unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 15:21:26 -0000 Yar Tikhiy writes: > The funny fact is that now sshd(8) behaves consistently, and it's > partly due to my change. [...] FWIW, although I was either too busy or too distracted to review Yar's patch when he submitted it in March: as the maintainer of both PAM and OpenSSH, I believe the patch is correct and I approve of Yar's commit. He has simply modified pam_unix(8) to behave in accordance with what was already documented in pw(8), long after OpenSSH was modified (by the vendor) to do so when not using PAM. I don't see that there's anything to argue about. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Sat May 5 16:33:44 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA29916A400; Sat, 5 May 2007 16:33:44 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C50C613C43E; Sat, 5 May 2007 16:33:44 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45GXiI6035438; Sat, 5 May 2007 16:33:44 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45GXi9v035437; Sat, 5 May 2007 16:33:44 GMT (envelope-from pjd) Message-Id: <200705051633.l45GXi9v035437@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 16:33:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom.h geom_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 16:33:45 -0000 pjd 2007-05-05 16:33:44 UTC FreeBSD src repository Modified files: sys/geom geom.h geom_subr.c Log: - Implement helper g_handleattr_str() function for string attributes handling. - Extend g_handleattr() to treat attribute as string when len=0. OK'ed by: phk Revision Changes Path 1.99 +1 -0 src/sys/geom/geom.h 1.91 +22 -7 src/sys/geom/geom_subr.c From owner-cvs-src@FreeBSD.ORG Sat May 5 16:35:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4705616A400; Sat, 5 May 2007 16:35:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 21DA813C487; Sat, 5 May 2007 16:35:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45GZNKt035746; Sat, 5 May 2007 16:35:23 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45GZMYA035745; Sat, 5 May 2007 16:35:22 GMT (envelope-from pjd) Message-Id: <200705051635.l45GZMYA035745@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 16:35:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom.h geom_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 16:35:23 -0000 pjd 2007-05-05 16:35:22 UTC FreeBSD src repository Modified files: sys/geom geom.h geom_io.c Log: Implement g_delete_data() similar to g_read_data() and g_write_data(). OK'ed by: phk Revision Changes Path 1.100 +1 -0 src/sys/geom/geom.h 1.75 +22 -0 src/sys/geom/geom_io.c From owner-cvs-src@FreeBSD.ORG Sat May 5 17:02:20 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 24B5516A401; Sat, 5 May 2007 17:02:20 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1780A13C458; Sat, 5 May 2007 17:02:20 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45H2Jh9047994; Sat, 5 May 2007 17:02:19 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45H2JhR047993; Sat, 5 May 2007 17:02:19 GMT (envelope-from pjd) Message-Id: <200705051702.l45H2JhR047993@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 17:02:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys disk.h src/sys/geom geom_dev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 17:02:20 -0000 pjd 2007-05-05 17:02:19 UTC FreeBSD src repository Modified files: sys/sys disk.h sys/geom geom_dev.c Log: Implement three new ioctls that can be used with GEOM provider: DIOCGFLUSH - Flush write cache (sends BIO_FLUSH). DIOCGDELETE - Delete data (mark as unused) (sends BIO_DELETE). DIOCGIDENT - Get provider's uniqe and fixed identifier (asks for GEOM::ident attribute). First two are self-explanatory, but the last one might not be. Here are properties of provider's ident: - ident value is preserved between reboots, - provider can be detached/attached and ident is preserved, - provider's name can change - ident can't, - ident value should not be based on on-disk metadata; in other words copying whole data from one disk to another should not yield the same ident for the other disk, - there could be more than one provider with the same ident, but only if they point at exactly the same physical storage, this is the case for multipathing for example, - GEOM classes that consumes single providers and provide single providers, like geli, gbde, should just attach class name to the ident of the underlying provider, - ident is an ASCII string (is printable), - ident is optional and applications can't relay on its presence. The main purpose for this is that application and remember provider's ident and once it tries to open provider by its name again, it may compare idents to be sure this is the right provider. If it is not (idents don't match), then it can open provider by its ident. OK'ed by: phk Revision Changes Path 1.94 +20 -0 src/sys/geom/geom_dev.c 1.42 +32 -0 src/sys/sys/disk.h From owner-cvs-src@FreeBSD.ORG Sat May 5 17:12:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C56216A402; Sat, 5 May 2007 17:12:16 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 262CE13C459; Sat, 5 May 2007 17:12:16 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45HCFOM050892; Sat, 5 May 2007 17:12:16 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45HCFaB050884; Sat, 5 May 2007 17:12:15 GMT (envelope-from pjd) Message-Id: <200705051712.l45HCFaB050884@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 17:12:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_disk.c geom_disk.h src/share/man/man9 disk.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 17:12:16 -0000 pjd 2007-05-05 17:12:15 UTC FreeBSD src repository Modified files: sys/geom geom_disk.c geom_disk.h share/man/man9 disk.9 Log: - Extend disk structure to allow to store disk's serial number, which can be retrieved via GEOM::ident attribute. - Bump disk(9) ABI version. OK'ed by: phk Revision Changes Path 1.10 +2 -0 src/share/man/man9/disk.9 1.102 +3 -1 src/sys/geom/geom_disk.c 1.7 +4 -1 src/sys/geom/geom_disk.h From owner-cvs-src@FreeBSD.ORG Sat May 5 17:36:43 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9334A16A401; Sat, 5 May 2007 17:36:43 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 6DAEE13C44C; Sat, 5 May 2007 17:36:43 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45HahZu054582; Sat, 5 May 2007 17:36:43 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45HahpQ054581; Sat, 5 May 2007 17:36:43 GMT (envelope-from jmg) Message-Id: <200705051736.l45HahpQ054581@repoman.freebsd.org> From: John-Mark Gurney Date: Sat, 5 May 2007 17:36:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/common loader.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 17:36:43 -0000 jmg 2007-05-05 17:36:43 UTC FreeBSD src repository Modified files: sys/boot/common loader.8 Log: fixup talk of kern.maxswzone... It's been 32MB for almost 5 years now... and only supports just over 7GB of swap... Sound a bit more professional.. Inspired by: Marc G. Fournier MFC After: 3 days Revision Changes Path 1.92 +6 -7 src/sys/boot/common/loader.8 From owner-cvs-src@FreeBSD.ORG Sat May 5 17:47:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4E2A916A4E9; Sat, 5 May 2007 17:47:25 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 91D0813C4C4; Sat, 5 May 2007 17:47:24 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45HlLEB056224; Sat, 5 May 2007 17:47:21 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45HlLKM056223; Sat, 5 May 2007 17:47:21 GMT (envelope-from pjd) Message-Id: <200705051747.l45HlLKM056223@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 17:47:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 17:47:25 -0000 pjd 2007-05-05 17:47:20 UTC FreeBSD src repository Modified files: sys/geom geom_disk.c Log: Because there are many strange hardware out there, allow to use only [a-zA-Z0-9-_@#%.] characters in d_ident field. Revision Changes Path 1.103 +39 -0 src/sys/geom/geom_disk.c From owner-cvs-src@FreeBSD.ORG Sat May 5 17:52:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5427D16A401; Sat, 5 May 2007 17:52:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2E02E13C46A; Sat, 5 May 2007 17:52:23 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45HqNse057277; Sat, 5 May 2007 17:52:23 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45HqN0K057275; Sat, 5 May 2007 17:52:23 GMT (envelope-from pjd) Message-Id: <200705051752.l45HqN0K057275@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 17:52:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_slice.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 17:52:23 -0000 pjd 2007-05-05 17:52:22 UTC FreeBSD src repository Modified files: sys/geom geom_slice.c Log: Handle GEOM::ident attribute by attaching 'sX' string at the end of ident received from the underlying provider, where X is pp->index value. OK'ed by: phk Revision Changes Path 1.62 +32 -0 src/sys/geom/geom_slice.c From owner-cvs-src@FreeBSD.ORG Sat May 5 18:08:04 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22C3416A403; Sat, 5 May 2007 18:08:04 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id D546613C46E; Sat, 5 May 2007 18:08:03 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.64.2]) by phk.freebsd.dk (Postfix) with ESMTP id A8D8D17382; Sat, 5 May 2007 18:08:01 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l45I80nk001823; Sat, 5 May 2007 18:08:01 GMT (envelope-from phk@critter.freebsd.dk) To: Pawel Jakub Dawidek From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 05 May 2007 17:02:19 GMT." <200705051702.l45H2JhR047993@repoman.freebsd.org> Date: Sat, 05 May 2007 18:08:00 +0000 Message-ID: <1822.1178388480@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys disk.h src/sys/geom geom_dev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 18:08:04 -0000 In message <200705051702.l45H2JhR047993@repoman.freebsd.org>, Pawel Jakub Dawid ek writes: > First two are self-explanatory, but the last one might not be. Here are > properties of provider's ident: > > - ident value should not be based on on-disk metadata; in other words > copying whole data from one disk to another should not yield the same > ident for the other disk, > - there could be more than one provider with the same ident, but only if > they point at exactly the same physical storage, this is the case for > multipathing for example, - If the provider cannot guarantee these two requirements, no ident shall be offered. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat May 5 18:09:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2EFDC16A406; Sat, 5 May 2007 18:09:18 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 099BA13C46C; Sat, 5 May 2007 18:09:18 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45I9HJO060587; Sat, 5 May 2007 18:09:17 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45I9HwB060586; Sat, 5 May 2007 18:09:17 GMT (envelope-from pjd) Message-Id: <200705051809.l45I9HwB060586@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 5 May 2007 18:09:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 18:09:18 -0000 pjd 2007-05-05 18:09:17 UTC FreeBSD src repository Modified files: sys/geom geom_disk.c Log: Allow to use ':' in d_ident, which is quite handy character. Revision Changes Path 1.104 +2 -1 src/sys/geom/geom_disk.c From owner-cvs-src@FreeBSD.ORG Sat May 5 18:58:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 837E816A401; Sat, 5 May 2007 18:58:23 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 75D1F13C458; Sat, 5 May 2007 18:58:23 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45IwNk2068017; Sat, 5 May 2007 18:58:23 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45IwNff068016; Sat, 5 May 2007 18:58:23 GMT (envelope-from alc) Message-Id: <200705051858.l45IwNff068016@repoman.freebsd.org> From: Alan Cox Date: Sat, 5 May 2007 18:58:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 18:58:23 -0000 alc 2007-05-05 18:58:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 pmap.c Log: MFC Revision 1.530 Replace diagnostic printf()s by assertions. Use consistent style for similar assertions. MFC Revision 1.540 Introduce pmap_try_insert_pv_entry(). Use pmap_try_insert_pv_entry() in pmap_copy() instead of pmap_insert_entry(). Eliminate the explicit low-memory checks in pmap_copy(). MFC Revision 1.544 Retire pmap_track_modified(). MFC Revision 1.555 Introduce the function pmap_enter_object(). MFC Revision 1.558 (in part) Change pmap_enter_quick_locked() to fail rather than wait if it is unable to allocate a page table page. Similarly, change pmap_enter_quick_locked() to call pmap_try_insert_pv_entry() rather than pmap_insert_entry(). Add an assertion that the object containing m_start is locked in pmap_enter_object(). Remove a similar assertion from pmap_enter_quick_locked() because that function no longer accesses the containing object. Remove a stale comment. Revision Changes Path 1.516.2.14 +122 -121 src/sys/amd64/amd64/pmap.c From owner-cvs-src@FreeBSD.ORG Sat May 5 19:50:39 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2388B16A404; Sat, 5 May 2007 19:50:39 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1293813C483; Sat, 5 May 2007 19:50:39 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45Joco5077562; Sat, 5 May 2007 19:50:38 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45JocKM077536; Sat, 5 May 2007 19:50:38 GMT (envelope-from alc) Message-Id: <200705051950.l45JocKM077536@repoman.freebsd.org> From: Alan Cox Date: Sat, 5 May 2007 19:50:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/include vmparam.h src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/ia64/ia64 machdep.c src/sys/ia64/include vmparam.h src/sys/powerpc/include vmparam.h src/sys/sparc64/include vmparam.h src/sys/sun4v/include ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 19:50:39 -0000 alc 2007-05-05 19:50:28 UTC FreeBSD src repository Modified files: sys/amd64/include vmparam.h sys/arm/include vmparam.h sys/i386/include vmparam.h sys/ia64/ia64 machdep.c sys/ia64/include vmparam.h sys/powerpc/include vmparam.h sys/sparc64/include vmparam.h sys/sun4v/include vmparam.h sys/vm vm_page.c vm_page.h Log: Define every architecture as either VM_PHYSSEG_DENSE or VM_PHYSSEG_SPARSE depending on whether the physical address space is densely or sparsely populated with memory. The effect of this definition is to determine which of two implementations of vm_page_array and PHYS_TO_VM_PAGE() is used. The legacy implementation is obtained by defining VM_PHYSSEG_DENSE, and a new implementation that trades off time for space is obtained by defining VM_PHYSSEG_SPARSE. For now, all architectures except for ia64 and sparc64 define VM_PHYSSEG_DENSE. Defining VM_PHYSSEG_SPARSE on ia64 allows the entirety of my Itanium 2's memory to be used. Previously, only the first 1 GB could be used. Defining VM_PHYSSEG_SPARSE on sparc64 allows USIIIi-based systems to boot without crashing. This change is a combination of Nathan Whitehorn's patch and my own work in perforce. Discussed with: kmacy, marius, Nathan Whitehorn PR: 112194 Revision Changes Path 1.47 +5 -0 src/sys/amd64/include/vmparam.h 1.8 +5 -0 src/sys/arm/include/vmparam.h 1.42 +5 -0 src/sys/i386/include/vmparam.h 1.215 +0 -15 src/sys/ia64/ia64/machdep.c 1.14 +5 -0 src/sys/ia64/include/vmparam.h 1.6 +5 -0 src/sys/powerpc/include/vmparam.h 1.16 +5 -0 src/sys/sparc64/include/vmparam.h 1.3 +5 -0 src/sys/sun4v/include/vmparam.h 1.342 +8 -0 src/sys/vm/vm_page.c 1.148 +20 -2 src/sys/vm/vm_page.h From owner-cvs-src@FreeBSD.ORG Sat May 5 20:17:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5CE8716A402; Sat, 5 May 2007 20:17:24 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4E33C13C46A; Sat, 5 May 2007 20:17:24 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45KHOWU083296; Sat, 5 May 2007 20:17:24 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45KHOAt083295; Sat, 5 May 2007 20:17:24 GMT (envelope-from mjacob) Message-Id: <200705052017.l45KHOAt083295@repoman.freebsd.org> From: Matt Jacob Date: Sat, 5 May 2007 20:17:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_pci.c isp_sbus.c isp_tpublic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 20:17:24 -0000 mjacob 2007-05-05 20:17:24 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_pci.c isp_sbus.c isp_tpublic.h Log: Make this an MP safe driver but also still be multi-release. Seems to work on RELENG_4 through -current and also on sparc64 now. There may still be some issues with the auto attach/detach code to sort out. MFC after: 3 days Revision Changes Path 1.146 +2 -17 src/sys/dev/isp/isp.c 1.140 +185 -224 src/sys/dev/isp/isp_freebsd.c 1.105 +91 -39 src/sys/dev/isp/isp_freebsd.h 1.143 +99 -135 src/sys/dev/isp/isp_pci.c 1.33 +46 -81 src/sys/dev/isp/isp_sbus.c 1.19 +18 -6 src/sys/dev/isp/isp_tpublic.h From owner-cvs-src@FreeBSD.ORG Sat May 5 20:18:25 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7050B16A401; Sat, 5 May 2007 20:18:25 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 4973813C458; Sat, 5 May 2007 20:18:25 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45KIPRG083351; Sat, 5 May 2007 20:18:25 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45KIPLJ083350; Sat, 5 May 2007 20:18:25 GMT (envelope-from mjacob) Message-Id: <200705052018.l45KIPLJ083350@repoman.freebsd.org> From: Matt Jacob Date: Sat, 5 May 2007 20:18:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_pci.c mpt_raid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 20:18:25 -0000 mjacob 2007-05-05 20:18:25 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_pci.c mpt_raid.c Log: Make this driver MP safe and still be a multi-release driver. Obtained from: 99% of the work done by Scott Long. MFC after: 3 days Revision Changes Path 1.41 +16 -4 src/sys/dev/mpt/mpt.c 1.40 +36 -34 src/sys/dev/mpt/mpt.h 1.56 +62 -53 src/sys/dev/mpt/mpt_cam.c 1.6 +8 -0 src/sys/dev/mpt/mpt_cam.h 1.50 +0 -10 src/sys/dev/mpt/mpt_pci.c 1.15 +28 -28 src/sys/dev/mpt/mpt_raid.c From owner-cvs-src@FreeBSD.ORG Sat May 5 21:13:16 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D496216A406; Sat, 5 May 2007 21:13:16 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id C677413C469; Sat, 5 May 2007 21:13:16 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45LDGaS001606; Sat, 5 May 2007 21:13:16 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45LDGuQ001605; Sat, 5 May 2007 21:13:16 GMT (envelope-from alc) Message-Id: <200705052113.l45LDGuQ001605@repoman.freebsd.org> From: Alan Cox Date: Sat, 5 May 2007 21:13:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 21:13:16 -0000 alc 2007-05-05 21:13:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 mp_machdep.c pmap.c Log: MFC Acquiring smp_ipi_mtx on every call to pmap_invalidate_*() is wasteful. For example, during a buildworld more than half of the calls do not generate an IPI because the only TLB entry invalidated is on the calling processor. This revision pushes down the acquisition and release of smp_ipi_mtx into smp_tlb_shootdown() and smp_targeted_tlb_shootdown() and instead uses sched_pin() and sched_unpin() in pmap_invalidate_*() so that thread migration doesn't lead to a missed TLB invalidation. Revision Changes Path 1.260.2.11 +8 -2 src/sys/amd64/amd64/mp_machdep.c 1.516.2.15 +8 -64 src/sys/amd64/amd64/pmap.c From owner-cvs-src@FreeBSD.ORG Sat May 5 22:18:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1961816A401; Sat, 5 May 2007 22:18:19 +0000 (UTC) (envelope-from scottl@pooker.samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id C20B713C4B9; Sat, 5 May 2007 22:18:18 +0000 (UTC) (envelope-from scottl@pooker.samsco.org) Received: from [192.168.254.15] (ydesk.samsco.home [192.168.254.15]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l45LlAN3080006; Sat, 5 May 2007 15:47:10 -0600 (MDT) (envelope-from scottl@pooker.samsco.org) Message-ID: <463CFB3B.2010702@pooker.samsco.org> Date: Sat, 05 May 2007 15:46:35 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Matt Jacob References: <200705052018.l45KIPLJ083350@repoman.freebsd.org> In-Reply-To: <200705052018.l45KIPLJ083350@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [192.168.254.1]); Sat, 05 May 2007 15:47:10 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_pci.c mpt_raid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2007 22:18:19 -0000 Matt Jacob wrote: > mjacob 2007-05-05 20:18:25 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_pci.c > mpt_raid.c > Log: > Make this driver MP safe and still be a multi-release driver. > > Obtained from: 99% of the work done by Scott Long. > MFC after: 3 days > > Revision Changes Path > 1.41 +16 -4 src/sys/dev/mpt/mpt.c > 1.40 +36 -34 src/sys/dev/mpt/mpt.h > 1.56 +62 -53 src/sys/dev/mpt/mpt_cam.c > 1.6 +8 -0 src/sys/dev/mpt/mpt_cam.h > 1.50 +0 -10 src/sys/dev/mpt/mpt_pci.c > 1.15 +28 -28 src/sys/dev/mpt/mpt_raid.c Fantastic, thanks a lot for taking care of this and ISP. Every modern SCSI driver is now MPSAFE with the exception of umass and sbp, which both have larger issues to deal with first. It'll be nice to get drivers like SYM taken care of, so any volunteers are welcomed! Scott