From owner-freebsd-arm@FreeBSD.ORG  Sun Dec  2 13:13:38 2007
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9050716A41A
	for <freebsd-arm@freebsd.org>; Sun,  2 Dec 2007 13:13:38 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id B8C1A13C4E7
	for <freebsd-arm@freebsd.org>; Sun,  2 Dec 2007 13:13:37 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.14.1/8.13.8) with ESMTP id lB2E9L5A040694;
	Sun, 2 Dec 2007 15:09:21 +0100 (CET)
	(envelope-from mlfbsd@dong.ci0.org)
Received: (from mlfbsd@localhost)
	by dong.ci0.org (8.14.1/8.13.8/Submit) id lB2E9K2E040693;
	Sun, 2 Dec 2007 15:09:20 +0100 (CET) (envelope-from mlfbsd)
Date: Sun, 2 Dec 2007 15:09:20 +0100
From: Olivier Houchard <mlfbsd@ci0.org>
To: Rafal Jaworowski <raj@semihalf.com>
Message-ID: <20071202140920.GA40640@ci0.org>
References: <474FF9BF.8090707@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <474FF9BF.8090707@semihalf.com>
User-Agent: Mutt/1.4.1i
Cc: freebsd-arm@freebsd.org
Subject: Re: ARM arch subdir cleanups
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2007 13:13:38 -0000

On Fri, Nov 30, 2007 at 12:53:35PM +0100, Rafal Jaworowski wrote:
> Hi,
> Attached are two patches with the following cleanups:
> 
> 1. Convert nexus to standard device since it's mandatory anyway, remove stale
> nexus_io_asm.S and nexus_io.c
> 
> 2. Streamline sys/conf/files.arm (and hence the kernel image contents): move
> asm routines to appropriate sys/arm/<platform>/files.<platform>
> 
> 
> It seems to me other items in the ARM arch subdirectory would benefit from
> optimization/cleanups too, for example:
> 
> - Shared OBIO routines. At least these are nearly identical and could be
> compressed into one I guess:
> 
>   xscale/i80321/obio_space.c
>   xscale/i8134x/obio_space.c
>   xscale/pxa2x0/pxa2x0_space.c (in P4)
> 
> - Shared bus space generic methods. A lot of BS methods like *_bs_map(),
> _bs_subregion() etc. are copied in separate files for different ARM platforms,
> but most of this could be placed in one file, just like we have a common
> assembly routines in the arm/arm/bus_space_asm_generic.S.
> 
> - Others like arm/arm/machdep.c and arm/arm/sys_machdep.c seem akin, could
> they be merged into one file?
> 
> I can work on cleaning those up, would such changes be welcome?
> 
> Rafal


Hi Rafal,

I just committed your patches. Yes, this kind of work is very welcome.

Thanks a lot !

Olivier