From owner-freebsd-bugs@FreeBSD.ORG Sun Jun 24 00:20:01 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6A9DF16A421 for ; Sun, 24 Jun 2007 00:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 4E7E413C45D for ; Sun, 24 Jun 2007 00:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5O0K1G5010191 for ; Sun, 24 Jun 2007 00:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5O0K1mU010190; Sun, 24 Jun 2007 00:20:01 GMT (envelope-from gnats) Resent-Date: Sun, 24 Jun 2007 00:20:01 GMT Resent-Message-Id: <200706240020.l5O0K1mU010190@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, David Sanderson Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 038C416A41F for ; Sun, 24 Jun 2007 00:10:32 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id D310313C468 for ; Sun, 24 Jun 2007 00:10:31 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5O0AVad024110 for ; Sun, 24 Jun 2007 00:10:31 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l5O0AV3r024109; Sun, 24 Jun 2007 00:10:31 GMT (envelope-from nobody) Message-Id: <200706240010.l5O0AV3r024109@www.freebsd.org> Date: Sun, 24 Jun 2007 00:10:31 GMT From: David Sanderson To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: misc/113979: sysinstall does not support UFS1 filesystems in install.cfg X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2007 00:20:01 -0000 >Number: 113979 >Category: misc >Synopsis: sysinstall does not support UFS1 filesystems in install.cfg >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jun 24 00:20:00 GMT 2007 >Closed-Date: >Last-Modified: >Originator: David Sanderson >Release: FreeBSD 6.2 >Organization: Panasas, Inc. >Environment: FreeBSD perf-x4 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 08:43:30 UTC 2007 root@portnoy.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP amd64 >Description: The FreeBSD 6.2 sysinstall supports creating UFS1 or UFS2 filesystems when used interactively, but only supports UFS2 filesystems via a noninteractive install via install.cfg. >How-To-Repeat: >Fix: Patch attached with submission follows: Change 210521 by dsanderson@dsanderson-k2-sb7-tango-bsd-dws2 on 2007/06/23 19:10:32 Teach the FreeBSD 6 sysinstall how to create a UFS1 filesystem via install.cfg. The default is still UFS2. To select UFS1, use "ufs1" as the filesystem type in the label arguments. Tested with an install.cfg fragment like so: # root, 8 GB twed0s1-1=ufs1 16777216 / # swap, 8 GB twed0s1-2=swap 16777216 none # /var, rest of the disk twed0s1-4=ufs1 0 /var # now invoke the label editor diskLabelEditor To see whether a filesystem is UFS1 or UFS2, you can use dumpfs. For instance, 11826358700000# dumpfs / | sed 1q magic 11954 (UFS1) time Sat Jun 23 23:06:41 2007 Affected files ... .. //depot/branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c#2 edit Differences ... ==== //depot/branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c#2 (text) ==== Index: branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c --- branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c.~1~ Sat Jun 23 20:05:33 2007 +++ branch/tango-bsd-dws/src/freebsd6/src/usr.sbin/sysinstall/label.c Sat Jun 23 20:05:33 2007 @@ -1636,6 +1636,7 @@ for (entries = 1;; entries++) { intmax_t sz; int soft = 0; + int ufs1 = 0; snprintf(name, sizeof name, "%s-%d", c1->name, entries); if ((cp = variable_get(name)) == NULL) break; @@ -1652,6 +1653,8 @@ strcpy(mpoint, "SWAP"); } else { type = PART_FILESYSTEM; + if (!strcmp(typ, "ufs1")) + ufs1 = 1; if (!strcmp(mpoint, "/")) flags |= CHUNK_IS_ROOT; } @@ -1672,6 +1675,7 @@ pi = tmp->private_data = new_part(PART_FILESYSTEM, mpoint, TRUE); tmp->private_free = safe_free; pi->newfs_data.newfs_ufs.softupdates = soft; + pi->newfs_data.newfs_ufs.ufs1 = ufs1; } } } End of Patch. >Release-Note: >Audit-Trail: >Unformatted: