From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 2 10:00:04 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E04E16A417 for ; Sun, 2 Dec 2007 10:00:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E001F13C455 for ; Sun, 2 Dec 2007 10:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB2A03Ij078229 for ; Sun, 2 Dec 2007 10:00:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB2A035k078228; Sun, 2 Dec 2007 10:00:03 GMT (envelope-from gnats) Resent-Date: Sun, 2 Dec 2007 10:00:03 GMT Resent-Message-Id: <200712021000.lB2A035k078228@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michal Vranek Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43C9916A417 for ; Sun, 2 Dec 2007 09:59:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 324CF13C455 for ; Sun, 2 Dec 2007 09:59:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lB29x8vM055250 for ; Sun, 2 Dec 2007 09:59:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lB29x7xo055249; Sun, 2 Dec 2007 09:59:07 GMT (envelope-from nobody) Message-Id: <200712020959.lB29x7xo055249@www.freebsd.org> Date: Sun, 2 Dec 2007 09:59:07 GMT From: Michal Vranek To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/118380: libkvm - kvm_close doesn't dealocate all used memory X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2007 10:00:04 -0000 >Number: 118380 >Category: misc >Synopsis: libkvm - kvm_close doesn't dealocate all used memory >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 02 10:00:03 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Michal Vranek >Release: 6.2, 6.3 >Organization: >Environment: FreeBSD xerius.felk.cvut.cz 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #3: Sun Nov 4 22:19:33 CET 2007 root@xerius.felk.cvut.cz:/usr/obj/usr/src/sys/XERIUS i38 6 >Description: Using more times sequencely kvm-library functions to get environment variables of other running proceses causes memory consume in the questioning process. I think the reason is kd->argspc and kd->argbuf nowhere dealocated. >How-To-Repeat: Run this code and watch its size in memory. void main() { pid_t pid; scanf("%d",&pid); // input pid of another running proces while(1) { int count; char errbuf[_POSIX2_LINE_MAX]; struct kinfo_proc *process_identity; kvm_t *kd; char **environment_variables; kd = kvm_openfiles( NULL , NULL, NULL, O_RDONLY, errbuf ); if ( kd == NULL ) exit(1); process_identity = kvm_getprocs( kd, KERN_PROC_PID, pid, &count ); if ( process_identity == NULL ) { kvm_close( kd ); exit(1); } environment_variables = kvm_getenvv( kd, process_identity, 0 ); if( environment_variables == NULL ) { kvm_close( kd ); exit(1); } /* here could be variables listing */ kvm_close( kd ); } } >Fix: Most probably the solution is to modify (add two times free()) kvm_close() in /usr/src/lib/libkvm/kvm.c . int kvm_close(kd) kvm_t *kd; { int error = 0; if (kd->pmfd >= 0) error |= close(kd->pmfd); if (kd->vmfd >= 0) error |= close(kd->vmfd); if (kd->nlfd >= 0) error |= close(kd->nlfd); if (kd->vmst) _kvm_freevtop(kd); if (kd->procbase != 0) free((void *)kd->procbase); if (kd->argv != 0) free((void *)kd->argv); ///////////////////////////////////////////// if (kd->argspc != 0) free((void *) kd->argspc); if (kd->argbuf != 0) free((void *) kd->argbuf); ///////////////////////////////////////////// free((void *)kd); return (0); } >Release-Note: >Audit-Trail: >Unformatted: