From owner-freebsd-current@FreeBSD.ORG Sun Sep 30 00:33:14 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE35E16A418 for ; Sun, 30 Sep 2007 00:33:14 +0000 (UTC) (envelope-from w0lfie@clear.net.nz) Received: from smtp3.clear.net.nz (smtp3.clear.net.nz [203.97.33.64]) by mx1.freebsd.org (Postfix) with ESMTP id 9052213C457 for ; Sun, 30 Sep 2007 00:33:14 +0000 (UTC) (envelope-from w0lfie@clear.net.nz) Received: from clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp3.clear.net.nz (CLEAR Net Mail) with SMTP id <0JP500K81O7CBI20@smtp3.clear.net.nz> for freebsd-current@freebsd.org; Sun, 30 Sep 2007 13:33:12 +1300 (NZDT) Date: Sun, 30 Sep 2007 13:33:12 +1300 From: Sam Banks Sender: w0lfie@clear.net.nz To: freebsd-current@freebsd.org Message-id: <46feeec8.106.9f9.24060@clear.net.nz> MIME-version: 1.0 X-Mailer: CLEAR Net WebMail; webmail.clear.net.nz; user: w0lfie; ip: 121.73.22.121 Content-type: multipart/mixed; boundary="-=_fep1346feeec8" Priority: normal Subject: uipc_sockbuf sysctl X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: w0lfie@clear.net.nz List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 00:33:14 -0000 This is a multi-part message in MIME format. ---=_fep1346feeec8 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hey all, I have started looking into cleaning up sysctl's with empty descriptions and have come across kern.dummy. Looking into sys/kern/uipc_sockbuf.c, kern.dummy does absolutely nothing other than offer the ability to change it. The variable that the sysctl call populates (dummy) is not used directly in sys/kern/uipc_sockbuf.c or, as far as I can see, anywhere in the sys/ code. Is there a reason I'm missing why this seemingly uneeded sysctl call is in the code or can it be removed with the attached patch? Cheers, Sam. ---=_fep1346feeec8 Content-Type: application/octet-stream; name="uipc_sockbuf.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="uipc_sockbuf.c.diff" SW5kZXg6IHN5cy9rZXJuL3VpcGNfc29ja2J1Zi5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9rZXJuL3Vp cGNfc29ja2J1Zi5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE3MQpkaWZm IC11IC1yMS4xNzEgdWlwY19zb2NrYnVmLmMKLS0tIHN5cy9rZXJuL3VpcGNf c29ja2J1Zi5jCTMxIE1heSAyMDA3IDExOjUxOjIyIC0wMDAwCTEuMTcxCisr KyBzeXMva2Vybi91aXBjX3NvY2tidWYuYwkzMCBTZXAgMjAwNyAwMDoxODow NiAtMDAwMApAQCAtMTAyOSw4ICsxMDI5LDYgQEAKIH0KIAogLyogVGhpcyB0 YWtlcyB0aGUgcGxhY2Ugb2Yga2Vybi5tYXhzb2NrYnVmLCB3aGljaCBtb3Zl ZCB0byBrZXJuLmlwYy4gKi8KLXN0YXRpYyBpbnQgZHVtbXk7Ci1TWVNDVExf SU5UKF9rZXJuLCBLRVJOX0RVTU1ZLCBkdW1teSwgQ1RMRkxBR19SVywgJmR1 bW15LCAwLCAiIik7CiBTWVNDVExfT0lEKF9rZXJuX2lwYywgS0lQQ19NQVhT T0NLQlVGLCBtYXhzb2NrYnVmLCBDVExUWVBFX1VMT05HfENUTEZMQUdfUlcs CiAgICAgJnNiX21heCwgMCwgc3lzY3RsX2hhbmRsZV9zYl9tYXgsICJMVSIs ICJNYXhpbXVtIHNvY2tldCBidWZmZXIgc2l6ZSIpOwogU1lTQ1RMX1VMT05H KF9rZXJuX2lwYywgS0lQQ19TT0NLQlVGX1dBU1RFLCBzb2NrYnVmX3dhc3Rl X2ZhY3RvciwgQ1RMRkxBR19SVywK ---=_fep1346feeec8--