From owner-freebsd-emulation@FreeBSD.ORG  Sun Nov 25 00:57:18 2007
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 16B4616A420;
	Sun, 25 Nov 2007 00:57:18 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from Daffy.timing.com (mx1.timing.com [206.168.13.218])
	by mx1.freebsd.org (Postfix) with ESMTP id C47BA13C44B;
	Sun, 25 Nov 2007 00:57:17 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id lAP0iUvG014668;
	Sat, 24 Nov 2007 17:44:30 -0700 (MST)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.14.1/8.14.1) with ESMTP id lAP0iQ2X002842;
	Sat, 24 Nov 2007 17:44:26 -0700 (MST)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.14.1/8.14.1/Submit) id lAP0iQsk002839;
	Sat, 24 Nov 2007 17:44:26 -0700 (MST) (envelope-from jhein)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18248.50538.142360.921846@gromit.timing.com>
Date: Sat, 24 Nov 2007 17:44:26 -0700
From: John Hein <jhein@timing.com>
To: Roman Divacky <rdivacky@freebsd.org>
In-Reply-To: <20071124221946.GA74651@freebsd.org>
References: <20071124221946.GA74651@freebsd.org>
X-Mailer: VM 7.19 under Emacs 22.0.99.1
X-Virus-Scanned: ClamAV version 0.91.2,
	clamav-milter version 0.91.2 on Daffy.timing.com
X-Virus-Status: Clean
Cc: emulation@freebsd.org, des@freebsd.org
Subject: Re: compat/linprocfs
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2007 00:57:18 -0000

Roman Divacky wrote at 23:19 +0100 on Nov 24, 2007:
 > in
 > compat/linprocfs/linprocfs.c:linprocfs_doprocmaps() there's 
 > 
 >         unsigned int last_timestamp;
 > 
 > variable declaration, this variable is used only once in this function:
 > 
 >         if (last_timestamp + 1 != map->timestamp) {
 > 
 > ie. the map->timestamp is compared to some stack garbage + 1. this does not
 > seem to be correct, the last_timestamp must be set somewhere..
 > 
 > comments?

It is set 6 lines earlier...

		last_timestamp = map->timestamp;
		vm_map_unlock_read(map);
		error = uiomove(mebuffer, len, uio);
		vm_map_lock_read(map);
		if (error)
			break;
		if (last_timestamp + 1 != map->timestamp) {