From owner-freebsd-python@FreeBSD.ORG Sun Aug 26 15:49:14 2007 Return-Path: Delivered-To: freebsd-python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E18516A419; Sun, 26 Aug 2007 15:49:14 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: from hyperion.scode.org (cl-1361.ams-04.nl.sixxs.net [IPv6:2001:960:2:550::2]) by mx1.freebsd.org (Postfix) with ESMTP id 7198C13C45E; Sun, 26 Aug 2007 15:49:13 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: by hyperion.scode.org (Postfix, from userid 1001) id E3D9123CF44; Sun, 26 Aug 2007 17:49:11 +0200 (CEST) Date: Sun, 26 Aug 2007 17:49:11 +0200 From: Peter Schuller To: vd@FreeBSD.org Message-ID: <20070826154911.GA77348@hyperion.scode.org> References: <200708240648.l7O6mWrA052725@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline In-Reply-To: <200708240648.l7O6mWrA052725@freefall.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: bug-followup@FreeBSD.org, freebsd-python@FreeBSD.org Subject: Re: ports/115761: new port: devel/py-boto X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 15:49:14 -0000 --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sorry about the incompleteness/incorrectness of the submission. Been a while since I submitted a port last, and I should have taken more time to ensure I was complying. > * Add the heading comments just as in any other port. Use $FreeBSD$, it will > be expanded automatically Done. > * Use ports-mgmt/portlint to check the port before submitting the shar, > it should produce no warnings or fatals Done. It correctly points out the non-redundancy of MASTER_SITES. I'd be happy to host a mirror on distfiles.scode.org if that is considered appropriate. Should I do that and re-submit? > * pkg-plist must be sorted alphabetically, not like this: > %%PYTHON_SITELIBDIR%%/boto/ec2/__init__.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/connection.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/image.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/instance.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/keypair.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/securitygroup.pyc > %%PYTHON_SITELIBDIR%%/boto/ec2/__init__.pyo Done. > * Explain why is files/patch-setup.py needed? What happens, without that > patch? Added comment to patch. It got installed as PREFIX/bin/test.py which is a very generic name. In the interest of minimal downstream patching/maintenance, I just commented it out rather than renamed it or made it be installed elsewhere, given that it is not likely to be very interesting for users of the port. > * Remove the trailing space after "Mechanical Turk" in pkg-descr Done. > * Submit the shar as an attachment so it is available in the PR system > even after you remove it from your site. Uploading it into your site > and posting a link makes it easier to fetch, if you are not bothered, > do both :-) Attached. Also available as: http://distfiles.scode.org/ports/py-boto-newport-2.shar -- / Peter Schuller PGP userID: 0xE9758B7D or 'Peter Schuller ' Key retrieval: Send an E-Mail to getpgpkey@scode.org E-Mail: peter.schuller@infidyne.com Web: http://www.scode.org --VS++wcV0S1rZb1Fb--