From owner-freebsd-rc@FreeBSD.ORG Sun Apr 1 02:46:58 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D022416A401; Sun, 1 Apr 2007 02:46:58 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mrout3.yahoo.com (mrout3.yahoo.com [216.145.54.173]) by mx1.freebsd.org (Postfix) with ESMTP id A4B2713C44C; Sun, 1 Apr 2007 02:46:58 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from minion.local.neville-neil.com (proxy8.corp.yahoo.com [216.145.48.13]) by mrout3.yahoo.com (8.13.6/8.13.6/y.out) with ESMTP id l312aJuM095986; Sat, 31 Mar 2007 19:36:19 -0700 (PDT) Date: Sun, 01 Apr 2007 10:45:00 +0900 Message-ID: From: gnn@FreeBSD.org To: Mike Makonnen In-Reply-To: <20070329182906.GB38703@rogue.navcom.lan> References: <20070329182906.GB38703@rogue.navcom.lan> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.0.95 (i386-apple-darwin8.8.2) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: freebsd-net@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2007 02:46:58 -0000 Hi, I'm going to take a look over these changes as well. Best, George From owner-freebsd-rc@FreeBSD.ORG Mon Apr 2 11:08:20 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1034816A477 for ; Mon, 2 Apr 2007 11:08:20 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id E36D413C4D5 for ; Mon, 2 Apr 2007 11:08:19 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l32B8JIX052253 for ; Mon, 2 Apr 2007 11:08:19 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l32B8IpR052249 for freebsd-rc@FreeBSD.org; Mon, 2 Apr 2007 11:08:18 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Apr 2007 11:08:18 GMT Message-Id: <200704021108.l32B8IpR052249@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: linimon set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2007 11:08:20 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/48881 rc [PATCH] The influence of /etc/start_ifname on /etc/rc. o conf/98758 rc [patch] Templatize 'jail_fstab' in /etc/rc.d/jail o conf/98846 rc [patch] Templatize 'jail_rootdir' in /etc/rc.d/jail o conf/105689 rc syslogd starts too late at boot o conf/107155 rc /etc/rc.d/ppp-user does not bring up pppoe at boot o conf/107316 rc [rc.d]: [base] [rpc.lockd] nfslocking restart does not o conf/107364 rc pf fails to start on bootup after system update from F 7 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/45226 rc Fix for rc.network, ppp-user annoyance o conf/48870 rc [PATCH] rc.network: allow to cancel interface status d o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/73677 rc [patch] add support for powernow states to power_profi o conf/74817 rc [patch] network.subr: fixed automatic configuration of o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/78906 rc [patch] Allow mixer_enable="NO" in rc.conf o conf/79196 rc [PATCH] configurable dummynet loading from /etc/rc.co o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/85363 rc syntax error in /etc/rc.d/devfs o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o conf/88913 rc [patch] wrapper support for rc.subr o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/89870 rc [patch] feature request to make netif verbose rc.conf o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/95162 rc [patch] Missing feature in rc.subr o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/99595 rc [PATCH] /etc/rc.d/dhclient doesn't interact well with o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/102700 rc [PATCH] Add encrypted /tmp support to GELI/GBDE rc.d s o conf/102722 rc kerberos5 server startupscript should use --detach o conf/102913 rc /etc/rc.d/named killall in jailed OS o conf/103486 rc [rc.d][patch][chroot named] rc.d/jail: mount fstab aft o conf/103489 rc [rc.d] [patch] named_chroot_autoupdate doesn't work in o conf/103976 rc rc.d/named restart failure o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/105145 rc [PATCH] add redial function to rc.d/ppp o conf/105568 rc [patch] Add more flexibility to rc.conf, to choose "_e o conf/106009 rc [patch] Fix pppoed startup script to process multiply o conf/106873 rc [patch] rc.d/nfslocking does not properly restart 32 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Apr 3 21:42:29 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D537A16A401; Tue, 3 Apr 2007 21:42:29 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id 73FD413C455; Tue, 3 Apr 2007 21:42:29 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 43B3342948; Tue, 3 Apr 2007 23:11:35 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id DB5869D619; Tue, 3 Apr 2007 21:11:32 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id C51DD405B; Tue, 3 Apr 2007 23:11:32 +0200 (CEST) Date: Tue, 3 Apr 2007 23:11:32 +0200 From: Jeremie Le Hen To: Mike Makonnen Message-ID: <20070403211132.GL5155@obiwan.tataz.chchile.org> References: <20070329182906.GB38703@rogue.navcom.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070329182906.GB38703@rogue.navcom.lan> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-net@freebsd.org, freebsd-rc@freebsd.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2007 21:42:29 -0000 Hi Mike, Thank you for working on this. I'm always glad to see someone working on homogenization. I dare to post a few comments though: On Thu, Mar 29, 2007 at 09:29:06PM +0300, Mike Makonnen wrote: > What it does > ------------ > - rc.d/network_ipv6 is no longer necessary and can be removed > - IPv6 configuration is done on each interface in rc.d/netif along with IPv4 > - IPv6 routing and options processing is done in rc.d/routing along with IPv4 > - You can now do things like: > # Start/Stop IPv6 on all interfaces > /etc/rc.d/netif (start|stop) ip6 > # Start/Stop IPv6 only on interface rl0 > /etc/rc.d/netif (start|stop) rl0 ip6 > # Do IPv6 options processing > /etc/rc.d/routing options ip6 As Dag-Erling said, it may conflict with a future if_ip. Moreover, network interfaces are renameable, so the namespace conflict is even more likely. Although it breaks the standard rc(8) syntax, I would personaly prefer: /etc/rc.d/netif (start6|stop6) rl0 BTW, the proposed syntax isn't very usual either :). > - In order to differentiate between v4 and v6 configuration directives some > knobs in rc.conf(5)have been renamed with an ipv4_ prefix: > network_interfaces > ifconfig_DEFAULT > ifconfig_ > ifconfig__aliasX > defaultrouter > gateway_enable > static_routes > etc... > > - Modify all scripts that reference old knobs (without ipv4_ prefix) to > reference the new version of the knobs > > - Compatibility shims in rc.subr(8) so that old uses of knobs without an > ipv4_ prefix work as expected. As part of this change split the > code for this processing into its own function: old2new_knobs() This is neat. What about issuing a warning in order to make a quicker transition ? Again, thank you for working on this. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From owner-freebsd-rc@FreeBSD.ORG Tue Apr 3 23:14:25 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4624516A402; Tue, 3 Apr 2007 23:14:25 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id E774713C448; Tue, 3 Apr 2007 23:14:24 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l33NENVu053522; Tue, 3 Apr 2007 18:14:23 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l33NENAH053521; Tue, 3 Apr 2007 18:14:23 -0500 (CDT) (envelope-from brooks) Date: Tue, 3 Apr 2007 18:14:23 -0500 From: Brooks Davis To: Mike Makonnen Message-ID: <20070403231423.GA52441@lor.one-eyed-alien.net> References: <20070329182906.GB38703@rogue.navcom.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20070329182906.GB38703@rogue.navcom.lan> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Tue, 03 Apr 2007 18:14:23 -0500 (CDT) Cc: freebsd-net@freebsd.org, freebsd-rc@freebsd.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2007 23:14:25 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I keep forgetting to do a review so a few comments now and hopefully a fuller review later. On Thu, Mar 29, 2007 at 09:29:06PM +0300, Mike Makonnen wrote: > Hello folks, >=20 > Ever since rc.d was brought into the tree we all agreed IPv6 needed > to be integrated better. Well, I've finally gotten arround to it... sever= al > years later :-P >=20 > The patch is at: http://people.freebsd.org/~mtm/src-etc.ipv6.diff >=20 > What it does > ------------ > - rc.d/network_ipv6 is no longer necessary and can be removed > - IPv6 configuration is done on each interface in rc.d/netif along with = IPv4 > - IPv6 routing and options processing is done in rc.d/routing along with= IPv4 > - You can now do things like: > # Start/Stop IPv6 on all interfaces > /etc/rc.d/netif (start|stop) ip6 > # Start/Stop IPv6 only on interface rl0 > /etc/rc.d/netif (start|stop) rl0 ip6 > # Do IPv6 options processing > /etc/rc.d/routing options ip6 I think I'd prefer (start|stop)(4|6). I not sure what the value of the separation is, but don't care much. > Overview of the changes in src/etc > ----------------------------------- > - In order to differentiate between v4 and v6 configuration directives s= ome > knobs in rc.conf(5)have been renamed with an ipv4_ prefix: > network_interfaces I fell fairly strongly that ipv6_network_interfaces and network_interfaces are a mistake and that we should remove them rather than propagating them. The way I'd prefer to see interfaces that are exceptional with regard to address families specified with (|NO)IPV(4|6) variables in ifconfig_ or simply by not having ipv(4|6)_ifconfig_interface variables (that it's a little more complicated than that with ipv4_addrs_ around, but I think the concept holds). > ifconfig_DEFAULT > ifconfig_ ipv4 versions of these make sense, but at least ifconfig_ should continue to exist. For example both setting the mac address and starting WPA via the WPA keyword should not work in any address specific version because that would be a layering violation. > ifconfig__aliasX > defaultrouter > gateway_enable > static_routes > etc... >=20 > - Modify all scripts that reference old knobs (without ipv4_ prefix) to > reference the new version of the knobs >=20 > - Compatibility shims in rc.subr(8) so that old uses of knobs without an > ipv4_ prefix work as expected. As part of this change split the > code for this processing into its own function: old2new_knobs() >=20 > - Modify some routines in etc/network.subr to take an additional argument > to specify v4 or v6 configuration: > _ifconfig_get_args > ifconfig_getargs > autoif > wpaif >=20 > - Move some invocations of route(8) and v6 options processing into > rc.d/routing >=20 >=20 > I'm using the patches on my main work machine without any > problems, so I think it's ready for a wider review. Please > try it out and send me any comments, bug-reports, etc. >=20 > I would > especially like feedback from folks more familiar with IPv6. One > gotcha I've noticed is that if you boot with ipv6_enable turned > off, then try to start IPv6 on an interface later on, it doesn't > work because none of the interfaces (except lo0) has a link-local > address (see rc.d/auto_linklocal). How can we fix this? Also, I > would appreciate feedback on how stopping IPv6 on an interface > should be handled. In rc.d/network_ipv6 it was handled at all. > Currently, it goes through and deletes all > IPv6 addresses on the interface. I'd say if ipv6_enable=3DNO, attempting to configure IPv6 on an interface should fail. If they turn it on, I'm not sure what the best approach is. Not worrying about it may well be most appropriate. -- Brooks --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGEt/OXY6L6fI4GtQRAsjOAKDkHlrhguJvenZU5V2hzuYHGvZYIgCgshZi Zzs6i2QgOVzjkbl7Nksd8CA= =TwZj -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB-- From owner-freebsd-rc@FreeBSD.ORG Thu Apr 5 15:21:27 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACCF616A401; Thu, 5 Apr 2007 15:21:27 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from mx1.ethionet.et (mx1.ethionet.et [213.55.64.53]) by mx1.freebsd.org (Postfix) with ESMTP id 223A713C459; Thu, 5 Apr 2007 15:21:27 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from mx1.ethionet.et (localhost [127.0.0.1]) by localhost.ethionet.et (Postfix) with ESMTP id 2B45B5245; Thu, 5 Apr 2007 18:17:43 +0300 (EAT) Received: from rogue.navcom.lan (unknown [213.55.64.98])by mx1.ethionet.et ( Postfix) with SMTP id 44F0A51C8;Thu, 5 Apr 2007 18:17:40 +0300 (EAT) Received: by rogue.navcom.lan (Postfix, from userid 1001)id C97A717045; Thu, 5 Apr 2007 18:24:06 +0300 (EAT) Date: Thu, 5 Apr 2007 18:24:06 +0300 From: Mike Makonnen To: Jeremie Le Hen Message-ID: <20070405152406.GA1844@rogue.navcom.lan> References: <20070329182906.GB38703@rogue.navcom.lan> <20070403211132.GL5155 @obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070403211132.GL5155@obiwan.tataz.chchile.org> User-Agent: Mutt/1.4.2.2i X-Operating-System: FreeBSD/7.0-CURRENT (i386) X-imss-version: 2.46 X-imss-result: Passed X-imss-scores: Clean:99.90000 C:2 M:3 S:5 R:5 X-imss-settings: Baseline:4 C:3 M:3 S:4 R:3 (1.0000 1.0000) Cc: freebsd-net@freebsd.org, freebsd-rc@freebsd.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 15:21:27 -0000 On Tue, Apr 03, 2007 at 11:11:32PM +0200, Jeremie Le Hen wrote: > > As Dag-Erling said, it may conflict with a future if_ip. Moreover, > network interfaces are renameable, so the namespace conflict is even > more likely. > > Although it breaks the standard rc(8) syntax, I would personaly prefer: > /etc/rc.d/netif (start6|stop6) rl0 > > BTW, the proposed syntax isn't very usual either :). I wasn't happy about the syntax either, but I was at a loss at how to handle it. Now that you've mentioned the obvious answer, I'm wondering how come it never occured to me :-P > > > - In order to differentiate between v4 and v6 configuration directives some > > knobs in rc.conf(5)have been renamed with an ipv4_ prefix: > > network_interfaces > > ifconfig_DEFAULT > > ifconfig_ > > ifconfig__aliasX > > defaultrouter > > gateway_enable > > static_routes > > etc... > > > > - Modify all scripts that reference old knobs (without ipv4_ prefix) to > > reference the new version of the knobs > > > > - Compatibility shims in rc.subr(8) so that old uses of knobs without an > > ipv4_ prefix work as expected. As part of this change split the > > code for this processing into its own function: old2new_knobs() > > This is neat. What about issuing a warning in order to make a > quicker transition ? > I think this is a matter of personal preference. If a lot of people think there should be a warning I can add it. Personally, I don't see the need, we can keep the shims as long as we want. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org From owner-freebsd-rc@FreeBSD.ORG Thu Apr 5 15:44:07 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F23816A409; Thu, 5 Apr 2007 15:44:07 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from mx1.ethionet.et (mx1.ethionet.et [213.55.64.53]) by mx1.freebsd.org (Postfix) with ESMTP id 5228913C45E; Thu, 5 Apr 2007 15:44:01 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from mx1.ethionet.et (localhost [127.0.0.1]) by localhost.ethionet.et (Postfix) with ESMTP id C98CB5235; Thu, 5 Apr 2007 18:40:18 +0300 (EAT) Received: from rogue.navcom.lan (unknown [213.55.64.98])by mx1.ethionet.et ( Postfix) with SMTP id 2799551E6;Thu, 5 Apr 2007 18:40:18 +0300 (EAT) Received: by rogue.navcom.lan (Postfix, from userid 1001)id 8420417045; Thu, 5 Apr 2007 18:46:44 +0300 (EAT) Date: Thu, 5 Apr 2007 18:46:44 +0300 From: Mike Makonnen To: Brooks Davis Message-ID: <20070405154644.GB1844@rogue.navcom.lan> References: <20070329182906.GB38703@rogue.navcom.lan> <20070403231423.GA5244 1@lor.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070403231423.GA52441@lor.one-eyed-alien.net> User-Agent: Mutt/1.4.2.2i X-Operating-System: FreeBSD/7.0-CURRENT (i386) X-imss-version: 2.46 X-imss-result: Passed X-imss-scores: Clean:99.90000 C:2 M:3 S:5 R:5 X-imss-settings: Baseline:4 C:3 M:3 S:4 R:3 (1.0000 1.0000) Cc: freebsd-net@freebsd.org, freebsd-rc@freebsd.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 15:44:07 -0000 On Tue, Apr 03, 2007 at 06:14:23PM -0500, Brooks Davis wrote: > > - You can now do things like: > > # Start/Stop IPv6 on all interfaces > > /etc/rc.d/netif (start|stop) ip6 > > # Start/Stop IPv6 only on interface rl0 > > /etc/rc.d/netif (start|stop) rl0 ip6 > > # Do IPv6 options processing > > /etc/rc.d/routing options ip6 > > I think I'd prefer (start|stop)(4|6). I not sure what the value of the > separation is, but don't care much. I'll post a new patch with this change. Now that its been mentioned I agree, it's a better thatn what I came up with. > > Overview of the changes in src/etc > > ----------------------------------- > > - In order to differentiate between v4 and v6 configuration directives some > > knobs in rc.conf(5)have been renamed with an ipv4_ prefix: > > network_interfaces > > I fell fairly strongly that ipv6_network_interfaces and > network_interfaces are a mistake and that we should remove them > rather than propagating them. The way I'd prefer to see interfaces > that are exceptional with regard to address families specified with > (|NO)IPV(4|6) variables in ifconfig_ or simply by not > having ipv(4|6)_ifconfig_interface variables (that it's a little more > complicated than that with ipv4_addrs_ around, but I think > the concept holds). I agree completely. However, when this hits the tree I don't want peoples configurations to break (especially since I would like to see this in 6-stable if we can aggree on it). Also, since this feature is already deprecated in the man page I think we can provide silent support for it without explicitly advertising it untill people have had a suffient transition period. > > > ifconfig_DEFAULT > > ifconfig_ > > ipv4 versions of these make sense, but at least ifconfig_ > should continue to exist. For example both setting the mac address and > starting WPA via the WPA keyword should not work in any address specific > version because that would be a layering violation. > Ok. That should be doable, but it's probably going to make configuration decisions more complicated. For example, do we ignore the WPA in the ipv(4|6)_* variables or does it's presence in any of the variables enable it? > > I would > > especially like feedback from folks more familiar with IPv6. One > > gotcha I've noticed is that if you boot with ipv6_enable turned > > off, then try to start IPv6 on an interface later on, it doesn't > > work because none of the interfaces (except lo0) has a link-local > > address (see rc.d/auto_linklocal). How can we fix this? Also, I > > would appreciate feedback on how stopping IPv6 on an interface > > should be handled. In rc.d/network_ipv6 it was handled at all. > > Currently, it goes through and deletes all > > IPv6 addresses on the interface. > > I'd say if ipv6_enable=NO, attempting to configure IPv6 on an interface > should fail. If they turn it on, I'm not sure what the best approach > is. Not worrying about it may well be most appropriate. I don't agree. I would expect that if I enable IPv6 in rc.conf I wouldn't have to reboot the machine to get my network interfaces configured properly. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org From owner-freebsd-rc@FreeBSD.ORG Thu Apr 5 16:02:53 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6187316A402; Thu, 5 Apr 2007 16:02:53 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 039B313C45B; Thu, 5 Apr 2007 16:02:52 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l35G2pjt078120; Thu, 5 Apr 2007 11:02:51 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l35G2pH1078119; Thu, 5 Apr 2007 11:02:51 -0500 (CDT) (envelope-from brooks) Date: Thu, 5 Apr 2007 11:02:51 -0500 From: Brooks Davis To: Mike Makonnen Message-ID: <20070405160251.GA68077@lor.one-eyed-alien.net> References: <20070329182906.GB38703@rogue.navcom.lan> <20070403231423.GA52441@lor.one-eyed-alien.net> <20070405154644.GB1844@rogue.navcom.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <20070405154644.GB1844@rogue.navcom.lan> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 05 Apr 2007 11:02:51 -0500 (CDT) Cc: freebsd-net@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org Subject: Re: Merging rc.d/network_ipv6 into rc.d/netif X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 16:02:53 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 05, 2007 at 06:46:44PM +0300, Mike Makonnen wrote: > On Tue, Apr 03, 2007 at 06:14:23PM -0500, Brooks Davis wrote: > > > - You can now do things like: > > > # Start/Stop IPv6 on all interfaces > > > /etc/rc.d/netif (start|stop) ip6 > > > # Start/Stop IPv6 only on interface rl0 > > > /etc/rc.d/netif (start|stop) rl0 ip6 > > > # Do IPv6 options processing > > > /etc/rc.d/routing options ip6 > >=20 > > I think I'd prefer (start|stop)(4|6). I not sure what the value of the > > separation is, but don't care much. >=20 > I'll post a new patch with this change. Now that its been mentioned > I agree, it's a better thatn what I came up with.=20 >=20 > > > Overview of the changes in src/etc > > > ----------------------------------- > > > - In order to differentiate between v4 and v6 configuration directiv= es some > > > knobs in rc.conf(5)have been renamed with an ipv4_ prefix: > > > network_interfaces > >=20 > > I fell fairly strongly that ipv6_network_interfaces and > > network_interfaces are a mistake and that we should remove them > > rather than propagating them. The way I'd prefer to see interfaces > > that are exceptional with regard to address families specified with > > (|NO)IPV(4|6) variables in ifconfig_ or simply by not > > having ipv(4|6)_ifconfig_interface variables (that it's a little more > > complicated than that with ipv4_addrs_ around, but I think > > the concept holds). >=20 > I agree completely. However, when this hits the tree I don't want peoples > configurations to break (especially since I would like to see this in > 6-stable if we can aggree on it). Also, since this feature is already > deprecated in the man page I think we can provide silent support for > it without explicitly advertising it untill people have had a suffient > transition period. OK, do you think it would be possible to kill off=20 > > > ifconfig_DEFAULT > > > ifconfig_ > >=20 > > ipv4 versions of these make sense, but at least ifconfig_ > > should continue to exist. For example both setting the mac address and > > starting WPA via the WPA keyword should not work in any address specific > > version because that would be a layering violation. > >=20 >=20 > Ok. That should be doable, but it's probably going to make > configuration decisions more complicated. For example, do we ignore > the WPA in the ipv(4|6)_* variables or does it's presence in any > of the variables enable it? I'd ignore WPA outside of ifconfig_. I think we'll want DHCP to work there and under ipv4_ifconfig_, but not IPv6. That will change if/when a dhcp6 client arrives, but who knows when that will happen. > > > I would > > > especially like feedback from folks more familiar with IPv6. One > > > gotcha I've noticed is that if you boot with ipv6_enable turned > > > off, then try to start IPv6 on an interface later on, it doesn't > > > work because none of the interfaces (except lo0) has a link-local > > > address (see rc.d/auto_linklocal). How can we fix this? Also, I > > > would appreciate feedback on how stopping IPv6 on an interface > > > should be handled. In rc.d/network_ipv6 it was handled at all. > > > Currently, it goes through and deletes all > > > IPv6 addresses on the interface. > >=20 > > I'd say if ipv6_enable=3DNO, attempting to configure IPv6 on an interfa= ce > > should fail. If they turn it on, I'm not sure what the best approach > > is. Not worrying about it may well be most appropriate. >=20 > I don't agree. I would expect that if I enable IPv6 in rc.conf I wouldn't > have to reboot the machine to get my network interfaces configured > properly. That would be nice if we can make it work. I'm just not sure how much effort it's worth to make all the edge cases work. -- Brooks --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGFR2qXY6L6fI4GtQRAhO3AKC4X5kWLjxlS8RPmNKPcu6DJ3ypJgCggJLC JCp4UmykOptHlgyDsNRqefo= =r511 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--