From owner-freebsd-rc@FreeBSD.ORG  Sun Oct  7 11:03:57 2007
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4DF3516A468
	for <freebsd-rc@freebsd.org>; Sun,  7 Oct 2007 11:03:57 +0000 (UTC)
	(envelope-from mtm@FreeBSD.Org)
Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A264B13C465;
	Sun,  7 Oct 2007 11:03:55 +0000 (UTC) (envelope-from mtm@FreeBSD.Org)
Received: by terra.mike.lan (Postfix, from userid 1000)
	id AD4BD6954B; Sun,  7 Oct 2007 14:08:16 +0300 (EAT)
Date: Sun, 7 Oct 2007 14:08:16 +0300
From: Mike Makonnen <mtm@FreeBSD.Org>
To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
Message-ID: <20071007110815.GA16458@terra.mike.lan>
References: <bb4a86c70710061314j588ce9a9s6922d2c1e7100e6a@mail.gmail.com>
	<20071006215757.GA10458@terra.mike.lan>
	<bb4a86c70710061549o14447dfye9553a42ef77cadc@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bb4a86c70710061549o14447dfye9553a42ef77cadc@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
X-Operating-System: FreeBSD/7.0-CURRENT (i386)
Cc: freebsd-rc@freebsd.org
Subject: Re: multiple instances of ppp
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Oct 2007 11:03:57 -0000

On Sat, Oct 06, 2007 at 03:49:57PM -0700, Maksim Yevmenkin wrote:
> 
> thanks for your comments. what do you think about something like
> 
> # PROVIDE: ppp
> # REQUIRE: netif isdnd
> # KEYWORD: nojail
> 
> . /etc/rc.subr
> 
> name="ppp"
> rcvar=`set_rcvar`
> command="/usr/sbin/${name}"
> start_cmd="ppp_start"
> start_postcmd="ppp_poststart"
> 
> ppp_start_profile()
> {
> 	local _ppp_profile, _ppp_mode, _ppp_nat

You should lose the commas. Local variable declarations are space-separated.

Other than that, looks good.

cheers.
-- 
Mike Makonnen         | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc
mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8  5279 5359 2B82 7CD4 1F55
mtm @ FreeBSD.Org     | FreeBSD - http://www.freebsd.org