From owner-freebsd-rc@FreeBSD.ORG Sun Oct 14 06:36:25 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDC8C16A418; Sun, 14 Oct 2007 06:36:25 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id 675F213C43E; Sun, 14 Oct 2007 06:36:25 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 390743F6165; Sun, 14 Oct 2007 08:36:24 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id EAC2B3F6162; Sun, 14 Oct 2007 08:36:23 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 5540F9B497; Sun, 14 Oct 2007 06:36:19 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 4A5E6405B; Sun, 14 Oct 2007 08:36:19 +0200 (CEST) Date: Sun, 14 Oct 2007 08:36:19 +0200 From: Jeremie Le Hen To: Dirk Engling Message-ID: <20071014063619.GM28841@obiwan.tataz.chchile.org> References: <20071010194000.GA7260@terra.mike.lan> <20071014001341.I24298@erdgeist.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline In-Reply-To: <20071014001341.I24298@erdgeist.org> User-Agent: Mutt/1.5.15 (2007-04-06) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-rc@FreeBSD.Org, Mike Makonnen , jeremie@le-hen.org, bug-followup@FreeBSD.org Subject: Re: conf/116416: [patch] per-jail rc.conf(5) style configuration file in /etc/jail/ X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 06:36:26 -0000 --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Dirk, Thank you for your enlightened review. On Sun, Oct 14, 2007 at 12:27:03AM +0200, Dirk Engling wrote: > > On Wed, 10 Oct 2007, Mike Makonnen wrote: > > > I like this patch, especially the second revision. I think people who > > run a very large number of jails will appreciate it. However, I'd like > > to see a few changes made: > > Hi, before you reinvent the wheel, I'd like you to take a look at my > ezjail[1] project. I've done much of the work more than two years ago and > would call the results stable and in wide use. > > I'd be too happy to just use /etc/jail.d as config directory for jails, as I > do today with /usr/local/etc/ezjail. However, if you write config files the > right way, there is no need to throw awk on them, just source them. Certainly we would all benefit from your experience with ezjail. As for files in /etc/jail.d, I personally prefer the way I did it. IMO it is repetitions that /etc/jail.d/myjail contains: % jail_myjail_ip=... % jail_myjail_hostname=... % jail_myjail_rootdir=... The awk script is not a great deal and just translates "ip=..." to "jail__ip=...": % ip=... % hostname=... % rootdir=... Both ways have benefits and I would like to read some FreeBSD developper's opinion on this subject. I will change my patch accordingly, if needed. > Usign an rcorder style scheme on config files allows starting jails in a > predefined order. It is undoubtly necessary to be able to define jail starting order even in the "auto" case. I've made that change. > Allowing some pre-start commands to mount root dirs or attach certain disc > based memory images would be helpful, too. I completly agree. I've already come up to this conclusion for some time. I will submit another PR, unless Mike asks me to achieve this in the same patch. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > --vOmOzSkFvhd7u8Ms--