From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 06:01:26 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F32E416A400 for ; Mon, 26 Feb 2007 06:01:25 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B371913C49D for ; Mon, 26 Feb 2007 06:01:25 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1Q60G2W063128; Sun, 25 Feb 2007 23:00:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 25 Feb 2007 23:00:19 -0700 (MST) Message-Id: <20070225.230019.1649768891.imp@bsdimp.com> To: lydianconcepts@gmail.com From: "M. Warner Losh" In-Reply-To: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 25 Feb 2007 23:00:17 -0700 (MST) Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 06:01:26 -0000 In message: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> "Matthew Jacob" writes: : > The question is: Given that I know that the first USB/CF adapter : > always reports one too big, is there a way this can be fixed? : : There are two problems here that I see: : : a) The GEOM taste code cannot be overridden. : : b) How do we accomodate/detect broken h/w? : : I'm inclined to think that GEOM stuff cannot/should not be "fixed". : The second question is the harder one. : : You personally can fix this for yourself by doing your own specialized : quirk matching and just adjusting the READ CAPACITY results : accordingly. We have to ask whether this particular breakage is both : widespread enough and the devices important enough to try and : generalize some solution for. I took a look at Linux, and they have a quirk for this. A bunch of cameras have this bug, as do iPods and a few media readers... Warner From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 07:31:42 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EB04C16A402 for ; Mon, 26 Feb 2007 07:31:42 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.243]) by mx1.freebsd.org (Postfix) with ESMTP id A9C3613C467 for ; Mon, 26 Feb 2007 07:31:42 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: by an-out-0708.google.com with SMTP id c24so747764ana for ; Sun, 25 Feb 2007 23:31:42 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tZSraWo1WXK6pcq6PIDksMOtTqen2wL2DE9wZ/Z0WrGkwfVZeXLc8PHdFs0LldlXxQfs3PljmSuNVAExqcrKWN/FNS/8yD/5YsUVtwXulGog8ujpAqZShv8m5USWXRUx7jiw3SNNFH78ax182339Dh1b+Ri/tnvxRBujrgTPt9o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kNYcH7aNiH3Yz5ad+ukdTAfmS4VtfBmicWIcFLpmLYiCtw8FEUe0wPLvHIg+mfWmHfnL9ijZ94cq812LinoeVnN2nc1GIYhLLmqXDB3ZH8BO4B2JTrlhQtW4AAdTKZ92En+7hMqr0EKWru9opnjC/aQX6GlYerSZDj+ZX+Fje80= Received: by 10.114.60.19 with SMTP id i19mr1998023waa.1172475101704; Sun, 25 Feb 2007 23:31:41 -0800 (PST) Received: by 10.114.25.18 with HTTP; Sun, 25 Feb 2007 23:31:41 -0800 (PST) Message-ID: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> Date: Sun, 25 Feb 2007 23:31:41 -0800 From: "Matthew Jacob" To: "M. Warner Losh" In-Reply-To: <20070225.230019.1649768891.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 07:31:43 -0000 > > I took a look at Linux, and they have a quirk for this. A bunch of > cameras have this bug, as do iPods and a few media readers... > So, is your take then we should have a "subtract by N" read capacity quirk? From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 08:50:27 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7873216A400 for ; Mon, 26 Feb 2007 08:50:27 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 26B1213C428 for ; Mon, 26 Feb 2007 08:50:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1Q8n3pj016424; Mon, 26 Feb 2007 01:49:08 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E29EF9.3030306@samsco.org> Date: Mon, 26 Feb 2007 01:48:57 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: "M. Warner Losh" References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> In-Reply-To: <20070225.230019.1649768891.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 26 Feb 2007 01:49:08 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 08:50:27 -0000 M. Warner Losh wrote: > In message: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> > "Matthew Jacob" writes: > : > The question is: Given that I know that the first USB/CF adapter > : > always reports one too big, is there a way this can be fixed? > : > : There are two problems here that I see: > : > : a) The GEOM taste code cannot be overridden. > : > : b) How do we accomodate/detect broken h/w? > : > : I'm inclined to think that GEOM stuff cannot/should not be "fixed". > : The second question is the harder one. > : > : You personally can fix this for yourself by doing your own specialized > : quirk matching and just adjusting the READ CAPACITY results > : accordingly. We have to ask whether this particular breakage is both > : widespread enough and the devices important enough to try and > : generalize some solution for. > > I took a look at Linux, and they have a quirk for this. A bunch of > cameras have this bug, as do iPods and a few media readers... > > Warner So is it an off-by-one issue for all of these devices, or do we need to have a mechanism for encoding a variable fudge factor? Secondly, is it only a problem with USB devices? Third, do we want only the READ_CAPACITY that is done during probe+attach to be fudged, or do we want to intercept every READ_CAPACITY attempt from every source and fudge them all? Scott From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 11:16:04 2007 Return-Path: X-Original-To: freebsd-scsi@FreeBSD.org Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CD1916A415 for ; Mon, 26 Feb 2007 11:16:04 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 6FB2E13C46B for ; Mon, 26 Feb 2007 11:16:04 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1QBG4JH005553 for ; Mon, 26 Feb 2007 11:16:04 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1QBFx4j005549 for freebsd-scsi@FreeBSD.org; Mon, 26 Feb 2007 11:15:59 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 26 Feb 2007 11:15:59 GMT Message-Id: <200702261115.l1QBFx4j005549@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: linimon set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 11:16:04 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/27059 scsi [sym] SCSI subsystem hangs under heavy load on (Server o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/40895 scsi wierd kernel / device driver bug o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o kern/60598 scsi wire down of scsi devices conflicts with config o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 o kern/81887 scsi [aac] Adaptec SCSI 2130S aac0: GetDeviceProbeInfo comm o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/93128 scsi [sym] FreeBSD 6.1 BETA 1 has problems with Symbios/LSI o kern/94838 scsi Kernel panic while mounting SD card with lock switch o o kern/99954 scsi [ahc] reading from DVD failes on 6.x (regression) 15 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/23314 scsi aic driver fails to detect Adaptec 1520B unless PnP is o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce o kern/38828 scsi [feature request] DPT PM2012B/90 doesn't work o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/96133 scsi [scsi] [patch] add scsi quirk for joyfly 128mb flash u o kern/103702 scsi [cam] [patch] ChipsBnk: Unsupported USB memory stick 7 problems total. From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 15:46:46 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8F4D416A401 for ; Mon, 26 Feb 2007 15:46:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4AA2B13C4A6 for ; Mon, 26 Feb 2007 15:46:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1QFhYew019082; Mon, 26 Feb 2007 08:43:35 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 26 Feb 2007 08:43:37 -0700 (MST) Message-Id: <20070226.084337.-399281611.imp@bsdimp.com> To: lydianconcepts@gmail.com From: "M. Warner Losh" In-Reply-To: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> References: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 26 Feb 2007 08:43:35 -0700 (MST) Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 15:46:46 -0000 In message: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> "Matthew Jacob" writes: : > : > I took a look at Linux, and they have a quirk for this. A bunch of : > cameras have this bug, as do iPods and a few media readers... : > : : So, is your take then we should have a "subtract by N" read capacity quirk? I think so. Since I need it, I'll work up a patch for the group to review. Warner From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 16:05:17 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 33CB016A409 for ; Mon, 26 Feb 2007 16:05:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id DEEC913C478 for ; Mon, 26 Feb 2007 16:05:16 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1QG58gD019339; Mon, 26 Feb 2007 09:05:14 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E3052E.7040506@samsco.org> Date: Mon, 26 Feb 2007 09:05:02 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: "M. Warner Losh" References: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <20070226.084337.-399281611.imp@bsdimp.com> In-Reply-To: <20070226.084337.-399281611.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 26 Feb 2007 09:05:14 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 16:05:17 -0000 M. Warner Losh wrote: > In message: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> > "Matthew Jacob" writes: > : > > : > I took a look at Linux, and they have a quirk for this. A bunch of > : > cameras have this bug, as do iPods and a few media readers... > : > > : > : So, is your take then we should have a "subtract by N" read capacity quirk? > > I think so. Since I need it, I'll work up a patch for the group to > review. > > Warner Was my email on this lost? Scott From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 16:16:39 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 46C3D16A401 for ; Mon, 26 Feb 2007 16:16:39 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E6CD913C47E for ; Mon, 26 Feb 2007 16:16:38 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1QGFGoK034458; Mon, 26 Feb 2007 09:15:16 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 26 Feb 2007 09:15:19 -0700 (MST) Message-Id: <20070226.091519.-1303465881.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <45E29EF9.3030306@samsco.org> References: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <45E29EF9.3030306@samsco.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 26 Feb 2007 09:15:17 -0700 (MST) Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 16:16:39 -0000 In message: <45E29EF9.3030306@samsco.org> Scott Long writes: : M. Warner Losh wrote: : > In message: <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> : > "Matthew Jacob" writes: : > : > The question is: Given that I know that the first USB/CF adapter : > : > always reports one too big, is there a way this can be fixed? : > : : > : There are two problems here that I see: : > : : > : a) The GEOM taste code cannot be overridden. : > : : > : b) How do we accomodate/detect broken h/w? : > : : > : I'm inclined to think that GEOM stuff cannot/should not be "fixed". : > : The second question is the harder one. : > : : > : You personally can fix this for yourself by doing your own specialized : > : quirk matching and just adjusting the READ CAPACITY results : > : accordingly. We have to ask whether this particular breakage is both : > : widespread enough and the devices important enough to try and : > : generalize some solution for. : > : > I took a look at Linux, and they have a quirk for this. A bunch of : > cameras have this bug, as do iPods and a few media readers... : > : > Warner : : So is it an off-by-one issue for all of these devices, or do we need to : have a mechanism for encoding a variable fudge factor? Strictly off-by-one. The capacity reported is the number of sectors, not the highest sector number. At least that's the Linux quirk. : Secondly, is it : only a problem with USB devices? As far as I know yes. This problem happens when the usb to mass storage device bridge chip does something wrong. This isn't a problem in the actual mass storage device. : Third, do we want only the : READ_CAPACITY that is done during probe+attach to be fudged, or do we : want to intercept every READ_CAPACITY attempt from every source and : fudge them all? I suspect all of them. I've been reading umass sources, and it looks like we're already dealing with some READ_CAPACITY issues in umass_cam_sense_cb: } else if ((sc->quirks & RS_NO_CLEAR_UA) && (csio->cdb_io.cdb_bytes[0] == READ_CAPACITY) && ((csio->sense_data.flags & SSD_KEY) == SSD_KEY_UNIT_ATTENTION)) { /* * Some devices do not clear the unit attention error * on request sense. We insert a test unit ready * command to make sure we clear the unit attention * condition, then allow the retry to proceed as * usual. */ It looks like there are two other callbacks (umass_cam_cb and umass_cam_quirk_cb). Judging from the comments, I can ignore umass_cam_quirk_cb. I'm guessing the 'Third' question would translate to 'do we have to do it both places, or just in the umass_cam_sense_cb?' To be honest, I'm unsure. Lemme play around with my device that does this and I'll get back to you. I might be able to snag my step-son's ipod nano as well to see if it really does what the linux driver says or not. This could also be autoprobed if you don't mind the usual cam error message on failed transfer, since I know everybody's love for quirks and quirk tables. Now that I think about it, this may have been what Matthew was getting at earlier in this thread. Warner From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 16:22:16 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 418F116A401 for ; Mon, 26 Feb 2007 16:22:16 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 0400913C4AC for ; Mon, 26 Feb 2007 16:22:15 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1QGM8G3019452; Mon, 26 Feb 2007 09:22:13 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E3092A.5040404@samsco.org> Date: Mon, 26 Feb 2007 09:22:02 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Matthew Jacob References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> In-Reply-To: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 26 Feb 2007 09:22:13 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: "M. Warner Losh" , scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 16:22:16 -0000 Matthew Jacob wrote: >> >> I took a look at Linux, and they have a quirk for this. A bunch of >> cameras have this bug, as do iPods and a few media readers... >> > > So, is your take then we should have a "subtract by N" read capacity quirk? If it's just a USB property, I'd like to avoid adding a quirk to the CAM core, especially one that requires multiple arguments. Scott From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 16:35:21 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0748A16A401 for ; Mon, 26 Feb 2007 16:35:21 +0000 (UTC) (envelope-from bartsch@dssgmbh.de) Received: from mail.incore.de (dss.incore.de [195.145.1.138]) by mx1.freebsd.org (Postfix) with ESMTP id B87DB13C478 for ; Mon, 26 Feb 2007 16:35:16 +0000 (UTC) (envelope-from bartsch@dssgmbh.de) Received: from localhost (inetmail.dmz [10.3.0.3]) by mail.incore.de (Postfix) with ESMTP id D384A4C304 for ; Mon, 26 Feb 2007 17:35:14 +0100 (CET) X-Virus-Scanned: amavisd-new at incore.de Received: from mail.incore.de ([10.3.0.3]) by localhost (inetmail.dmz [10.3.0.3]) (amavisd-new, port 10024) with LMTP id pxK+kTDWLQzM for ; Mon, 26 Feb 2007 17:35:08 +0100 (CET) Received: from mail.incore (fwintern.dmz [10.0.0.253]) by mail.incore.de (Postfix) with ESMTP id ACBFB4C29B for ; Mon, 26 Feb 2007 17:35:08 +0100 (CET) Received: from pcbart (pcbart.incore [192.168.0.57]) by mail.incore (Postfix) with ESMTP id A4BDB5C028 for ; Mon, 26 Feb 2007 17:35:08 +0100 (CET) From: Alfred Bartsch Organization: Data-Service GmbH To: freebsd-scsi@freebsd.org Date: Mon, 26 Feb 2007 17:35:07 +0100 User-Agent: KMail/1.9.1 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702261735.07783.bartsch@dssgmbh.de> Subject: Re: unable to create/delete array from LSI card using megaraid, megarc X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 16:35:21 -0000 Am Samstag, 10. Februar 2007 00:04 schrieb javocado: > I'm running 6.2-R and have installed linux-megamgr and megarc from > ports. Both utilities run fine, but neither will allow me to add or > remove an array from the system (I have to do it via the BIOS > utility). Relevant parts: > > # dmesg |grep amr > amr0: mem 0xdf200000-0xdf20ffff irq 72 at > device 1.0 on pci8 > amr0: delete logical drives supported by controller > amr0: Firmware 1L47, BIOS G121, 64MB RAM > amr0: delete logical drives supported by controller > amrd0: on amr0 > amrd0: 70006MB (143372288 sectors) RAID 1 (optimal) > amrd1: on amr0 > amrd1: 140013MB (286746624 sectors) RAID 1 (optimal) > > Is this normal, or do I have a misconfiguration? > -- This is IMHO some kind of accident control, try "# sysctl dev.amr.0.allow_volume_configure=1" before starting megarc/linux-megamgr. This should enable changes to the RAID configuration (replace 0 with 1 ... if you've got more than one MegaRAID-Controller in your server). HTH Alfred Bartsch mailto: From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 18:41:48 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0967B16A402 for ; Mon, 26 Feb 2007 18:41:48 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.230]) by mx1.freebsd.org (Postfix) with ESMTP id AAE2E13C47E for ; Mon, 26 Feb 2007 18:41:47 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: by wr-out-0506.google.com with SMTP id 71so278474wri for ; Mon, 26 Feb 2007 10:41:40 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sMBe8tTTNJhHxP+/UGlK63TTRGMUgp6w3YGTGFLAMhfdwa6j5r/Xq8y3LrhYaskXgGjQKOe6qGskTriFBYsN7txa/Kmy14HUliyRYBwbZzLjUjCzukFUkuXkd0TI+QmrlW0rCTe3aMNJBYH8O59UcekPgUGeelVXHJ0lrgWk8wU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YvZJ7yssawsGrUCmmZe8gV7TjiAJ4I5IXIViDAvYt88Uhx6Mfy+UgfOHqY18K1AQYFPz0sKoOQGJSNugZIeXFRy/ix4M7cIEN840daivXgflH9IyORJEmoe3HFE9Crp5817ZQGg8xcXTAV/YtvQ/JeAjgZ/VfMzMg8jGAP6QvRg= Received: by 10.114.205.1 with SMTP id c1mr103682wag.1172515299347; Mon, 26 Feb 2007 10:41:39 -0800 (PST) Received: by 10.114.25.18 with HTTP; Mon, 26 Feb 2007 10:41:37 -0800 (PST) Message-ID: <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> Date: Mon, 26 Feb 2007 10:41:37 -0800 From: "Matthew Jacob" To: "Scott Long" In-Reply-To: <45E3092A.5040404@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> Cc: "M. Warner Losh" , scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 18:41:48 -0000 It may be a property specific to USB devices, but the code affected is a property of the end target at the end of a transport, not the transport itself. On 2/26/07, Scott Long wrote: > Matthew Jacob wrote: > >> > >> I took a look at Linux, and they have a quirk for this. A bunch of > >> cameras have this bug, as do iPods and a few media readers... > >> > > > > So, is your take then we should have a "subtract by N" read capacity quirk? > > If it's just a USB property, I'd like to avoid adding a quirk to the CAM > core, especially one that requires multiple arguments. > > Scott > > From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 20:40:27 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3E9DC16A403 for ; Mon, 26 Feb 2007 20:40:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D9E8713C48D for ; Mon, 26 Feb 2007 20:40:26 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1QKbeOQ063932; Mon, 26 Feb 2007 13:37:40 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 26 Feb 2007 13:37:39 -0700 (MST) Message-Id: <20070226.133739.74686216.imp@bsdimp.com> To: lydianconcepts@gmail.com From: Warner Losh In-Reply-To: <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> References: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 26 Feb 2007 13:37:41 -0700 (MST) Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 20:40:27 -0000 > It may be a property specific to USB devices, but the code affected is > a property of the end target at the end of a transport, not the > transport itself. The transport already does so much futzing with the scsi request/replies that go down to the device that one more wouldn't be so horrible and would confine this brain-damage to the devices that have it... Warner From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 21:04:25 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 46DA216A400 for ; Mon, 26 Feb 2007 21:04:25 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.230]) by mx1.freebsd.org (Postfix) with ESMTP id 0218513C442 for ; Mon, 26 Feb 2007 21:04:24 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: by wr-out-0506.google.com with SMTP id 71so337996wri for ; Mon, 26 Feb 2007 13:04:24 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tGG1oqsKQQPolYQlom4rfqbk9ANp+0X2lRQQrESu265U5w05mL2+cUgsx7YYqpA8CS9/Fqvwm9XtrC8l0VwI8ZD7NDMlmoJAgNe58GrJfLM+3RIvAv56K8FHT0aVf5ZHI1WksJ8peyeriz+sL0x+8qa7aH8cZQJJs7SBjTgpX9E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=o3IYNRuuYMpysyA3/hE/RGIjXqgO3nsIPzSZWBd+J/nFKYqEzHPx3Xp4/kM1KGUuSL6daSe71kUI9gbhk44HBrbNfO+CRqVo9a8I4tyXuq/8h+zyDYQBBc5Z1hTxOD0AbSkRzI02G8DKrS1wKNNUIM7e19z1uQz8duXjTx9Aomk= Received: by 10.114.126.1 with SMTP id y1mr16980wac.1172523863274; Mon, 26 Feb 2007 13:04:23 -0800 (PST) Received: by 10.114.25.18 with HTTP; Mon, 26 Feb 2007 13:04:23 -0800 (PST) Message-ID: <7579f7fb0702261304yd52d46dy81e3ac30e02807b5@mail.gmail.com> Date: Mon, 26 Feb 2007 13:04:23 -0800 From: "Matthew Jacob" To: "Warner Losh" In-Reply-To: <20070226.133739.74686216.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> <20070226.133739.74686216.imp@bsdimp.com> Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 21:04:25 -0000 Oh, agreed. But rather than wander off into the umass code, thus spreading quirks around hither and yon, would it make sense to just do this in da which allows you to check transport type (now at least, for CAM_NEWTRAN). And this means, btw, that I don't believe it's necessary to fix all instantiations of READ CAPACITY (so that camcontrol(8) works). BTW- now that I think about it, I think that the 'taste' stuff that GEOM does with disk devices (reading the last sector) actually wouldn't work with tradtional MagnetoOptical devices anyway- you cannot read unrecorded media in this case- so GEOM might have to be dealt with at some point anyway. On 2/26/07, Warner Losh wrote: > > It may be a property specific to USB devices, but the code affected is > > a property of the end target at the end of a transport, not the > > transport itself. > > The transport already does so much futzing with the scsi > request/replies that go down to the device that one more wouldn't be > so horrible and would confine this brain-damage to the devices that > have it... > > Warner > From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 21:38:03 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C30216A408 for ; Mon, 26 Feb 2007 21:38:03 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 3401813C48E for ; Mon, 26 Feb 2007 21:38:02 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1QLbprd022278; Mon, 26 Feb 2007 14:37:56 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E35328.7040700@samsco.org> Date: Mon, 26 Feb 2007 14:37:44 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Warner Losh References: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> <20070226.133739.74686216.imp@bsdimp.com> In-Reply-To: <20070226.133739.74686216.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 26 Feb 2007 14:37:56 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 21:38:03 -0000 Warner Losh wrote: >> It may be a property specific to USB devices, but the code affected is >> a property of the end target at the end of a transport, not the >> transport itself. > > The transport already does so much futzing with the scsi > request/replies that go down to the device that one more wouldn't be > so horrible and would confine this brain-damage to the devices that > have it... > > Warner Strongly agreed. If the fudging only needed to happen at the READ_CAPACITY that is done for device creation in GEOM then having it be in the da driver would be appropriate. But since it needs to happen for all READ_CAPACITY requests, it's much better to have it isolated in the umass driver. Scott From owner-freebsd-scsi@FreeBSD.ORG Mon Feb 26 21:40:58 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B3CFC16A403 for ; Mon, 26 Feb 2007 21:40:58 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 680D713C4A6 for ; Mon, 26 Feb 2007 21:40:58 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1QLeoH8022294; Mon, 26 Feb 2007 14:40:56 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E353DC.10500@samsco.org> Date: Mon, 26 Feb 2007 14:40:44 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Matthew Jacob References: <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> <20070226.133739.74686216.imp@bsdimp.com> <7579f7fb0702261304yd52d46dy81e3ac30e02807b5@mail.gmail.com> In-Reply-To: <7579f7fb0702261304yd52d46dy81e3ac30e02807b5@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 26 Feb 2007 14:40:56 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: Warner Losh , scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2007 21:40:58 -0000 Matthew Jacob wrote: > Oh, agreed. But rather than wander off into the umass code, thus > spreading quirks around hither and yon, would it make sense to just do > this in da which allows you to check transport type (now at least, for > CAM_NEWTRAN). > > And this means, btw, that I don't believe it's necessary to fix all > instantiations of READ CAPACITY (so that camcontrol(8) works). > If you do the processing in the umass driver then camcontrol still works. What I'm talking about, and I believe that Warner is agreeing with, is sniffing the completion of all CDB's to see which ones are READ_CAPACITY responses, and then fudging the data before calling xpt_done(). > > BTW- now that I think about it, I think that the 'taste' stuff that > GEOM does with disk devices (reading the last sector) actually > wouldn't work with tradtional MagnetoOptical devices anyway- you > cannot read unrecorded media in this case- so GEOM might have to be > dealt with at some point anyway. > It would require similar handling as the CD driver, where the capacity can essentially change during a burning session. Scott From owner-freebsd-scsi@FreeBSD.ORG Tue Feb 27 00:26:38 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 80E7916A409 for ; Tue, 27 Feb 2007 00:26:38 +0000 (UTC) (envelope-from thomas@melamine.cuivre.fr.eu.org) Received: from melamine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [82.225.155.84]) by mx1.freebsd.org (Postfix) with ESMTP id 464DC13C4A7 for ; Tue, 27 Feb 2007 00:26:34 +0000 (UTC) (envelope-from thomas@melamine.cuivre.fr.eu.org) Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000) id 7C66E5C1A1; Tue, 27 Feb 2007 00:55:28 +0100 (CET) Resent-From: thomas@melamine.cuivre.fr.eu.org Resent-Date: Tue, 27 Feb 2007 00:55:28 +0100 Resent-Message-ID: <20070226235528.GA71839@melamine.cuivre.fr.eu.org> Resent-To: freebsd-scsi@freebsd.org Date: Sun, 25 Feb 2007 20:38:02 +0100 From: Thomas Quinot To: freebsd-scsi@freebsd.org Message-ID: <20070225193802.GA32605@melamine.cuivre.fr.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-message-flag: WARNING! Using Outlook can damage your computer. User-Agent: Mutt/1.5.11 Subject: xpt_done() and Giant? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 00:26:38 -0000 I'm currently trying to debug ATAPI/CAM issues with a particular ATA controller (kern/103602). Over the course of investigating this PR, the user reported the following crash when enabling CAMDEBUG: Tracing pid 16 tid 100014 td 0xc5106bd0 kdb_enter(c0a48ff7,0,c0a482f1,e3cbaba8,c5106bd0,...) at kdb_enter+0x30 panic(c0a482f1,c0a60666,c0a004cc,1033,c560c430,...) at panic+0x13b _mtx_assert(c0b4caa8,1,c0a004cc,1033,c5610000,...) at _mtx_assert+0x86 xpt_path_comp(c5410660,c560c430,c5462c40,c55e3e60,c5610000,...) at xpt_path_comp+0x32 xpt_done(c5610000,c546ae3c,c55e2b64,e3cbac3c,c55e2398,...) at xpt_done+0x30 free_hcb_and_ccb_done(c546ae3c,0,c55e2b64,2d2,1,...) at free_hcb_and_ccb_done+0x3c atapi_cb(c5486480,52,c0a4cb11,e3cbac74,c0748b94,...) at atapi_cb+0x78 ata_completed(c5486480,1,c0a4cb11,52,c5173b1c,...) at ata_completed+0x5c2 It looks to me like we're calling xpt_done() without holding Giant, which should work AFAICT, except that when enabling CAMDEBUG, xpt_done calls xpt_path_comp, which still has a GIANT_REQUIRED assertion, hence the failure above. So, should we maybe grab Giant in CAM_DEBUG? Thomas. From owner-freebsd-scsi@FreeBSD.ORG Tue Feb 27 14:48:57 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 63FB416A405 for ; Tue, 27 Feb 2007 14:48:57 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id EF1FD13C4A5 for ; Tue, 27 Feb 2007 14:48:56 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1REmkhS041153; Tue, 27 Feb 2007 07:48:51 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E444C6.40607@samsco.org> Date: Tue, 27 Feb 2007 07:48:38 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Matthew Jacob References: <45DE6C64.8020400@samsco.org> <20070223.100839.112608684.imp@bsdimp.com> <7579f7fb0702231017rdc246ebqeface91c9d5481e3@mail.gmail.com> <20070225.230019.1649768891.imp@bsdimp.com> <7579f7fb0702252331m7d3a61c5u224d898b4f04248c@mail.gmail.com> <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> In-Reply-To: <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Tue, 27 Feb 2007 07:48:52 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: "M. Warner Losh" , scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 14:48:57 -0000 I understand what you're saying. If you look in the umass driver, there is already a mechanism for quirks as well as a fairly large collection of quirks for bad SCSI protocol behavior from devices. These should all move up to CAM, I agree. However, what exists in CAM right now for XPORT-specific support is just a series of 'if' statements scattered around cam_xpt.c. If you moved Warner's quirk up as well as the other umass quirks, you're going to quickly make a royal mess out of cam_xpt.c. That's what I want to avoid. Once we figure out exactly what we want out of the XPORT code and get it a little more defined and organized, I think we can then start moving the quirks out of the umass driver. Until then, solving Warner's problem via umass.c is easy and doesn't complicate the end goal much at all. Scott Matthew Jacob wrote: > It may be a property specific to USB devices, but the code affected is > a property of the end target at the end of a transport, not the > transport itself. > > On 2/26/07, Scott Long wrote: >> Matthew Jacob wrote: >> >> >> >> I took a look at Linux, and they have a quirk for this. A bunch of >> >> cameras have this bug, as do iPods and a few media readers... >> >> >> > >> > So, is your take then we should have a "subtract by N" read capacity >> quirk? >> >> If it's just a USB property, I'd like to avoid adding a quirk to the CAM >> core, especially one that requires multiple arguments. >> >> Scott >> >> From owner-freebsd-scsi@FreeBSD.ORG Tue Feb 27 17:43:41 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1ED9516A40D for ; Tue, 27 Feb 2007 17:43:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B4A1113C4B2 for ; Tue, 27 Feb 2007 17:43:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1RHfaAe078136; Tue, 27 Feb 2007 10:41:37 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 27 Feb 2007 10:41:36 -0700 (MST) Message-Id: <20070227.104136.112559861.imp@bsdimp.com> To: scottl@samsco.org From: Warner Losh In-Reply-To: <45E444C6.40607@samsco.org> References: <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> <45E444C6.40607@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Tue, 27 Feb 2007 10:41:37 -0700 (MST) Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 17:43:41 -0000 > I understand what you're saying. If you look in the umass driver, there > is already a mechanism for quirks as well as a fairly large collection > of quirks for bad SCSI protocol behavior from devices. These should all > move up to CAM, I agree. However, what exists in CAM right now for > XPORT-specific support is just a series of 'if' statements scattered > around cam_xpt.c. If you moved Warner's quirk up as well as the other > umass quirks, you're going to quickly make a royal mess out of > cam_xpt.c. That's what I want to avoid. Once we figure out exactly > what we want out of the XPORT code and get it a little more defined and > organized, I think we can then start moving the quirks out of the umass > driver. Until then, solving Warner's problem via umass.c is easy and > doesn't complicate the end goal much at all. I would think that the quriks in the umass driver would be communicated in a transport neutral way to cam_xpt.c and friends. ANY transport could set ANY quirk and the code would just cope. No need for the xpt layer to peer into the transport at all (or is that the 'sim' in CAMese). For the moment, hacking umass is easiest and when the more generic mechanism comes along, the minor hack that I'm putting in wouldn't be burdonsome. Warner > Scott > > > Matthew Jacob wrote: > > It may be a property specific to USB devices, but the code affected is > > a property of the end target at the end of a transport, not the > > transport itself. > > > > On 2/26/07, Scott Long wrote: > >> Matthew Jacob wrote: > >> >> > >> >> I took a look at Linux, and they have a quirk for this. A bunch of > >> >> cameras have this bug, as do iPods and a few media readers... > >> >> > >> > > >> > So, is your take then we should have a "subtract by N" read capacity > >> quirk? > >> > >> If it's just a USB property, I'd like to avoid adding a quirk to the CAM > >> core, especially one that requires multiple arguments. > >> > >> Scott > >> > >> > > From owner-freebsd-scsi@FreeBSD.ORG Tue Feb 27 17:48:44 2007 Return-Path: X-Original-To: scsi@freebsd.org Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B1AC516A403 for ; Tue, 27 Feb 2007 17:48:44 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 686E013C442 for ; Tue, 27 Feb 2007 17:48:44 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1RHmaqt042514; Tue, 27 Feb 2007 10:48:42 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E46EEC.2010907@samsco.org> Date: Tue, 27 Feb 2007 10:48:28 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Warner Losh References: <45E3092A.5040404@samsco.org> <7579f7fb0702261041ld6f4a09q732bbbc419cf1c73@mail.gmail.com> <45E444C6.40607@samsco.org> <20070227.104136.112559861.imp@bsdimp.com> In-Reply-To: <20070227.104136.112559861.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Tue, 27 Feb 2007 10:48:42 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: scsi@freebsd.org Subject: Re: Quirk for this? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 17:48:44 -0000 Warner Losh wrote: >> I understand what you're saying. If you look in the umass driver, there >> is already a mechanism for quirks as well as a fairly large collection >> of quirks for bad SCSI protocol behavior from devices. These should all >> move up to CAM, I agree. However, what exists in CAM right now for >> XPORT-specific support is just a series of 'if' statements scattered >> around cam_xpt.c. If you moved Warner's quirk up as well as the other >> umass quirks, you're going to quickly make a royal mess out of >> cam_xpt.c. That's what I want to avoid. Once we figure out exactly >> what we want out of the XPORT code and get it a little more defined and >> organized, I think we can then start moving the quirks out of the umass >> driver. Until then, solving Warner's problem via umass.c is easy and >> doesn't complicate the end goal much at all. > > I would think that the quriks in the umass driver would be > communicated in a transport neutral way to cam_xpt.c and friends. ANY > transport could set ANY quirk and the code would just cope. No need > for the xpt layer to peer into the transport at all (or is that the > 'sim' in CAMese). > This is what I had in mind. Where the quirks come from is fairly arbitrary, but the code to execute the quirks will someday live in the XPT or periph drivers, not the SIM. > For the moment, hacking umass is easiest and when the more generic > mechanism comes along, the minor hack that I'm putting in wouldn't be > burdonsome. Yes, and consistent with how it's done now. Scott From owner-freebsd-scsi@FreeBSD.ORG Wed Feb 28 21:42:25 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39FC416A402 for ; Wed, 28 Feb 2007 21:42:25 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id E793913C4A7 for ; Wed, 28 Feb 2007 21:42:24 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l1SLgIwH052309; Wed, 28 Feb 2007 14:42:23 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E5F730.5070900@samsco.org> Date: Wed, 28 Feb 2007 14:42:08 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Thomas Quinot References: <20070225193802.GA32605@melamine.cuivre.fr.eu.org> In-Reply-To: <20070225193802.GA32605@melamine.cuivre.fr.eu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Wed, 28 Feb 2007 14:42:23 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-scsi@freebsd.org Subject: Re: xpt_done() and Giant? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2007 21:42:25 -0000 Thomas Quinot wrote: > I'm currently trying to debug ATAPI/CAM issues with a particular ATA > controller (kern/103602). Over the course of investigating this PR, > the user reported the following crash when enabling CAMDEBUG: > > Tracing pid 16 tid 100014 td 0xc5106bd0 > > kdb_enter(c0a48ff7,0,c0a482f1,e3cbaba8,c5106bd0,...) at kdb_enter+0x30 > panic(c0a482f1,c0a60666,c0a004cc,1033,c560c430,...) at panic+0x13b > _mtx_assert(c0b4caa8,1,c0a004cc,1033,c5610000,...) at _mtx_assert+0x86 > xpt_path_comp(c5410660,c560c430,c5462c40,c55e3e60,c5610000,...) at xpt_path_comp+0x32 > xpt_done(c5610000,c546ae3c,c55e2b64,e3cbac3c,c55e2398,...) at xpt_done+0x30 > free_hcb_and_ccb_done(c546ae3c,0,c55e2b64,2d2,1,...) at free_hcb_and_ccb_done+0x3c > atapi_cb(c5486480,52,c0a4cb11,e3cbac74,c0748b94,...) at atapi_cb+0x78 > ata_completed(c5486480,1,c0a4cb11,52,c5173b1c,...) at > ata_completed+0x5c2 > > It looks to me like we're calling xpt_done() without holding Giant, > which should work AFAICT, except that when enabling CAMDEBUG, xpt_done > calls xpt_path_comp, which still has a GIANT_REQUIRED assertion, hence > the failure above. > > So, should we maybe grab Giant in CAM_DEBUG? > > Thomas. > I overlooked this, sorry. Can you survive with it as it is for now? Scott From owner-freebsd-scsi@FreeBSD.ORG Wed Feb 28 23:24:00 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2156516A405 for ; Wed, 28 Feb 2007 23:24:00 +0000 (UTC) (envelope-from thomas@FreeBSD.ORG) Received: from melamine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [82.225.155.84]) by mx1.freebsd.org (Postfix) with ESMTP id DF3A613C49D for ; Wed, 28 Feb 2007 23:23:59 +0000 (UTC) (envelope-from thomas@FreeBSD.ORG) Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000) id 4C04F5C147; Thu, 1 Mar 2007 00:03:39 +0100 (CET) Date: Thu, 1 Mar 2007 00:03:39 +0100 From: Thomas Quinot To: Scott Long Message-ID: <20070228230339.GA77452@melamine.cuivre.fr.eu.org> References: <20070225193802.GA32605@melamine.cuivre.fr.eu.org> <45E5F730.5070900@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45E5F730.5070900@samsco.org> X-message-flag: WARNING! Using Outlook can damage your computer. User-Agent: Mutt/1.5.11 Cc: freebsd-scsi@freebsd.org Subject: Re: xpt_done() and Giant? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2007 23:24:00 -0000 * Scott Long, 2007-02-28 : > I overlooked this, sorry. Can you survive with it as it is for now? Well, the current situation has been current for quite some time, so I think I can survive it :-) On the other hand, the ATAPI/CAM interrupt routine runs outside of Giant and calls xpt_done (and also calls CAM_DEBUGGED itself), and it would be nice if CAMDEBUG worked with it. Is there any compelling reason for having GIANT_REQUIRED in xpt_path_comp? The only case I can see this as useful is when called in the context of CAM_DEBUG or CAM_DEBUGGED, to protect against a concurrent update of cam_dpath, but this really looks to me like a really tiny corner case. Thomas. From owner-freebsd-scsi@FreeBSD.ORG Thu Mar 1 17:27:36 2007 Return-Path: X-Original-To: freebsd-scsi@FreeBSD.ORG Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 06B3216A401; Thu, 1 Mar 2007 17:27:36 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id AFC5613C481; Thu, 1 Mar 2007 17:27:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from scott-longs-computer.local (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l21HRTmo057347; Thu, 1 Mar 2007 10:27:34 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E70CF5.10500@samsco.org> Date: Thu, 01 Mar 2007 10:27:17 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: Thomas Quinot References: <20070225193802.GA32605@melamine.cuivre.fr.eu.org> <45E5F730.5070900@samsco.org> <20070228230339.GA77452@melamine.cuivre.fr.eu.org> In-Reply-To: <20070228230339.GA77452@melamine.cuivre.fr.eu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 01 Mar 2007 10:27:34 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-scsi@FreeBSD.ORG Subject: Re: xpt_done() and Giant? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2007 17:27:36 -0000 Thomas Quinot wrote: > * Scott Long, 2007-02-28 : > >> I overlooked this, sorry. Can you survive with it as it is for now? > > Well, the current situation has been current for quite some time, so I > think I can survive it :-) > > On the other hand, the ATAPI/CAM interrupt routine runs outside of Giant > and calls xpt_done (and also calls CAM_DEBUGGED itself), and it would be > nice if CAMDEBUG worked with it. Is there any compelling reason for > having GIANT_REQUIRED in xpt_path_comp? The only case I can see this as > useful is when called in the context of CAM_DEBUG or CAM_DEBUGGED, to > protect against a concurrent update of cam_dpath, but this really looks > to me like a really tiny corner case. > > Thomas. > Full locking will be going into CAM soon, making this moot. Scott From owner-freebsd-scsi@FreeBSD.ORG Thu Mar 1 23:44:54 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E13D116A401 for ; Thu, 1 Mar 2007 23:44:54 +0000 (UTC) (envelope-from tommarnk@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.185]) by mx1.freebsd.org (Postfix) with ESMTP id 2CE8413C48D for ; Thu, 1 Mar 2007 23:44:54 +0000 (UTC) (envelope-from tommarnk@gmail.com) Received: by nf-out-0910.google.com with SMTP id k27so1018147nfc for ; Thu, 01 Mar 2007 15:44:52 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=Yaxy8O4KybAiBAw4Q5qYdazEDUKkHBBSFBFrHrEgn9T3Oy//mMLZOsYAq+folnN31I2V0dWZpNqQGgAoe5goEIMUlI9Hlj+7cZXf5oe3K4zG2FfyQZjyEC7hN/M6pdsH7J6F+4E+SA+5r06S1m/SQF8E9YuO2QPtnKa9vV1BFE8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=uAeo8jz+3nHuq5qwlVqypUfHuClPPICEIzJ+qOEz5q5NYt2q9uAn3oq58SPhmqUz5yO+0/p/ygFG8mLhGEf9pqdwo/v7nx8aJoYop8Pboml7jDxg2+gw2mkBprP+KtmzYzGitjQaZ8QLRUXqT35mBY1bp9O0y28JVbazKjpbPJA= Received: by 10.49.36.6 with SMTP id o6mr6767783nfj.1172791233656; Thu, 01 Mar 2007 15:20:33 -0800 (PST) Received: by 10.48.162.8 with HTTP; Thu, 1 Mar 2007 15:20:33 -0800 (PST) Message-ID: <67ce2c3a0703011520w7ca06735sfa44edb64777a250@mail.gmail.com> Date: Fri, 2 Mar 2007 00:20:33 +0100 From: wiak To: freebsd-scsi@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: FreeBSD 6.2 & 7.0 can't find & mount NEC AD-7170S SATA DVD-RW X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2007 23:44:55 -0000 FreeBSD 6.2/7.0 can't find & mount NEC AD-7170S SATA DVD+-RW it boots FreeBSD right up to media > CD/DVD in sysinstall and fails to mount *System* Abit AT8 (ATI RD480+ULI 1575) AMD Athlon 64 X2 3800+ OCZ EL DDR PC-4000 Gold GX XTC 2GB Dual Channel PowerColor Radeon X1800 XT 512MB 1x WDC Raptor 74GB 10,000RPM, 16MB, NCQ, SATA 1.5Gp/s 2x Seagate Barracuda 7200.10 320GB, 7200RPM, 16MB, NCQ, SATA 3Gp/s NEC AD-7170S SATA DVD+-RW (Sony-NEC Optiarc) BenQ FP937s+ (8ms) Realtek ALC882D (Dolby Digital Live) Hiper Type-R 580W From owner-freebsd-scsi@FreeBSD.ORG Fri Mar 2 00:09:54 2007 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A48EA16A400 for ; Fri, 2 Mar 2007 00:09:54 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 5C7FE13C48E for ; Fri, 2 Mar 2007 00:09:54 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l2209lL5059202; Thu, 1 Mar 2007 17:09:53 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E76B3E.1060103@samsco.org> Date: Thu, 01 Mar 2007 17:09:34 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: wiak References: <67ce2c3a0703011520w7ca06735sfa44edb64777a250@mail.gmail.com> In-Reply-To: <67ce2c3a0703011520w7ca06735sfa44edb64777a250@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 01 Mar 2007 17:09:53 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED, UPPERCASE_25_50 autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-scsi@freebsd.org Subject: Re: FreeBSD 6.2 & 7.0 can't find & mount NEC AD-7170S SATA DVD-RW X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2007 00:09:54 -0000 FreeBSD doesn't support SATA ATAPI at this time. Scott wiak wrote: > FreeBSD 6.2/7.0 can't find & mount NEC AD-7170S SATA DVD+-RW > it boots FreeBSD right up to media > CD/DVD in sysinstall and fails to > mount > > *System* > Abit AT8 (ATI RD480+ULI 1575) > AMD Athlon 64 X2 3800+ > OCZ EL DDR PC-4000 Gold GX XTC 2GB Dual Channel > PowerColor Radeon X1800 XT 512MB > 1x WDC Raptor 74GB 10,000RPM, 16MB, NCQ, SATA 1.5Gp/s > 2x Seagate Barracuda 7200.10 320GB, 7200RPM, 16MB, NCQ, SATA 3Gp/s > NEC AD-7170S SATA DVD+-RW (Sony-NEC Optiarc) > BenQ FP937s+ (8ms) > Realtek ALC882D (Dolby Digital Live) > Hiper Type-R 580W > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org"