From owner-freebsd-smp@FreeBSD.ORG Sun Apr 1 01:02:58 2007 Return-Path: X-Original-To: smp@freebsd.org Delivered-To: freebsd-smp@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4AA8E16A401 for ; Sun, 1 Apr 2007 01:02:58 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 080D913C46E for ; Sun, 1 Apr 2007 01:02:57 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by an-out-0708.google.com with SMTP id c24so879820ana for ; Sat, 31 Mar 2007 18:02:57 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=lYC4JoyTIICBxdHuNC9AniCHDwG3Os6ZW9jehBpzGQw+GVoiHGYASwqPuu08S7LAUJcgZxER4qIdmmLL06ZHmaY4PKkKu8f5xYx+IC/gszkwvF+/dCixOS9H6yA/eeRQHIgbmL5QFttxzZFiq0n1PQ41wh8YmTFxZYW3BMuseTE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ugnuCHNabW6+drqcCpswqf3xGSzvWUNjOnSadyXM8NPMTYtwE8RZV/f0baSwF6lUjzaLXV7J3PX64WW4lz1vJqAMjIPLKcVotLPoKcOl/4rs+TYS3lr459b8sBYxgwTaDnRnZWyCQPqjOgWJ8Q6RJL4vs2sNZN0LG86YsWLpR84= Received: by 10.100.128.8 with SMTP id a8mr2556573and.1175387777509; Sat, 31 Mar 2007 17:36:17 -0700 (PDT) Received: by 10.100.191.1 with HTTP; Sat, 31 Mar 2007 17:36:17 -0700 (PDT) Message-ID: <3bbf2fe10703311736g6fd051a0w39bee9d750321b51@mail.gmail.com> Date: Sun, 1 Apr 2007 02:36:17 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Kris Kennaway" In-Reply-To: <20070331234602.GB77982@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703312323.l2VNNgPb006391@repoman.freebsd.org> <20070331234602.GB77982@xor.obsecurity.org> X-Google-Sender-Auth: b78d70ea61a9c953 Cc: smp@freebsd.org, current@freebsd.org Subject: Re: cvs commit: src/share/man/man9 Makefile sx.9 src/sys/conf NOTES options src/sys/dev/acpica acpi_ec.c src/sys/dev/mxge if_mxge.c src/sys/dev/usb if_aue.c if_axe.c src/sys/gnu/fs/xfs/FreeBSD/support mrlock.c mrlock.h ... X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2007 01:02:58 -0000 2007/4/1, Kris Kennaway : > eOn Sat, Mar 31, 2007 at 11:23:42PM +0000, John Baldwin wrote: > > jhb 2007-03-31 23:23:42 UTC > > > > FreeBSD src repository > > > > Modified files: > > share/man/man9 Makefile sx.9 > > sys/conf NOTES options > > sys/dev/acpica acpi_ec.c > > sys/dev/mxge if_mxge.c > > sys/dev/usb if_aue.c if_axe.c > > sys/gnu/fs/xfs/FreeBSD/support mrlock.c mrlock.h > > sys/i386/acpica acpi_machdep.c > > sys/kern kern_sx.c > > sys/netinet6 in6_src.c > > sys/sys sleepqueue.h sx.h > > Added files: > > sys/sys _sx.h > > Log: > > Optimize sx locks to use simple atomic operations for the common cases of > > obtaining and releasing shared and exclusive locks. The algorithms for > > manipulating the lock cookie are very similar to that rwlocks. This patch > > also adds support for exclusive locks using the same algorithm as mutexes. > > Thanks to Attilio for doing this work and to John for committing it. > This is a significant step forward for 7.0 and will be the basis for > some major performance optimizations to be committed in the near > future (e.g. filedesc locking from rwatson, which gives even better > mysql performance than the "tophalf" mutexes Jeff and I recently > benchmarked). Thanks a lot to you for the biggest effort you did in testing and benchmarking the patch and to pho@ who did first stability tests on the first revision of the patch. These credits should be however shared completely with John who did an excellent job of revision on the code and in particulary for the challenging discussions we had during the time of sx rewriting. I think I learned a lot by his incredible way of coding. Attilio -- Peace can only be achieved by understanding - A. Einstein