From owner-freebsd-smp@FreeBSD.ORG Sun Sep 2 01:04:23 2007 Return-Path: Delivered-To: smp@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8833416A420 for ; Sun, 2 Sep 2007 01:04:23 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 1705F13C45D for ; Sun, 2 Sep 2007 01:04:22 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id k4so919794nfd for ; Sat, 01 Sep 2007 18:04:02 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=SRHVFHocB91jR2ir+xc7vH901E4tRMfAOynpDu9TZvpTKA0mSV0fbIgP0RklUhJsHgCApZa/UfYYBaf19cCbdtcnWMxXrMumSzMey5MgHUS0uvjPNPJggWGzD4yWgKffu1LXn/lMLpIkutkxQksY/sHOyjNT7Q4q2gpli12teVM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ur8G+91ngnMew69I+yymB/FwaoX2cqNSSbRUmycv181SdXXmUxdTK64q5S4tFShkYBg1rz/f0l2gHbDqsT++p/K7VtpPAg/zRUtgo+9ue5CWQL8eItEldOiliagG9xRscO1PwoEUlny0nPufwIZTIE2IaXfT0YOJfdNoiFnYsM0= Received: by 10.78.170.17 with SMTP id s17mr2416081hue.1188695041644; Sat, 01 Sep 2007 18:04:01 -0700 (PDT) Received: by 10.78.97.18 with HTTP; Sat, 1 Sep 2007 18:04:01 -0700 (PDT) Message-ID: <3bbf2fe10709011804r71dbde02wcb50b4b319476940@mail.gmail.com> Date: Sun, 2 Sep 2007 03:04:01 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Alfred Perlstein" In-Reply-To: <20070831071048.GF87451@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070831071048.GF87451@elvis.mu.org> X-Google-Sender-Auth: cd65937bb9a1ffdb Cc: smp@freebsd.org Subject: Re: request for review: backport of sx and rwlocks from 7.0 to 6-stable X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2007 01:04:23 -0000 2007/8/31, Alfred Perlstein : > Hi guys, > > Some work here at work was approved for sharing with community so > I'm posting it here in hope of a review. > > We run some pretty good stress testing on our code, so I think it's > pretty solid. > > My only concern is that I've tried my best to preserve kernel source > API, but not binary compat though a few simple #defines. > > I can make binary compat, in albeit a somewhat confusing manner, but > that will require some rototilling and weird renaming of calls to > the sleepq and turnstile code. In short, I'd rather not, but I will > if you think it's something that should be done. > > There's also a few placeholders for lock profiling which I will > very likely be backporting shortly as well. > > Patch is attached. > > Comments/questions? Hello Alfred, I started looking at the patch and I have 2 things to say: - why you backported the allocating patch with UMA in sleepqueues? it is ortogonhal to this problem and it is not necessary due in this case I think - Instead than using the stub __aligned() for struct thread, you should use what we alredy do for 7.0 as dealing with uma allocation functions and a separate stub for thread0. you can workaround the missing of uma functions with a simple macro. I will try to give a line-by-line revision ASAP. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein