From owner-freebsd-stable@FreeBSD.ORG  Mon Apr 30 01:50:56 2007
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: freebsd-stable@FreeBSD.ORG
Delivered-To: freebsd-stable@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 727A816A400;
	Mon, 30 Apr 2007 01:50:56 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88])
	by mx1.freebsd.org (Postfix) with ESMTP id 189AD13C45D;
	Mon, 30 Apr 2007 01:50:55 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from [202.179.0.164] (helo=daemon.micom.mng.net)
	by publicd.ub.mng.net with esmtpa (Exim 4.63 (FreeBSD))
	(envelope-from <ganbold@micom.mng.net>)
	id 1HiL2P-0005DF-0S; Mon, 30 Apr 2007 10:50:49 +0900
Message-ID: <46354B78.5000909@micom.mng.net>
Date: Mon, 30 Apr 2007 09:50:48 +0800
From: Ganbold <ganbold@micom.mng.net>
User-Agent: Thunderbird 2.0.0.0 (X11/20070425)
MIME-Version: 1.0
To: Thomas Quinot <thomas@FreeBSD.ORG>
References: <20070427150134.64D3713C448@mx1.freebsd.org>
	<20070427153218.GA9091@melamine.cuivre.fr.eu.org>
	<20070427174922.GA5655@zone3000.net> <46324CCF.7040109@samsco.org>
	<20070427193119.GA95165@melamine.cuivre.fr.eu.org>
In-Reply-To: <20070427193119.GA95165@melamine.cuivre.fr.eu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-stable@FreeBSD.ORG, bug-followup@FreeBSD.ORG, linimon@FreeBSD.ORG,
	Nikolay Pavlov <quetzal@zone3000.net>, mjacob@FreeBSD.ORG
Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2007 01:50:56 -0000

Thomas Quinot wrote:
> * Scott Long, 2007-04-27 :
>
>   
>> Oh hell, I know exactly what the problem is!  The opcode for a
>> TEST_UNIT_READY is 0x00.  This is probably the command that is
>> generating the CHECK_CONDITION.  The test for saved_cmd is entirely
>> bogus.
>>     
>
> Hmmmm. Looks like a very plausible culprit. Good catch Scott!
> (I felt there had to be something wrong when I wrote that test,
> incidentally, precisely because of TEST_UNIT_READY).
>
> Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3,
> please let me know if it works for you.
>
> Thomas.
>
> Index: atapi-cam.c
> ===================================================================
> RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v
> retrieving revision 1.50
> diff -u -r1.50 atapi-cam.c
> --- atapi-cam.c	14 Mar 2007 01:59:00 -0000	1.50
> +++ atapi-cam.c	27 Apr 2007 19:26:09 -0000
> @@ -729,7 +743,7 @@
>  		 * issued a REQUEST SENSE automatically and that operation
>  		 * returned without error.
>  		 */
> -		if (request->u.atapi.saved_cmd != 0 && request->error == 0) {
> +		if (request->u.atapi.sense.key != 0 && request->error == 0) {
>  		    bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense));
>  		    csio->ccb_h.status |= CAM_AUTOSNS_VALID;
>  		}
>
>
>
>   

Scott, Thomas, thank you very much for the effort fixing this problem.
k3b starts fine with this patch.

Ganbold