From owner-freebsd-usb@FreeBSD.ORG  Sun Jul 29 18:10:39 2007
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5903916A417
	for <freebsd-usb@freebsd.org>; Sun, 29 Jul 2007 18:10:39 +0000 (UTC)
	(envelope-from cvs-src@yandex.ru)
Received: from smtp2.yandex.ru (smtp2.yandex.ru [213.180.200.18])
	by mx1.freebsd.org (Postfix) with ESMTP id 4AB3F13C45E
	for <freebsd-usb@freebsd.org>; Sun, 29 Jul 2007 18:10:38 +0000 (UTC)
	(envelope-from cvs-src@yandex.ru)
Received: from [193.138.150.10] ([193.138.150.10]:21703 "EHLO
	nx7400.local.domain" smtp-auth: "cvs-src" TLS-CIPHER: <none>
	TLS-PEER-CN1: <none>) by mail.yandex.ru with ESMTP id S4395365AbXG2RhI
	(ORCPT <rfc822;freebsd-usb@freebsd.org>);
	Sun, 29 Jul 2007 21:37:08 +0400
X-Comment: RFC 2476 MSA function at smtp2.yandex.ru logged sender identity as:
	cvs-src
Message-ID: <46AD07FE.30501@yandex.ru>
Date: Sun, 29 Jul 2007 21:34:54 +0000
From: "R.Mahmatkhanov" <cvs-src@yandex.ru>
User-Agent: Thunderbird 2.0.0.5 (X11/20070726)
MIME-Version: 1.0
To: freebsd-usb@freebsd.org
Content-Type: multipart/mixed; boundary="------------080200060305070905070102"
Subject: Missing newline in umodem.c
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: cvs-src@yandex.ru
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jul 2007 18:10:39 -0000

This is a multi-part message in MIME format.
--------------080200060305070905070102
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Good day!
This is cut from my dmesg:

"""
ucom0: <CURITEL Incorporated CURITEL HX-550C USB Modem, class 2/0, rev
1.10/0.00, addr 2> on uhub1
ucom0: iclass 2/2ucom0: data interface 1, has CM over data, has break
ucom0: status change notification available
"""

There are missing newline after "ucom0: iclass 2/2". This printf is in 
umodem_attach() from umodem.c:297:

         device_printf(self, "iclass %d/%d", id->bInterfaceClass,
           id->bInterfaceSubClass);

I beleave we can fix this with patch attached.
Can anybody please consider it?


--------------080200060305070905070102
Content-Type: text/x-patch;
 name="umodem.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="umodem.c.diff"

--- /usr/src/sys/dev/usb/umodem.c	2007-06-28 14:59:51.000000000 +0000
+++ umodem.c	2007-07-29 21:29:24.000000000 +0000
@@ -294,7 +294,7 @@
 	sc->sc_ctl_iface = uaa->iface;
 	id = usbd_get_interface_descriptor(sc->sc_ctl_iface);
 	sc->sc_ctl_iface_no = id->bInterfaceNumber;
-	device_printf(self, "iclass %d/%d", id->bInterfaceClass,
+	device_printf(self, "iclass %d/%d\n", id->bInterfaceClass,
 	  id->bInterfaceSubClass);
 
 	umodem_get_caps(dev, &sc->sc_cm_cap, &sc->sc_acm_cap);

--------------080200060305070905070102--