From owner-freebsd-amd64@FreeBSD.ORG Mon Jul 21 06:50:02 2008 Return-Path: Delivered-To: freebsd-amd64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6CDA106567B for ; Mon, 21 Jul 2008 06:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 98EC68FC27 for ; Mon, 21 Jul 2008 06:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6L6o22v082336 for ; Mon, 21 Jul 2008 06:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6L6o269082335; Mon, 21 Jul 2008 06:50:02 GMT (envelope-from gnats) Resent-Date: Mon, 21 Jul 2008 06:50:02 GMT Resent-Message-Id: <200807210650.m6L6o269082335@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-amd64@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, KOIE Hidetaka Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FD54106564A for ; Mon, 21 Jul 2008 06:48:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 2BDA08FC19 for ; Mon, 21 Jul 2008 06:48:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6L6mhTK014113 for ; Mon, 21 Jul 2008 06:48:43 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m6L6mh7Z014112; Mon, 21 Jul 2008 06:48:43 GMT (envelope-from nobody) Message-Id: <200807210648.m6L6mh7Z014112@www.freebsd.org> Date: Mon, 21 Jul 2008 06:48:43 GMT From: KOIE Hidetaka To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 X-Mailman-Approved-At: Mon, 21 Jul 2008 11:16:38 +0000 Cc: Subject: amd64/125820: sysctl dev.k8temp.*.sensor1.* are invalid. X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2008 06:50:02 -0000 >Number: 125820 >Category: amd64 >Synopsis: sysctl dev.k8temp.*.sensor1.* are invalid. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-amd64 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 21 06:50:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: KOIE Hidetaka >Release: 8.0-CURRENT >Organization: surigiken >Environment: FreeBSD guriandgura 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Fri Jul 18 22:14:34 JST 2008 koie@guriandgura:/usr/obj/usr/src/sys/GURIANDGURA amd64 >Description: It seems that temperature of sensor 1 is wrong.. ORIGINAL VERSION % sysctl dev.k8temp dev.k8temp.0.%desc: AMD K8 Thermal Sensors dev.k8temp.0.%driver: k8temp dev.k8temp.0.%parent: hostb3 dev.k8temp.0.sensor0.core0: 49 dev.k8temp.0.sensor0.core1: 48 dev.k8temp.0.sensor1.core0: 49 dev.k8temp.0.sensor1.core1: 49 dev.k8temp.1.%desc: AMD K8 Thermal Sensors dev.k8temp.1.%driver: k8temp dev.k8temp.1.%parent: hostb7 dev.k8temp.1.sensor0.core0: 49 dev.k8temp.1.sensor0.core1: 47 dev.k8temp.1.sensor1.core0: 48 dev.k8temp.1.sensor1.core1: 48 PATCHED VERSION % sysctl dev.k8temp dev.k8temp.0.%desc: AMD K8 Thermal Sensors dev.k8temp.0.%driver: k8temp dev.k8temp.0.%parent: hostb3 dev.k8temp.0.sensor0.core0: 50 dev.k8temp.0.sensor0.core1: 49 dev.k8temp.0.sensor1.core0: -49 dev.k8temp.0.sensor1.core1: -49 dev.k8temp.1.%desc: AMD K8 Thermal Sensors dev.k8temp.1.%driver: k8temp dev.k8temp.1.%parent: hostb7 dev.k8temp.1.sensor0.core0: 47 dev.k8temp.1.sensor0.core1: 45 dev.k8temp.1.sensor1.core0: -49 dev.k8temp.1.sensor1.core1: -49 /usr/local/sbin/k8temp says % sudo k8temp -d 0:0:1 <-- (cpu=0 core=0 sensor=1) CPUID: Vendor: AuthenticAMD, 0x40f12: Model=41 Family=f+0 Stepping=2 Advanced Power Management=0x3f Temperature sensor: Yes Frequency ID control: Yes Voltage ID control: Yes THERMTRIP support: Yes HW Thermal control: Yes SW Thermal control: Yes 100MHz multipliers: No HW P-State control: No TSC Invariant: No Thermtrip=0x00001b64 (CurTmp=0x00 (-49c) TjOffset=0x00 DiodeOffset=0x1b (-16c)) >How-To-Repeat: >Fix: Patch attached with submission follows: Index: k8temp.c =================================================================== RCS file: /museum/freebsd/repo/usr/src/sys/dev/k8temp/k8temp.c,v retrieving revision 1.7 diff -u -p -r1.7 k8temp.c --- k8temp.c 6 Jul 2008 16:18:58 -0000 1.7 +++ k8temp.c 21 Jul 2008 06:34:36 -0000 @@ -216,13 +216,13 @@ k8temp_attach(device_t dev) SYSCTL_ADD_PROC(sysctlctx, SYSCTL_CHILDREN(sysctlnode), OID_AUTO, "core0", CTLTYPE_INT | CTLFLAG_RD, - dev, SENSOR0_CORE0, k8temp_sysctl, "I", + dev, SENSOR1_CORE0, k8temp_sysctl, "I", "Sensor 1 / Core 0 temperature"); SYSCTL_ADD_PROC(sysctlctx, SYSCTL_CHILDREN(sysctlnode), OID_AUTO, "core1", CTLTYPE_INT | CTLFLAG_RD, - dev, SENSOR0_CORE0, k8temp_sysctl, "I", + dev, SENSOR1_CORE1, k8temp_sysctl, "I", "Sensor 1 / Core 1 temperature"); return (0); >Release-Note: >Audit-Trail: >Unformatted: