From owner-freebsd-arm@FreeBSD.ORG  Sun Apr 20 15:01:48 2008
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5327C106566C;
	Sun, 20 Apr 2008 15:01:48 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F2E78FC13;
	Sun, 20 Apr 2008 15:01:47 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [62.113.133.152] (account mc467741@c2i.net [62.113.133.152]
	verified) by mailfe03.swip.net (CommuniGate Pro SMTP 5.1.13)
	with ESMTPA id 910387411; Sun, 20 Apr 2008 16:01:28 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-arm@freebsd.org
Date: Sun, 20 Apr 2008 16:02:39 +0200
User-Agent: KMail/1.9.7
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200804201602.40517.hselasky@c2i.net>
Cc: John Baldwin <jhb@freebsd.org>
Subject: AT91RM9200 and possibly other ARM targets are broken in 8-current
	after recent commit
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2008 15:01:48 -0000

Hi John,

I'm sorry to say that a recent patch done by you has broken at least the 
AT91RM9200 target in 8-current.

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/arm/arm/intr.c.diff?r1=1.19;r2=1.20

I spent spent several hours today scratching my head why the platform didn't 
boot. I added a couple of prints into the code:

void
arm_handler_execute(struct trapframe *frame, int irqnb)
{
        struct intr_event *event;
        struct thread *td = curthread;
        int i;
        
        PCPU_INC(cnt.v_intr);
        td->td_intr_nesting_level++;
        while ((i = arm_get_next_irq()) != -1) {
                intrcnt[intrcnt_tab[i]]++;
                event = intr_events[i];
XXX                printf("i%u", i);
                if (intr_event_handle(event, frame) != 0) {
                        /* XXX: Log stray IRQs */
                        arm_mask_irq(i);
                }
        }
        td->td_intr_nesting_level--;
}

void
arm_mask_irq(uintptr_t nb)
{
XXX        printf("m%u\n", (uint8_t *)nb - (uint8_t *)0);
        bus_space_write_4(at91_softc->sc_st,
            at91_softc->sc_sys_sh, IC_IDCR, 1 << nb);
 
}

void
arm_unmask_irq(uintptr_t nb)
{
XXX        printf("u%u\n", (uint8_t *)nb - (uint8_t *)0);
        bus_space_write_4(at91_softc->sc_st,
        at91_softc->sc_sys_sh, IC_IECR, 1 << nb);
        bus_space_write_4(at91_softc->sc_st, at91_softc->sc_sys_sh,
            IC_EOICR, 0);
 
}

All I get during bootup is "i1". Then the platform hangs. By modifying 
the "arm_handler_execute" things work again:

void
arm_handler_execute(struct trapframe *frame, int irqnb)
{
        struct intr_event *event;
        struct thread *td = curthread;
        int i;
                
        PCPU_INC(cnt.v_intr);
        td->td_intr_nesting_level++;
        while ((i = arm_get_next_irq()) != -1) {
                intrcnt[intrcnt_tab[i]]++;
                event = intr_events[i];
XXX                arm_mask_irq(i);
                if (intr_event_handle(event, frame) != 0) {
                        /* XXX: Log stray IRQs */
                }
XXX                arm_unmask_irq(i);
        }
        td->td_intr_nesting_level--;
}

I understand that the mask and unmask functions should be called by the 
factored out code, but they are not called in the same manner like before.

How can we fix this ?

--HPS