From owner-freebsd-bugs@FreeBSD.ORG Sun May 18 02:40:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B609E1065671 for ; Sun, 18 May 2008 02:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8FB698FC1D for ; Sun, 18 May 2008 02:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4I2e3Nd083281 for ; Sun, 18 May 2008 02:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4I2e3pF083280; Sun, 18 May 2008 02:40:03 GMT (envelope-from gnats) Resent-Date: Sun, 18 May 2008 02:40:03 GMT Resent-Message-Id: <200805180240.m4I2e3pF083280@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthew Luckie Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDD69106564A for ; Sun, 18 May 2008 02:30:14 +0000 (UTC) (envelope-from mjl@luckie.org.nz) Received: from mailfilter9.ihug.co.nz (mailfilter9.ihug.co.nz [203.109.136.9]) by mx1.freebsd.org (Postfix) with ESMTP id 68BA98FC0A for ; Sun, 18 May 2008 02:30:14 +0000 (UTC) (envelope-from mjl@luckie.org.nz) Received: from 203-109-186-4.dsl.dyn.ihug.co.nz (HELO spandex.luckie.org.nz) ([203.109.186.4]) by smtp.mailfilter1.ihug.co.nz with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 May 2008 14:30:11 +1200 Received: from rayon.luckie.org.nz ([192.168.1.25]) by spandex.luckie.org.nz with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1JxYf5-000HD6-Ak for FreeBSD-gnats-submit@freebsd.org; Sun, 18 May 2008 14:30:11 +1200 Received: from mjl by rayon.luckie.org.nz with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1JxYf7-0001QM-NP for FreeBSD-gnats-submit@freebsd.org; Sun, 18 May 2008 14:30:13 +1200 Message-Id: Date: Sun, 18 May 2008 14:30:13 +1200 From: Matthew Luckie Sender: Matthew Luckie To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/123774: [patch] kdump time_t printing issues X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Luckie List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 May 2008 02:40:03 -0000 >Number: 123774 >Category: bin >Synopsis: [patch] kdump time_t printing issues >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 18 02:40:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Matthew Luckie >Release: FreeBSD 7.0-RELEASE-p1 arm >Organization: >Environment: System: FreeBSD vinyl.luckie.org.nz 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #4: Sun May 18 08:49:48 NZST 2008 root@rayon.luckie.org.nz:/usr/obj/arm/usr/src/sys/vinyl arm >Description: On systems with 64-bit time_t values, such as arm, kdump -T prints the following: 988 ktrace 0.1211060384 RET ktrace 0 where you would otherwise expect to see 988 ktrace 1211060384.667338 RET ktrace 0 >How-To-Repeat: ktrace / kdump on a system with a 64-bit time_t >Fix: There is no non-kludge solution that I am aware of. http://lists.freebsd.org/pipermail/freebsd-ports/2006-January/028656.html --- patch-kdump.c begins here --- --- kdump.c.orig 2008-01-12 13:07:50.000000000 +1300 +++ kdump.c 2008-05-18 14:14:30.000000000 +1200 @@ -290,8 +290,9 @@ timevalsub(&kth->ktr_time, &prevtime); prevtime = temp; } - (void)printf("%ld.%06ld ", - kth->ktr_time.tv_sec, kth->ktr_time.tv_usec); + (void)printf("%lld.%06ld ", + (long long int)kth->ktr_time.tv_sec, + kth->ktr_time.tv_usec); } (void)printf("%s ", type); } --- patch-kdump.c ends here --- >Release-Note: >Audit-Trail: >Unformatted: