From owner-freebsd-fs@FreeBSD.ORG Sun Jun 1 17:12:11 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33C3A106564A for ; Sun, 1 Jun 2008 17:12:11 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.237]) by mx1.freebsd.org (Postfix) with ESMTP id F049C8FC17 for ; Sun, 1 Jun 2008 17:12:10 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so685254rvf.43 for ; Sun, 01 Jun 2008 10:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=VALIKSf9fimpPwda2LVINne13kvxJPSS9j3KTo+GYOE=; b=mOzWGE6XUypAzPQwE+KxCEkBOH6JWn5Pxa8IXItZl3onBKKcmFW00IaBxABmcXfXxVmljJRXMUxN21CjVF5CHyCQhOI9sxAOaRS1EwCr3QCtUM4TCkg/d/H9keSkGRbrNG8ptNXDzBA+UhwB5HxOBa+rBtnHzAbldYeFnKBfZDU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=tcbVYvReepsRnlpFvmTeRh1TebjsZonNLXVLFlCe50rGh1fhn8MZjlKLQfIhaQ50P+BnpupFE7Ojl2TspZXoFLa6Obp90DMOEElS48DJuVnj6DtC/gn2XnYr3pP1qpu6S9LFu3Q9MXGdFtrreCvHPBTWV1M/5NFxiSmGDLror20= Received: by 10.140.157.1 with SMTP id f1mr4399960rve.220.1212338658810; Sun, 01 Jun 2008 09:44:18 -0700 (PDT) Received: by 10.140.207.1 with HTTP; Sun, 1 Jun 2008 09:44:18 -0700 (PDT) Message-ID: <2e77fc10806010944p5fde4782nffa437230ff36362@mail.gmail.com> Date: Sun, 1 Jun 2008 12:44:18 -0400 From: "Niki Denev" Sender: ndenev@gmail.com To: "Pawel Jakub Dawidek" In-Reply-To: <20080530065439.GB3596@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2e77fc10802120304n32fd1c42m52e6bc617ba07c35@mail.gmail.com> <20080530065439.GB3596@garage.freebsd.pl> X-Google-Sender-Auth: 82e85300968cde0a Cc: freebsd-fs@freebsd.org Subject: Re: ZFS panic when changing zfs dataset mountpoint X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jun 2008 17:12:11 -0000 On Fri, May 30, 2008 at 2:54 AM, Pawel Jakub Dawidek wrote: > On Tue, Feb 12, 2008 at 01:04:38PM +0200, Niki Denev wrote: >> Hi, >> >> I got the following panic when trying to set/change the mountpoint >> property of a dataset. >> >> I did : >> # zfs set mountpoint=/usr/ports zfs2/ports >> and the machine crashed. >> >> The datased had one snapshot taken. >> >> Here is what i was able to extract from the dump : > [...] >> #8 0xffffffff804800d5 in _sx_xlock (sx=0xa0, opts=0, >> file=0xffffffff80c697f0 >> "/usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c", >> line=1069) at atomic.h:142 >> #9 0xffffffff80c50b2a in zfsctl_umount_snapshots (vfsp=Variable >> "vfsp" is not available. >> ) at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c:1069 >> #10 0xffffffff80c57978 in zfs_umount (vfsp=0xffffff00014f5650, >> fflag=0, td=0xffffff001483b6a0) >> at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c:692 > [...] > > I tried to reproduce your problem, but I can't. This is clearly related > to unmounting snapshots. Was your snapshot mounted at the time of > calling 'zfs set mountpoint='? I tried both scenarious (having mounted > and unmounted snapshot) and no panic. Is there anything else you did? > > -- > Pawel Jakub Dawidek http://www.wheel.pl > pjd@FreeBSD.org http://www.FreeBSD.org > FreeBSD committer Am I Evil? Yes, I Am! > Hi Pawel, Sorry for my late reply. I cannot test right now because the machine suffered multiple disk failures, and is currently offline, but as far as I remember the machine had several snapshots mounted at the time of the panic. Regards, Niki