From owner-freebsd-ia64@FreeBSD.ORG Sun Oct 19 16:53:02 2008 Return-Path: Delivered-To: freebsd-ia64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6189B106568B for ; Sun, 19 Oct 2008 16:53:02 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout016.mac.com (asmtpout016.mac.com [17.148.16.91]) by mx1.freebsd.org (Postfix) with ESMTP id 4EF258FC1F for ; Sun, 19 Oct 2008 16:53:02 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed Received: from [192.168.1.95] (209-128-86-226.bayarea.net [209.128.86.226]) by asmtp016.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K8Z00E34W79KE50@asmtp016.mac.com> for freebsd-ia64@freebsd.org; Sun, 19 Oct 2008 09:52:25 -0700 (PDT) Message-id: <35C58F22-E133-49AB-923E-AE858802D389@mac.com> From: Marcel Moolenaar To: Christian Kandeler In-reply-to: <200810171319.38605.christian.kandeler@hob.de> Date: Sun, 19 Oct 2008 09:52:20 -0700 References: <200810171319.38605.christian.kandeler@hob.de> X-Mailer: Apple Mail (2.929.2) Cc: freebsd-ia64@freebsd.org Subject: Re: Question about ia64_ap_startup() X-BeenThere: freebsd-ia64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the IA-64 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Oct 2008 16:53:02 -0000 On Oct 17, 2008, at 4:19 AM, Christian Kandeler wrote: > Hello, > > I've been looking at the implementation of ia64_ap_startup() and it > seems to me that the "ap_awake++" statement has a rather obvious race > condition. Shouldn't one of the atomic macros be used here instead? > Or am I missing something? No, you're not missing anything. It should use an atomic operation. -- Marcel Moolenaar xcllnt@mac.com