From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 7 06:22:37 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 775C91065671 for ; Sat, 7 Jun 2008 06:22:37 +0000 (UTC) (envelope-from jamie@gritton.org) Received: from gritton.org (gritton.org [161.58.222.4]) by mx1.freebsd.org (Postfix) with ESMTP id 376858FC1B for ; Sat, 7 Jun 2008 06:22:37 +0000 (UTC) (envelope-from jamie@gritton.org) Received: from glorfindel.gritton.org (c-76-27-80-223.hsd1.ut.comcast.net [76.27.80.223]) (authenticated bits=0) by gritton.org (8.13.6.20060614/8.13.6) with ESMTP id m5760FNn077186 for ; Sat, 7 Jun 2008 00:00:15 -0600 (MDT) Message-ID: <484A23EE.8080308@gritton.org> Date: Sat, 07 Jun 2008 00:00:14 -0600 From: James Gritton User-Agent: Thunderbird 2.0.0.9 (X11/20080228) MIME-Version: 1.0 To: freebsd-virtualization@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.92.1/7391/Fri Jun 6 21:32:51 2008 on gritton.org X-Virus-Status: Clean Subject: R_xxx counterparts to the V_xxx macros X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2008 06:22:37 -0000 There are places where a variable has been replaced with a V_ macro, only to be set explicitly to the "virtual" data from thread0 or the like. For example, I know of a few places where V_hostname is set like this. It would make sense to have an R_hostname as well, an easy shortcut the the real hostname instead of the virtual one. You'd need either a static "vprocg0" structure, or a pointer somewhere to the main entry (could be thread0 again, I suppose). Likewise with the other structures where other globals may live. Perhaps many (most?) variables will only ever be referred to in their fully virtual state. But for those where the intention is to use the machine's "true" parameter, it would be more clear if that was made explicit in the macro. - Jamie From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 7 16:51:29 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DA981065671 for ; Sat, 7 Jun 2008 16:51:29 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outJ.internet-mail-service.net (outj.internet-mail-service.net [216.240.47.233]) by mx1.freebsd.org (Postfix) with ESMTP id F0F3C8FC12 for ; Sat, 7 Jun 2008 16:51:28 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id D2798247D; Sat, 7 Jun 2008 09:51:28 -0700 (PDT) Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 8BC222D6052; Sat, 7 Jun 2008 09:51:28 -0700 (PDT) Message-ID: <484ABC90.9070301@elischer.org> Date: Sat, 07 Jun 2008 09:51:28 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: James Gritton References: <484A23EE.8080308@gritton.org> In-Reply-To: <484A23EE.8080308@gritton.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-virtualization@freebsd.org Subject: Re: R_xxx counterparts to the V_xxx macros X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2008 16:51:29 -0000 James Gritton wrote: > There are places where a variable has been replaced with a V_ macro, > only to be set explicitly to the "virtual" data from thread0 or the > like. For example, I know of a few places where V_hostname is set like > this. > > It would make sense to have an R_hostname as well, an easy shortcut the > the real hostname instead of the virtual one. You'd need either a > static "vprocg0" structure, or a pointer somewhere to the main entry > (could be thread0 again, I suppose). Likewise with the other structures > where other globals may live. > > Perhaps many (most?) variables will only ever be referred to in their > fully virtual state. But for those where the intention is to use the > machine's "true" parameter, it would be more clear if that was made > explicit in the macro. It's an interesting idea, however what is the "real" hostname? what makes one vimage the 'real' one? theoretically you can get it via: INIT_VNET_INET(thread0.td_vnet) as you noted.. a macro that does that could be done I guess.. #define R_hostname ... I wouldn't do it for all variables however.. let us keep it in mind and when we have vimage in we'll see how useful it is. > > - Jamie > _______________________________________________ > freebsd-virtualization@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization > To unsubscribe, send any mail to > "freebsd-virtualization-unsubscribe@freebsd.org" From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 7 17:04:00 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 748071065672 for ; Sat, 7 Jun 2008 17:04:00 +0000 (UTC) (envelope-from jamie@gritton.org) Received: from gritton.org (gritton.org [161.58.222.4]) by mx1.freebsd.org (Postfix) with ESMTP id 401338FC18 for ; Sat, 7 Jun 2008 17:04:00 +0000 (UTC) (envelope-from jamie@gritton.org) Received: from glorfindel.gritton.org (c-76-27-80-223.hsd1.ut.comcast.net [76.27.80.223]) (authenticated bits=0) by gritton.org (8.13.6.20060614/8.13.6) with ESMTP id m57H3xB7046178 for ; Sat, 7 Jun 2008 11:03:59 -0600 (MDT) Message-ID: <484ABF7E.3050601@gritton.org> Date: Sat, 07 Jun 2008 11:03:58 -0600 From: James Gritton User-Agent: Thunderbird 2.0.0.9 (X11/20080228) MIME-Version: 1.0 To: freebsd-virtualization@freebsd.org References: <484A23EE.8080308@gritton.org> <484ABC90.9070301@elischer.org> In-Reply-To: <484ABC90.9070301@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.92.1/7395/Sat Jun 7 10:15:12 2008 on gritton.org X-Virus-Status: Clean Subject: Re: R_xxx counterparts to the V_xxx macros X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2008 17:04:00 -0000 Julian Elischer wrote: > It's an interesting idea, however what is the "real" hostname? > what makes one vimage the 'real' one? You could ask this if all images were indeed equal. However, they're hierarchical, and there's one that is there when the box starts up, and can't be gotten rid of. If there weren't a "real" hostname, there would never be a place in the code where you don't have a better choice than using thread0's credential. > I wouldn't do it for all variables however.. Quite true. I suspect that most variables replaced by vnet always have a context that they naturally belong to, and would never need to know about a "real" value. I think it's the few that are outside of vnet that would most show this. My focus right now is jail integration, so these are the parts that I notice, as vnet wouldn't be integrated with jails so much as placed on top of them (as they are now placed on top of vimage which is almost but not quite entirely vnet). - Jamie From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 7 17:26:18 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E1B2106566B for ; Sat, 7 Jun 2008 17:26:18 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outA.internet-mail-service.net (outa.internet-mail-service.net [216.240.47.224]) by mx1.freebsd.org (Postfix) with ESMTP id 1DC1D8FC14 for ; Sat, 7 Jun 2008 17:26:18 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id 4495424AE; Sat, 7 Jun 2008 10:26:18 -0700 (PDT) Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 9A90D2D6004; Sat, 7 Jun 2008 10:26:17 -0700 (PDT) Message-ID: <484AC4B9.2060207@elischer.org> Date: Sat, 07 Jun 2008 10:26:17 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: James Gritton References: <484A23EE.8080308@gritton.org> <484ABC90.9070301@elischer.org> <484ABF7E.3050601@gritton.org> In-Reply-To: <484ABF7E.3050601@gritton.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-virtualization@freebsd.org Subject: Re: R_xxx counterparts to the V_xxx macros X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2008 17:26:18 -0000 James Gritton wrote: > Julian Elischer wrote: >> It's an interesting idea, however what is the "real" hostname? >> what makes one vimage the 'real' one? > > You could ask this if all images were indeed equal. However, they're > hierarchical, and there's one that is there when the box starts up, and > can't be gotten rid of. If there weren't a "real" hostname, there would > never be a place in the code where you don't have a better choice than > using thread0's credential. > >> I wouldn't do it for all variables however.. > > Quite true. I suspect that most variables replaced by vnet always have > a context that they naturally belong to, and would never need to know > about a "real" value. I think it's the few that are outside of vnet > that would most show this. > > My focus right now is jail integration, so these are the parts that I > notice, as vnet wouldn't be integrated with jails so much as placed on > top of them (as they are now placed on top of vimage which is almost but > not quite entirely vnet). excellent. Be aware that the patch ( http://www.freebsd.org/~julian/vimage.diff ) (updated today) may not be EXACTLY what is committed as we are re-doing it in order to abide by the plan worked out at the Ottawa devsummit. This plan wants us to break up the patch into parts so it may result in a very slightly different outcome in a few places.. I do believe we do want to integrate the jails and vimage a bit more.. let us know what you are thinking... > > - Jamie > _______________________________________________ > freebsd-virtualization@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization > To unsubscribe, send any mail to > "freebsd-virtualization-unsubscribe@freebsd.org"