From owner-freebsd-virtualization@FreeBSD.ORG Sun Aug 3 08:06:01 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BB9A1065676 for ; Sun, 3 Aug 2008 08:06:01 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outR.internet-mail-service.net (outr.internet-mail-service.net [216.240.47.241]) by mx1.freebsd.org (Postfix) with ESMTP id 864458FC1C for ; Sun, 3 Aug 2008 08:06:01 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id A5BDD2476; Sun, 3 Aug 2008 01:06:01 -0700 (PDT) Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id EEFAB2D60CD; Sun, 3 Aug 2008 01:06:00 -0700 (PDT) Message-ID: <489566F5.9040308@elischer.org> Date: Sun, 03 Aug 2008 01:06:13 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: FreeBSD Net , freebsd-virtualization@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Developers adding global variables. X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Aug 2008 08:06:01 -0000 If you are adding globals to the networking code, (or if you have added soem globals in the last few months, could you make sure that I am aware of them? marko Zec and I are trying to keep teh Vimage tree in perforce in sync with -current but there is noo automatic way that we would be noticfied of the sudden appearance of a new global variable in the networking code. Today I noticed tcp_do_ecn and tcp_ecn_maxretries but only because of their proximity to another change. thanks Julian From owner-freebsd-virtualization@FreeBSD.ORG Sun Aug 3 10:32:17 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86E4E1065677; Sun, 3 Aug 2008 10:32:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5D5568FC12; Sun, 3 Aug 2008 10:32:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id B388C46B5C; Sun, 3 Aug 2008 06:32:16 -0400 (EDT) Date: Sun, 3 Aug 2008 11:32:16 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Julian Elischer In-Reply-To: <489566F5.9040308@elischer.org> Message-ID: References: <489566F5.9040308@elischer.org> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Sun, 03 Aug 2008 10:48:53 +0000 Cc: FreeBSD Net , freebsd-virtualization@freebsd.org Subject: Re: Developers adding global variables. X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Aug 2008 10:32:17 -0000 On Sun, 3 Aug 2008, Julian Elischer wrote: > If you are adding globals to the networking code, (or if you have added soem > globals in the last few months, could you make sure that I am aware of them? > > marko Zec and I are trying to keep teh Vimage tree in perforce in sync with > -current but there is noo automatic way that we would be noticfied of the > sudden appearance of a new global variable in the networking code. > > Today I noticed tcp_do_ecn and tcp_ecn_maxretries but only because of their > proximity to another change. While not a universal solution, one technique you could use to catch things like this is to compare the set of symbols in a !virtualization kernel with those in a virtualization kernels, perhaps using nm(1), and compare that difference set over time. Not perfect, but it would allow you to look for things that have been missed. FWIW, I have no immediate plans to add any global variables to the network stack. Robert N M Watson Computer Laboratory University of Cambridge