From owner-freebsd-virtualization@FreeBSD.ORG  Sun Sep  7 06:27:04 2008
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 125AE106567E
	for <freebsd-virtualization@freebsd.org>;
	Sun,  7 Sep 2008 06:27:04 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outS.internet-mail-service.net (outs.internet-mail-service.net
	[216.240.47.242])
	by mx1.freebsd.org (Postfix) with ESMTP id EB2D08FC1C
	for <freebsd-virtualization@freebsd.org>;
	Sun,  7 Sep 2008 06:27:03 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id E07B023FF;
	Sat,  6 Sep 2008 23:27:03 -0700 (PDT)
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id 17F922D6087;
	Sat,  6 Sep 2008 23:27:03 -0700 (PDT)
Message-ID: <48C3743D.9090503@elischer.org>
Date: Sat, 06 Sep 2008 23:27:09 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: Marko Zec <zec@FreeBSD.org>, FreeBSD virtualization mailing list
	<freebsd-virtualization@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: FOREACH_VNET...
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Sep 2008 06:27:04 -0000

trying to replace VNET_ITERLOOP_{BEGIN,END}



looking at an example:

static void
if_slowtimo(void *arg)
{
         struct ifnet *ifp;

         IFNET_RLOCK();
         VNET_ITERLOOP_BEGIN();
         INIT_VNET_NET(curvnet);
         TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
                 if (ifp->if_timer == 0 || --ifp->if_timer)
                         continue;
                 if (ifp->if_watchdog)
                         (*ifp->if_watchdog)(ifp);
         }
         VNET_ITERLOOP_END();
         IFNET_RUNLOCK();
         timeout(if_slowtimo, (void *)0, hz / IFNET_SLOWHZ);
}


If we expand this out we get: (reindented for readability)

static void
if_slowtimo(void *arg)
{
         struct ifnet *ifp;

         IFNET_RLOCK();
         struct vnet *vnet_iter;
         VNET_LIST_REF();
         LIST_FOREACH(vnet_iter, &vnet_head, vnet_le) {
                 struct vnet *saved_vnet = curvnet;
                 curvnet = vnet_iter;
                 INIT_VNET_NET(curvnet);
                 TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
                         if (ifp->if_timer == 0 || --ifp->if_timer)
                                 continue;
                         if (ifp->if_watchdog)
                                 (*ifp->if_watchdog)(ifp);
                 }
                 curvnet = saved_vnet;
         }
         VNET_LIST_UNREF();
         IFNET_RUNLOCK();
         timeout(if_slowtimo, (void *)0, hz / IFNET_SLOWHZ);
}

now several things leap out here..
(like, declaring variables in mid block)
using different macros to try do this cleanly might lead to:



static void
if_slowtimo(void *arg)
{
         struct ifnet *ifp;
         VNET_DECL(vnet_iter);
         VNET_DECL(saved_vnet);

         IFNET_RLOCK();
	CURVNET_SAVE(saved_vnet);
         VNET_LIST_REF();
         FOREACH_VNET(vnet_iter) {
		
                 CURVNET_SET_QUIET(vnet_iter);
                 INIT_VNET_NET(vnet_iter);
                 TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
                         if (ifp->if_timer == 0 || --ifp->if_timer)
                                 continue;
                         if (ifp->if_watchdog)
                                 (*ifp->if_watchdog)(ifp);
                 }
         }
         CURVNET_SET(vnet_hold);
         VNET_LIST_UNREF();
         IFNET_RUNLOCK();
         timeout(if_slowtimo, (void *)0, hz / IFNET_SLOWHZ);
}

this adds a lot to the original..

I could see:

using bigger macros, getting it back (size wise) to:

static void
if_slowtimo(void *arg)
{
         struct ifnet *ifp;
         VNET_ITERATOR_DECL(vnet_iter, saved_vnet);

         IFNET_RLOCK();
         FOREACH_VNET(vnet_iter, saved_vnet) {
		VNET_SWITCHTO(vnet_iter);
                 TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
                         if (ifp->if_timer == 0 || --ifp->if_timer)
                                 continue;
                         if (ifp->if_watchdog)
                                 (*ifp->if_watchdog)(ifp);
                 }
         }
         FOREACH_VNET_COMPLETE(saved_vnet);
         IFNET_RUNLOCK();
         timeout(if_slowtimo, (void *)0, hz / IFNET_SLOWHZ);
}

still bigger than the original macros though arguably more "C-like"

anyone have better ways to express this?

Brook, robert, bz? does this look better?


Julian