From owner-freebsd-virtualization@FreeBSD.ORG Tue Sep 16 17:45:07 2008 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94DAE106566B for ; Tue, 16 Sep 2008 17:45:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 4E6A88FC23 for ; Tue, 16 Sep 2008 17:45:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 7E89641C647; Tue, 16 Sep 2008 19:45:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id u1ufIvkk+pAl; Tue, 16 Sep 2008 19:45:06 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 2BF0341C66F; Tue, 16 Sep 2008 19:45:06 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id CB5FB44487F; Tue, 16 Sep 2008 17:43:09 +0000 (UTC) Date: Tue, 16 Sep 2008 17:43:09 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Julian Elischer In-Reply-To: <48C780E4.2050207@elischer.org> Message-ID: <20080916174040.Y65801@maildrop.int.zabbadoz.net> References: <200809081655.m88GtxbV000906@repoman.freebsd.org> <48C780E4.2050207@elischer.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Marko Zec , FreeBSD virtualization mailing list Subject: Re: Vnet iteration X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Sep 2008 17:45:07 -0000 > Marko Zec wrote: Hi, >> http://perforce.freebsd.org/chv.cgi?CH=149433 >> >> Change 149433 by zec@zec_tpx32 on 2008/09/08 16:55:34 >> >> First-cut replacement of VNET_ITERLOOP_BEGIN() / >> VNET_ITERLOOP_END() kludges with VNET_FOREACH() constructs >> discussed at freebsd-virtualization@ >> Needs a bit more testing before merging over to >> vimage-commit2 branch. >> >> Differences ... > > [...] > >> + VNET_FOREACH(vnet_iter) { >> + CURVNET_SET(vnet_iter); /* XXX CURVNET_SET_QUIET() ? */ >> + INIT_VNET_NET(vnet_iter); >> + TAILQ_FOREACH(ifp, &V_ifnet, if_link) >> + (void)ifaddr_event_handler(NULL, ifp); >> + CURVNET_RESTORE(); >> } > > this looks great.. > > I'd like to see as much of this as possible in commit2 > and then I'd like to see it committed as soon as brokk, bz and others have > kicked the t[yi]res a bit. > :-) So can anyone bring it over to commit2? Marko, are you around? I had been generating a diff last weekend again to push this and found that the diff size changed from ~200k to ~800k so I suspect there was a mis-integration or someone forgot to set the label? /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.