From owner-p4-projects@FreeBSD.ORG  Sun Jul  6 01:42:32 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C36E41065682; Sun,  6 Jul 2008 01:42:31 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 85AE3106564A;
	Sun,  6 Jul 2008 01:42:31 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp
	[133.80.152.80])
	by mx1.freebsd.org (Postfix) with ESMTP id 1F4C18FC15;
	Sun,  6 Jul 2008 01:42:30 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from localhost (localhost [IPv6:::1])
	by watery.cc.kogakuin.ac.jp (unknown) with ESMTP id m661FePO072727;
	Sun, 6 Jul 2008 10:15:40 +0900 (JST)
	(envelope-from nyan@jp.FreeBSD.org)
Date: Sun, 06 Jul 2008 10:15:12 +0900 (JST)
Message-Id: <20080706.101512.193761302.nyan@jp.FreeBSD.org>
To: marcel@freebsd.org
From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
In-Reply-To: <200807051805.m65I5T4Y056554@repoman.freebsd.org>
References: <200807051805.m65I5T4Y056554@repoman.freebsd.org>
X-Mailer: Mew version 6.1 on Emacs 22.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 144729 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jul 2008 01:42:32 -0000

In article <200807051805.m65I5T4Y056554@repoman.freebsd.org>
Marcel Moolenaar <marcel@freebsd.org> writes:

> @@ -67,9 +65,7 @@
>  	struct uart_class *class;
>  	unsigned int i, j, ivar;
>  
> -	class = &uart_ns8250_class;	/* currently ns8250 only */
> -	if (class == NULL)
> -		return (ENXIO);
> +	class = &uart_i8251_class;
>  
>  	/* Check the environment. */
>  	if (uart_getenv(devtype, di, class) == 0)

Please revert this change.  We want to use ns8250 class as default.
And the above comment in the diff was wrong...
The uart_i8251_class should be added to the uart_classes in uart_subr.c.

---
TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>