From owner-freebsd-arm@FreeBSD.ORG  Sun Oct  4 22:28:22 2009
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A48F71065672
	for <freebsd-arm@FreeBSD.org>; Sun,  4 Oct 2009 22:28:22 +0000 (UTC)
	(envelope-from doginou@kanar.ci0.org)
Received: from kanar.ci0.org (kanar.ci0.org [88.191.50.96])
	by mx1.freebsd.org (Postfix) with ESMTP id 448F88FC0A
	for <freebsd-arm@FreeBSD.org>; Sun,  4 Oct 2009 22:28:22 +0000 (UTC)
Received: from kanar.ci0.org (pluxor@localhost [127.0.0.1])
	by kanar.ci0.org (8.14.2/8.14.3) with ESMTP id n94MUZn2073151;
	Mon, 5 Oct 2009 00:30:35 +0200 (CEST)
	(envelope-from doginou@kanar.ci0.org)
Received: (from doginou@localhost)
	by kanar.ci0.org (8.14.2/8.14.3/Submit) id n94MUZ5Q073150;
	Mon, 5 Oct 2009 00:30:35 +0200 (CEST) (envelope-from doginou)
Date: Mon, 5 Oct 2009 00:30:35 +0200
From: Olivier Houchard <cognet@ci0.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20091004223035.GA72827@ci0.org>
References: <4AC599FC.1070304@tomjudge.com>
	<20091002155600.2c2f615d.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091002155600.2c2f615d.stas@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-arm@FreeBSD.org
Subject: Re: [patch] Compilation problems in sys/arm/arm/pmap.c when
	PMAP_DEBUG is defined.
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Oct 2009 22:28:22 -0000

On Fri, Oct 02, 2009 at 03:56:00PM +0400, Stanislav Sedov wrote:
> On Fri, 02 Oct 2009 06:13:16 +0000
> Tom Judge <tom@tomjudge.com> mentioned:
> 
> > Hi,
> > 
> > I ran into some issues this evening while I was building some kernels 
> > with PMAP_DEBUG defined.
> > 
> > I have attached a patch that addresses the problems with the DPRINTF 
> > sections. (The first 2 hunks should probably be ignored).
> > 
> > However there are 2 warnings about unused functions when PMAP_INLINE is 
> > defined as "". I did not know what the correct fix for this was so I 
> > defined PMAP_INLINE to __inline even when PMAP_DEBUG was set, which 
> > seemed to hide the problem again.
> > 
> 
> Actually, these two functions with PMAP_INLINE prefixes are unused.  I
> believe we can drop them.
> 
> Olivier, what do you think about the following patch?
> 

Hi Stanislav,

Removing pmap_use_l1() is fine, but please just comment
pmap_dcache_wbinv_all() for now, and keep pmap_clean_page(), it's here to
remember we still write back/invalidate the whole cache in pmap_copy_page()
which is suboptimal.

Regards,

Olivier