From owner-freebsd-bluetooth@FreeBSD.ORG Mon Jan 26 21:10:39 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B216510656E3 for ; Mon, 26 Jan 2009 21:10:39 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.237]) by mx1.freebsd.org (Postfix) with ESMTP id 862418FC33 for ; Mon, 26 Jan 2009 21:10:39 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so6157864rvf.43 for ; Mon, 26 Jan 2009 13:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=T/WMleLnT4MAw5FWsM/A4GcYwKjq2UnQ9VkR+RgrCFs=; b=RrbFtYo+tpEU+gsGTRfbTjW2xr1tzZXOPpOafUK9Lcr1o0ZS5JRpm7ic4U6XSW0Jpu I9xd8Fu+qz4YgfcQK0rrKMwRKXvJwHbXFjkSPz1PWBE062YqUbfqiGQAwQSI+2u8PLnz Aui10maLHr2gCwD3UOkgHPY7iT6huL/VdsHkI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=JKULApN7O3MN2tqT12ancgk9iIz4SC0TVM8q18R2tCwScvydlVS9fUfzdgd1/K6+1E R8Y00eNnYO2j0/kgyIgJKhda7IacwUZBIIh8ilTrbF15js929JGmwuZH+Csr4NrBSWtr PDFC+4+/u396LvoRSkI5idCZ3wDuPTWOKB3c8= MIME-Version: 1.0 Received: by 10.141.114.19 with SMTP id r19mr2365126rvm.24.1233004239113; Mon, 26 Jan 2009 13:10:39 -0800 (PST) In-Reply-To: References: Date: Mon, 26 Jan 2009 13:10:39 -0800 Message-ID: From: Maksim Yevmenkin To: "freebsd-bluetooth@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: ng_ubt2 patch committed X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2009 21:10:40 -0000 dear frebsd-bluetooth@ users with HPS blessing another updated/cleaned up version of the ng_ubt2 driver for usb2 was committed to -head. this version should properly handle stalled usb transfers (i.e. the system should not panic anymore). also the code is now (hopefully) easier to read/understand/maintain. please give it a try and let me know if there are any problems. i'm also interested to hear about your experiences with ng_ubt2 and how it stacks up to usb1 ng_ubt. i also would like to thank HPS for his patience while working with me on this. thanks, max ==== Author: emax Date: Mon Jan 26 20:59:41 2009 New Revision: 187741 URL: http://svn.freebsd.org/changeset/base/187741 Log: Clean up ng_ubt2. Get rid of excessive use of NG_NODE_REF/UNREF(). Make detach() completely synchronous. Properly handle stalled USB transfers (use internal mechanism instead of submitting own control transfers). Rename/remove a couple of variables and update comments. This work was done in close collaboration with HPS. Reviewed by: HPS Modified: head/sys/dev/usb2/bluetooth/ng_ubt2.c head/sys/dev/usb2/bluetooth/ng_ubt2_var.h