From owner-freebsd-bluetooth@FreeBSD.ORG Tue Dec 1 12:23:03 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 095F81065670 for ; Tue, 1 Dec 2009 12:23:03 +0000 (UTC) (envelope-from m.drochner@googlemail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by mx1.freebsd.org (Postfix) with ESMTP id 8F3428FC14 for ; Tue, 1 Dec 2009 12:23:02 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id e12so323571fga.13 for ; Tue, 01 Dec 2009 04:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:x-mailer:mime-version:content-type :content-transfer-encoding; bh=owNyq+1uOtOsIwneuLhLRvQ1QeodWw6up8cfxo4fnnQ=; b=dnkoPD2M/AV1tUKCCnoTmf3GyjMGhD3uAw2n95SBLzPTiKdHk1rrIjQr/ysI3ZaFrh oWKAhWBltkd9e0Z++svi5zHXODxAnjjvVGx+55JpPgtjm23/+nsAtShaGKqWsMXO/NW5 sz6+A/ALsZMmyzWahnjtl9te3QFA339u/Sjag= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; b=DpaDj0ZhUkFmX/6w5YMiHZltqnbg+N3vdHAmiojmxLhnDDouNL1GBoABYjollHjm2S AxwRGmU/zL3qrLSKdSi6zMQhhBAQyaL6Q8NHO7W0Tn6IL6oHsVjCr9NyYwJzlPEBWExO qntDIbLNlRDxsLDz/zZ4D3g+gmWS5wMgOfXCI= Received: by 10.86.11.9 with SMTP id 9mr5263615fgk.13.1259668256757; Tue, 01 Dec 2009 03:50:56 -0800 (PST) Received: from zelz27 (gnat.frm2.tum.de [129.187.179.99]) by mx.google.com with ESMTPS id e11sm1823566fga.19.2009.12.01.03.50.55 (version=SSLv3 cipher=RC4-MD5); Tue, 01 Dec 2009 03:50:55 -0800 (PST) Date: Tue, 1 Dec 2009 12:50:54 +0100 From: Matthias Drochner To: Maksim Yevmenkin Message-ID: <20091201125054.44a00147@zelz27> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.4; i486--netbsdelf) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-bluetooth@freebsd.org, plunky@netbsd.org Subject: patch to make obexapp work with BSD iconv(3) X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2009 12:23:03 -0000 Here is a patch which removes the GNU iconv dependency from obexapp. I've successfully tested it by sending vcards with strange names; the resulting files were identical. The relevant changes are: -just use the result of nl_langinfo(CODESET) as input of iconv_open(3), this is more robust than trying to interpret the locale string -remove iconvctl(ICONV_SET_DISCARD_ILSEQ) -- BSD doesn't have this and it should be unneeded because it only compensates for some non-standard behaviour of GNU iconv. (The bsdxml->expat part is unrelated.) best regards Matthias