From owner-freebsd-bugs@FreeBSD.ORG Sun Jun 21 03:00:20 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7490106567F for ; Sun, 21 Jun 2009 03:00:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B6F018FC1E for ; Sun, 21 Jun 2009 03:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n5L30HJw060079 for ; Sun, 21 Jun 2009 03:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n5L30Hnn060078; Sun, 21 Jun 2009 03:00:17 GMT (envelope-from gnats) Resent-Date: Sun, 21 Jun 2009 03:00:17 GMT Resent-Message-Id: <200906210300.n5L30Hnn060078@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pete Carah Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 526581065677 for ; Sun, 21 Jun 2009 02:50:07 +0000 (UTC) (envelope-from pete@port4.altadena.net) Received: from kestrel.altadena.net (kestrel.altadena.net [207.136.131.34]) by mx1.freebsd.org (Postfix) with ESMTP id 2AD498FC16 for ; Sun, 21 Jun 2009 02:50:06 +0000 (UTC) (envelope-from pete@port4.altadena.net) Received: from gate.east.altadena.net ([173.10.157.233] helo=port4.altadena.net) by kestrel.altadena.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1MIClK-000Pyk-8N for FreeBSD-gnats-submit@freebsd.org; Sat, 20 Jun 2009 19:26:30 -0700 Received: from port4.altadena.net (localhost [127.0.0.1]) by port4.altadena.net (8.14.3/8.14.3) with ESMTP id n5L2C6oD001065 for ; Sat, 20 Jun 2009 22:12:06 -0400 (EDT) (envelope-from pete@port4.altadena.net) Received: (from pete@localhost) by port4.altadena.net (8.14.3/8.14.3/Submit) id n5L2C6KG001064; Sat, 20 Jun 2009 22:12:06 -0400 (EDT) (envelope-from pete) Message-Id: <200906210212.n5L2C6KG001064@port4.altadena.net> Date: Sat, 20 Jun 2009 22:12:06 -0400 (EDT) From: Pete Carah To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/135874: Geom_linux_lvm misses newer fedora defaults X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pete Carah List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 03:00:21 -0000 >Number: 135874 >Category: kern >Synopsis: Geom_linux_lvm misses newer fedora defaults >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jun 21 03:00:17 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Pete Carah >Release: FreeBSD 7.2-STABLE amd64 >Organization: Altadena Internet >Environment: System: FreeBSD port4.altadena.net 7.2-STABLE FreeBSD 7.2-STABLE #2 r194560M: Sat Jun 20 21:50:58 EDT 2009 pete@port4.altadena.net:/usr/obj/usr/src/sys/PORT47 amd64 >Description: Geom doesn't derive the correct name for default logical volumes in the default fedora 11 layout, which are named lv_root and lv_swap. The problem is that isalpha doesn't include underscore. >How-To-Repeat: Try to mount a linux lvm whose name contains an underscore. >Fix: --- g_linux_lvm.c (revision 194560) +++ g_linux_lvm.c (working copy) @@ -828,7 +828,8 @@ #define GRAB_NAME(tok, name, len) \ len = 0; \ - while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len])) && \ + while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len]) || \ + tok[len] == '_' ) && \ len < G_LLVM_NAMELEN - 1) \ len++; \ bcopy(tok, name, len); \ >Release-Note: >Audit-Trail: >Unformatted: