From owner-freebsd-current@FreeBSD.ORG Sun Nov 15 05:04:54 2009 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1C09106566B for ; Sun, 15 Nov 2009 05:04:54 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 577CB8FC19 for ; Sun, 15 Nov 2009 05:04:54 +0000 (UTC) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id E81AD55CD9A5; Sun, 15 Nov 2009 13:04:52 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id szGwq23nWvUK; Sun, 15 Nov 2009 13:04:47 +0800 (CST) Received: from delta.delphij.net (c-69-181-136-105.hsd1.ca.comcast.net [69.181.136.105]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 55DE855CD994; Sun, 15 Nov 2009 13:04:45 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=m9DMNxE21RCel8KH50J+zUivQwlKbzQ7sY1fs5krlcIYobYjjg84PBXbhbzRdvhEE hgTOCZI91+oEt7anKaAFQ== Message-ID: <4AFF8BE9.9000003@delphij.net> Date: Sat, 14 Nov 2009 21:04:41 -0800 From: Xin LI Organization: The Geek China Organization User-Agent: Thunderbird 2.0.0.23 (X11/20091022) MIME-Version: 1.0 To: Jilles Tjoelker References: <200911090237.nA92b2m7005471__19254.880565177$1257734275$gmane$org@svn.freebsd.org> <867htvhygy.fsf@gmail.com> <4AFDDEA1.70900@delphij.net> <4AFDE27F.1070406@delphij.net> <4AFDEB70.5080807@delphij.net> <20091114130524.GA35115@stack.nl> In-Reply-To: <20091114130524.GA35115@stack.nl> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anonymous , freebsd-current@FreeBSD.ORG, d@delphij.net, matthew green Subject: Re: svn commit: r199066 - head/usr.bin/gzip X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2009 05:04:54 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jilles Tjoelker wrote: > On Fri, Nov 13, 2009 at 03:27:44PM -0800, Xin LI wrote: >> The previous fix has introduced an issue that revealed another bug as >> well (gzip -d -c can't decompress large-ish input stream, i.e. something >> like bzip2 -c ObsoleteFiles.inc | gunzip -d -c). The proposed patch: > >> * Set end_of_file flag if we hit a short read. This usually saves one >> read after the actual end of file. > > A short read does not necessarily mean EOF on a pipe or other > non-regular file. Yes you're right, what we really need is to distinguish between an non-existent end of file and a real short read. I'll see if I would have some other alternatives. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAkr/i+kACgkQi+vbBBjt66BqvQCgokChJF0RLKP/v1R7dNaWbtcP wAMAn29dHIxhGRwqI0IEjZhIIwxbT63X =g18V -----END PGP SIGNATURE-----