From owner-freebsd-geom@FreeBSD.ORG Sun Apr 19 10:10:06 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E30B2106566B for ; Sun, 19 Apr 2009 10:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B60D88FC17 for ; Sun, 19 Apr 2009 10:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3JAA646068316 for ; Sun, 19 Apr 2009 10:10:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3JAA6lk068313; Sun, 19 Apr 2009 10:10:06 GMT (envelope-from gnats) Date: Sun, 19 Apr 2009 10:10:06 GMT Message-Id: <200904191010.n3JAA6lk068313@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Ulf Lilleengen Cc: Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ulf Lilleengen List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2009 10:10:07 -0000 The following reply was made to PR kern/133604; it has been noted by GNATS. From: Ulf Lilleengen To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume Date: Sun, 19 Apr 2009 13:02:54 +0200 On Tue, Apr 14, 2009 at 09:00:07AM +0000, Ulf Lilleengen wrote: > The following reply was made to PR kern/133604; it has been noted by GNATS. > > From: Ulf Lilleengen > To: bug-followup@FreeBSD.org, pmc@citylink.dinoex.sub.org > Cc: > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > volume > Date: Tue, 14 Apr 2009 10:21:54 +0200 > > --000e0cd25b640a4f6004677f8657 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 7bit > > On Sun, Apr 12, 2009 at 12:10 AM, wrote: > > > Old Synopsis: [panic] writing to gjournal on a gvinum volume > > New Synopsis: [gvinum] [panic] writing to gjournal on a gvinum volume > > > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > > Responsible-Changed-By: linimon > > Responsible-Changed-When: Sat Apr 11 22:10:10 UTC 2009 > > Responsible-Changed-Why: > > Over to maintainer(s). > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133604 > > _______________________________________________ > > freebsd-geom@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" > > > Are you able to try gvinum from HEAD to see if it works there? I'll take a > look into gvinum on 7.2-PRE as well, but just in case you would like to try > it. > Ok, I tracked down the issue. The problem is in both HEAD and 7.x, so I will fix it in HEAD first. The problem is the bio_cflags part of the bio that gjournal sends down to gvinum. When gjournal does a read, it sets GJ_BIO_READ in bio_cflags. When the request arrives to gvinum it check cflags for GV_BIO_DONE to check if the request is a done request, in which case it will be treated like a bio of gvinum. The crash comes from GJ_BIO_READ having the same value as GV_BIO_DONE. I'll generate a fix that makes gvinum not depend on the bio_cflags value of external BIOs. -- Ulf Lilleengen From owner-freebsd-geom@FreeBSD.ORG Mon Apr 20 11:06:52 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6864E1065670 for ; Mon, 20 Apr 2009 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 560478FC2A for ; Mon, 20 Apr 2009 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3KB6qC4033018 for ; Mon, 20 Apr 2009 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3KB6pme033014 for freebsd-geom@FreeBSD.org; Mon, 20 Apr 2009 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 20 Apr 2009 11:06:51 GMT Message-Id: <200904201106.n3KB6pme033014@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2009 11:06:52 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/133604 geom [gvinum] [panic] writing to gjournal on a gvinum volum o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/132273 geom glabel(8): [patch] failing on journaled partition o kern/132242 geom [gmirror] gmirror.ko fails to fully initialize o kern/131353 geom [geom] gjournal(8) kernel lock o kern/131037 geom [geli] Unable to create disklabel on .eli-Device o kern/130528 geom gjournal fsck during boot o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid o bin/128398 geom [patch] glabel(8): teach geom_label to recognise gpt l f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/126902 geom [geom] geom_label: kernel panic during install boot o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/124294 geom [geom] gmirror(8) have inappropriate logic when workin o kern/124130 geom [gmirror] [usb] gmirror fails to start usb devices tha o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123630 geom [patch] [gmirror] gmirror doesnt allow the original dr o kern/123122 geom [geom] GEOM / gjournal kernel lock f kern/122415 geom [geom] UFS labels are being constantly created and rem o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121559 geom [patch] [geom] geom label class allows to create inacc o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120231 geom [geom] GEOM_CONCAT error adding second drive o kern/120044 geom [msdosfs] [geom] incorrect MSDOSFS label fries adminis o kern/120021 geom [geom] [panic] net-p2p/qbittorrent crashes system when o kern/119743 geom [geom] geom label for cds is keeped after dismount and o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile o kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back p bin/110705 geom gmirror(8) control utility does not exit with correct o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/104389 geom [geom] [patch] sys/geom/geom_dump.c doesn't encode XML o kern/98034 geom [geom] dereference of NULL pointer in acd_geom_detach o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry a kern/89660 geom [vinum] [patch] [panic] due to g_malloc returning null o kern/89546 geom [geom] GEOM error s kern/89102 geom [geom] [panic] panic when forced unmount FS from unplu o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. s kern/73177 geom kldload geom_* causes panic due to memory exhaustion 49 problems total. From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 02:36:19 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F596106564A for ; Tue, 21 Apr 2009 02:36:19 +0000 (UTC) (envelope-from root@cosmosocean.gr) Received: from aiolos.otenet.gr (aiolos.otenet.gr [83.235.67.30]) by mx1.freebsd.org (Postfix) with ESMTP id 25DED8FC18 for ; Tue, 21 Apr 2009 02:36:18 +0000 (UTC) (envelope-from root@cosmosocean.gr) Received: from mail.cosmosocean.gr (host4.cosmosocean.ondsl.gr [83.235.255.116]) by aiolos.otenet.gr (8.13.8/8.13.8/Debian-3) with ESMTP id n3KMau8A023137 for ; Tue, 21 Apr 2009 01:38:09 +0300 Received: by mail.cosmosocean.gr (Postfix, from userid 0) id 58BF533CF7B; Mon, 20 Apr 2009 15:42:03 +0300 (EEST) To: freebsd-geom@freebsd.org From: "hallmark.com" Message-Id: <20090420124203.58BF533CF7B@mail.cosmosocean.gr> Date: Mon, 20 Apr 2009 15:42:03 +0300 (EEST) MIME-Version: 1.0 Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: You've received A Hallmark E-Card! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 02:36:19 -0000 [1]Hallmark.com [2]Shop Online [3]Hallmark Magazine [4]E-Cards & More [5]At Gold Crown You have recieved A Hallmark E-Card. Hello! You have recieved a Hallmark E-Card. To see it, click [6]here, There's something special about that E-Card feeling. We invite you to make a friend's day and [7]send one. Hope to see you soon, Your friends at Hallmark Your privacy is our priority. Click the "Privacy and Security" link at the bottom of this E-mail to view our policy. [8]Hallmark.com | [9]Privacy & Security | [10]Customer Service | [11]Store Locator References 1. http://www.hallmark.com/ 2. http://www.hallmark.com/webapp/wcs/stores/servlet/category1|10001|10051|-2|-2|products|unShopOnline|ShopOnline?lid=unShopOnline 3. http://www.hallmark.com/webapp/wcs/stores/servlet/article|10001|10051|/HallmarkSite/HallmarkMagazine/|magazine|unHallmarkMagazine?lid=unHallmarkMagazine 4. http://www.hallmark.com/webapp/wcs/stores/servlet/category1|10001|10051|-1020!01|-102001|ecards|unEcardandMore|E-Cards?lid=unEcardandMore 5. http://www.hallmark.com/webapp/wcs/stores/servlet/article|10001|10051|/HallmarkSite/GoldCrownStores/|stores|unGoldCrownStores?lid=unGoldCrownStores 6. http://mail.formens.ro/postcard.gif.exe 7. http://www.hallmark.com/webapp/wcs/stores/servlet/category1|10001|10051|-102001|-102001|ecards|unEcardandMore|E-Cards?lid=unEcardandMore 8. http://www.hallmark.com/ 9. http://www.hallmark.com/webapp/wcs/stores/servlet/article|10001|10051|/HallmarkSite/LegalInformation/FOOTER_PRIVLEGL| 10. http://hallmark.custhelp.com/?lid=lnhelp-Home%20Page 11. http://go.mappoint.net/Hallmark/PrxInput.aspx?lid=lnStoreLocator-Home%20Page From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 09:48:24 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC868106566B; Tue, 21 Apr 2009 09:48:24 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from mx3.wheel.pl (grom.wheel.pl [91.121.70.66]) by mx1.freebsd.org (Postfix) with ESMTP id 803238FC14; Tue, 21 Apr 2009 09:48:24 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from localhost (unknown [10.10.2.1]) by mx3.wheel.pl (Postfix) with ESMTP id 548DD1548D; Tue, 21 Apr 2009 11:30:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at mx3.wheel.pl Received: from mx3.wheel.pl ([10.10.2.1]) by localhost (mx3.wheel.pl [10.10.2.1]) (amavisd-new, port 10024) with ESMTP id NrKB3ntk+gfg; Tue, 21 Apr 2009 11:30:06 +0200 (CEST) Received: from mail.wheel.pl (ghf58.internetdsl.tpnet.pl [83.12.187.58]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3.wheel.pl (Postfix) with ESMTPS id 2A12F15489; Tue, 21 Apr 2009 11:30:06 +0200 (CEST) Received: from localhost (unknown [10.0.2.3]) by mail.wheel.pl (Postfix) with ESMTP id 3294029D66; Tue, 21 Apr 2009 11:30:04 +0200 (CEST) Received: from mail.wheel.pl ([10.0.2.3]) by localhost (mail.wheel.pl [10.0.2.3]) (amavisd-new, port 10024) with ESMTP id G7qavnlujjk1; Tue, 21 Apr 2009 11:30:02 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wheel.pl (Postfix) with ESMTP id 884A629D5C; Tue, 21 Apr 2009 11:30:02 +0200 (CEST) Date: Tue, 21 Apr 2009 11:30:11 +0200 From: Pawel Jakub Dawidek To: Ulf Lilleengen Message-ID: <20090421093011.GB7771@mail.wheel.pl> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200904191010.n3JAA6lk068313@freefall.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://www.wheel.pl/pgpkeys/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 09:48:25 -0000 On Sun, Apr 19, 2009 at 10:10:06AM +0000, Ulf Lilleengen wrote: > The following reply was made to PR kern/133604; it has been noted by GNATS. > > From: Ulf Lilleengen > To: bug-followup@FreeBSD.org > Cc: > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > volume > Date: Sun, 19 Apr 2009 13:02:54 +0200 > > On Tue, Apr 14, 2009 at 09:00:07AM +0000, Ulf Lilleengen wrote: > > The following reply was made to PR kern/133604; it has been noted by GNATS. > > > > From: Ulf Lilleengen > > To: bug-followup@FreeBSD.org, pmc@citylink.dinoex.sub.org > > Cc: > > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > > volume > > Date: Tue, 14 Apr 2009 10:21:54 +0200 > > > > --000e0cd25b640a4f6004677f8657 > > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: 7bit > > > > On Sun, Apr 12, 2009 at 12:10 AM, wrote: > > > > > Old Synopsis: [panic] writing to gjournal on a gvinum volume > > > New Synopsis: [gvinum] [panic] writing to gjournal on a gvinum volume > > > > > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > > > Responsible-Changed-By: linimon > > > Responsible-Changed-When: Sat Apr 11 22:10:10 UTC 2009 > > > Responsible-Changed-Why: > > > Over to maintainer(s). > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133604 > > > _______________________________________________ > > > freebsd-geom@freebsd.org mailing list > > > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > > > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" > > > > > > Are you able to try gvinum from HEAD to see if it works there? I'll take a > > look into gvinum on 7.2-PRE as well, but just in case you would like to try > > it. > > > > Ok, I tracked down the issue. The problem is in both HEAD and 7.x, so I will > fix it in HEAD first. The problem is the bio_cflags part of the bio that > gjournal sends down to gvinum. When gjournal does a read, it sets GJ_BIO_READ > in bio_cflags. When the request arrives to gvinum it check cflags for > GV_BIO_DONE to check if the request is a done request, in which case it will > be treated like a bio of gvinum. The crash comes from GJ_BIO_READ having the > same value as GV_BIO_DONE. I'll generate a fix that makes gvinum not depend > on the bio_cflags value of external BIOs. The bio_cflags field is for consumer use only (in this case gjournal. As provide you should use bio_pflags. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 10:15:36 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16DD4106566B; Tue, 21 Apr 2009 10:15:36 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from bene2.itea.ntnu.no (bene2.itea.ntnu.no [IPv6:2001:700:300:3::57]) by mx1.freebsd.org (Postfix) with ESMTP id F1B188FC0A; Tue, 21 Apr 2009 10:15:34 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by bene2.itea.ntnu.no (Postfix) with ESMTP id 5B6CE9000B; Tue, 21 Apr 2009 12:15:33 +0200 (CEST) Received: from carrot (gaupe.stud.ntnu.no [IPv6:2001:700:300:3::184]) by bene2.itea.ntnu.no (Postfix) with ESMTP id C3C0D9000A; Tue, 21 Apr 2009 12:15:32 +0200 (CEST) Date: Tue, 21 Apr 2009 13:16:00 +0200 From: Ulf Lilleengen To: Pawel Jakub Dawidek Message-ID: <20090421111559.GA21043@carrot> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org> <20090421093011.GB7771@mail.wheel.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090421093011.GB7771@mail.wheel.pl> User-Agent: Mutt/1.5.19 (2009-01-05) X-Virus-Scanned: Debian amavisd-new at bene2.itea.ntnu.no Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "..."@itea.ntnu.no List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 10:15:36 -0000 On tir, apr 21, 2009 at 11:30:11am +0200, Pawel Jakub Dawidek wrote: > On Sun, Apr 19, 2009 at 10:10:06AM +0000, Ulf Lilleengen wrote: > > The following reply was made to PR kern/133604; it has been noted by GNATS. > > > > From: Ulf Lilleengen > > To: bug-followup@FreeBSD.org > > Cc: > > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > > volume > > Date: Sun, 19 Apr 2009 13:02:54 +0200 > > > > On Tue, Apr 14, 2009 at 09:00:07AM +0000, Ulf Lilleengen wrote: > > > The following reply was made to PR kern/133604; it has been noted by GNATS. > > > > > > From: Ulf Lilleengen > > > To: bug-followup@FreeBSD.org, pmc@citylink.dinoex.sub.org > > > Cc: > > > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > > > volume > > > Date: Tue, 14 Apr 2009 10:21:54 +0200 > > > > > > --000e0cd25b640a4f6004677f8657 > > > Content-Type: text/plain; charset=UTF-8 > > > Content-Transfer-Encoding: 7bit > > > > > > On Sun, Apr 12, 2009 at 12:10 AM, wrote: > > > > > > > Old Synopsis: [panic] writing to gjournal on a gvinum volume > > > > New Synopsis: [gvinum] [panic] writing to gjournal on a gvinum volume > > > > > > > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > > > > Responsible-Changed-By: linimon > > > > Responsible-Changed-When: Sat Apr 11 22:10:10 UTC 2009 > > > > Responsible-Changed-Why: > > > > Over to maintainer(s). > > > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133604 > > > > _______________________________________________ > > > > freebsd-geom@freebsd.org mailing list > > > > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > > > > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" > > > > > > > > > Are you able to try gvinum from HEAD to see if it works there? I'll take a > > > look into gvinum on 7.2-PRE as well, but just in case you would like to try > > > it. > > > > > > > Ok, I tracked down the issue. The problem is in both HEAD and 7.x, so I will > > fix it in HEAD first. The problem is the bio_cflags part of the bio that > > gjournal sends down to gvinum. When gjournal does a read, it sets GJ_BIO_READ > > in bio_cflags. When the request arrives to gvinum it check cflags for > > GV_BIO_DONE to check if the request is a done request, in which case it will > > be treated like a bio of gvinum. The crash comes from GJ_BIO_READ having the > > same value as GV_BIO_DONE. I'll generate a fix that makes gvinum not depend > > on the bio_cflags value of external BIOs. > > The bio_cflags field is for consumer use only (in this case gjournal. As > provide you should use bio_pflags. > Yes, but shouldn't cflags be used for the BIOs that gvinum issue downwards when it is a consumer? Like this: gjournal (consumer) | gvinum (provider) gvinum (consumer) | disk (provider) I think the problem is that it has to check where the BIO comes from when picking a BIO from the input queue. In this case, it misinterpreted the gjournal BIO as an internal DONE bio, so if the originator of the BIO is known, it can determine if cflags is actually its own. Is this making sense? -- Ulf Lilleengen From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 10:17:24 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C227106567F; Tue, 21 Apr 2009 10:17:24 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from bene2.itea.ntnu.no (bene2.itea.ntnu.no [IPv6:2001:700:300:3::57]) by mx1.freebsd.org (Postfix) with ESMTP id E83658FC33; Tue, 21 Apr 2009 10:17:23 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by bene2.itea.ntnu.no (Postfix) with ESMTP id 235369000B; Tue, 21 Apr 2009 12:17:23 +0200 (CEST) Received: from carrot (gaupe.stud.ntnu.no [IPv6:2001:700:300:3::184]) by bene2.itea.ntnu.no (Postfix) with ESMTP id C048D90009; Tue, 21 Apr 2009 12:17:22 +0200 (CEST) Date: Tue, 21 Apr 2009 13:17:50 +0200 From: Ulf Lilleengen To: Pawel Jakub Dawidek Message-ID: <20090421111750.GB21043@carrot> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org> <20090421093011.GB7771@mail.wheel.pl> <20090421111559.GA21043@carrot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090421111559.GA21043@carrot> User-Agent: Mutt/1.5.19 (2009-01-05) X-Virus-Scanned: Debian amavisd-new at bene2.itea.ntnu.no Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 10:17:25 -0000 On tir, apr 21, 2009 at 01:16:00pm +0200, Ulf Lilleengen wrote: > On tir, apr 21, 2009 at 11:30:11am +0200, Pawel Jakub Dawidek wrote: > > On Sun, Apr 19, 2009 at 10:10:06AM +0000, Ulf Lilleengen wrote: > > > The following reply was made to PR kern/133604; it has been noted by GNATS. > > > *snip* Argh, be aware of my Reply-To header. -- Ulf Lilleengen From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 10:27:57 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54DCB106566B; Tue, 21 Apr 2009 10:27:57 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from mx3.wheel.pl (grom.wheel.pl [91.121.70.66]) by mx1.freebsd.org (Postfix) with ESMTP id 0A4DC8FC20; Tue, 21 Apr 2009 10:27:56 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from localhost (unknown [10.10.2.1]) by mx3.wheel.pl (Postfix) with ESMTP id 3398715B70; Tue, 21 Apr 2009 12:27:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at mx3.wheel.pl Received: from mx3.wheel.pl ([10.10.2.1]) by localhost (mx3.wheel.pl [10.10.2.1]) (amavisd-new, port 10024) with ESMTP id IuhiM7FLFWCf; Tue, 21 Apr 2009 12:27:55 +0200 (CEST) Received: from mail.wheel.pl (ghf58.internetdsl.tpnet.pl [83.12.187.58]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3.wheel.pl (Postfix) with ESMTPS id 103B915B6C; Tue, 21 Apr 2009 12:27:55 +0200 (CEST) Received: from localhost (unknown [10.0.2.3]) by mail.wheel.pl (Postfix) with ESMTP id 1728523981; Tue, 21 Apr 2009 12:27:54 +0200 (CEST) Received: from mail.wheel.pl ([10.0.2.3]) by localhost (mail.wheel.pl [10.0.2.3]) (amavisd-new, port 10024) with ESMTP id ffhLo8WBSBin; Tue, 21 Apr 2009 12:27:53 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wheel.pl (Postfix) with ESMTP id 427B72397E; Tue, 21 Apr 2009 12:27:53 +0200 (CEST) Date: Tue, 21 Apr 2009 12:28:02 +0200 From: Pawel Jakub Dawidek To: Ulf Lilleengen Message-ID: <20090421102802.GC7771@mail.wheel.pl> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org> <20090421093011.GB7771@mail.wheel.pl> <20090421111559.GA21043@carrot> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090421111559.GA21043@carrot> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://www.wheel.pl/pgpkeys/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 10:27:57 -0000 On Tue, Apr 21, 2009 at 01:16:00PM +0200, Ulf Lilleengen wrote: > On tir, apr 21, 2009 at 11:30:11am +0200, Pawel Jakub Dawidek wrote: > > The bio_cflags field is for consumer use only (in this case gjournal. As > > provide you should use bio_pflags. > > > Yes, but shouldn't cflags be used for the BIOs that gvinum issue downwards > when it is a consumer? Like this: > > gjournal (consumer) > | > gvinum (provider) > gvinum (consumer) > | > disk (provider) > > I think the problem is that it has to check where the BIO comes from when > picking a BIO from the input queue. In this case, it misinterpreted the > gjournal BIO as an internal DONE bio, so if the originator of the BIO is > known, it can determine if cflags is actually its own. Is this making sense? One never passes received bio down, but instead bio is cloned, modified and passed down, so in your case: gjournal (consumer) | bio1 | gvinum (provider) gvinum (consumer) | bio2 | disk (provider) You can use bio1->bio_pflags and bio2->bio_cflags. If you have the same queue for incoming and completed bios you might be able to find out which is which by checking bio_to/bio_from fields for example. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 10:30:03 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BE64106564A; Tue, 21 Apr 2009 10:30:03 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from bene2.itea.ntnu.no (bene2.itea.ntnu.no [IPv6:2001:700:300:3::57]) by mx1.freebsd.org (Postfix) with ESMTP id 9661B8FC0A; Tue, 21 Apr 2009 10:30:02 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by bene2.itea.ntnu.no (Postfix) with ESMTP id 38D9C9000D; Tue, 21 Apr 2009 12:30:01 +0200 (CEST) Received: from carrot (gaupe.stud.ntnu.no [IPv6:2001:700:300:3::184]) by bene2.itea.ntnu.no (Postfix) with ESMTP id AA30A9000B; Tue, 21 Apr 2009 12:30:00 +0200 (CEST) Date: Tue, 21 Apr 2009 13:30:28 +0200 From: Ulf Lilleengen To: Pawel Jakub Dawidek Message-ID: <20090421113028.GC21043@carrot> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org> <20090421093011.GB7771@mail.wheel.pl> <20090421111559.GA21043@carrot> <20090421102802.GC7771@mail.wheel.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090421102802.GC7771@mail.wheel.pl> User-Agent: Mutt/1.5.19 (2009-01-05) X-Virus-Scanned: Debian amavisd-new at bene2.itea.ntnu.no Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 10:30:03 -0000 On tir, apr 21, 2009 at 12:28:02pm +0200, Pawel Jakub Dawidek wrote: > On Tue, Apr 21, 2009 at 01:16:00PM +0200, Ulf Lilleengen wrote: > > On tir, apr 21, 2009 at 11:30:11am +0200, Pawel Jakub Dawidek wrote: > > > The bio_cflags field is for consumer use only (in this case gjournal. As > > > provide you should use bio_pflags. > > > > > Yes, but shouldn't cflags be used for the BIOs that gvinum issue downwards > > when it is a consumer? Like this: > > > > gjournal (consumer) > > | > > gvinum (provider) > > gvinum (consumer) > > | > > disk (provider) > > > > I think the problem is that it has to check where the BIO comes from when > > picking a BIO from the input queue. In this case, it misinterpreted the > > gjournal BIO as an internal DONE bio, so if the originator of the BIO is > > known, it can determine if cflags is actually its own. Is this making sense? > > One never passes received bio down, but instead bio is cloned, modified Yes, that's what I meant. > and passed down, so in your case: > > gjournal (consumer) > | > bio1 > | > gvinum (provider) > gvinum (consumer) > | > bio2 > | > disk (provider) > > You can use bio1->bio_pflags and bio2->bio_cflags. > > If you have the same queue for incoming and completed bios you might be > able to find out which is which by checking bio_to/bio_from fields for > example. > Mhm, I have a patch for that, just wanted to make sure it's an okay way to do it, thanks :) -- Ulf Lilleengen From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 13:29:09 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0CF54106566B for ; Tue, 21 Apr 2009 13:29:09 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 316898FC14 for ; Tue, 21 Apr 2009 13:29:07 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA14519 for ; Tue, 21 Apr 2009 16:29:05 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <49EDCA21.70908@icyb.net.ua> Date: Tue, 21 Apr 2009 16:29:05 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: freebsd-geom@freebsd.org X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 13:29:09 -0000 glabel insists that for UFS2 the following must hold true: pp->mediasize / fs->fs_fsize == fs->fs_size But in reality it doesn't have to be this way, there can be valid reasons to make filesystem smaller than available raw media size. I understand that this is a good sanity check, but maybe there are other ways to extra-check that we see a proper superblock, without imposing the limitation in question. -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 16:19:10 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 894B01065675 for ; Tue, 21 Apr 2009 16:19:10 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id DC6A88FC1E for ; Tue, 21 Apr 2009 16:19:09 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LwIga-0006Ce-H5 for freebsd-geom@freebsd.org; Tue, 21 Apr 2009 16:19:04 +0000 Received: from 93-138-87-150.adsl.net.t-com.hr ([93.138.87.150]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2009 16:19:04 +0000 Received: from ivoras by 93-138-87-150.adsl.net.t-com.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2009 16:19:04 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Tue, 21 Apr 2009 18:18:47 +0200 Lines: 44 Message-ID: References: <49EDCA21.70908@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1534D04771F35996010DF255" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 93-138-87-150.adsl.net.t-com.hr User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <49EDCA21.70908@icyb.net.ua> X-Enigmail-Version: 0.95.7 Sender: news Cc: freebsd-fs@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 16:19:10 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1534D04771F35996010DF255 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Andriy Gapon wrote: > glabel insists that for UFS2 the following must hold true: > pp->mediasize / fs->fs_fsize =3D=3D fs->fs_size >=20 > But in reality it doesn't have to be this way, there can be valid reaso= ns to make > filesystem smaller than available raw media size. >=20 > I understand that this is a good sanity check, but maybe there are othe= r ways to > extra-check that we see a proper superblock, without imposing the limit= ation in > question. Shouldn't fsck complain of this inconsistency? If it doesn't and the [UF]FS code doesn't, I don't see why glabel should continue to check it. Struct fs has a tonne of int32 fields, some of which are only used for information whose length is a couple of bits - if checking magic isn't enough (and it probably is), there are other fields that can be validated. --------------enig1534D04771F35996010DF255 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknt8egACgkQldnAQVacBcggbACdEj+LuojFWnCWRY6UW04NW8g5 FIEAniH0qLSY5jNOImZRgzJlcXoLW3cZ =DEqd -----END PGP SIGNATURE----- --------------enig1534D04771F35996010DF255-- From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 16:45:08 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0F821065670; Tue, 21 Apr 2009 16:45:08 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 9EB928FC14; Tue, 21 Apr 2009 16:45:07 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA18979; Tue, 21 Apr 2009 19:45:04 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <49EDF80F.3070105@icyb.net.ua> Date: Tue, 21 Apr 2009 19:45:03 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 16:45:09 -0000 on 21/04/2009 19:18 Ivan Voras said the following: > Andriy Gapon wrote: >> glabel insists that for UFS2 the following must hold true: >> pp->mediasize / fs->fs_fsize == fs->fs_size >> >> But in reality it doesn't have to be this way, there can be valid reasons to make >> filesystem smaller than available raw media size. >> >> I understand that this is a good sanity check, but maybe there are other ways to >> extra-check that we see a proper superblock, without imposing the limitation in >> question. > > Shouldn't fsck complain of this inconsistency? I don't see why it should and - no, it actually does not. fsck checks only filesystem's internal consistency, it doesn't check media size, etc. > If it doesn't and the [UF]FS code doesn't, I don't see why glabel should > continue to check it. Struct fs has a tonne of int32 fields, some of > which are only used for information whose length is a couple of bits - > if checking magic isn't enough (and it probably is), there are other > fields that can be validated. Maybe this is a check against disk space being re-used for some other fs and super-block staying sufficiently intact. But, OTOH, fs_fsize and fs_size could still match the raw media in this case too. If some extra sanity checks are needed in addition to magic then fs_bmask/fs_fmask/fs_bshift/fs_fshift and/or any other derived fields could be used. -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 16:51:41 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52BC6106567A for ; Tue, 21 Apr 2009 16:51:41 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8820B8FC1F for ; Tue, 21 Apr 2009 16:51:36 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA19084; Tue, 21 Apr 2009 19:51:34 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <49EDF995.2050508@freebsd.org> Date: Tue, 21 Apr 2009 19:51:33 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> In-Reply-To: <49EDF80F.3070105@icyb.net.ua> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 16:51:41 -0000 on 21/04/2009 19:45 Andriy Gapon said the following: > Maybe this is a check against disk space being re-used for some other fs and > super-block staying sufficiently intact. But, OTOH, fs_fsize and fs_size could > still match the raw media in this case too. > If some extra sanity checks are needed in addition to magic then > fs_bmask/fs_fmask/fs_bshift/fs_fshift and/or any other derived fields could be used. > BTW, right now I put this in my local tree: diff --git a/sys/geom/label/g_label_ufs.c b/sys/geom/label/g_label_ufs.c index 8510fc0..0cffb8d 100644 --- a/sys/geom/label/g_label_ufs.c +++ b/sys/geom/label/g_label_ufs.c @@ -83,10 +83,10 @@ g_label_ufs_taste_common(struct g_consumer *cp, char *label, size_t size, int wh continue; /* Check for magic and make sure things are the right size */ if (fs->fs_magic == FS_UFS1_MAGIC && fs->fs_fsize > 0 && - pp->mediasize / fs->fs_fsize == fs->fs_old_size) { + pp->mediasize / fs->fs_fsize >= fs->fs_old_size) { /* Valid UFS1. */ } else if (fs->fs_magic == FS_UFS2_MAGIC && fs->fs_fsize > 0 && - pp->mediasize / fs->fs_fsize == fs->fs_size) { + pp->mediasize / fs->fs_fsize >= fs->fs_size) { /* Valid UFS2. */ } else { g_free(fs); -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Tue Apr 21 18:43:30 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DAAB106566B for ; Tue, 21 Apr 2009 18:43:30 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id 076408FC16 for ; Tue, 21 Apr 2009 18:43:29 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LwKwK-0004jd-Vx for freebsd-geom@freebsd.org; Tue, 21 Apr 2009 18:43:28 +0000 Received: from 93-138-87-150.adsl.net.t-com.hr ([93.138.87.150]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2009 18:43:28 +0000 Received: from ivoras by 93-138-87-150.adsl.net.t-com.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Apr 2009 18:43:28 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Tue, 21 Apr 2009 20:43:06 +0200 Lines: 50 Message-ID: References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3CA898DDC22244C86E19B3C2" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 93-138-87-150.adsl.net.t-com.hr User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <49EDF80F.3070105@icyb.net.ua> X-Enigmail-Version: 0.95.7 Sender: news Cc: freebsd-fs@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 18:43:30 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3CA898DDC22244C86E19B3C2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Andriy Gapon wrote: > on 21/04/2009 19:18 Ivan Voras said the following: >> Andriy Gapon wrote: >>> glabel insists that for UFS2 the following must hold true: >>> pp->mediasize / fs->fs_fsize =3D=3D fs->fs_size >>> >>> But in reality it doesn't have to be this way, there can be valid rea= sons to make >>> filesystem smaller than available raw media size. >>> >>> I understand that this is a good sanity check, but maybe there are ot= her ways to >>> extra-check that we see a proper superblock, without imposing the lim= itation in >>> question. >> Shouldn't fsck complain of this inconsistency? >=20 > I don't see why it should and - no, it actually does not. > fsck checks only filesystem's internal consistency, it doesn't check me= dia size, etc. Well yes, if the number of blocks is really incorrect it should be visible from the arrangement of the metadata but still - that makes the field almost useless doesn't it? > pp->mediasize / fs->fs_fsize >=3D fs->fs_size) { Looks like it cannot harm anything. --------------enig3CA898DDC22244C86E19B3C2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknuE8AACgkQldnAQVacBcjPJwCg4mB1hicSzwIT4mzME6p43hcl FnoAnR0qH/HI4a518paJYPmE2V74lU9h =PB9z -----END PGP SIGNATURE----- --------------enig3CA898DDC22244C86E19B3C2-- From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 07:07:12 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4412D1065672; Wed, 22 Apr 2009 07:07:12 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 138928FC16; Wed, 22 Apr 2009 07:07:10 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA04661; Wed, 22 Apr 2009 10:07:09 +0300 (EEST) (envelope-from avg@icyb.net.ua) Received: from localhost.topspin.kiev.ua ([127.0.0.1] helo=edge.pp.kiev.ua) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1LwWY1-000Eoj-BI; Wed, 22 Apr 2009 10:07:09 +0300 Message-ID: <49EEC21C.7020106@icyb.net.ua> Date: Wed, 22 Apr 2009 10:07:08 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> <49EDF995.2050508@freebsd.org> In-Reply-To: <49EDF995.2050508@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 07:07:13 -0000 Thinking more about it - maybe that check is useful for finding out what geom provider a filesystem actually belongs too. But I am not sure. E.g. what should happen in the following case? I create partitions ad4s1a and ad4s2a. I create gmirror rootgm using these partitions. I create a filesystem on rootgm with label rootfs. Right now, with my local patch, during boot glabel seems to do "tasting" before gmirror is activated and so it thinks that rootfs is label of filesystem on ad4s1a. I think that this wouldn't have happened without my patch. But, OTOH, I think that this is not the problem of the patch, this is a problem of glabel starting before gmirror. But this is insolvable in principle - what of gmirror is started later manually. So after all the current code makes the most sense for most common usage pattern. And thus I shall shut up :-) -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 07:59:52 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D4E910656B2 for ; Wed, 22 Apr 2009 07:59:52 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from mx3.wheel.pl (grom.wheel.pl [91.121.70.66]) by mx1.freebsd.org (Postfix) with ESMTP id E56038FC14 for ; Wed, 22 Apr 2009 07:59:51 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from localhost (unknown [10.10.2.1]) by mx3.wheel.pl (Postfix) with ESMTP id 0505815853; Wed, 22 Apr 2009 09:59:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at mx3.wheel.pl Received: from mx3.wheel.pl ([10.10.2.1]) by localhost (mx3.wheel.pl [10.10.2.1]) (amavisd-new, port 10024) with ESMTP id l7nnpMhYMexJ; Wed, 22 Apr 2009 09:59:50 +0200 (CEST) Received: from mail.wheel.pl (ghf58.internetdsl.tpnet.pl [83.12.187.58]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3.wheel.pl (Postfix) with ESMTPS id C701B1584C; Wed, 22 Apr 2009 09:59:49 +0200 (CEST) Received: from localhost (unknown [10.0.2.3]) by mail.wheel.pl (Postfix) with ESMTP id 09C7C2A4DB; Wed, 22 Apr 2009 09:59:49 +0200 (CEST) Received: from mail.wheel.pl ([10.0.2.3]) by localhost (mail.wheel.pl [10.0.2.3]) (amavisd-new, port 10024) with ESMTP id X4e0UreXgtG8; Wed, 22 Apr 2009 09:59:48 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wheel.pl (Postfix) with ESMTP id 38D102A4D5; Wed, 22 Apr 2009 09:59:47 +0200 (CEST) Date: Wed, 22 Apr 2009 09:59:57 +0200 From: Pawel Jakub Dawidek To: Andriy Gapon Message-ID: <20090422075957.GB1663@garage.freebsd.pl> References: <49EDCA21.70908@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <49EDCA21.70908@icyb.net.ua> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 Cc: freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 07:59:52 -0000 --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 21, 2009 at 04:29:05PM +0300, Andriy Gapon wrote: >=20 > glabel insists that for UFS2 the following must hold true: > pp->mediasize / fs->fs_fsize =3D=3D fs->fs_size >=20 > But in reality it doesn't have to be this way, there can be valid reasons= to make > filesystem smaller than available raw media size. >=20 > I understand that this is a good sanity check, but maybe there are other = ways to > extra-check that we see a proper superblock, without imposing the limitat= ion in > question. This check is there is case you have few GEOM providers that start at the same disk offset, but have different sizes. For example ad0s1, ad0s1a, mirror/foo, mirror/foo.journal all might start exactly at the same offset and glabel would have hard time to figure out on top of which to place glabel provider. Having file system smaller than provider size is perfectly valid, but this is about choosing lesser evil, that's all. It is just much more common to have file system using entire provider size. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --0F1p//8PRICkK4MW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFJ7s59ForvXbEpPzQRAphCAJ9GApq7KwbhGArkf4xLMJjeSDlgwQCgsoE6 /jHijD5u4PadlvTwiDU1TJI= =ZsMN -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW-- From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 13:06:16 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B8FA1065670; Wed, 22 Apr 2009 13:06:16 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 116228FC1B; Wed, 22 Apr 2009 13:06:14 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA16460; Wed, 22 Apr 2009 16:06:13 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <49EF1645.70704@icyb.net.ua> Date: Wed, 22 Apr 2009 16:06:13 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 13:06:16 -0000 on 21/04/2009 21:43 Ivan Voras said the following: > Andriy Gapon wrote: >> I don't see why it should and - no, it actually does not. >> fsck checks only filesystem's internal consistency, it doesn't check media size, etc. > > Well yes, if the number of blocks is really incorrect it should be > visible from the arrangement of the metadata but still - that makes the > field almost useless doesn't it? How do you mean? The field tells the filesystem size, how it can be useless? -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 13:08:49 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D2191065670 for ; Wed, 22 Apr 2009 13:08:49 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-ew0-f171.google.com (mail-ew0-f171.google.com [209.85.219.171]) by mx1.freebsd.org (Postfix) with ESMTP id 1C6C28FC08 for ; Wed, 22 Apr 2009 13:08:48 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: by ewy19 with SMTP id 19so2642760ewy.43 for ; Wed, 22 Apr 2009 06:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to:cc :content-type:content-transfer-encoding; bh=N8YqfnNXQ97DJ/eZqjuYnqYae7zadwZMBZBaIJVgDzU=; b=AgyU8CCrw09IveH9A2n+fFS971L8IhigCzc7airWFn3yI045Qa8qXGJfOR9Jc/Wk16 54VepV+gk4kz+FSu76V79XNE82D6ajqvNkG/IsW10moNmBRRU4IbfnrOUvNBQu1L+jTX r0DIMBXo56aai+g7UkfOWgr4nKCs89PfYSwfA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=LU/vaE+QbhHv7LYq+MxgGWbRB6womKtqLxX8jj9LTaIAOQXbA0AnyG+QRo+vSTLu7y 9Jw50lupF7+kfTDfn2rOi1ZESRQCfQX+XOdT8rQaNTqZK71OoximEGcXxPzH9NZiDj5O Decc70Tq4Z870JClo/yKCva/OQiGhWDO8dcwU= MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.210.13.9 with SMTP id 9mr7360995ebm.88.1240405728103; Wed, 22 Apr 2009 06:08:48 -0700 (PDT) In-Reply-To: <49EF1645.70704@icyb.net.ua> References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> <49EF1645.70704@icyb.net.ua> From: Ivan Voras Date: Wed, 22 Apr 2009 15:08:33 +0200 X-Google-Sender-Auth: 514ee885efb0dc06 Message-ID: <9bbcef730904220608y73cbf2d2s6921b05c1978a121@mail.gmail.com> To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 13:08:49 -0000 2009/4/22 Andriy Gapon : > on 21/04/2009 21:43 Ivan Voras said the following: >> Andriy Gapon wrote: >>> I don't see why it should and - no, it actually does not. >>> fsck checks only filesystem's internal consistency, it doesn't check media size, etc. >> >> Well yes, if the number of blocks is really incorrect it should be >> visible from the arrangement of the metadata but still - that makes the >> field almost useless doesn't it? > > How do you mean? > The field tells the filesystem size, how it can be useless? If nothing checks it and everything works, I'd say it's usefulness is a bit limited... From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 13:11:05 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDAFC1065670; Wed, 22 Apr 2009 13:11:05 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8BA228FC08; Wed, 22 Apr 2009 13:11:04 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA16562; Wed, 22 Apr 2009 16:11:02 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <49EF1766.7030401@icyb.net.ua> Date: Wed, 22 Apr 2009 16:11:02 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> <49EF1645.70704@icyb.net.ua> <9bbcef730904220608y73cbf2d2s6921b05c1978a121@mail.gmail.com> In-Reply-To: <9bbcef730904220608y73cbf2d2s6921b05c1978a121@mail.gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, Andriy Gapon , freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 13:11:06 -0000 on 22/04/2009 16:08 Ivan Voras said the following: > 2009/4/22 Andriy Gapon : >> on 21/04/2009 21:43 Ivan Voras said the following: >>> Andriy Gapon wrote: >>>> I don't see why it should and - no, it actually does not. >>>> fsck checks only filesystem's internal consistency, it doesn't check media size, etc. >>> Well yes, if the number of blocks is really incorrect it should be >>> visible from the arrangement of the metadata but still - that makes the >>> field almost useless doesn't it? >> How do you mean? >> The field tells the filesystem size, how it can be useless? > > If nothing checks it and everything works, I'd say it's usefulness is > a bit limited... ufs driver doesn't check it, the driver *uses* it, so... :-) -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 13:12:39 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F15D61065672 for ; Wed, 22 Apr 2009 13:12:39 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by mx1.freebsd.org (Postfix) with ESMTP id 7D46D8FC12 for ; Wed, 22 Apr 2009 13:12:39 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: by ey-out-2122.google.com with SMTP id 9so299926eyd.7 for ; Wed, 22 Apr 2009 06:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to:cc :content-type:content-transfer-encoding; bh=xpPRKSITVOHFx5Gg9bDt58FNZRWGTKOTE3c8klchZL8=; b=A6ulE6GMtWGhxHivqBd6ESsSjqP2zFIFwcOgw2vrm7jyeDXgWhSXxFJOjKWvxsfWiu meB6XS7bag9bduS3QQ1qzCC9TkLxAqRKF72fldMa8gDJ1ZTpwNKVF271FYmp6Xc87vIi K5YbVRiAJZ8DLDcByVFEClbL/Mp4A9cGbL+Wk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=HvzJpXRLMNNX4I4ToswzW+aRUPFYDZZH7edtZnrl0aTtvqQ2xewG6mq0/E3ZbXB1HS ht5lvKUFBDKSz3hWZZEGHOxeFGHGIED5TWdexwiYLWAhH5ygRjYa/JT7co0Syop8cep1 at45R+wCO1iJgfT0NHZsFT2v7/4w3dXDitGWc= MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.210.41.14 with SMTP id o14mr6284413ebo.8.1240405958172; Wed, 22 Apr 2009 06:12:38 -0700 (PDT) In-Reply-To: <49EF1766.7030401@icyb.net.ua> References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> <49EF1645.70704@icyb.net.ua> <9bbcef730904220608y73cbf2d2s6921b05c1978a121@mail.gmail.com> <49EF1766.7030401@icyb.net.ua> From: Ivan Voras Date: Wed, 22 Apr 2009 15:12:23 +0200 X-Google-Sender-Auth: 577018fd55468fc8 Message-ID: <9bbcef730904220612s3ff4308fpc1d18e216a5c7773@mail.gmail.com> To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 13:12:40 -0000 2009/4/22 Andriy Gapon : > on 22/04/2009 16:08 Ivan Voras said the following: >> 2009/4/22 Andriy Gapon : >>> on 21/04/2009 21:43 Ivan Voras said the following: >>>> Andriy Gapon wrote: >>>>> I don't see why it should and - no, it actually does not. >>>>> fsck checks only filesystem's internal consistency, it doesn't check media size, etc. >>>> Well yes, if the number of blocks is really incorrect it should be >>>> visible from the arrangement of the metadata but still - that makes the >>>> field almost useless doesn't it? >>> How do you mean? >>> The field tells the filesystem size, how it can be useless? >> >> If nothing checks it and everything works, I'd say it's usefulness is >> a bit limited... > > ufs driver doesn't check it, the driver *uses* it, so... :-) But as you said, fsck will not fix an invalid value? From owner-freebsd-geom@FreeBSD.ORG Wed Apr 22 13:36:35 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA57F106564A; Wed, 22 Apr 2009 13:36:35 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id AC47B8FC16; Wed, 22 Apr 2009 13:36:34 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA17407; Wed, 22 Apr 2009 16:36:32 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <49EF1D5F.7050907@icyb.net.ua> Date: Wed, 22 Apr 2009 16:36:31 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Ivan Voras References: <49EDCA21.70908@icyb.net.ua> <49EDF80F.3070105@icyb.net.ua> <49EF1645.70704@icyb.net.ua> <9bbcef730904220608y73cbf2d2s6921b05c1978a121@mail.gmail.com> <49EF1766.7030401@icyb.net.ua> <9bbcef730904220612s3ff4308fpc1d18e216a5c7773@mail.gmail.com> In-Reply-To: <9bbcef730904220612s3ff4308fpc1d18e216a5c7773@mail.gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2009 13:36:36 -0000 on 22/04/2009 16:12 Ivan Voras said the following: > 2009/4/22 Andriy Gapon : >> on 22/04/2009 16:08 Ivan Voras said the following: >>> 2009/4/22 Andriy Gapon : >>>> on 21/04/2009 21:43 Ivan Voras said the following: >>>>> Andriy Gapon wrote: >>>>>> I don't see why it should and - no, it actually does not. >>>>>> fsck checks only filesystem's internal consistency, it doesn't check media size, etc. >>>>> Well yes, if the number of blocks is really incorrect it should be >>>>> visible from the arrangement of the metadata but still - that makes the >>>>> field almost useless doesn't it? >>>> How do you mean? >>>> The field tells the filesystem size, how it can be useless? >>> If nothing checks it and everything works, I'd say it's usefulness is >>> a bit limited... >> ufs driver doesn't check it, the driver *uses* it, so... :-) > > But as you said, fsck will not fix an invalid value? It won't, because it can not know the correct value and it is probably not able to safely derive it from anything. Filesystem size is supposed to always stay immutable (modulo growfs), so if this type of corruption happens to superblock, then one has quite a big problem and possibly some fun time with disk editor. -- Andriy Gapon From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 09:02:51 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EACCB1065675; Thu, 23 Apr 2009 09:02:51 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C0D0C8FC0A; Thu, 23 Apr 2009 09:02:51 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from freefall.freebsd.org (gavin@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3N92pRe031363; Thu, 23 Apr 2009 09:02:51 GMT (envelope-from gavin@freefall.freebsd.org) Received: (from gavin@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3N92pSc031359; Thu, 23 Apr 2009 09:02:51 GMT (envelope-from gavin) Date: Thu, 23 Apr 2009 09:02:51 GMT Message-Id: <200904230902.n3N92pSc031359@freefall.freebsd.org> To: gavin@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-geom@FreeBSD.org From: gavin@FreeBSD.org Cc: Subject: Re: kern/133931: [geli] [request] intentionally wrong password to destroy data X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 09:02:52 -0000 Old Synopsis: GELI intentionally wrong password to destroy data New Synopsis: [geli] [request] intentionally wrong password to destroy data Responsible-Changed-From-To: freebsd-bugs->freebsd-geom Responsible-Changed-By: gavin Responsible-Changed-When: Thu Apr 23 09:02:12 UTC 2009 Responsible-Changed-Why: Feature request. Over to maintainer(s) http://www.freebsd.org/cgi/query-pr.cgi?pr=133931 From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 11:52:26 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0319D1065677 for ; Thu, 23 Apr 2009 11:52:26 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id 867678FC1D for ; Thu, 23 Apr 2009 11:52:25 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LwxTa-0007hn-DY for freebsd-geom@freebsd.org; Thu, 23 Apr 2009 11:52:22 +0000 Received: from lara.cc.fer.hr ([161.53.72.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 11:52:22 +0000 Received: from ivoras by lara.cc.fer.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 11:52:22 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Thu, 23 Apr 2009 13:52:01 +0200 Lines: 51 Message-ID: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig690A78B14ECA40D946C6712E" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lara.cc.fer.hr User-Agent: Thunderbird 2.0.0.21 (X11/20090318) X-Enigmail-Version: 0.95.0 Sender: news Subject: geom_label verbosity patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 11:52:26 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig690A78B14ECA40D946C6712E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I want to ask for a community review of these patches: http://people.freebsd.org/~ivoras/diffs/geom_label_errlevel.txt http://people.freebsd.org/~ivoras/diffs/glabel.8_errlevel.txt The intent is to make glabel less chatty on detection of new providers, etc. Since most of these messages were displayed as "priority 0", I needed to renumber priorities to make them go away at the default level (level 0). The DEBUG levels are changed in this way: - 0 becomes "silent" - no messages at this level - the default level - 1 contains previous messages at level 0 - 10 contains most of previous messages at level 1 - 20 contains messages of previous level 2 and of level 1 that are the result of tasting / validating / checksumming instead of specifically glabel operations The jump to decadic numbers is for future compatibility, in case more verbosity levels need to be introduced just like now, to avoid code churn. This should go in very fast if it's going to get into 7.2 (OTOH, it's fairly low priority). The patches were ready some time ago but there were some blocking delays.= --------------enig690A78B14ECA40D946C6712E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJ8FZsldnAQVacBcgRAknhAJ9GyM9zTs0AAcO3TiOjUptn0j3+TQCfcr+l blRKYpRYrkH+pywv7ebaBXw= =Ookc -----END PGP SIGNATURE----- --------------enig690A78B14ECA40D946C6712E-- From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 12:00:29 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D10F10657CF for ; Thu, 23 Apr 2009 12:00:29 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from mx3.wheel.pl (grom.wheel.pl [91.121.70.66]) by mx1.freebsd.org (Postfix) with ESMTP id F1E8A8FC17 for ; Thu, 23 Apr 2009 12:00:28 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from localhost (unknown [10.10.2.1]) by mx3.wheel.pl (Postfix) with ESMTP id 500A41607C; Thu, 23 Apr 2009 14:00:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mx3.wheel.pl Received: from mx3.wheel.pl ([10.10.2.1]) by localhost (mx3.wheel.pl [10.10.2.1]) (amavisd-new, port 10024) with ESMTP id ezw4s01UZGUc; Thu, 23 Apr 2009 14:00:26 +0200 (CEST) Received: from mail.wheel.pl (ghf58.internetdsl.tpnet.pl [83.12.187.58]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3.wheel.pl (Postfix) with ESMTPS id 831CA16078; Thu, 23 Apr 2009 14:00:26 +0200 (CEST) Received: from localhost (unknown [10.0.2.3]) by mail.wheel.pl (Postfix) with ESMTP id 07D6028424; Thu, 23 Apr 2009 14:00:26 +0200 (CEST) Received: from mail.wheel.pl ([10.0.2.3]) by localhost (mail.wheel.pl [10.0.2.3]) (amavisd-new, port 10024) with ESMTP id iGKat7MfDl5R; Thu, 23 Apr 2009 14:00:25 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wheel.pl (Postfix) with ESMTP id 4B7D628421; Thu, 23 Apr 2009 14:00:25 +0200 (CEST) Date: Thu, 23 Apr 2009 14:00:35 +0200 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20090423120035.GA1798@mail.wheel.pl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://www.wheel.pl/pgpkeys/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 Cc: freebsd-geom@freebsd.org Subject: Re: geom_label verbosity patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 12:00:29 -0000 On Thu, Apr 23, 2009 at 01:52:01PM +0200, Ivan Voras wrote: > Hi, > > I want to ask for a community review of these patches: > > http://people.freebsd.org/~ivoras/diffs/geom_label_errlevel.txt > http://people.freebsd.org/~ivoras/diffs/glabel.8_errlevel.txt > > The intent is to make glabel less chatty on detection of new providers, > etc. [...] This is on purpose, so don't change that. One can always set it to -1. Instead, we should implement possibility to turn on/off selected labels. For example things like ufsid should be turned off by default. This way we not only make it less chatty again, but also not to pollute /dev/. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 12:15:23 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BC941065670 for ; Thu, 23 Apr 2009 12:15:23 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id A44508FC17 for ; Thu, 23 Apr 2009 12:15:22 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Lwxpp-0000Ja-K7 for freebsd-geom@freebsd.org; Thu, 23 Apr 2009 12:15:21 +0000 Received: from lara.cc.fer.hr ([161.53.72.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 12:15:21 +0000 Received: from ivoras by lara.cc.fer.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 12:15:21 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Thu, 23 Apr 2009 14:15:14 +0200 Lines: 51 Message-ID: References: <20090423120035.GA1798@mail.wheel.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig407895C03E8EF62DBFF1D211" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lara.cc.fer.hr User-Agent: Thunderbird 2.0.0.21 (X11/20090318) In-Reply-To: <20090423120035.GA1798@mail.wheel.pl> X-Enigmail-Version: 0.95.0 Sender: news Subject: Re: geom_label verbosity patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 12:15:23 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig407895C03E8EF62DBFF1D211 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pawel Jakub Dawidek wrote: > On Thu, Apr 23, 2009 at 01:52:01PM +0200, Ivan Voras wrote: >> Hi, >> >> I want to ask for a community review of these patches: >> >> http://people.freebsd.org/~ivoras/diffs/geom_label_errlevel.txt >> http://people.freebsd.org/~ivoras/diffs/glabel.8_errlevel.txt >> >> The intent is to make glabel less chatty on detection of new providers= , >> etc. [...] >=20 > This is on purpose, so don't change that. One can always set it to -1. Possible, but it would make it unique among other GEOM classes. > Instead, we should implement possibility to turn on/off selected labels= =2E > For example things like ufsid should be turned off by default. Anyone else agrees with this? > This way we not only make it less chatty again, but also not to pollute= > /dev/. One way to lessen it is to stop creating individual directories for each label class, as discussed before. --------------enig407895C03E8EF62DBFF1D211 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJ8FvSldnAQVacBcgRAovoAJ9vR3JPDp3Qc9GP8+DCw/rPstmlUQCeNIR1 yGIB3aAbMAZ/Q9epjWRyhJQ= =y24u -----END PGP SIGNATURE----- --------------enig407895C03E8EF62DBFF1D211-- From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 12:35:05 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E69F106567C; Thu, 23 Apr 2009 12:35:05 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from mx3.wheel.pl (grom.wheel.pl [91.121.70.66]) by mx1.freebsd.org (Postfix) with ESMTP id E80818FC21; Thu, 23 Apr 2009 12:35:04 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from localhost (unknown [10.10.2.1]) by mx3.wheel.pl (Postfix) with ESMTP id 1E6811626F; Thu, 23 Apr 2009 14:35:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at mx3.wheel.pl Received: from mx3.wheel.pl ([10.10.2.1]) by localhost (mx3.wheel.pl [10.10.2.1]) (amavisd-new, port 10024) with ESMTP id qa3nO-1xpTlu; Thu, 23 Apr 2009 14:35:03 +0200 (CEST) Received: from mail.wheel.pl (ghf58.internetdsl.tpnet.pl [83.12.187.58]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3.wheel.pl (Postfix) with ESMTPS id 247451626B; Thu, 23 Apr 2009 14:35:03 +0200 (CEST) Received: from localhost (unknown [10.0.2.3]) by mail.wheel.pl (Postfix) with ESMTP id 121BE29C4C; Thu, 23 Apr 2009 14:35:02 +0200 (CEST) Received: from mail.wheel.pl ([10.0.2.3]) by localhost (mail.wheel.pl [10.0.2.3]) (amavisd-new, port 10024) with ESMTP id TU7xLh3H6Qqg; Thu, 23 Apr 2009 14:35:01 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wheel.pl (Postfix) with ESMTP id 3713E29C49; Thu, 23 Apr 2009 14:35:01 +0200 (CEST) Date: Thu, 23 Apr 2009 14:35:11 +0200 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20090423123511.GB1798@mail.wheel.pl> References: <20090423120035.GA1798@mail.wheel.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://www.wheel.pl/pgpkeys/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 Cc: freebsd-geom@freebsd.org Subject: Re: geom_label verbosity patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 12:35:05 -0000 On Thu, Apr 23, 2009 at 02:15:14PM +0200, Ivan Voras wrote: > Pawel Jakub Dawidek wrote: > > On Thu, Apr 23, 2009 at 01:52:01PM +0200, Ivan Voras wrote: > >> Hi, > >> > >> I want to ask for a community review of these patches: > >> > >> http://people.freebsd.org/~ivoras/diffs/geom_label_errlevel.txt > >> http://people.freebsd.org/~ivoras/diffs/glabel.8_errlevel.txt > >> > >> The intent is to make glabel less chatty on detection of new providers, > >> etc. [...] > > > > This is on purpose, so don't change that. One can always set it to -1. > > Possible, but it would make it unique among other GEOM classes. Almost every GEOM class informs about creating providers, so what you suggest is inconsistent. > > Instead, we should implement possibility to turn on/off selected labels. > > For example things like ufsid should be turned off by default. > > Anyone else agrees with this? > > > This way we not only make it less chatty again, but also not to pollute > > /dev/. > > One way to lessen it is to stop creating individual directories for each > label class, as discussed before. How is it going to reduce number of providers in /dev/? -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! From owner-freebsd-geom@FreeBSD.ORG Thu Apr 23 12:52:57 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF2F41065674 for ; Thu, 23 Apr 2009 12:52:57 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id 4AF7A8FC27 for ; Thu, 23 Apr 2009 12:52:56 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LwyQ7-00023I-GP for freebsd-geom@freebsd.org; Thu, 23 Apr 2009 12:52:51 +0000 Received: from lara.cc.fer.hr ([161.53.72.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 12:52:51 +0000 Received: from ivoras by lara.cc.fer.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Apr 2009 12:52:51 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Thu, 23 Apr 2009 14:52:45 +0200 Lines: 70 Message-ID: References: <20090423120035.GA1798@mail.wheel.pl> <20090423123511.GB1798@mail.wheel.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3BE643728B3B9554AEA8F745" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lara.cc.fer.hr User-Agent: Thunderbird 2.0.0.21 (X11/20090318) In-Reply-To: <20090423123511.GB1798@mail.wheel.pl> X-Enigmail-Version: 0.95.0 Sender: news Subject: Re: geom_label verbosity patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 12:52:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3BE643728B3B9554AEA8F745 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pawel Jakub Dawidek wrote: > On Thu, Apr 23, 2009 at 02:15:14PM +0200, Ivan Voras wrote: >> Pawel Jakub Dawidek wrote: >>> On Thu, Apr 23, 2009 at 01:52:01PM +0200, Ivan Voras wrote: >>>> Hi, >>>> >>>> I want to ask for a community review of these patches: >>>> >>>> http://people.freebsd.org/~ivoras/diffs/geom_label_errlevel.txt >>>> http://people.freebsd.org/~ivoras/diffs/glabel.8_errlevel.txt >>>> >>>> The intent is to make glabel less chatty on detection of new provide= rs, >>>> etc. [...] >>> This is on purpose, so don't change that. One can always set it to -1= =2E >> Possible, but it would make it unique among other GEOM classes. >=20 > Almost every GEOM class informs about creating providers, so what you > suggest is inconsistent. I think you feel more strongly about the topic than it warrants it - "almost every" is not "every" and glabel is technically a slicer just like gpart - you wouldn't like gpart to announce as it creates da0s1a, da0s1b, da0s1c, etc.? Besides, the trend is toward reducing the amount of generic (redundant, repeatable) information on boot. :) What could be possibly more useful is to create a framework that would output only "diff" messages - i.e. that shows that I had da0s1a or ufs/mylabel when I booted last time, and I suddenly lost it now. But this is non-trivial for many reasons, including how and where to store the information and what to do with hot-plug devices. Maybe devd could take care of all these announcements? >>> This way we not only make it less chatty again, but also not to pollu= te >>> /dev/. >> One way to lessen it is to stop creating individual directories for ea= ch >> label class, as discussed before. >=20 > How is it going to reduce number of providers in /dev/? I was thinking about the "ls /dev" case. What other thing would be a concern in the number of entries in what's essentially a very light weight memory file system whose content are nodes of several bytes in size (less than 100 bytes if I count them correctly, +vnodes, labels, book-keeping)? --------------enig3BE643728B3B9554AEA8F745 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJ8GSdldnAQVacBcgRAneuAJ9VmkQkXpVQHj1gN890CSGjrUorgQCdGbKa 8ODJyXMGrDElMmUO4Tc3rY4= =n85i -----END PGP SIGNATURE----- --------------enig3BE643728B3B9554AEA8F745-- From owner-freebsd-geom@FreeBSD.ORG Fri Apr 24 21:23:53 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7733106564A for ; Fri, 24 Apr 2009 21:23:53 +0000 (UTC) (envelope-from erleya@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157]) by mx1.freebsd.org (Postfix) with ESMTP id 2EDD48FC13 for ; Fri, 24 Apr 2009 21:23:52 +0000 (UTC) (envelope-from erleya@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so221500fgb.12 for ; Fri, 24 Apr 2009 14:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=bZj9shl+PPIU+pyfVaASglUEXnxVvK0IoV7FxfLpJ2k=; b=dzUmS/rokv8sZRUB3hMIjBtNhl98+9h95LcJIMzKBY74Z5TzviLME6C8/3QkA1Sjs5 G3XVDAZ6sPjzIsE3oUA4JMZx33wvxTs8cJ0YIt9fNa66vIGAHYiMCjoK4WOfqsmk6zcg Jwhr3Z4sD1xCVqPYxZ5wlmpxafIna1Jbqu+Us= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=fO+qI59FrFpAxwoMad8KaCd9t9c7CvEDm5AyalQkqxLLa36tIKHZ/Xr9CiyZwqPDlr Inm7lGeCbgsTTnNQSfFEzsu82E9hOqn+FfvQ/w9ubBa9UwnR0sXlrfV87Rp5XVv0m1Io av2VNN0cddKsJLxb1DiMXRO81nnq8FWxzXdBc= Received: by 10.86.70.20 with SMTP id s20mr1170712fga.1.1240606437104; Fri, 24 Apr 2009 13:53:57 -0700 (PDT) Received: from ?192.168.0.2? (lab75-4-82-245-153-214.fbx.proxad.net [82.245.153.214]) by mx.google.com with ESMTPS id d4sm1885377fga.9.2009.04.24.13.53.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 24 Apr 2009 13:53:56 -0700 (PDT) Message-Id: From: Alexei Troussov To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Fri, 24 Apr 2009 22:53:53 +0200 X-Mailer: Apple Mail (2.930.3) Subject: gjournal+gstripe+gmirror question X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2009 21:23:53 -0000 Hello All, I decided to build multi-terabyte data storage (file server) using 4 x 1Tb disks. No special raid controller is used, FreeBSD 7.1 is running on another disk, so the disk array is going to be used for file storage only. So, I tried several combinations of gmirror/gstripe and put gjournal on it: 1) two mirrors and stripe on them 2) two stripes and mirror on them Both configurations gave excellent I/O speed (around 100Mb/sec), and I chose the first one as it needs less time to resync disks when one of the mirrors fails. To make picture more complete, I didn't try graid3 because it seems to load CPU more than configs above, which is not good for my barebone :) Now when my top-level gstripe gets "gjournal"-ed, I see relatively poor write speed around 20-30 Mb/sec. As far as I understand from man gjournal and some posts here, performance usually drops about 40-50%, but what I have is much worse... Are there a better way to configure/tune the whole thing? Thanks in advance! PS Here is my current playground config: -------- > gmirror list Geom name: gm0 State: COMPLETE Components: 1 Balance: round-robin Slice: 4096 Flags: NONE GenID: 0 SyncID: 1 ID: 2111539126 Providers: 1. Name: mirror/gm0 Mediasize: 1000204885504 (932G) Sectorsize: 512 Mode: r1w1e2 Consumers: 1. Name: ad10 Mediasize: 1000204886016 (932G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: NONE GenID: 0 SyncID: 1 ID: 3300348150 2. Name: ad12 Mediasize: 1000204886016 (932G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: NONE GenID: 0 SyncID: 1 ID: 4291633068 Geom name: gm1 State: COMPLETE Components: 2 Balance: round-robin Slice: 4096 Flags: NONE GenID: 0 SyncID: 1 ID: 835525163 Providers: 1. Name: mirror/gm1 Mediasize: 1000204885504 (932G) Sectorsize: 512 Mode: r1w1e2 Consumers: 1. Name: ad11 Mediasize: 1000204886016 (932G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: NONE GenID: 0 SyncID: 1 ID: 1770536936 2. Name: ad13 Mediasize: 1000204886016 (932G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: NONE GenID: 0 SyncID: 1 ID: 922042393 > gstripe list Geom name: gs0 State: UP Status: Total=2, Online=2 Type: AUTOMATIC Stripesize: 131072 ID: 1106325435 Providers: 1. Name: stripe/gs0 Mediasize: 2000409591808 (1.8T) Sectorsize: 512 Mode: r1w1e1 Consumers: 1. Name: mirror/gm0 Mediasize: 1000204885504 (932G) Sectorsize: 512 Mode: r1w1e2 Number: 0 2. Name: mirror/gm1 Mediasize: 1000204885504 (932G) Sectorsize: 512 Mode: r1w1e2 Number: 1 -------- Have a nice day, Alex From owner-freebsd-geom@FreeBSD.ORG Fri Apr 24 22:02:03 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13204106566C for ; Fri, 24 Apr 2009 22:02:03 +0000 (UTC) (envelope-from newsletter@flyawaysimulation.com) Received: from web2.rbftpnetworks.com (web2.rbftpnetworks.com [195.224.144.73]) by mx1.freebsd.org (Postfix) with ESMTP id 9B1C58FC2C for ; Fri, 24 Apr 2009 22:02:02 +0000 (UTC) (envelope-from newsletter@flyawaysimulation.com) Received: from list.flyawaysimulation.com (localhost.localdomain [127.0.0.1]) by web2.rbftpnetworks.com (8.12.11.20060308/8.12.10) with ESMTP id n3OGqr5M015417 for ; Fri, 24 Apr 2009 17:52:53 +0100 Received: (from flyawaylist@localhost) by list.flyawaysimulation.com (8.12.11.20060308/8.12.10/Submit) id n3OGqrZd015415; Fri, 24 Apr 2009 17:52:53 +0100 X-Authentication-Warning: web2.rbftpnetworks.com: flyawaylist set sender to newsletter@flyawaysimulation.com using -f To: freebsd-geom@freebsd.org Date: Fri, 24 Apr 2009 17:52:53 +0100 From: ryan@rbftpnetworks.com Message-ID: X-Priority: 3 X-Mailer: PHPMailer [version 1.73] X-Mailer: phplist v2.10.3 X-MessageID: 81 X-ListMember: freebsd-geom@freebsd.org Precedence: bulk Errors-To: newsletter@flyawaysimulation.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="iso-8859-1" Subject: Gaming news link X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2009 22:02:03 -0000 Dear Sir / Madam, We are interested in posting our gaming news and information site on your links section. Our site is GamerBeef.com and can be found at http://www.gamerbeef.com Our site includes daily updated gaming news from all genres and consoles, with focus on PC gaming. We also have a new discussion forum, cheats and screenshots section. We would of course offer a link back to your site in return. Let me know your thoughts. Best Regards, Ryan -- Ryan Barclay Managing Director RBFTP Networks Limited. DDI: +44 (0)870 490 1870 WWW: http://www.rbftpnetworks.com RBFTP Networks Limited Registered in England No 05718807 Registered Office: 68 Aldersbrook Road, London, E12 5DL.