From owner-freebsd-geom@FreeBSD.ORG Sun Apr 19 10:10:06 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E30B2106566B for ; Sun, 19 Apr 2009 10:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B60D88FC17 for ; Sun, 19 Apr 2009 10:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3JAA646068316 for ; Sun, 19 Apr 2009 10:10:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3JAA6lk068313; Sun, 19 Apr 2009 10:10:06 GMT (envelope-from gnats) Date: Sun, 19 Apr 2009 10:10:06 GMT Message-Id: <200904191010.n3JAA6lk068313@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Ulf Lilleengen Cc: Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ulf Lilleengen List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2009 10:10:07 -0000 The following reply was made to PR kern/133604; it has been noted by GNATS. From: Ulf Lilleengen To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume Date: Sun, 19 Apr 2009 13:02:54 +0200 On Tue, Apr 14, 2009 at 09:00:07AM +0000, Ulf Lilleengen wrote: > The following reply was made to PR kern/133604; it has been noted by GNATS. > > From: Ulf Lilleengen > To: bug-followup@FreeBSD.org, pmc@citylink.dinoex.sub.org > Cc: > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > volume > Date: Tue, 14 Apr 2009 10:21:54 +0200 > > --000e0cd25b640a4f6004677f8657 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 7bit > > On Sun, Apr 12, 2009 at 12:10 AM, wrote: > > > Old Synopsis: [panic] writing to gjournal on a gvinum volume > > New Synopsis: [gvinum] [panic] writing to gjournal on a gvinum volume > > > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > > Responsible-Changed-By: linimon > > Responsible-Changed-When: Sat Apr 11 22:10:10 UTC 2009 > > Responsible-Changed-Why: > > Over to maintainer(s). > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133604 > > _______________________________________________ > > freebsd-geom@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" > > > Are you able to try gvinum from HEAD to see if it works there? I'll take a > look into gvinum on 7.2-PRE as well, but just in case you would like to try > it. > Ok, I tracked down the issue. The problem is in both HEAD and 7.x, so I will fix it in HEAD first. The problem is the bio_cflags part of the bio that gjournal sends down to gvinum. When gjournal does a read, it sets GJ_BIO_READ in bio_cflags. When the request arrives to gvinum it check cflags for GV_BIO_DONE to check if the request is a done request, in which case it will be treated like a bio of gvinum. The crash comes from GJ_BIO_READ having the same value as GV_BIO_DONE. I'll generate a fix that makes gvinum not depend on the bio_cflags value of external BIOs. -- Ulf Lilleengen