Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Apr 2009 23:13:01 +0200
From:      Ed Schouten <ed@80386.nl>
To:        mips@FreeBSD.org
Subject:   Remove insque()/remque()
Message-ID:  <20090426211301.GC58540@hoeg.nl>

next in thread | raw e-mail | index | archive | help

--z+buRVFir587KtL+
Content-Type: multipart/mixed; boundary="8WKGInOJRMBXYFEc"
Content-Disposition: inline


--8WKGInOJRMBXYFEc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

I just noticed support.S has some functions that are never called,
namely insque() and remque(). We only had one consumer of these
functions (netipx), but it used an inlined version of this function. I
haven't tested this patch, but I don't have any reason to believe it
breaks stuff.

Anyway, I'm just sending this patch to you folks. Have fun with it! ;-)

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--8WKGInOJRMBXYFEc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="que.diff"
Content-Transfer-Encoding: quoted-printable

Index: sys/mips/mips/support.S
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/mips/mips/support.S	(revision 191520)
+++ sys/mips/mips/support.S	(working copy)
@@ -581,34 +581,6 @@
 	li	v0, -1
 END(fswintrberr)
=20
-/*
- * Insert 'p' after 'q'.
- *	_insque(p, q)
- *		caddr_t p, q;
- */
-LEAF(_insque)
-	lw	v0, 0(a1)		# v0 =3D q->next
-	sw	a1, 4(a0)		# p->prev =3D q
-	sw	v0, 0(a0)		# p->next =3D q->next
-	sw	a0, 4(v0)		# q->next->prev =3D p
-	j	ra
-	sw	a0, 0(a1)		# q->next =3D p
-END(_insque)
-
-/*
- * Remove item 'p' from queue.
- *	_remque(p)
- *		caddr_t p;
- */
-LEAF(_remque)
-	lw	v0, 0(a0)		# v0 =3D p->next
-	lw	v1, 4(a0)		# v1 =3D p->prev
-	nop
-	sw	v0, 0(v1)		# p->prev->next =3D p->next
-	j	ra
-	sw	v1, 4(v0)		# p->next->prev =3D p->prev
-END(_remque)
-
 /*------------------------------------------------------------------------=
--
  *
  * Mips_GetCOUNT --

--8WKGInOJRMBXYFEc--

--z+buRVFir587KtL+
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkn0zl0ACgkQ52SDGA2eCwVX3QCfZMy3BhcB6u8PwFpXYX60+iqV
rdYAn0zWPaZp89WJGIFL51b5SzdvMq3g
=zVgk
-----END PGP SIGNATURE-----

--z+buRVFir587KtL+--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090426211301.GC58540>