From owner-freebsd-net@FreeBSD.ORG Sun Feb 8 14:26:54 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B78DB106564A for ; Sun, 8 Feb 2009 14:26:54 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay07.ispgateway.de (smtprelay07.ispgateway.de [80.67.29.7]) by mx1.freebsd.org (Postfix) with ESMTP id 475C78FC1D for ; Sun, 8 Feb 2009 14:26:54 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from [88.153.16.241] (helo=localhost) by smtprelay07.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1LWAcW-00050H-Mj; Sun, 08 Feb 2009 15:26:52 +0100 Date: Sun, 8 Feb 2009 15:26:47 +0100 From: Fabian Keil To: Jeff Roberson Message-ID: <20090208152647.3e4316d1@fabiankeil.de> In-Reply-To: <20090202094226.E983@desktop> References: <20090131125100.N983@desktop> <20090201160544.4f1961b4@fabiankeil.de> <20090201170550.482bf325@fabiankeil.de> <20090202094226.E983@desktop> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; i386-portbld-freebsd8.0) X-PGP-KEY-URL: http://www.fabiankeil.de/gpg-keys/freebsd-listen-2008-08-18.asc Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/oairxi+cdhO/y_tS6A7FjxC"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Df-Sender: 775067 Cc: freebsd-net@freebsd.org Subject: Re: mbuf revision, testers/comments wanted. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Feb 2009 14:26:55 -0000 --Sig_/oairxi+cdhO/y_tS6A7FjxC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Jeff Roberson wrote: > On Sun, 1 Feb 2009, Fabian Keil wrote: >=20 > > Fabian Keil wrote: > > > >> Jeff Roberson wrote: > >> > >>> http://people.freebsd.org/~jeff/mbuf_ref2.diff > >> > >>> I have been experimenting with different revisions to the mbuf api to > >>> improve performance and simplify code. This patch is the first of > >>> several proposed steps towards those goals. The aim of this patch is > >>> two fold; > >> > >>> I would appreciate testing feedback from varied workloads to make sure > >>> there are no bugs before I go forward with this. I have tested only > >>> host oriented networking with a few drivers. It is not anticipated > >>> that there will be any significant incompatibilities introduced with > >>> this round but there is always that possibility. > > > >> 5) > >> Finally, I tested the patch on an IBM ThinPad R51. The kernel > >> hangs on boot, the last messages are (hand transcribed): > >> > >> iwi0: mem 0xc0214000-0xc0214fff irq 11 = at device 2.0 on pci2 > >> iwi0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xc0214000 > >> iwi0: could not allocate rx mbuf > >> iwi0: could not allocate Rx ring > >> bpfdetach: was not attached > > > > Never mind, kernel and user land weren't completely in > > sync and this might be related to the recent wlan commits. > > I'll retry with an up-to-date user land. > I have updated the patch here: >=20 > http://people.freebsd.org/~jeff/mbuf_ref2.diff >=20 > This resolves the !INVARIANTS bug and improves the style as you suggested. I run into several system hangs (or maybe panics) yesterday, mostly with Xorg running so I didn't get any details. I got one on the console though. After running a regression test that opens multiple HTTP connections to the loop back device, I used rsync to restore some files that were damaged by an earlier hang. That lead to a page fault in em_start_locked(). While I dumped core from the debugger, savecore didn't find the dump afterwards. Anyway, there's a screen shot available at: http://www.fabiankeil.de/bilder/freebsd/mbuf-patch-page-fault-em_start_lock= ed.jpg Before the patch I didn't see any surprising panics in quite a while. I reverted the patch for now to verify that the system is stable without it. Fabian --Sig_/oairxi+cdhO/y_tS6A7FjxC Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmO66cACgkQBYqIVf93VJ0OVACfRJ+NbIrKYvG3EJsba9UjXd4O D8oAn0y9otsWu8XyQyD0x1zIX3aHnNLY =MTw/ -----END PGP SIGNATURE----- --Sig_/oairxi+cdhO/y_tS6A7FjxC--