From owner-freebsd-net@FreeBSD.ORG Sun Sep 13 01:04:59 2009 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0AA0C106566C for ; Sun, 13 Sep 2009 01:04:59 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id A90D88FC0A for ; Sun, 13 Sep 2009 01:04:58 +0000 (UTC) Received: from compute1.internal (compute1.internal [10.202.2.41]) by gateway1.messagingengine.com (Postfix) with ESMTP id AE0F266F12; Sat, 12 Sep 2009 21:04:57 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 12 Sep 2009 21:04:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=message-id:date:from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpout; bh=QuxNHsbKgaKu4LoDKi3BtjyZD0Q=; b=Tul6tEemxSFP8IkrbD2T2Uk/GSG7a2M1z4vb3e6IZGJyOplqZEH0XkDkV+911TM04VqpGnLZFPdFPw1BuSDOidmeTb/GEtGNEWc7q2PiYrXYqLGIt6KXRGwhrz7eaSz50xPQHP8HYOr6QJ2ViUulnb3+vKfo3BZpNHGAFIFg3us= X-Sasl-enc: +nh/foHJMzexiEpTLtzufp65cWyu6JOqSxuWEHBQAcj6 1252803897 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id EE0056A08C; Sat, 12 Sep 2009 21:04:56 -0400 (EDT) Message-ID: <4AAC4534.9040606@incunabulum.net> Date: Sun, 13 Sep 2009 02:04:52 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: freebsd-gnats-submit@FreeBSD.org References: <200909091921.n89JL2wr014985@freefall.freebsd.org> In-Reply-To: <200909091921.n89JL2wr014985@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@FreeBSD.org Subject: Re: kern/138666: [multicast] [panic] not working multicast through igmpproxy X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2009 01:04:59 -0000 I did a quick pass over ip_mroute.c to see if I could have introduced any obvious errors during refactoring; didn't see anything obvious. The backtrace which was posted points towards a trashed rte->m pointer, assuming it's accurate and the arguments didn't get trashed on-stack. The MFC lock should be held in expire_mfc(). I'll add a lock assertion there for now. The VIF lock shouldn't be needed in this path.