From owner-freebsd-stable@FreeBSD.ORG  Sun Jul 26 00:08:15 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8921C1065670
	for <freebsd-stable@FreeBSD.org>; Sun, 26 Jul 2009 00:08:15 +0000 (UTC)
	(envelope-from jamie@FreeBSD.org)
Received: from gritton.org (gritton.org [161.58.222.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 4554B8FC16
	for <freebsd-stable@FreeBSD.org>; Sun, 26 Jul 2009 00:08:15 +0000 (UTC)
	(envelope-from jamie@FreeBSD.org)
Received: from glorfindel.gritton.org (c-76-27-80-223.hsd1.ut.comcast.net
	[76.27.80.223]) (authenticated bits=0)
	by gritton.org (8.13.6.20060614/8.13.6) with ESMTP id n6PNovpE096216;
	Sat, 25 Jul 2009 17:50:57 -0600 (MDT)
Message-ID: <4A6B9A60.90302@FreeBSD.org>
Date: Sat, 25 Jul 2009 17:50:56 -0600
From: Jamie Gritton <jamie@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090220)
MIME-Version: 1.0
To: Michael Butler <imb@protected-networks.net>
References: <4A6B0BD3.6040206@protected-networks.net>
In-Reply-To: <4A6B0BD3.6040206@protected-networks.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-stable <freebsd-stable@FreeBSD.org>
Subject: Re: regression with jexec?
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jul 2009 00:08:15 -0000

Michael Butler wrote:

> After a clean rebuild ('rm -rf /usr/obj/*') ..
> 
> imb@aaron:/home/imb> uname -a
> FreeBSD aaron.protected-networks.net 7.2-STABLE FreeBSD 7.2-STABLE #0:
> Sat Jul 25 05:39:55 EDT 2009
> 
> imb@aaron:/home/imb> jls
>    JID  IP Address      Hostname                      Path
> 
>  [ .. ]
> 
>      5  202.12.127.68   db.protected-networks.net
> 		/usr/local/jails/db.protected-networks.net
> 
> imb@aaron:/home/imb> sudo jexec 5 tcsh
> jexec: Unable to parse jail ID.: No such file or directory
> 
> Huh?
> 
> 	imb


The symptom in jexec can be fixed by this little patch:

Index: usr.sbin/jexec/jexec.c
===================================================================
--- usr.sbin/jexec/jexec.c	(revision 195879)
+++ usr.sbin/jexec/jexec.c	(working copy)
@@ -248,6 +248,7 @@
  	if (argc < 2)
  		usage();
  	if (strlen(argv[0]) > 0) {
+		errno = 0;
  		jid = (int)strtol(argv[0], NULL, 10);
  		if (errno)
  			err(1, "Unable to parse jail ID.");

But the broader problem is malloc.  It's leaving errno set to
ENOENT when /etc/malloc.conf doesn't exist.  This seems like
wrong behavior to me.

- Jamie